216863 2020-09-22 19:29:11 -0700 Unify debug and release target aliases 2020-09-22 20:38:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin darin ddkilzer jbedard thorton webkit-bug-importer oldest_to_newest 1690985 0 krollin 2020-09-22 19:29:11 -0700 Some Makefiles have "debug", "d", "release", and "r" for build targets. Others also include "dev", "develop", "development", "dep", "deploy", and "deployment". Because of this inconsistency, trying to use those additional targets didn't work. It looks like all Makefiles used to support all of those targets, but some got dropped along the way. For instance, the top-level Makefile and Source/Makefile dropped them in 2013 as part of Bug 107863. And it looks like WebKitLibraries/Makefile never had them. Given that those additional targets don't work, it seems like no one uses them, so let's remove them completely. 1690986 1 webkit-bug-importer 2020-09-22 19:29:25 -0700 <rdar://problem/69407746> 1690987 2 409443 krollin 2020-09-22 19:33:11 -0700 Created attachment 409443 Patch 1691011 3 ews-feeder 2020-09-22 20:38:22 -0700 Committed r267458: <https://trac.webkit.org/changeset/267458> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409443. 409443 2020-09-22 19:33:11 -0700 2020-09-22 20:38:23 -0700 Patch bug-216863-20200922193311.patch text/plain 5687 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggMGIyNjliOGZk MDBlZGUxNzcxOTgzNjQ3ODFhNDhkZWQxMDJmZjQ5NS4uMmU0ZDg5YmM0YzhlZTRhMzRmNDgwNzZl NGM4NDE5ZTczZWJiOTRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIw LTA5LTIyICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBVbmlm eSBkZWJ1ZyBhbmQgcmVsZWFzZSB0YXJnZXQgYWxpYXNlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2ODYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82OTQwNzc0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBbGwgTWFrZWZpbGVzIGhhdmUgImRlYnVnIiwgImQiLCAicmVsZWFzZSIsIGFuZCAiciIg Zm9yIGJ1aWxkCisgICAgICAgIHRhcmdldHMuIE90aGVycyAtLSBidXQgbm90IGFsbCAtLSBhbHNv IGluY2x1ZGUgImRldiIsICJkZXZlbG9wIiwKKyAgICAgICAgImRldmVsb3BtZW50IiwgImRlcCIs ICJkZXBsb3kiLCBhbmQgImRlcGxveW1lbnQiLiBCZWNhdXNlIG9mIHRoaXMKKyAgICAgICAgaW5j b25zaXN0ZW5jeSwgdHJ5aW5nIHRvIHVzZSB0aG9zZSBhZGRpdGlvbmFsIHRhcmdldHMgZGlkbid0 IHdvcmsuIEl0CisgICAgICAgIGxvb2tzIGxpa2UgYWxsIE1ha2VmaWxlcyB1c2VkIHRvIHN1cHBv cnQgYWxsIG9mIHRob3NlIHRhcmdldHMsIGJ1dAorICAgICAgICBzb21lIGdvdCBkcm9wcGVkIGFs b25nIHRoZSB3YXkuIEZvciBpbnN0YW5jZSwgdGhlIHRvcC1sZXZlbCBNYWtlZmlsZQorICAgICAg ICBhbmQgU291cmNlL01ha2VmaWxlIGRyb3BwZWQgdGhlbSBpbiAyMDEzIGFzIHBhcnQgb2YgQnVn IDEwNzg2My4gQW5kIGl0CisgICAgICAgIGxvb2tzIGxpa2UgV2ViS2l0TGlicmFyaWVzL01ha2Vm aWxlIG5ldmVyIGhhZCB0aGVtLiBHaXZlbiB0aGF0IHRob3NlCisgICAgICAgIGFkZGl0aW9uYWwg dGFyZ2V0cyBkb24ndCB3b3JrLCBpdCBzZWVtcyBsaWtlIG5vIG9uZSB1c2VzIHRoZW0sIHNvCisg ICAgICAgIGxldCdzIHJlbW92ZSB0aGVtIGNvbXBsZXRlbHkuCisKKyAgICAgICAgKiBNYWtlZmls ZToKKwogMjAyMC0wOS0yMiAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVmYWN0b3IgYnVpbGQgcnVsZXMgaW4gTWFrZWZpbGVzIGFuZCBNYWtlZmlsZS5zaGFy ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L01ha2VmaWxlIGIvU291cmNlL1RoaXJk UGFydHkvTWFrZWZpbGUKaW5kZXggZmZhNGIxZGJhZThiYTgxMDBiOGY3MWZmMWFkNDEzMDliMzQ4 ZDM2YS4uYjM4NWNiMjdkN2NiMGUxY2ZmZDQxZjdjNmQ0ZjQ5YTRhODE3MzJkYyAxMDA2NDQKLS0t IGEvU291cmNlL1RoaXJkUGFydHkvTWFrZWZpbGUKKysrIGIvU291cmNlL1RoaXJkUGFydHkvTWFr ZWZpbGUKQEAgLTM1LDEwICszNSwxMCBAQCBlbmRlZgogYWxsOgogCUAkKGJ1aWxkX3RhcmdldF9m b3JfZWFjaF9tb2R1bGUpCiAKLWRlYnVnIGQgZGV2ZWxvcG1lbnQgZGV2IGRldmVsb3A6CitkZWJ1 ZyBkOgogCUAkKGJ1aWxkX3RhcmdldF9mb3JfZWFjaF9tb2R1bGUpCiAKLXJlbGVhc2UgciBkZXBs b3ltZW50IGRlcCBkZXBsb3k6CityZWxlYXNlIHI6CiAJQCQoYnVpbGRfdGFyZ2V0X2Zvcl9lYWNo X21vZHVsZSkKIAogcmVsZWFzZSthc3NlcnQgcmE6CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2I1ZWU2YzkzMzhlZWRmZDcwNzMwNDdhYzFiNDE3 YmI2ZGYyZTVjMC4uODllM2FiYjE1OWZhNDliNDQyM2UzMjhmYWJkODg0YmRjMjJhZGUwMCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI0IEBACisyMDIwLTA5LTIyICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKwor ICAgICAgICBVbmlmeSBkZWJ1ZyBhbmQgcmVsZWFzZSB0YXJnZXQgYWxpYXNlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2ODYzCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82OTQwNzc0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBbGwgTWFrZWZpbGVzIGhhdmUgImRlYnVnIiwgImQiLCAicmVsZWFz ZSIsIGFuZCAiciIgZm9yIGJ1aWxkCisgICAgICAgIHRhcmdldHMuIE90aGVycyAtLSBidXQgbm90 IGFsbCAtLSBhbHNvIGluY2x1ZGUgImRldiIsICJkZXZlbG9wIiwKKyAgICAgICAgImRldmVsb3Bt ZW50IiwgImRlcCIsICJkZXBsb3kiLCBhbmQgImRlcGxveW1lbnQiLiBCZWNhdXNlIG9mIHRoaXMK KyAgICAgICAgaW5jb25zaXN0ZW5jeSwgdHJ5aW5nIHRvIHVzZSB0aG9zZSBhZGRpdGlvbmFsIHRh cmdldHMgZGlkbid0IHdvcmsuIEl0CisgICAgICAgIGxvb2tzIGxpa2UgYWxsIE1ha2VmaWxlcyB1 c2VkIHRvIHN1cHBvcnQgYWxsIG9mIHRob3NlIHRhcmdldHMsIGJ1dAorICAgICAgICBzb21lIGdv dCBkcm9wcGVkIGFsb25nIHRoZSB3YXkuIEZvciBpbnN0YW5jZSwgdGhlIHRvcC1sZXZlbCBNYWtl ZmlsZQorICAgICAgICBhbmQgU291cmNlL01ha2VmaWxlIGRyb3BwZWQgdGhlbSBpbiAyMDEzIGFz IHBhcnQgb2YgQnVnIDEwNzg2My4gQW5kIGl0CisgICAgICAgIGxvb2tzIGxpa2UgV2ViS2l0TGli cmFyaWVzL01ha2VmaWxlIG5ldmVyIGhhZCB0aGVtLiBHaXZlbiB0aGF0IHRob3NlCisgICAgICAg IGFkZGl0aW9uYWwgdGFyZ2V0cyBkb24ndCB3b3JrLCBpdCBzZWVtcyBsaWtlIG5vIG9uZSB1c2Vz IHRoZW0sIHNvCisgICAgICAgIGxldCdzIHJlbW92ZSB0aGVtIGNvbXBsZXRlbHkuCisKKyAgICAg ICAgKiBNYWtlZmlsZToKKwogMjAyMC0wOS0yMiAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNjYwNzUpOiBXZWJDb250ZW50IHByb2Nlc3Mg Y3Jhc2hlcyBhdCBUZXh0TWFuaXB1bGF0aW9uQ29udHJvbGxlcjo6Z2V0UGF0aApkaWZmIC0tZ2l0 IGEvVG9vbHMvTWFrZWZpbGUgYi9Ub29scy9NYWtlZmlsZQppbmRleCAzMDk0Nzg5OTY0YjUwYWZh M2E3NjQyYjU2ZTM0N2M0MmU4ODllYjVlLi5lZThhMzM3ODAzZmZhYWRjODlkMGUzNWE2MDkwNjll ZTMwMWQ3MWJhIDEwMDY0NAotLS0gYS9Ub29scy9NYWtlZmlsZQorKysgYi9Ub29scy9NYWtlZmls ZQpAQCAtMzEsMTAgKzMxLDEwIEBAIGVuZGVmCiBhbGw6CiAJQCQoYnVpbGRfdGFyZ2V0X2Zvcl9l YWNoX21vZHVsZSkKIAotZGVidWcgZCBkZXZlbG9wbWVudCBkZXYgZGV2ZWxvcDoKK2RlYnVnIGQ6 CiAJQCQoYnVpbGRfdGFyZ2V0X2Zvcl9lYWNoX21vZHVsZSkKIAotcmVsZWFzZSByIGRlcGxveW1l bnQgZGVwIGRlcGxveToKK3JlbGVhc2UgcjoKIAlAJChidWlsZF90YXJnZXRfZm9yX2VhY2hfbW9k dWxlKQogCiByZWxlYXNlK2Fzc2VydCByYToKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCA1NGFkY2U3M2E5YTBhYTYxMTgyNjljOThiZWIwMjlmYjlhZWFiYWUyLi5mMmU0 ZDU2ZTQyZjc5Nzk5NWQxNzY3ZmE4YjIyMGI0ZmRiNmEyMTM4IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDktMjIgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFVuaWZ5IGRlYnVnIGFuZCByZWxl YXNlIHRhcmdldCBhbGlhc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTY4NjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5NDA3NzQ2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbCBNYWtlZmls ZXMgaGF2ZSAiZGVidWciLCAiZCIsICJyZWxlYXNlIiwgYW5kICJyIiBmb3IgYnVpbGQKKyAgICAg ICAgdGFyZ2V0cy4gT3RoZXJzIC0tIGJ1dCBub3QgYWxsIC0tIGFsc28gaW5jbHVkZSAiZGV2Iiwg ImRldmVsb3AiLAorICAgICAgICAiZGV2ZWxvcG1lbnQiLCAiZGVwIiwgImRlcGxveSIsIGFuZCAi ZGVwbG95bWVudCIuIEJlY2F1c2Ugb2YgdGhpcworICAgICAgICBpbmNvbnNpc3RlbmN5LCB0cnlp bmcgdG8gdXNlIHRob3NlIGFkZGl0aW9uYWwgdGFyZ2V0cyBkaWRuJ3Qgd29yay4gSXQKKyAgICAg ICAgbG9va3MgbGlrZSBhbGwgTWFrZWZpbGVzIHVzZWQgdG8gc3VwcG9ydCBhbGwgb2YgdGhvc2Ug dGFyZ2V0cywgYnV0CisgICAgICAgIHNvbWUgZ290IGRyb3BwZWQgYWxvbmcgdGhlIHdheS4gRm9y IGluc3RhbmNlLCB0aGUgdG9wLWxldmVsIE1ha2VmaWxlCisgICAgICAgIGFuZCBTb3VyY2UvTWFr ZWZpbGUgZHJvcHBlZCB0aGVtIGluIDIwMTMgYXMgcGFydCBvZiBCdWcgMTA3ODYzLiBBbmQgaXQK KyAgICAgICAgbG9va3MgbGlrZSBXZWJLaXRMaWJyYXJpZXMvTWFrZWZpbGUgbmV2ZXIgaGFkIHRo ZW0uIEdpdmVuIHRoYXQgdGhvc2UKKyAgICAgICAgYWRkaXRpb25hbCB0YXJnZXRzIGRvbid0IHdv cmssIGl0IHNlZW1zIGxpa2Ugbm8gb25lIHVzZXMgdGhlbSwgc28KKyAgICAgICAgbGV0J3MgcmVt b3ZlIHRoZW0gY29tcGxldGVseS4KKworICAgICAgICAqIE1ha2VmaWxlLnNoYXJlZDoKKwogMjAy MC0wOS0yMiAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVm YWN0b3IgYnVpbGQgcnVsZXMgaW4gTWFrZWZpbGVzIGFuZCBNYWtlZmlsZS5zaGFyZWQKZGlmZiAt LWdpdCBhL01ha2VmaWxlLnNoYXJlZCBiL01ha2VmaWxlLnNoYXJlZAppbmRleCBiNzc0YTEwNDI3 ZmJiYzJhYzdlNWZjYjMwYTgwYWI1MmExZGY2M2UwLi44MTBhM2VkYzYwNWEwY2M4N2IzNmFiN2Ey ODczZmU4Y2FhM2E4NzZjIDEwMDY0NAotLS0gYS9NYWtlZmlsZS5zaGFyZWQKKysrIGIvTWFrZWZp bGUuc2hhcmVkCkBAIC0xMDksMTEgKzEwOSwxMSBAQCBpZm5lcSAoLCQoc3RyaXAgJChBU0FOX09Q VElPTikgJChUU0FOX09QVElPTikgJChXS19MVE9fT1BUSU9OKSkpCiBlbmRpZgogCUAkKGNhbGwg aW52b2tlX3hjb2RlLCxHQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TPSckKEdDQ19QUkVQUk9D RVNTT1JfQURESVRJT05TKSAkJChpbmhlcml0ZWQpJykKIAotZGVidWcgZCBkZXZlbG9wbWVudCBk ZXYgZGV2ZWxvcDogZm9yY2UKK2RlYnVnIGQ6IGZvcmNlCiAJQCQoY2FsbCBzZXRfd2Via2l0X2Nv bmZpZ3VyYXRpb24sLS1kZWJ1ZykKIAlAJChjYWxsIGludm9rZV94Y29kZSwsR0NDX1BSRVBST0NF U1NPUl9ERUZJTklUSU9OUz0nJChHQ0NfUFJFUFJPQ0VTU09SX0FERElUSU9OUykgJCQoaW5oZXJp dGVkKScpCiAKLXJlbGVhc2UgciBkZXBsb3ltZW50IGRlcCBkZXBsb3k6IGZvcmNlCityZWxlYXNl IHI6IGZvcmNlCiAJQCQoY2FsbCBzZXRfd2Via2l0X2NvbmZpZ3VyYXRpb24sLS1yZWxlYXNlKQog CUAkKGNhbGwgaW52b2tlX3hjb2RlLCxHQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TPSckKEdD Q19QUkVQUk9DRVNTT1JfQURESVRJT05TKSAkJChpbmhlcml0ZWQpJykKIAo=