216860 2020-09-22 17:42:19 -0700 [GPU Process] fast/canvas/canvas-blend-image.html and fast/canvas/canvas-blend-solid.html fail on macOS 2020-09-22 20:42:18 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh dino sabouhallawa thorton webkit-bug-importer oldest_to_newest 1690956 0 wenson_hsieh 2020-09-22 17:42:19 -0700 SSIA 1690959 1 wenson_hsieh 2020-09-22 17:46:53 -0700 Super simple test case: ``` <canvas width="1" height="1"></canvas> <script> let canvas = document.querySelector("canvas"); let context = canvas.getContext("2d"); context.fillStyle = "red"; context.fillRect(0, 0, 1, 1); let data = context.getImageData(0, 0, 1, 1); document.write(`This is solid red (RGBA): ${data.data[0]}, ${data.data[1]}, ${data.data[2]}, ${data.data[3]}`); </script> ``` This is expected to output “This is solid red (RGBA): 255, 0, 0, 255”. However, when forcing unaccelerated remote image buffers using the GPU process, we get this instead: “This is solid red (RGBA): 0, 0, 255, 255” 1690963 2 409434 wenson_hsieh 2020-09-22 18:22:14 -0700 Created attachment 409434 Patch 1691002 3 409434 sabouhallawa 2020-09-22 20:07:08 -0700 Comment on attachment 409434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409434&action=review > Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:-63 > -#if PLATFORM(IOS_FAMILY) This change will affect all platforms including Cairo. But I think this is the right behavior even for the Cairo surface. 1691006 4 409434 wenson_hsieh 2020-09-22 20:23:48 -0700 Comment on attachment 409434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409434&action=review >> Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:-63 >> -#if PLATFORM(IOS_FAMILY) > > This change will affect all platforms including Cairo. But I think this is the right behavior even for the Cairo surface. 👍🏻 1691012 5 ews-feeder 2020-09-22 20:41:48 -0700 Committed r267459: <https://trac.webkit.org/changeset/267459> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409434. 1691013 6 webkit-bug-importer 2020-09-22 20:42:18 -0700 <rdar://problem/69410569> 409434 2020-09-22 18:22:14 -0700 2020-09-22 20:41:49 -0700 Patch bug-216860-20200922182213.patch text/plain 2307 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI0NjAzZWJkNGRjZTk1Y2Zk NWU3MjA5MWU1ODU2MzQ1MTRlMzJjOTguLjk5ZjdlOWU0MjU3NjdiN2MxN2UxN2JhNzQwMjI3NTE1 YjIyYWZmNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDktMjIgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVSBQcm9jZXNzXSBm YXN0L2NhbnZhcy9jYW52YXMtYmxlbmQtaW1hZ2UuaHRtbCBhbmQgZmFzdC9jYW52YXMvY2FudmFz LWJsZW5kLXNvbGlkLmh0bWwgZmFpbCBvbiBtYWNPUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2ODYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgdHdvIHRlc3RzIGRpc2FibGUgYWNjZWxlcmF0 ZWQgZHJhd2luZyBmb3IgY2FudmFzIGVsZW1lbnRzOyB3aGVuIHVzaW5nIHRoZSBHUFUgcHJvY2Vz cywgdGhpcyBjYXVzZXMgdXMgdG8KKyAgICAgICAgdXNlIGBJbWFnZUJ1ZmZlclNoYXJlYWJsZUJp dG1hcEJhY2tlbmRgIGFzIHRoZSBiYWNrLWVuZCBmb3IgdGhlIGltYWdlIGJ1ZmZlciBiYWNraW5n IHRoZSBjYW52YXMgZWxlbWVudC4KKworICAgICAgICBPbiBib3RoIG1hY09TIGFuZCBpT1MsIHRo ZSBpbWFnZSBidWZmZXIgaXMgYmFja2VkIGJ5IEJHUkEgaW1hZ2UgZGF0YS4gSG93ZXZlciwgd2Ug b3ZlcnJpZGUKKyAgICAgICAgYGJhY2tlbmRDb2xvckZvcm1hdCgpYCBhbmQgcmV0dXJuIGBDb2xv ckZvcm1hdDo6QkdSQWAgb25seSBmb3IgYFBMQVRGT1JNKElPU19GQU1JTFkpYCwgY2F1c2luZyBg cHV0SW1hZ2VEYXRhYAorICAgICAgICBhbmQgYGdldEltYWdlRGF0YWAgdG8gcmVzdWx0IGluIGZs aXBwZWQgcmVkIGFuZCBibHVlIGNoYW5uZWxzIG9uIG1hY09TLCB3aGljaCBzdWJzZXF1ZW50bHkg Y2F1c2VzIHRoZXNlIHR3bworICAgICAgICBsYXlvdXQgdGVzdHMgdG8gZmFpbC4KKworICAgICAg ICBGaXggdGhlc2UgdGVzdHMgYnkgcmVtb3ZpbmcgdGhlIGBQTEFURk9STShJT1NfRkFNSUxZKWAg Z3VhcmQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9JbWFnZUJ1ZmZlclNo YXJlYWJsZUJpdG1hcEJhY2tlbmQuaDoKKwogMjAyMC0wOS0yMSAgQmFzdWtlIFN1enVraSAgPGJh c3VrZS5zdXp1a2lAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXVtQbGF5U3RhdGlvbl0g U3VwcG9ydCBkaWZmZXJlbnQgaW5zdGFuY2VzIG9mIGxpc3RlbmVyIGNsaWVudC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvSW1hZ2VCdWZmZXJTaGFy ZWFibGVCaXRtYXBCYWNrZW5kLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBo aWNzL0ltYWdlQnVmZmVyU2hhcmVhYmxlQml0bWFwQmFja2VuZC5oCmluZGV4IDRhNzM3MjcxZTIy MmZiNGY2ZWRlOTllMTE0NTk3YWNlMWI0OWZkMWIuLjhkNGU4OGYwMGRhZGE3NzA2OGEwYTY3Yjcw OTRlMjU4ODI4MjEwNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUv Z3JhcGhpY3MvSW1hZ2VCdWZmZXJTaGFyZWFibGVCaXRtYXBCYWNrZW5kLmgKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9JbWFnZUJ1ZmZlclNoYXJlYWJsZUJpdG1h cEJhY2tlbmQuaApAQCAtNjAsOSArNjAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBwdXRJbWFnZURh dGEoV2ViQ29yZTo6QWxwaGFQcmVtdWx0aXBsaWNhdGlvbiBpbnB1dEZvcm1hdCwgY29uc3QgV2Vi Q29yZTo6SW1hZ2VEYXRhJiwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgc3JjUmVjdCwgY29uc3Qg V2ViQ29yZTo6SW50UG9pbnQmIGRlc3RQb2ludCwgV2ViQ29yZTo6QWxwaGFQcmVtdWx0aXBsaWNh dGlvbiBkZXN0Rm9ybWF0KSBvdmVycmlkZTsKIAogcHJpdmF0ZToKLSNpZiBQTEFURk9STShJT1Nf RkFNSUxZKQogICAgIENvbG9yRm9ybWF0IGJhY2tlbmRDb2xvckZvcm1hdCgpIGNvbnN0IG92ZXJy aWRlIHsgcmV0dXJuIENvbG9yRm9ybWF0OjpCR1JBOyB9Ci0jZW5kaWYKIAogICAgIFJlZlB0cjxT aGFyZWFibGVCaXRtYXA+IG1fYml0bWFwOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQ+IG1fY29udGV4dDsK