216830 2020-09-22 09:24:16 -0700 [GTK] REGRESSION(r267398): several hidpi tests are failing 2020-09-22 12:19:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino lmoura aperez lmoura webkit-bug-importer oldest_to_newest 1690729 0 dpino 2020-09-22 09:24:16 -0700 The following tests are failing after r267398: fast/hidpi/clip-text-in-hidpi.html [ Failure ] fast/hidpi/image-srcset-change-dynamically-from-js-2x.html [ Failure ] fast/hidpi/image-srcset-fraction-1.5x.html [ Failure ] fast/hidpi/image-srcset-fraction.html [ Failure ] fast/hidpi/image-srcset-invalid-inputs-except-one.html [ Failure ] fast/hidpi/image-srcset-simple-2x.html [ Failure ] fast/hidpi/image-srcset-simple-in-variable-2x.html [ Failure ] fast/hidpi/image-srcset-src-selection-2x.html [ Failure ] See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r267406%20(15968)/results.html 1690732 1 dpino 2020-09-22 09:29:39 -0700 Also: fast/hidpi/image-set-gradient-multi.html [ ImageOnlyFailure ] fast/hidpi/image-set-gradient.html [ ImageOnlyFailure ] 1690765 2 dpino 2020-09-22 10:23:35 -0700 These other tests also started failing in r267398: fast/dom/HTMLImageElement/sizes/image-sizes-2x.html [ Failure ] fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html [ Failure ] fast/events/mouse-cursor-image-set.html [ Failure http/tests/loading/sizes/preload-image-sizes-2x.html [ Failure ] 1690798 3 409386 lmoura 2020-09-22 11:54:38 -0700 Created attachment 409386 Patch 1690799 4 409386 aperez 2020-09-22 11:57:25 -0700 Comment on attachment 409386 Patch Thanks for submitting this… View in context: https://bugs.webkit.org/attachment.cgi?id=409386&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:-3758 > -#if USE(CAIRO) && !HAVE(CAIRO_SURFACE_SET_DEVICE_SCALE) Ouch, I feel silly for missing this in r267398 — I checked my shell history and it turns out that I grepped around for HAVE_CAIRO_SURFACE_SET_DEVICE_SCALE instead of just CAIRO_SURFACE_SET_DEVICE_SCALE 🤦️ 1690813 5 ews-feeder 2020-09-22 12:18:22 -0700 Committed r267431: <https://trac.webkit.org/changeset/267431> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409386. 1690814 6 webkit-bug-importer 2020-09-22 12:19:17 -0700 <rdar://problem/69385138> 409386 2020-09-22 11:54:38 -0700 2020-09-22 12:18:23 -0700 Patch bug-216830-20200922155436.patch text/plain 1493 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFlMzRjMTg4NWVlOWUwZjFh MTZmZjM0ZTFiYzc4YjkzODhmYjZiZDEuLjBiMWRkMWRhYTQ2NzM5MmQ4ODNkMjdkYjJmYTlmNjJj MWZhYzI0YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDktMjIgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUkVHUkVTU0lPTihyMjY3 Mzk4KTogc2V2ZXJhbCBoaWRwaSB0ZXN0cyBhcmUgZmFpbGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2ODMwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRDdXN0b21EZXZpY2VTY2FsZUZh Y3Rvcik6IFJlbW92ZSBjaGVjayBmb3IgcmVtb3ZlZCBkZWZpbmUuCisKIDIwMjAtMDktMjIgIFBl ciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gU3Rh cnQgY29sbGVjdGluZyB0ZWxlbWV0cnkgZnJvbSBhIHNldCBvZiBYUEMgc2VydmljZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGQzYjhjMzU1NDBmM2YyNDU2 ZjcxMDU1ZjViNGQ3YTc4MjI2MGQzODcuLjVlZGY0MzI5YWQ1MDg1YWQ0YTQ0MmE2ZTA3YmQ0NjAw NjJmNjdjZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAt Mzc1MywxMiArMzc1Myw2IEBAIGZsb2F0IFdlYlBhZ2VQcm94eTo6ZGV2aWNlU2NhbGVGYWN0b3Io KSBjb25zdAogCiB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0Q3VzdG9tRGV2aWNlU2NhbGVGYWN0b3Io ZmxvYXQgY3VzdG9tU2NhbGVGYWN0b3IpCiB7Ci0gICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9u Y2Ugd2UgYnVtcCBjYWlybyByZXF1aXJlbWVudHMgdG8gc3VwcG9ydCBIaURQSS4KLSAgICAvLyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzc4Ci0jaWYgVVNFKENB SVJPKSAmJiAhSEFWRShDQUlST19TVVJGQUNFX1NFVF9ERVZJQ0VfU0NBTEUpCi0gICAgcmV0dXJu OwotI2VuZGlmCi0KICAgICBpZiAobV9jdXN0b21EZXZpY2VTY2FsZUZhY3RvciAmJiBtX2N1c3Rv bURldmljZVNjYWxlRmFjdG9yLnZhbHVlKCkgPT0gY3VzdG9tU2NhbGVGYWN0b3IpCiAgICAgICAg IHJldHVybjsKIAo=