216825 2020-09-22 08:41:53 -0700 Correct instructions for building iOS in ReadMe 2020-09-25 01:39:35 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207043 InRadar P2 Normal --- 1 jbedard jbedard ddkilzer jbedard krollin pancfmiaomiao webkit-bug-importer oldest_to_newest 1690708 0 jbedard 2020-09-22 08:41:53 -0700 Chenfeng pointed out in https://bugs.webkit.org/show_bug.cgi?id=207043 that I forgot to update our top level ReadMe to agree with https://webkit.org/building-webkit/. 1690711 1 webkit-bug-importer 2020-09-22 08:44:18 -0700 <rdar://problem/69372654> 1690715 2 409363 jbedard 2020-09-22 08:49:43 -0700 Created attachment 409363 Patch 1690740 3 409363 ddkilzer 2020-09-22 09:39:54 -0700 Comment on attachment 409363 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409363&action=review > ReadMe.md:99 > +where `platform` is `ios`, `tvos` or `watchos`. Are we sure this is `tvos` and not `appletv`? I've made that mistaken many times. :) 1690741 4 jbedard 2020-09-22 09:41:48 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 409363 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409363&action=review > > > ReadMe.md:99 > > +where `platform` is `ios`, `tvos` or `watchos`. > > Are we sure this is `tvos` and not `appletv`? I've made that mistaken many > times. :) Yes, I made sure to check what our builders are passing: https://build.webkit.org/builders/Apple-tvOS-Simulator-13-Release-Build/builds/2605/steps/compile-webkit/logs/stdio 1690746 5 ews-feeder 2020-09-22 09:45:53 -0700 Committed r267416: <https://trac.webkit.org/changeset/267416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409363. 1691810 6 pancfmiaomiao 2020-09-25 01:39:35 -0700 (In reply to Jonathan Bedard from comment #0) > Chenfeng pointed out in https://bugs.webkit.org/show_bug.cgi?id=207043 that > I forgot to update our top level ReadMe to agree with > https://webkit.org/building-webkit/. Sorry I just check my email today. And I find a shell command also needing to be updated. 409363 2020-09-22 08:49:43 -0700 2020-09-22 09:45:54 -0700 Patch bug-216825-20200922084943.patch text/plain 2430 jbedard SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NzQw OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA5 LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBDb3Jy ZWN0IGluc3RydWN0aW9ucyBmb3IgYnVpbGRpbmcgaU9TIGluIFJlYWRNZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2ODI1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS82OTM3MjY1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFJlYWRNZS5tZDogVXBkYXRlIGlPUyBidWlsZCBpbnN0cnVjdGlvbnMg dG8gYXBwbHkgdG8gYWxsIGVtYmVkZGVkIHBsYXRmb3Jtcy4KKwogMjAyMC0wOS0yMSAgQWRyaWFu IFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0g VXNlIGltcG9ydGVkIHRhcmdldHMgaW4gZmluZCBtb2R1bGUgZm9yIHRoZSBBVEsgU1BJMiBicmlk Z2UgZGVwZW5kZW5jeQpJbmRleDogUmVhZE1lLm1kCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFJlYWRNZS5tZAko cmV2aXNpb24gMjY3NDA5KQorKysgUmVhZE1lLm1kCSh3b3JraW5nIGNvcHkpCkBAIC03NSw5ICs3 NSw5IEBAIFlvdSBjYW4gb3BlbiBgV2ViS2l0Lnhjd29ya3NwYWNlYCB0byBidWkKIAogSWYgeW91 IGRvbid0IHVzZSBhIGN1c3RvbSBidWlsZCBsb2NhdGlvbiBpbiBYY29kZSBwcmVmZXJlbmNlcywg eW91IGhhdmUgdG8gdXBkYXRlIHRoZSB3b3Jrc3BhY2Ugc2V0dGluZ3MgdG8gdXNlIGBXZWJLaXRC dWlsZGAgZGlyZWN0b3J5LiAgSW4gbWVudSBiYXIsIGNob29zZSBGaWxlID4gV29ya3NwYWNlIFNl dHRpbmdzLCB0aGVuIGNsaWNrIHRoZSBBZHZhbmNlZCBidXR0b24sIHNlbGVjdCAiQ3VzdG9tIiwg IlJlbGF0aXZlIHRvIFdvcmtzcGFjZSIsIGFuZCBlbnRlciBgV2ViS2l0QnVpbGRgIGZvciBib3Ro IFByb2R1Y3RzIGFuZCBJbnRlcm1lZGlhdGVzLgogCi0jIyMgQnVpbGRpbmcgaU9TIFBvcnQKKyMj IyBFbWJlZGRlZCBCdWlsZHMKIAotVGhlIGZpcnN0IHRpbWUgYWZ0ZXIgeW91IGluc3RhbGwgYSBu ZXcgWGNvZGUsIHlvdSB3aWxsIG5lZWQgdG8gcnVuIHRoZSBmb2xsb3dpbmcgY29tbWFuZCB0byBl bmFibGUgWGNvZGUgdG8gYnVpbGQgY29tbWFuZCBsaW5lIHRvb2xzIGZvciBpT1MgU2ltdWxhdG9y OgoraU9TLCB0dk9TIGFuZCB3YXRjaE9TIGFyZSBhbGwgY29uc2lkZXJlZCBlbWJlZGRlZCBidWls ZHMuIFRoZSBmaXJzdCB0aW1lIGFmdGVyIHlvdSBpbnN0YWxsIGEgbmV3IFhjb2RlLCB5b3Ugd2ls bCBuZWVkIHRvIHJ1bjoKIAogYGBgCiBzdWRvIFRvb2xzL1NjcmlwdHMvY29uZmlndXJlLXhjb2Rl LWZvci1pb3MtZGV2ZWxvcG1lbnQKQEAgLTg1LDEyICs4NSwxOSBAQCBzdWRvIFRvb2xzL1Njcmlw dHMvY29uZmlndXJlLXhjb2RlLWZvci1pCiAKIFdpdGhvdXQgdGhpcyBzdGVwLCB5b3Ugd2lsbCBz ZWUgdGhlIGVycm9yIG1lc3NhZ2U6ICJgdGFyZ2V0IHNwZWNpZmllcyBwcm9kdWN0IHR5cGUg4oCY Y29tLmFwcGxlLnByb2R1Y3QtdHlwZS50b29s4oCZLCBidXQgdGhlcmXigJlzIG5vIHN1Y2ggcHJv ZHVjdCB0eXBlIGZvciB0aGUg4oCYaXBob25lc2ltdWxhdG9y4oCZIHBsYXRmb3JtLmAiIHdoZW4g YnVpbGRpbmcgdGFyZ2V0IGBKU0NMTEludE9mZnNldHNFeHRyYWN0b3JgIG9mIHByb2plY3QgYEph dmFTY3JpcHRDb3JlYC4KIAotUnVuIHRoZSBmb2xsb3dpbmcgY29tbWFuZCB0byBidWlsZCBhIGRl YnVnIGJ1aWxkIHdpdGggZGVidWdnaW5nIHN5bWJvbHMgYW5kIGFzc2VydGlvbnMgZm9yIGlPUzoK K1J1biB0aGUgZm9sbG93aW5nIGNvbW1hbmQgdG8gYnVpbGQgYSBkZWJ1ZyBidWlsZCB3aXRoIGRl YnVnZ2luZyBzeW1ib2xzIGFuZCBhc3NlcnRpb25zIGZvciBlbWJlZGVkZGVkIHNpbXVsYXRvcnM6 CiAKIGBgYAotVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1kZWJ1ZyAtLWlvcy1zaW11bGF0 b3IKK1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IC0tZGVidWcgLS08cGxhdGZvcm0+LXNpbXVs YXRvcgogYGBgCiAKK29yIGVtYmVkZGVkIGRldmljZXM6CitgYGAKK1Rvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0IC0tZGVidWcgLS08cGxhdGZvcm0+LWRldmljZQorYGBgCisKK3doZXJlIGBwbGF0 Zm9ybWAgaXMgYGlvc2AsIGB0dm9zYCBvciBgd2F0Y2hvc2AuCisKICMjIyBCdWlsZGluZyB0aGUg R1RLKyBQb3J0CiAKIEZvciBwcm9kdWN0aW9uIGJ1aWxkczoK