216757 2020-09-20 20:13:04 -0700 [LFC][BFC] Move hasClearance out of BoxGeometry 2020-09-21 12:16:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1690239 0 zalan 2020-09-20 20:13:04 -0700 It belongs in BlockFormattingState 1690240 1 409255 zalan 2020-09-20 20:15:59 -0700 Created attachment 409255 Patch 1690293 2 409255 sam 2020-09-21 06:31:17 -0700 Comment on attachment 409255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409255&action=review > Source/WebCore/ChangeLog:8 > + Do not cache the hasClearance state in BoxGeometry. Would be good to include the rationale for this change here. 1690302 3 ews-feeder 2020-09-21 06:49:12 -0700 Committed r267343: <https://trac.webkit.org/changeset/267343> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409255. 1690416 4 webkit-bug-importer 2020-09-21 12:16:40 -0700 <rdar://problem/69319234> 409255 2020-09-20 20:15:59 -0700 2020-09-21 06:49:13 -0700 Patch bug-216757-20200920201558.patch text/plain 7041 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY1YmExZjkxNjA1M2M3 MWIxYmFkN2ZlNjcyODhhZTViYjM0MjhlYi4uNzM1MTE3ZjU1ZWVhYjJlNWI0MjY4MjAzYzU0ZGMw ZWY5NmQ5NmQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTA5LTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBNb3ZlIGhh c0NsZWFyYW5jZSBvdXQgb2YgQm94R2VvbWV0cnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjc1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBjYWNoZSB0aGUgaGFzQ2xlYXJhbmNlIHN0YXRl IGluIEJveEdlb21ldHJ5LgorCisgICAgICAgICogbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9j a0Zvcm1hdHRpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tG b3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZVZlcnRpY2FsUG9zaXRpb25Gb3JGbG9hdENsZWFyKToK KyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6dmVydGlj YWxQb3NpdGlvbldpdGhNYXJnaW4gY29uc3QpOgorICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1h dHRpbmcvQmxvY2tGb3JtYXR0aW5nU3RhdGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 QmxvY2tGb3JtYXR0aW5nU3RhdGU6OnNldEhhc0NsZWFyYW5jZSk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ1N0YXRlOjpjbGVhckNsZWFyYW5jZSk6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ1N0YXRlOjpoYXNDbGVhcmFuY2UgY29u c3QpOgorICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBz ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6 Ok1hcmdpbkNvbGxhcHNlOjpoYXNDbGVhcmFuY2UgY29uc3QpOgorICAgICAgICAqIGxheW91dC9s YXlvdXR0cmVlL0xheW91dEJveEdlb21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6Qm94R2VvbWV0cnk6OkJveEdlb21ldHJ5KToKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJl ZS9MYXlvdXRCb3hHZW9tZXRyeS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCb3hHZW9t ZXRyeTo6aGFzQ2xlYXJhbmNlIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6Qm94R2VvbWV0cnk6OnNldEhhc0NsZWFyYW5jZSk6IERlbGV0ZWQuCisKIDIwMjAtMDkt MjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNd IElubGluZUZvcm1hdHRpbmdTdGF0ZSBzaG91bGQgbm90IHN0b3JlIGRpc3BsYXkgbGluZXMgYW5k IHJ1bnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcv QmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tm b3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IDM1NjFkYWY0NTgxNDVj OTVkYTJjMjU3NWFhODc2NjQzYTZhOGQ2YTkuLmFiMzE1ZjE1ZjBlMDI0MWJlZjdmZTMzOGY1ZWVj OWQyODFiYzI5OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1h dHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcApAQCAtMzEzLDcg KzMxMyw3IEBAIHZvaWQgQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZVZlcnRpY2FsUG9z aXRpb25Gb3JGbG9hdENsZWFyKGNvbnN0IEZsb2F0aW5nCiAgICAgQVNTRVJUKCp2ZXJ0aWNhbFBv c2l0aW9uQW5kQ2xlYXJhbmNlLnBvc2l0aW9uID49IGJveEdlb21ldHJ5LmxvZ2ljYWxUb3AoKSk7 CiAgICAgYm94R2VvbWV0cnkuc2V0TG9naWNhbFRvcCgqdmVydGljYWxQb3NpdGlvbkFuZENsZWFy YW5jZS5wb3NpdGlvbik7CiAgICAgaWYgKHZlcnRpY2FsUG9zaXRpb25BbmRDbGVhcmFuY2UuY2xl YXJhbmNlKQotICAgICAgICBib3hHZW9tZXRyeS5zZXRIYXNDbGVhcmFuY2UoKTsKKyAgICAgICAg Zm9ybWF0dGluZ1N0YXRlKCkuc2V0SGFzQ2xlYXJhbmNlKGxheW91dEJveCk7CiAgICAgLy8gRklY TUU6IFJlc2V0IHRoZSBtYXJnaW4gdmFsdWVzIG9uIHRoZSBhbmNlc3RvcnMvcHJldmlvdXMgc2li bGluZ3Mgbm93IHRoYXQgdGhlIGZsb2F0IGF2b2lkZXIgd2l0aCBjbGVhcmFuY2UgZG9lcyBub3Qg bWFyZ2luIGNvbGxhcHNlIGFueW1vcmUuCiB9CiAKQEAgLTQ3Nyw3ICs0NzcsNyBAQCBMYXlvdXRV bml0IEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OnZlcnRpY2FsUG9zaXRpb25XaXRoTWFyZ2luKGNv bnN0IEJveCYgbGF5b3V0QgogICAgIC8vIDMuIENoZWNrIGlmIHRoZSBwcmV2aW91cyBib3gncyBt YXJnaW5zIGNvbGxhcHNlIHRocm91Z2guIElmIG5vdCAtPiByZXR1cm4gcHJldmlvdXMgYm94JyBi b3R0b20gZXhjbHVkaW5nIG1hcmdpbiBhZnRlciArIG1hcmdpbkJlZm9yZSAodGhleSBhcmUgc3Vw cG9zZWQgdG8gYmUgZXF1YWwpCiAgICAgLy8gNC4gR28gdG8gcHJldmlvdXMgYm94IGFuZCBzdGFy dCBmcm9tIHN0ZXAgIzEgdW50aWwgd2UgaGl0IHRoZSBwYXJlbnQgYm94LgogICAgIGF1dG8mIGJv eEdlb21ldHJ5ID0gZ2VvbWV0cnlGb3JCb3gobGF5b3V0Qm94KTsKLSAgICBpZiAoYm94R2VvbWV0 cnkuaGFzQ2xlYXJhbmNlKCkpCisgICAgaWYgKGZvcm1hdHRpbmdTdGF0ZSgpLmhhc0NsZWFyYW5j ZShsYXlvdXRCb3gpKQogICAgICAgICByZXR1cm4gYm94R2VvbWV0cnkubG9naWNhbFRvcCgpOwog CiAgICAgYXV0byogY3VycmVudExheW91dEJveCA9ICZsYXlvdXRCb3g7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ1N0YXRl LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGlu Z1N0YXRlLmgKaW5kZXggZmIyOGM5MmQ3MTg0YzAyMzE5Y2MzOTQ4ZThhZmQ3NWQ2ZjVmYjY2Yy4u MWU2Y2Q2MTlkZDMxNmY1OWIzZjQwOWJmMzVkNzA5NmQ5ZmI3YzhiMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdTdGF0ZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0 aW5nU3RhdGUuaApAQCAtMjksNiArMjksNyBAQAogCiAjaW5jbHVkZSAiRm9ybWF0dGluZ1N0YXRl LmgiCiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvYy5oPgorI2luY2x1ZGUgPHd0Zi9XZWFrSGFzaFNl dC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiBuYW1lc3BhY2UgTGF5b3V0IHsKQEAgLTQ0LDgg KzQ1LDEzIEBAIHB1YmxpYzoKICAgICBVc2VkVmVydGljYWxNYXJnaW4gdXNlZFZlcnRpY2FsTWFy Z2luKGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdCB7IHJldHVybiBtX3VzZWRWZXJ0aWNhbE1h cmdpbnMuZ2V0KCZsYXlvdXRCb3gpOyB9CiAgICAgYm9vbCBoYXNVc2VkVmVydGljYWxNYXJnaW4o Y29uc3QgQm94JiBsYXlvdXRCb3gpIGNvbnN0IHsgcmV0dXJuIG1fdXNlZFZlcnRpY2FsTWFyZ2lu cy5jb250YWlucygmbGF5b3V0Qm94KTsgfQogCisgICAgdm9pZCBzZXRIYXNDbGVhcmFuY2UoY29u c3QgQm94JiBsYXlvdXRCb3gpIHsgbV9jbGVhcmFuY2VTZXQuYWRkKGxheW91dEJveCk7IH0KKyAg ICB2b2lkIGNsZWFySGFzQ2xlYXJhbmNlKGNvbnN0IEJveCYgbGF5b3V0Qm94KSB7IG1fY2xlYXJh bmNlU2V0LnJlbW92ZShsYXlvdXRCb3gpOyB9CisgICAgYm9vbCBoYXNDbGVhcmFuY2UoY29uc3Qg Qm94JiBsYXlvdXRCb3gpIGNvbnN0IHsgcmV0dXJuIG1fY2xlYXJhbmNlU2V0LmNvbnRhaW5zKGxh eW91dEJveCk7IH0KKwogcHJpdmF0ZToKICAgICBIYXNoTWFwPGNvbnN0IEJveCosIFVzZWRWZXJ0 aWNhbE1hcmdpbj4gbV91c2VkVmVydGljYWxNYXJnaW5zOworICAgIFdlYWtIYXNoU2V0PGNvbnN0 IEJveD4gbV9jbGVhcmFuY2VTZXQ7CiB9OwogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcApp bmRleCBlMDI0MzliNmEyOTAyZjJiMDRjMWVhMzRlMzM4MzI1OTFkYjQ1YTE5Li43NGQ2YmY4MDJk MGJmZGRkZGE3OTkyYTNkOTY3NjAwODc3YmY3MzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5j cHAKQEAgLTg3LDkgKzg3LDcgQEAgYm9vbCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5D b2xsYXBzZTo6aGFzQ2xlYXJhbmNlKGNvbnN0IEJveCYgbGF5b3V0Qm94KQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgLy8gRklYTUU6IHByZWNvbXB1dGVkVmVydGljYWxQb3NpdGlvbkZvckZv cm1hdHRpbmdSb290IGxvZ2ljIGVuZHMgdXAgY2FsbGluZyBpbnRvIHRoaXMgZnVuY3Rpb24gd2hl biB0aGUgbGF5b3V0Qm94IChmaXJzdCBpbmZsb3cgY2hpbGQpIGhhcwogICAgIC8vIG5vdCBiZWVu IGxhaWQgb3V0LgotICAgIGlmICghbGF5b3V0U3RhdGUoKS5oYXNCb3hHZW9tZXRyeShsYXlvdXRC b3gpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgcmV0dXJuIGZvcm1hdHRpbmdDb250ZXh0 KCkuZ2VvbWV0cnlGb3JCb3gobGF5b3V0Qm94KS5oYXNDbGVhcmFuY2UoKTsKKyAgICByZXR1cm4g Zm9ybWF0dGluZ0NvbnRleHQoKS5mb3JtYXR0aW5nU3RhdGUoKS5oYXNDbGVhcmFuY2UobGF5b3V0 Qm94KTsKIH0KIAogYm9vbCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5Db2xsYXBzZTo6 bWFyZ2luQmVmb3JlQ29sbGFwc2VzV2l0aFBhcmVudE1hcmdpbkFmdGVyKGNvbnN0IEJveCYgbGF5 b3V0Qm94KSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRy ZWUvTGF5b3V0Qm94R2VvbWV0cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRy ZWUvTGF5b3V0Qm94R2VvbWV0cnkuY3BwCmluZGV4IGQ3YTk2ZWJkZDMzOWY3MDY5NzRkNzMzMDE3 OTY2MDFjYWEzNjQ2YmEuLjYxZDVkMmJmNDA1OGVmN2RhYTU5OTBhNzRhYTE1ZWU3MTRmMjQ2OWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveEdl b21ldHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRC b3hHZW9tZXRyeS5jcHAKQEAgLTQxLDcgKzQxLDYgQEAgQm94R2VvbWV0cnk6OkJveEdlb21ldHJ5 KGNvbnN0IEJveEdlb21ldHJ5JiBvdGhlcikKICAgICAsIG1fY29udGVudEhlaWdodChvdGhlci5t X2NvbnRlbnRIZWlnaHQpCiAgICAgLCBtX2hvcml6b250YWxNYXJnaW4ob3RoZXIubV9ob3Jpem9u dGFsTWFyZ2luKQogICAgICwgbV92ZXJ0aWNhbE1hcmdpbihvdGhlci5tX3ZlcnRpY2FsTWFyZ2lu KQotICAgICwgbV9oYXNDbGVhcmFuY2Uob3RoZXIubV9oYXNDbGVhcmFuY2UpCiAgICAgLCBtX2Jv cmRlcihvdGhlci5tX2JvcmRlcikKICAgICAsIG1fcGFkZGluZyhvdGhlci5tX3BhZGRpbmcpCiAj aWYgQVNTRVJUX0VOQUJMRUQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlv dXR0cmVlL0xheW91dEJveEdlb21ldHJ5LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0 dHJlZS9MYXlvdXRCb3hHZW9tZXRyeS5oCmluZGV4IDg1YmM3NGYyN2U5NmY3MTQzMGRhYTE5MWY5 ZGE3YWZmZGFkZjlmMGMuLmY3ODFkMzU4YTgxYjQyOGMxZmM1ZTBjOGZmZGEwZmZiZjQyZTdkYTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveEdl b21ldHJ5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94 R2VvbWV0cnkuaApAQCAtNzEsNyArNzEsNiBAQCBwdWJsaWM6CiAgICAgTGF5b3V0VW5pdCBtYXJn aW5TdGFydCgpIGNvbnN0OwogICAgIExheW91dFVuaXQgbWFyZ2luQWZ0ZXIoKSBjb25zdDsKICAg ICBMYXlvdXRVbml0IG1hcmdpbkVuZCgpIGNvbnN0OwotICAgIGJvb2wgaGFzQ2xlYXJhbmNlKCkg Y29uc3QgeyByZXR1cm4gbV9oYXNDbGVhcmFuY2U7IH0KIAogICAgIExheW91dFVuaXQgYm9yZGVy VG9wKCkgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCBib3JkZXJMZWZ0KCkgY29uc3Q7CkBAIC0xMzEs NyArMTMwLDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRIb3Jpem9udGFsTWFyZ2luKEhvcml6 b250YWxNYXJnaW4pOwogICAgIHZvaWQgc2V0VmVydGljYWxNYXJnaW4oVmVydGljYWxNYXJnaW4p OwotICAgIHZvaWQgc2V0SGFzQ2xlYXJhbmNlKCkgeyBtX2hhc0NsZWFyYW5jZSA9IHRydWU7IH0K IAogICAgIHZvaWQgc2V0Qm9yZGVyKExheW91dDo6RWRnZXMpOwogCkBAIC0xNjMsNyArMTYxLDYg QEAgcHJpdmF0ZToKIAogICAgIEhvcml6b250YWxNYXJnaW4gbV9ob3Jpem9udGFsTWFyZ2luOwog ICAgIFZlcnRpY2FsTWFyZ2luIG1fdmVydGljYWxNYXJnaW47Ci0gICAgYm9vbCBtX2hhc0NsZWFy YW5jZSB7IGZhbHNlIH07CiAKICAgICBMYXlvdXQ6OkVkZ2VzIG1fYm9yZGVyOwogICAgIE9wdGlv bmFsPExheW91dDo6RWRnZXM+IG1fcGFkZGluZzsK