216741 2020-09-19 19:39:19 -0700 Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node 2020-09-21 12:01:30 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 216325 1 darin darin achristensen cdumez esprehn+autocc ews-watchlist kondapallykalyan rniwa sam webkit-bug-importer wenson_hsieh oldest_to_newest 1690140 0 darin 2020-09-19 19:39:19 -0700 Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node 1690141 1 409221 darin 2020-09-19 19:46:47 -0700 Created attachment 409221 Patch 1690151 2 409221 rniwa 2020-09-19 21:42:06 -0700 Comment on attachment 409221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review > Source/WebCore/ChangeLog:8 > + This is covered by tests, but the fix itself is only testable when live range Can we add a test with <!-- test-runner-options? 1690177 3 darin 2020-09-20 11:01:56 -0700 We could, but do you want me to add tests that duplicate the WPT ones that we will just delete when we turn the flag on? I don’t think we should. 1690178 4 409221 darin 2020-09-20 11:03:41 -0700 Comment on attachment 409221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review >> Source/WebCore/ChangeLog:8 >> + This is covered by tests, but the fix itself is only testable when live range > > Can we add a test with <!-- test-runner-options? I’d prefer not to add tests that duplicate the Web Platform Tests coverage. But obviously in this one simple case I could add it. I just don’t think it’s valuable. The Web Platform Tests will be there when we turn the flag on. 1690183 5 ews-feeder 2020-09-20 11:10:24 -0700 Committed r267327: <https://trac.webkit.org/changeset/267327> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409221. 1690384 6 webkit-bug-importer 2020-09-21 12:01:30 -0700 <rdar://problem/69318338> 409221 2020-09-19 19:46:47 -0700 2020-09-20 11:10:24 -0700 Patch bug-216741-20200919194647.patch text/plain 3608 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ4NDE5MTE0YWY5YzZk YWNhYjgxMTFlY2E2MzAxMTRlMDkzYjBmNS4uNDk1MjQ4ZWM2MTNlYmMzNWRkOWM4YWQzMjY1NmU3 ZjU2MjdiODUwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA5LTE5ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTZWxlY3Rpb24gQVBJOiBGaXgg c2VsZWN0QWxsQ2hpbGRlbiB0byByZXR1cm4gSW52YWxpZE5vZGVUeXBlRXJyb3Igd2hlbiBwYXNz ZWQgYSBEb2N1bWVudFR5cGUgbm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE2NzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBpcyBjb3ZlcmVkIGJ5IHRlc3RzLCBidXQgdGhlIGZpeCBpdHNl bGYgaXMgb25seSB0ZXN0YWJsZSB3aGVuIGxpdmUgcmFuZ2UKKyAgICAgICAgc2VsZWN0aW9uIGlz IGVuYWJsZWQuIFNvIGZvciBub3cgdGhlIG90aGVyIHRlc3RzIGFyZSBzaW1wbHkgY2hlY2tpbmcg dGhhdCBubworICAgICAgICByZWdyZXNzaW9uIG9yIGJlaGF2aW9yIGNoYW5nZSB3YXMgaW50cm9k dWNlZCBieSBhY2NpZGVudC4KKworICAgICAgICAqIHBhZ2UvRE9NU2VsZWN0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRPTVNlbGVjdGlvbjo6c2VsZWN0QWxsQ2hpbGRyZW4pOiBSZXR1cm4g dGhlIHZhbHVlIHJldHVybmVkIGJ5CisgICAgICAgIHNldEJhc2VBbmRFeHRlbnQgc28gd2UgZG9u J3QgZGlzY2FyZCBhbnkgZXhjZXB0aW9uIGl0IG1pZ2h0IHRocm93LiBJbgorICAgICAgICBwcmFj dGljZSwgdGhhdCdzIG9ubHkgdGhpcyBvbmUuCisgICAgICAgICogcGFnZS9ET01TZWxlY3Rpb24u aDogVXBkYXRlZCByZXR1cm4gdHlwZSBzbyB3ZSBjYW4gdGhyb3cgYW4gZXhjZXB0aW9uLgorICAg ICAgICAqIHBhZ2UvRE9NU2VsZWN0aW9uLmlkbDogQWRkZWQgTWF5VGhyb3dFeGNlcHRpb24uCisK IDIwMjAtMDktMTkgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAg ICAgICAgIEltcGxlbWVudGF0aW9uIGZvciBBWElzb2xhdGVkT2JqZWN0OjpuZXh0U2libGluZyBh bmQgcHJldmlvdXNTaWJsaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01T ZWxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24uY3BwCmluZGV4 IDI5OTcwMmU3MmEzZmE4ZmM4NjY1YmY3NmEwZTdiM2I2OTMxYmU4YTcuLmFjNmVmZGJkMTljMDJm ZDY2OTcyYjZjZmM0OTFkZWYwNDU0NjM2YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NU2VsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlv bi5jcHAKQEAgLTQxMiwxMCArNDEyLDExIEBAIGJvb2wgRE9NU2VsZWN0aW9uOjpjb250YWluc05v ZGUoTm9kZSYgbm9kZSwgYm9vbCBhbGxvd1BhcnRpYWwpIGNvbnN0CiAgICAgcmV0dXJuIHJhbmdl ICYmIChhbGxvd1BhcnRpYWwgPyBpbnRlcnNlY3RzKCpyYW5nZSwgbm9kZSkgOiBjb250YWlucygq cmFuZ2UsIG5vZGUpKTsKIH0KIAotdm9pZCBET01TZWxlY3Rpb246OnNlbGVjdEFsbENoaWxkcmVu KE5vZGUmIG5vZGUpCitFeGNlcHRpb25Pcjx2b2lkPiBET01TZWxlY3Rpb246OnNlbGVjdEFsbENo aWxkcmVuKE5vZGUmIG5vZGUpCiB7Ci0gICAgLy8gVGhpcyBkb2Vzbid0IChhbmQgc2hvdWxkbid0 KSBzZWxlY3QgdGV4dCBub2RlIGNoYXJhY3RlcnMuCi0gICAgc2V0QmFzZUFuZEV4dGVudCgmbm9k ZSwgMCwgJm5vZGUsIG5vZGUuY291bnRDaGlsZE5vZGVzKCkpOworICAgIC8vIFRoaXMgZG9lc24n dCAoYW5kIHNob3VsZG4ndCkgc2VsZWN0IHRoZSBjaGFyYWN0ZXJzIGluIGEgbm9kZSBpZiBwYXNz ZWQgYSB0ZXh0IG5vZGUuCisgICAgLy8gU2VsZWN0aW9uIEFQSSBzcGVjaWZpY2F0aW9uIHNlZW1z IHRvIGhhdmUgdGhpcyB3cm9uZzogaHR0cHM6Ly9naXRodWIuY29tL3czYy9zZWxlY3Rpb24tYXBp L2lzc3Vlcy8xMjUKKyAgICByZXR1cm4gc2V0QmFzZUFuZEV4dGVudCgmbm9kZSwgMCwgJm5vZGUs IG5vZGUuY291bnRDaGlsZE5vZGVzKCkpOwogfQogCiBTdHJpbmcgRE9NU2VsZWN0aW9uOjp0b1N0 cmluZygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlv bi5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24uaAppbmRleCAwMmQwMGY2ZGI1 ODBmN2IyOGJkNTJlN2I2Njc1OTQxMjg0ZTNiZjJhLi41NDFiZTQyMzk4N2Y3YTQ0NDBlMTE1ZTlh MWQzZjE1MWQ0NjA4MWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVNlbGVj dGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmgKQEAgLTc2LDcg Kzc2LDcgQEAgcHVibGljOgogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHJlbW92ZVJhbmdlKFJhbmdl Jik7CiAgICAgdm9pZCBkZWxldGVGcm9tRG9jdW1lbnQoKTsKICAgICBib29sIGNvbnRhaW5zTm9k ZShOb2RlJiwgYm9vbCBwYXJ0bHlDb250YWluZWQpIGNvbnN0OwotICAgIHZvaWQgc2VsZWN0QWxs Q2hpbGRyZW4oTm9kZSYpOworICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHNlbGVjdEFsbENoaWxkcmVu KE5vZGUmKTsKIAogICAgIFN0cmluZyB0b1N0cmluZygpIGNvbnN0OwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlvbi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVNlbGVjdGlvbi5pZGwKaW5kZXggZTZjZjEzNDIzNzgyOWQ1MzZjMzlkZjBlOWJjYmZiMmU4 YmNmYzc1MS4uMTM0MDc3ZmNjYzQ5MzdjNzU2ZmM5MDVjOWVjYzY2YjQ4ZmU2YTY3OSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24uaWRsCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmlkbApAQCAtNTksNyArNTksNyBAQAogICAgIFtNYXlU aHJvd0V4Y2VwdGlvbl0gdW5kZWZpbmVkIGV4dGVuZChOb2RlIG5vZGUsIG9wdGlvbmFsIHVuc2ln bmVkIGxvbmcgb2Zmc2V0ID0gMCk7CiAKICAgICBbTWF5VGhyb3dFeGNlcHRpb25dIHVuZGVmaW5l ZCBzZXRCYXNlQW5kRXh0ZW50KE5vZGU/IGJhc2VOb2RlLCB1bnNpZ25lZCBsb25nIGJhc2VPZmZz ZXQsIE5vZGU/IGV4dGVudE5vZGUsIHVuc2lnbmVkIGxvbmcgZXh0ZW50T2Zmc2V0KTsKLSAgICB1 bmRlZmluZWQgc2VsZWN0QWxsQ2hpbGRyZW4oTm9kZSBub2RlKTsKKyAgICBbTWF5VGhyb3dFeGNl cHRpb25dIHVuZGVmaW5lZCBzZWxlY3RBbGxDaGlsZHJlbihOb2RlIG5vZGUpOwogCiAgICAgW0NF UmVhY3Rpb25zXSB1bmRlZmluZWQgZGVsZXRlRnJvbURvY3VtZW50KCk7CiAgICAgYm9vbGVhbiBj b250YWluc05vZGUoTm9kZSBub2RlLCBvcHRpb25hbCBib29sZWFuIGFsbG93UGFydGlhbENvbnRh aW5tZW50ID0gZmFsc2UpOwo=