216738 2020-09-19 18:38:34 -0700 Change render tree selection painting code to use non-canonicalized points 2025-10-11 16:46:28 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build All All RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=216325 InRadar P2 Normal --- 1 darin darin ews-watchlist mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1690136 0 darin 2020-09-19 18:38:34 -0700 Selection API: Remove unneeded incorrect code that overwrites the base and extent of a selection based on visibility 1690137 1 409220 darin 2020-09-19 18:42:33 -0700 Created attachment 409220 Patch 1690224 2 darin 2020-09-20 14:36:11 -0700 OK, turns out I misunderstood the code here. It’s calling a setSelection function on the render tree, which should not have any effect on the selection in the DOM. But somehow it did have an effect. Need to restore the old code and figure out what was happening. 1690249 3 darin 2020-09-20 21:42:14 -0700 Not sure I need to do this any time soon. It’s nice to improve how we tie painting the selection to the DOM to not rely on so much editing strangeness. But not needed for the Selection API project. 1692258 4 webkit-bug-importer 2020-09-26 18:39:15 -0700 <rdar://problem/69639857> 2150273 5 darin 2025-10-11 16:46:28 -0700 I’m not going to use this bug report to do anything. Someone might resolve this some day, but we don’t need to keep this bug open. 409220 2020-09-19 18:42:33 -0700 2020-09-20 21:41:19 -0700 Patch bug-216738-20200919184233.patch text/plain 7008 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ4NDE5MTE0YWY5YzZk YWNhYjgxMTFlY2E2MzAxMTRlMDkzYjBmNS4uYWYyN2RiNWFkODBiOGJmN2VjN2MxMjBjOTcxYTcw ODRmODU5ZmVmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA5LTE5ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTZWxlY3Rpb24gQVBJOiBSZW1v dmUgdW5uZWVkZWQgaW5jb3JyZWN0IGNvZGUgdGhhdCBvdmVyd3JpdGVzIHRoZSBiYXNlIGFuZCBl eHRlbnQgb2YgYSBzZWxlY3Rpb24gYmFzZWQgb24gdmlzaWJpbGl0eQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NzM4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL0ZyYW1lU2VsZWN0aW9u LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjp1cGRhdGVBcHBlYXJhbmNl KTogVGhlIGNvZGUgaW4gdGhlIHNlY29uZCBoYWxmIG9mIHRoaXMKKyAgICAgICAgZnVuY3Rpb24g aGFzIGxpdHRsZSB0byBkbyB3aXRoIHVwZGF0aW5nICJhcHBlYXJhbmNlIiBhbmQgb3ZlcndyaXRl cyB0aGUgZW5kIHBvaW50cworICAgICAgICBvZiB0aGUgc2VsZWN0aW9uIGJhc2VkIG9uIHJlbmRl cmVyIHN0YXRlLiBJdCdzIGVudGlyZWx5IHVubmVjZXNzYXJ5IG91dHNpZGUgb2YKKyAgICAgICAg cGFpbnRCbG9ja0N1cnNvciBtb2RlLCBhbmQgaXQncyBhbHNvIGFuIGluY29ycmVjdCB3YXkgdG8g aW1wbGVtZW50IHRoYXQgbW9kZS4gV2UgY2FuCisgICAgICAgIHJldHVybiBsYXRlciBhbmQgcmUt aW1wbGVtZW50IHBhaW50QmxvY2tDdXJzb3IgY29ycmVjdGx5LCBidXQgZm9yIG5vdywgY2hhbmdl ZCB0aGlzCisgICAgICAgIHNvIGl0IGRvZXNuJ3QgY2F1c2UgdHJvdWJsZSB3aGVuIHBhaW50Qmxv Y2tDdXJzb3IgaXMgZmFsc2UgYW5kIHNvIHdlIGNhbiB0ZXN0IHRvIGJlCisgICAgICAgIHN1cmUg ZXZlcnl0aGluZyBpcyBPSyB3aXRob3V0IHRoaXMgY29kZS4KKwogMjAyMC0wOS0xOSAgQW5kcmVz IEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50YXRp b24gZm9yIEFYSXNvbGF0ZWRPYmplY3Q6Om5leHRTaWJsaW5nIGFuZCBwcmV2aW91c1NpYmxpbmcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCmluZGV4IDljODg5NGM0 YTVkZjRhOTMwMTY4NDVkZTllMGZkZGQ0NGFjZTA5YzEuLjBlZmM4OGQ2ODU5MDUwM2ZjYTVhOWY4 YjdkZTNkOTE2Y2RmODQ5MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJh bWVTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rp b24uY3BwCkBAIC0yMTA5LDE2ICsyMTA5LDEyIEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246OnVwZGF0 ZUFwcGVhcmFuY2UoKQogICAgICAgICByZXR1cm47CiAjZW5kaWYKIAotICAgIC8vIFBhaW50IGEg YmxvY2sgY3Vyc29yIGluc3RlYWQgb2YgYSBjYXJldCBpbiBvdmVydHlwZSBtb2RlIHVubGVzcyB0 aGUgY2FyZXQgaXMgYXQgdGhlIGVuZCBvZiBhIGxpbmUgKGluIHRoaXMgY2FzZQotICAgIC8vIHRo ZSBGcmFtZVNlbGVjdGlvbiB3aWxsIHBhaW50IGEgYmxpbmtpbmcgY2FyZXQgYXMgdXN1YWwpLgot ICAgIFZpc2libGVTZWxlY3Rpb24gb2xkU2VsZWN0aW9uID0gc2VsZWN0aW9uKCk7Ci0KICNpZiBF TkFCTEUoVEVYVF9DQVJFVCkKICAgICBib29sIHBhaW50QmxvY2tDdXJzb3IgPSBtX3Nob3VsZFNo b3dCbG9ja0N1cnNvciAmJiBtX3NlbGVjdGlvbi5pc0NhcmV0KCkgJiYgIWlzTG9naWNhbEVuZE9m TGluZShtX3NlbGVjdGlvbi52aXNpYmxlRW5kKCkpOwogICAgIGJvb2wgY2FyZXRSZWN0Q2hhbmdl ZE9yQ2xlYXJlZCA9IHJlY29tcHV0ZUNhcmV0UmVjdCgpOwogCiAgICAgYm9vbCBjYXJldEJyb3dz aW5nID0gbV9kb2N1bWVudC0+c2V0dGluZ3MoKS5jYXJldEJyb3dzaW5nRW5hYmxlZCgpOwotICAg IGJvb2wgc2hvdWxkQmxpbmsgPSAhcGFpbnRCbG9ja0N1cnNvciAmJiBjYXJldElzVmlzaWJsZSgp ICYmIGlzQ2FyZXQoKSAmJiAob2xkU2VsZWN0aW9uLmlzQ29udGVudEVkaXRhYmxlKCkgfHwgY2Fy ZXRCcm93c2luZyk7CisgICAgYm9vbCBzaG91bGRCbGluayA9ICFwYWludEJsb2NrQ3Vyc29yICYm IGNhcmV0SXNWaXNpYmxlKCkgJiYgaXNDYXJldCgpICYmIChzZWxlY3Rpb24oKS5pc0NvbnRlbnRF ZGl0YWJsZSgpIHx8IGNhcmV0QnJvd3NpbmcpOwogCiAgICAgLy8gSWYgdGhlIGNhcmV0IG1vdmVk LCBzdG9wIHRoZSBibGluayB0aW1lciBzbyB3ZSBjYW4gcmVzdGFydCB3aXRoIGEKICAgICAvLyBi bGFjayBjYXJldCBpbiB0aGUgbmV3IGxvY2F0aW9uLgpAQCAtMjEzOCwxOSArMjEzNCwyMSBAQCB2 b2lkIEZyYW1lU2VsZWN0aW9uOjp1cGRhdGVBcHBlYXJhbmNlKCkKICAgICB9CiAjZW5kaWYKIAor I2lmIEVOQUJMRShURVhUX0NBUkVUKQorICAgIC8vIFBhaW50IGEgYmxvY2sgY3Vyc29yIGluc3Rl YWQgb2YgYSBjYXJldCBpbiBvdmVydHlwZSBtb2RlIHVubGVzcyB0aGUgY2FyZXQgaXMgYXQgdGhl IGVuZCBvZiBhIGxpbmUgKGluIHRoaXMgY2FzZQorICAgIC8vIHRoZSBGcmFtZVNlbGVjdGlvbiB3 aWxsIHBhaW50IGEgYmxpbmtpbmcgY2FyZXQgYXMgdXN1YWwpLgorCisgICAgLy8gRklYTUU6IEFs dGVyaW5nIHRoZSBhbmNob3IgYW5kIGZvY3VzIHRvIG1ha2UgdXMgcGFpbnQgYSBibG9jayBjdXJz b3IgaXMgbm90IGNvbXBhdGlibGUgd2l0aCB0aGUgU2VsZWN0aW9uIEFQSTsgbmVlZCBhIGRpZmZl cmVudCB0ZWNobmlxdWUuCisgICAgaWYgKCFwYWludEJsb2NrQ3Vyc29yKQorICAgICAgICByZXR1 cm47CisKICAgICBSZW5kZXJWaWV3KiB2aWV3ID0gbV9kb2N1bWVudC0+cmVuZGVyVmlldygpOwog ICAgIGlmICghdmlldykKICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gQ29uc3RydWN0IGEgbmV3 IFZpc2libGVTb2x1dGlvbiwgc2luY2UgbV9zZWxlY3Rpb24gaXMgbm90IG5lY2Vzc2FyaWx5IHZh bGlkLCBhbmQgdGhlIGZvbGxvd2luZyBzdGVwcworICAgIC8vIENvbnN0cnVjdCBhIG5ldyBWaXNp YmxlU2VsZWN0aW9uLCBzaW5jZSBtX3NlbGVjdGlvbiBpcyBub3QgbmVjZXNzYXJpbHkgdmFsaWQs IGFuZCB0aGUgZm9sbG93aW5nIHN0ZXBzCiAgICAgLy8gYXNzdW1lIGEgdmFsaWQgc2VsZWN0aW9u LiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTU2Mz4gYW5k IDxyZGFyOi8vcHJvYmxlbS8xMDIzMjg2Nj4uCi0jaWYgRU5BQkxFKFRFWFRfQ0FSRVQpCi0gICAg VmlzaWJsZVBvc2l0aW9uIGVuZFZpc2libGVQb3NpdGlvbiA9IHBhaW50QmxvY2tDdXJzb3IgPyBt b2RpZnlFeHRlbmRpbmdGb3J3YXJkKFRleHRHcmFudWxhcml0eTo6Q2hhcmFjdGVyR3JhbnVsYXJp dHkpIDogb2xkU2VsZWN0aW9uLnZpc2libGVFbmQoKTsKLSAgICBWaXNpYmxlU2VsZWN0aW9uIHNl bGVjdGlvbihvbGRTZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCksIGVuZFZpc2libGVQb3NpdGlvbik7 Ci0jZWxzZQotICAgIFZpc2libGVTZWxlY3Rpb24gc2VsZWN0aW9uKG9sZFNlbGVjdGlvbi52aXNp YmxlU3RhcnQoKSwgb2xkU2VsZWN0aW9uLnZpc2libGVFbmQoKSk7Ci0jZW5kaWYKLQorICAgIFZp c2libGVTZWxlY3Rpb24gc2VsZWN0aW9uKHRoaXMtPnNlbGVjdGlvbigpLnZpc2libGVTdGFydCgp LCBtb2RpZnlFeHRlbmRpbmdGb3J3YXJkKFRleHRHcmFudWxhcml0eTo6Q2hhcmFjdGVyR3JhbnVs YXJpdHkpKTsKICAgICBpZiAoIXNlbGVjdGlvbi5pc1JhbmdlKCkpIHsKICAgICAgICAgdmlldy0+ c2VsZWN0aW9uKCkuY2xlYXJTZWxlY3Rpb24oKTsKICAgICAgICAgcmV0dXJuOwpAQCAtMjE2MCwy NSArMjE1OCwyMyBAQCB2b2lkIEZyYW1lU2VsZWN0aW9uOjp1cGRhdGVBcHBlYXJhbmNlKCkKICAg ICAvLyBFeGFtcGxlOiBmb28gPGE+YmFyPC9hPi4gIEltYWdpbmUgdGhhdCBhIGxpbmUgd3JhcCBv Y2N1cnMgYWZ0ZXIgJ2ZvbycsIGFuZCB0aGF0ICdiYXInIGlzIHNlbGVjdGVkLiAgIElmIHdlIHBh c3MgW2ZvbywgM10KICAgICAvLyBhcyB0aGUgc3RhcnQgb2YgdGhlIHNlbGVjdGlvbiwgdGhlIHNl bGVjdGlvbiBwYWludGluZyBjb2RlIHdpbGwgdGhpbmsgdGhhdCBjb250ZW50IG9uIHRoZSBsaW5l IGNvbnRhaW5pbmcgJ2ZvbycgaXMgc2VsZWN0ZWQKICAgICAvLyBhbmQgd2lsbCBmaWxsIHRoZSBn YXAgYmVmb3JlICdiYXInLgotICAgIFBvc2l0aW9uIHN0YXJ0UG9zID0gc2VsZWN0aW9uLnN0YXJ0 KCk7Ci0gICAgUG9zaXRpb24gY2FuZGlkYXRlID0gc3RhcnRQb3MuZG93bnN0cmVhbSgpOwotICAg IGlmIChjYW5kaWRhdGUuaXNDYW5kaWRhdGUoKSkKLSAgICAgICAgc3RhcnRQb3MgPSBjYW5kaWRh dGU7Ci0gICAgUG9zaXRpb24gZW5kUG9zID0gc2VsZWN0aW9uLmVuZCgpOwotICAgIGNhbmRpZGF0 ZSA9IGVuZFBvcy51cHN0cmVhbSgpOwotICAgIGlmIChjYW5kaWRhdGUuaXNDYW5kaWRhdGUoKSkK LSAgICAgICAgZW5kUG9zID0gY2FuZGlkYXRlOworICAgIGF1dG8gc3RhcnQgPSBzZWxlY3Rpb24u c3RhcnQoKTsKKyAgICBpZiAoYXV0byBjYW5kaWRhdGUgPSBzdGFydC5kb3duc3RyZWFtKCk7IGNh bmRpZGF0ZS5pc0NhbmRpZGF0ZSgpKQorICAgICAgICBzdGFydCA9IGNhbmRpZGF0ZTsKKyAgICBh dXRvIGVuZCA9IHNlbGVjdGlvbi5lbmQoKTsKKyAgICBpZiAoYXV0byBjYW5kaWRhdGUgPSBlbmQu dXBzdHJlYW0oKTsgZW5kLmlzQ2FuZGlkYXRlKCkpCisgICAgICAgIGVuZCA9IGNhbmRpZGF0ZTsK IAogICAgIC8vIFdlIGNhbiBnZXQgaW50byBhIHN0YXRlIHdoZXJlIHRoZSBzZWxlY3Rpb24gZW5k cG9pbnRzIG1hcCB0byB0aGUgc2FtZSBWaXNpYmxlUG9zaXRpb24gd2hlbiBhIHNlbGVjdGlvbiBp cyBkZWxldGVkCiAgICAgLy8gYmVjYXVzZSB3ZSBkb24ndCB5ZXQgbm90aWZ5IHRoZSBGcmFtZVNl bGVjdGlvbiBvZiB0ZXh0IHJlbW92YWwuCi0gICAgaWYgKHN0YXJ0UG9zLmlzTm90TnVsbCgpICYm IGVuZFBvcy5pc05vdE51bGwoKSAmJiBzZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCkgIT0gc2VsZWN0 aW9uLnZpc2libGVFbmQoKSkgewotICAgICAgICBSZW5kZXJPYmplY3QqIHN0YXJ0UmVuZGVyZXIg PSBzdGFydFBvcy5kZXByZWNhdGVkTm9kZSgpLT5yZW5kZXJlcigpOwotICAgICAgICBpbnQgc3Rh cnRPZmZzZXQgPSBzdGFydFBvcy5kZXByZWNhdGVkRWRpdGluZ09mZnNldCgpOwotICAgICAgICBS ZW5kZXJPYmplY3QqIGVuZFJlbmRlcmVyID0gZW5kUG9zLmRlcHJlY2F0ZWROb2RlKCktPnJlbmRl cmVyKCk7Ci0gICAgICAgIGludCBlbmRPZmZzZXQgPSBlbmRQb3MuZGVwcmVjYXRlZEVkaXRpbmdP ZmZzZXQoKTsKLSAgICAgICAgQVNTRVJUKHN0YXJ0T2Zmc2V0ID49IDAgJiYgZW5kT2Zmc2V0ID49 IDApOwotICAgICAgICB2aWV3LT5zZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb24oeyBzdGFydFJlbmRl cmVyLCBlbmRSZW5kZXJlciwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0YXJ0T2Zmc2V0KSwgc3Rh dGljX2Nhc3Q8dW5zaWduZWQ+KGVuZE9mZnNldCkgfSk7CisgICAgaWYgKHN0YXJ0LmlzTm90TnVs bCgpICYmIHN0YXJ0LmlzTm90TnVsbCgpICYmIHNlbGVjdGlvbi52aXNpYmxlU3RhcnQoKSAhPSBz ZWxlY3Rpb24udmlzaWJsZUVuZCgpKSB7CisgICAgICAgIGF1dG8gc3RhcnRSZW5kZXJlciA9IHN0 YXJ0LmRlcHJlY2F0ZWROb2RlKCktPnJlbmRlcmVyKCk7CisgICAgICAgIHVuc2lnbmVkIHN0YXJ0 T2Zmc2V0ID0gc3RhcnQuZGVwcmVjYXRlZEVkaXRpbmdPZmZzZXQoKTsKKyAgICAgICAgYXV0byBl bmRSZW5kZXJlciA9IHN0YXJ0LmRlcHJlY2F0ZWROb2RlKCktPnJlbmRlcmVyKCk7CisgICAgICAg IHVuc2lnbmVkIGVuZE9mZnNldCA9IHN0YXJ0LmRlcHJlY2F0ZWRFZGl0aW5nT2Zmc2V0KCk7Cisg ICAgICAgIHZpZXctPnNlbGVjdGlvbigpLnNldFNlbGVjdGlvbih7IHN0YXJ0UmVuZGVyZXIsIGVu ZFJlbmRlcmVyLCBzdGFydE9mZnNldCwgZW5kT2Zmc2V0IH0pOwogICAgIH0KKyNlbmRpZgogfQog CiB2b2lkIEZyYW1lU2VsZWN0aW9uOjpzZXRDYXJldFZpc2liaWxpdHkoQ2FyZXRWaXNpYmlsaXR5 IHZpc2liaWxpdHkpCkBAIC0yMzk5LDggKzIzOTUsNyBAQCB2b2lkIEZyYW1lU2VsZWN0aW9uOjpy ZXZlYWxTZWxlY3Rpb24oU2VsZWN0aW9uUmV2ZWFsTW9kZSByZXZlYWxNb2RlLCBjb25zdCBTY3Jv bAogICAgICAgICAgICAgfQogICAgICAgICB9CiAjZWxzZQotICAgICAgICAvLyBGSVhNRTogVGhp cyBjb2RlIG9ubHkgaGFuZGxlcyBzY3JvbGxpbmcgdGhlIHN0YXJ0Q29udGFpbmVyJ3MgbGF5ZXIs IGJ1dAotICAgICAgICAvLyB0aGUgc2VsZWN0aW9uIHJlY3QgY291bGQgaW50ZXJzZWN0IG1vcmUg dGhhbiBqdXN0IHRoYXQuCisgICAgICAgIC8vIEZJWE1FOiBUaGlzIGNvZGUgb25seSBoYW5kbGVz IHNjcm9sbGluZyB0aGUgc3RhcnRDb250YWluZXIncyBsYXllciwgYnV0IHRoZSBzZWxlY3Rpb24g cmVjdCBjb3VsZCBpbnRlcnNlY3QgbW9yZSB0aGFuIGp1c3QgdGhhdC4KICAgICAgICAgLy8gU2Vl IDxyZGFyOi8vcHJvYmxlbS80Nzk5ODk5Pi4KICAgICAgICAgaWYgKHN0YXJ0LmRlcHJlY2F0ZWRO b2RlKCktPnJlbmRlcmVyKCktPnNjcm9sbFJlY3RUb1Zpc2libGUocmVjdCwgaW5zaWRlRml4ZWQs IHsgcmV2ZWFsTW9kZSwgYWxpZ25tZW50LCBhbGlnbm1lbnQsIFNob3VsZEFsbG93Q3Jvc3NPcmln aW5TY3JvbGxpbmc6OlllcyB9KSkKICAgICAgICAgICAgIHVwZGF0ZUFwcGVhcmFuY2UoKTsK