216717 2020-09-18 15:04:32 -0700 [JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct 2020-09-18 18:22:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1689969 0 ysuzuki 2020-09-18 15:04:32 -0700 [JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct 1689970 1 409173 ysuzuki 2020-09-18 15:13:43 -0700 Created attachment 409173 Patch 1689972 2 409175 ysuzuki 2020-09-18 15:25:08 -0700 Created attachment 409175 Patch 1689978 3 webkit-bug-importer 2020-09-18 15:50:02 -0700 <rdar://problem/69179885> 1689990 4 409175 mark.lam 2020-09-18 16:26:38 -0700 Comment on attachment 409175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409175&action=review Nice. Looks good so far but I still need to check this against the MarkedBlock code. Here are some typos while I continue reviewing. > Source/JavaScriptCore/ChangeLog:9 > + However, this means that HeapCell::isLive will see this object dead until it is marked. /object dead/object as dead/ > Source/JavaScriptCore/heap/PreciseAllocation.cpp:218 > + // We do not need to care about concurrency here since marking thread is stopped right now. This is followin to the logic /followin/equivalent/ 1689991 5 409175 ysuzuki 2020-09-18 16:31:18 -0700 Comment on attachment 409175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409175&action=review >> Source/JavaScriptCore/ChangeLog:9 >> + However, this means that HeapCell::isLive will see this object dead until it is marked. > > /object dead/object as dead/ Fixed. >> Source/JavaScriptCore/heap/PreciseAllocation.cpp:218 >> + // We do not need to care about concurrency here since marking thread is stopped right now. This is followin to the logic > > /followin/equivalent/ Fixed. 1689992 6 409178 ysuzuki 2020-09-18 16:32:30 -0700 Created attachment 409178 Patch 1690006 7 409178 mark.lam 2020-09-18 17:36:35 -0700 Comment on attachment 409178 Patch r=me. Nice fix, and nice comments documenting the reasoning behind all this. 1690012 8 ysuzuki 2020-09-18 18:22:49 -0700 Committed r267304: <https://trac.webkit.org/changeset/267304> 409173 2020-09-18 15:13:43 -0700 2020-09-18 15:25:06 -0700 Patch bug-216717-20200918151343.patch text/plain 3697 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NGMyYTZkM2E3MGIwMzNmOWJhYTRiZTQyNTJlYzI2NjQwNjRlYjY4Li4wZjg0MTY0OThjMTBlOWY3 YWY4ZWIxNWU4ZWRjYmNiODBkNzhiMmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wOS0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFByZWNpc2VBbGxvY2F0aW9uJ3MgaXNOZXdseUFsbG9jYXRlZCBm bGFnIHNob3VsZCBiZSBwcm9wYWdhdGVkIGZyb20gaXNNYXJrZWQgYXQgR0MgYmVnaW4gcGhhc2Ug dG8gbWFrZSBpc0xpdmUgY29ycmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE2NzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiBzdGFydGluZyBmdWxsIEdDLCBhdCBiZWdpbk1hcmtpbmcsIFBy ZWNpc2VBbGxvY2F0aW9uJ3MgbWFyayBiaXQgaXMgY2xlYXJlZCB0byBiZSB1c2FibGUgZm9yIHVw Y29taW5nIG1hcmtpbmcuCisgICAgICAgIEhvd2V2ZXIsIHRoaXMgbWVhbnMgdGhhdCBIZWFwQ2Vs bDo6aXNMaXZlIHdpbGwgc2VlIHRoaXMgb2JqZWN0IGRlYWQgdW50aWwgaXQgaXMgbWFya2VkLgor ICAgICAgICBMZXQncyBjb25zaWRlciB0aGF0IHRoaXMgb2JqZWN0IGlzIG5vdCBuZXdseSBhbGxv Y2F0ZWQgb25lLiBUaGVuLCBpdHMgaXNOZXdseUFsbG9jYXRlZCBpcyBmYWxzZS4gQW5kIG5vdyBt YXJrIGJpdAorICAgICAgICBpcyBhbHNvIGNsZWFyZWQuIFNpbmNlIFByZWNpc2VBbGxvY2F0aW9u Ojppc0xpdmUgaXMgaXNOZXdseUFsbG9jYXRlZCB8fCBpc01hcmtlZCwgdGhlbiBpdCBsb29rcyBk ZWFkLCB3aGlsZSBpdCBpcyBsaXZlLgorICAgICAgICBUaGlzIGNvbmZ1c2VzIEhlYXBDZWxsOmlz TGl2ZSBmdW5jdGlvbiBhbmQgbWFrZXMgc29tZSBvZiB3YXRjaHBvaW50cyBwZXJmb3JtIHdyb25n IGRlY2lzaW9ucyAoZS5nLiB0aGlzIGNvbmRpdGlvbiBpcworICAgICAgICBubyBsb25nZXIgdmFs aWQsIGxldCdzIGp1c3QgZGlzY2FyZCBpdCkuCisgICAgICAgIEF0IHRoZSBiZWdpbm5pbmcgb2Yg ZnVsbCBjb2xsZWN0aW9uLCB3ZSBzaG91bGQgcHJvcGFnYXRlIHRoZSBvbGQgbWFyayBiaXQgdG8g aXNOZXdseUFsbG9jYXRlZCBzbyB0aGF0IGl0IGxvb2tzIGxpdmUKKyAgICAgICAgZHVyaW5nIG1h cmtpbmcuIFRoaXMgaXMgc2ltaWxhciB0cmljayB0byBNYXJrZWRCbG9jazo6YWJvdXRUb01hcmsu CisKKyAgICAgICAgKiBoZWFwL1ByZWNpc2VBbGxvY2F0aW9uLmNwcDoKKyAgICAgICAgKEpTQzo6 UHJlY2lzZUFsbG9jYXRpb246OmZsaXApOgorCiAyMDIwLTA5LTE3ICBZdXN1a2UgU3V6dWtpICA8 eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQXN5bmMgZ2VuZXJhdG9yIGRlZmF1 bHQtZXhwb3J0IGlzIG5vdCBoYW5kbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaGVhcC9QcmVjaXNlQWxsb2NhdGlvbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9QcmVjaXNlQWxsb2NhdGlvbi5jcHAKaW5kZXggNDg4MTdjOTVjZjVkMDdjZWRlMDIwNGVkNTlk NzFlODFhZDVlNmYwOC4uOTkxY2I2NTRjNTBiYTJmNWI2ZDJkZGY0YzMyNDg2OGRkZTE5ZTA2OSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUHJlY2lzZUFsbG9jYXRpb24u Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1ByZWNpc2VBbGxvY2F0aW9uLmNw cApAQCAtMjEzLDcgKzIxMywyMSBAQCB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpyZWFwV2Vha1Nl dCgpCiB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpmbGlwKCkKIHsKICAgICBBU1NFUlQoaGVhcCgp LT5jb2xsZWN0aW9uU2NvcGUoKSA9PSBDb2xsZWN0aW9uU2NvcGU6OkZ1bGwpOwotICAgIGNsZWFy TWFya2VkKCk7CisgICAgLy8gUHJvcGFnYXRlIHRoZSBsYXN0IHRpbWUncyBtYXJrIGJpdCB0byBt X2lzTmV3bHlBbGxvY2F0ZWQgc28gdGhhdCBgaXNMaXZlYCB3aWxsIHNheSAieWVzIiB1bnRpbCB0 aGlzIEdDIGN5Y2xlIGZpbmlzaGVzLgorICAgIC8vIEFmdGVyIHRoYXQsIG1faXNOZXdseUFsbG9j YXRlZCBpcyBjbGVhcmVkIGFnYWluLiBTbyBvbmx5IHByZXZpb3VzbHkgbWFya2VkIG9yIGFjdHVh bGx5IG5ld2x5IGNyZWF0ZWQgb2JqZWN0cyBzdXJ2aXZlLgorICAgIC8vIFdlIGRvIG5vdCBuZWVk IHRvIGNhcmUgYWJvdXQgY29uY3VycmVuY3kgaGVyZSBzaW5jZSBtYXJraW5nIHRocmVhZCBpcyBz dG9wcGVkIHJpZ2h0IG5vdy4gVGhpcyBpcyBmb2xsb3dpbiB0byB0aGUgbG9naWMKKyAgICAvLyBv ZiBNYXJrZWRCbG9jazo6YWJvdXRUb01hcmtTbG93LgorICAgIC8vICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBOOiBOZXdseUFsbG9jYXRlZCwgTTogTWFya2VkCisgICAgLy8g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWZ0ZXIgdGhp cyAgICAgICAgIGF0IHRoZSBlbmQgICAgICAgIFdoZW4gY3ljbGUKKyAgICAvLyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTiBNICBmdW5jdGlvbiAgICBOIE0gICAg IG9mIGN5Y2xlICAgIE4gTSAgaXMgZmluaXNoZWQgICBOIE0KKyAgICAvLyBUaGUgbGl2ZSBvYmpl Y3Qgc3Vydml2ZXMgdGhlIGxhc3QgY3ljbGUgICAgMCAxICAgICAgPT4gICAgICAxIDAgICAgICAg ID0+ICAgICAgIDEgMSAgICAgICA9PiAgICAgICAwIDEgICAgPT4gbGl2ZQorICAgIC8vIFRoZSBk ZWFkIG9iamVjdCBpbiB0aGUgbGFzdCBjeWNsZSAgICAgICAgICAwIDAgICAgICA9PiAgICAgIDAg MCAgICAgICAgPT4gICAgICAgMCAwICAgICAgID0+ICAgICAgIDAgMCAgICA9PiBkZWFkCisgICAg Ly8gVGhlIGxpdmUgb2JqZWN0IG5ld2x5IGNyZWF0ZWQgYWZ0ZXIgdGhpcyAgICAgICAgICAgID0+ ICAgICAgMSAwICAgICAgICA9PiAgICAgICAxIDEgICAgICAgPT4gICAgICAgMCAxICAgID0+IGxp dmUKKyAgICAvLyBUaGUgZGVhZCBvYmplY3QgbmV3bHkgY3JlYXRlZCBhZnRlciB0aGlzICAgICAg ICAgICAgPT4gICAgICAxIDAgICAgICAgID0+ICAgICAgIDEgMCAgICAgICA9PiAgICAgICAwIDAg ICAgPT4gZGVhZAorICAgIC8vIFRoZSBsaXZlIG9iamVjdCBuZXdseSBjcmVhdGVkIGJlZm9yZSB0 aGlzICAxIDAgICAgICA9PiAgICAgIDEgMCAgICAgICAgPT4gICAgICAgMSAxICAgICAgID0+ICAg ICAgIDAgMSAgICA9PiBsaXZlCisgICAgLy8gVGhlIGRlYWQgb2JqZWN0IG5ld2x5IGNyZWF0ZWQg YmVmb3JlIHRoaXMgIDEgMCAgICAgID0+ICAgICAgMSAwICAgICAgICA9PiAgICAgICAxIDAgICAg ICAgPT4gICAgICAgMCAwICAgID0+IGRlYWQKKyAgICBtX2lzTmV3bHlBbGxvY2F0ZWQgfD0gaXNN YXJrZWQoKTsKKyAgICBtX2lzTWFya2VkLnN0b3JlKGZhbHNlLCBzdGQ6Om1lbW9yeV9vcmRlcl9y ZWxheGVkKTsKIH0KIAogYm9vbCBQcmVjaXNlQWxsb2NhdGlvbjo6aXNFbXB0eSgpCg== 409175 2020-09-18 15:25:08 -0700 2020-09-18 16:32:29 -0700 Patch bug-216717-20200918152507.patch text/plain 4143 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NGMyYTZkM2E3MGIwMzNmOWJhYTRiZTQyNTJlYzI2NjQwNjRlYjY4Li4wZjg0MTY0OThjMTBlOWY3 YWY4ZWIxNWU4ZWRjYmNiODBkNzhiMmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wOS0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFByZWNpc2VBbGxvY2F0aW9uJ3MgaXNOZXdseUFsbG9jYXRlZCBm bGFnIHNob3VsZCBiZSBwcm9wYWdhdGVkIGZyb20gaXNNYXJrZWQgYXQgR0MgYmVnaW4gcGhhc2Ug dG8gbWFrZSBpc0xpdmUgY29ycmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE2NzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiBzdGFydGluZyBmdWxsIEdDLCBhdCBiZWdpbk1hcmtpbmcsIFBy ZWNpc2VBbGxvY2F0aW9uJ3MgbWFyayBiaXQgaXMgY2xlYXJlZCB0byBiZSB1c2FibGUgZm9yIHVw Y29taW5nIG1hcmtpbmcuCisgICAgICAgIEhvd2V2ZXIsIHRoaXMgbWVhbnMgdGhhdCBIZWFwQ2Vs bDo6aXNMaXZlIHdpbGwgc2VlIHRoaXMgb2JqZWN0IGRlYWQgdW50aWwgaXQgaXMgbWFya2VkLgor ICAgICAgICBMZXQncyBjb25zaWRlciB0aGF0IHRoaXMgb2JqZWN0IGlzIG5vdCBuZXdseSBhbGxv Y2F0ZWQgb25lLiBUaGVuLCBpdHMgaXNOZXdseUFsbG9jYXRlZCBpcyBmYWxzZS4gQW5kIG5vdyBt YXJrIGJpdAorICAgICAgICBpcyBhbHNvIGNsZWFyZWQuIFNpbmNlIFByZWNpc2VBbGxvY2F0aW9u Ojppc0xpdmUgaXMgaXNOZXdseUFsbG9jYXRlZCB8fCBpc01hcmtlZCwgdGhlbiBpdCBsb29rcyBk ZWFkLCB3aGlsZSBpdCBpcyBsaXZlLgorICAgICAgICBUaGlzIGNvbmZ1c2VzIEhlYXBDZWxsOmlz TGl2ZSBmdW5jdGlvbiBhbmQgbWFrZXMgc29tZSBvZiB3YXRjaHBvaW50cyBwZXJmb3JtIHdyb25n IGRlY2lzaW9ucyAoZS5nLiB0aGlzIGNvbmRpdGlvbiBpcworICAgICAgICBubyBsb25nZXIgdmFs aWQsIGxldCdzIGp1c3QgZGlzY2FyZCBpdCkuCisgICAgICAgIEF0IHRoZSBiZWdpbm5pbmcgb2Yg ZnVsbCBjb2xsZWN0aW9uLCB3ZSBzaG91bGQgcHJvcGFnYXRlIHRoZSBvbGQgbWFyayBiaXQgdG8g aXNOZXdseUFsbG9jYXRlZCBzbyB0aGF0IGl0IGxvb2tzIGxpdmUKKyAgICAgICAgZHVyaW5nIG1h cmtpbmcuIFRoaXMgaXMgc2ltaWxhciB0cmljayB0byBNYXJrZWRCbG9jazo6YWJvdXRUb01hcmsu CisKKyAgICAgICAgKiBoZWFwL1ByZWNpc2VBbGxvY2F0aW9uLmNwcDoKKyAgICAgICAgKEpTQzo6 UHJlY2lzZUFsbG9jYXRpb246OmZsaXApOgorCiAyMDIwLTA5LTE3ICBZdXN1a2UgU3V6dWtpICA8 eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQXN5bmMgZ2VuZXJhdG9yIGRlZmF1 bHQtZXhwb3J0IGlzIG5vdCBoYW5kbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaGVhcC9QcmVjaXNlQWxsb2NhdGlvbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9QcmVjaXNlQWxsb2NhdGlvbi5jcHAKaW5kZXggNDg4MTdjOTVjZjVkMDdjZWRlMDIwNGVkNTlk NzFlODFhZDVlNmYwOC4uY2EyYjhmZGZmNWRiYzA4YWFiNzA4MzBjZmQ3ZDRmMWQ5NzlhNzBjMiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUHJlY2lzZUFsbG9jYXRpb24u Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1ByZWNpc2VBbGxvY2F0aW9uLmNw cApAQCAtMjEzLDcgKzIxMywyNiBAQCB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpyZWFwV2Vha1Nl dCgpCiB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpmbGlwKCkKIHsKICAgICBBU1NFUlQoaGVhcCgp LT5jb2xsZWN0aW9uU2NvcGUoKSA9PSBDb2xsZWN0aW9uU2NvcGU6OkZ1bGwpOwotICAgIGNsZWFy TWFya2VkKCk7CisgICAgLy8gUHJvcGFnYXRlIHRoZSBsYXN0IHRpbWUncyBtYXJrIGJpdCB0byBt X2lzTmV3bHlBbGxvY2F0ZWQgc28gdGhhdCBgaXNMaXZlYCB3aWxsIHNheSAieWVzIiB1bnRpbCB0 aGlzIEdDIGN5Y2xlIGZpbmlzaGVzLgorICAgIC8vIEFmdGVyIHRoYXQsIG1faXNOZXdseUFsbG9j YXRlZCBpcyBjbGVhcmVkIGFnYWluLiBTbyBvbmx5IHByZXZpb3VzbHkgbWFya2VkIG9yIGFjdHVh bGx5IG5ld2x5IGNyZWF0ZWQgb2JqZWN0cyBzdXJ2aXZlLgorICAgIC8vIFdlIGRvIG5vdCBuZWVk IHRvIGNhcmUgYWJvdXQgY29uY3VycmVuY3kgaGVyZSBzaW5jZSBtYXJraW5nIHRocmVhZCBpcyBz dG9wcGVkIHJpZ2h0IG5vdy4gVGhpcyBpcyBmb2xsb3dpbiB0byB0aGUgbG9naWMKKyAgICAvLyBv ZiBNYXJrZWRCbG9jazo6YWJvdXRUb01hcmtTbG93LgorICAgIC8vIFdlIGludm9rZSB0aGlzIGZ1 bmN0aW9uIG9ubHkgd2hlbiB0aGlzIGlzIGZ1bGwgY29sbGVjdGlvbi4gVGhpcyBlbnN1cmVzIHRo YXQgYXQgdGhlIGVuZCBvZiB1cGNvbWluZyBjeWNsZSwgd2Ugd2lsbAorICAgIC8vIGNsZWFyIE5l d2x5QWxsb2NhdGVkIGJpdHMgb2YgYWxsIG9iamVjdHMuIFNvIHRoaXMgd29ya3MgY29ycmVjdGx5 LgorICAgIC8vCisgICAgLy8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE46 IE5ld2x5QWxsb2NhdGVkLCBNOiBNYXJrZWQKKyAgICAvLyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBhZnRlciB0aGlzICAgICAgICAgYXQgdGhlIGVuZCAg ICAgICAgV2hlbiBjeWNsZQorICAgIC8vICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBOIE0gIGZ1bmN0aW9uICAgIE4gTSAgICAgb2YgY3ljbGUgICAgTiBNICBpcyBm aW5pc2hlZCAgIE4gTQorICAgIC8vIFRoZSBsaXZlIG9iamVjdCBzdXJ2aXZlcyB0aGUgbGFzdCBj eWNsZSAgICAwIDEgICAgICA9PiAgICAgIDEgMCAgICAgICAgPT4gICAgICAgMSAxICAgICAgID0+ ICAgICAgIDAgMSAgICA9PiBsaXZlCisgICAgLy8gVGhlIGRlYWQgb2JqZWN0IGluIHRoZSBsYXN0 IGN5Y2xlICAgICAgICAgIDAgMCAgICAgID0+ICAgICAgMCAwICAgICAgICA9PiAgICAgICAwIDAg ICAgICAgPT4gICAgICAgMCAwICAgID0+IGRlYWQKKyAgICAvLyBUaGUgbGl2ZSBvYmplY3QgbmV3 bHkgY3JlYXRlZCBhZnRlciB0aGlzICAgICAgICAgICAgPT4gICAgICAxIDAgICAgICAgID0+ICAg ICAgIDEgMSAgICAgICA9PiAgICAgICAwIDEgICAgPT4gbGl2ZQorICAgIC8vIFRoZSBkZWFkIG9i amVjdCBuZXdseSBjcmVhdGVkIGFmdGVyIHRoaXMgICAgICAgICAgICA9PiAgICAgIDEgMCAgICAg ICAgPT4gICAgICAgMSAwICAgICAgID0+ICAgICAgIDAgMCAgICA9PiBkZWFkCisgICAgLy8gVGhl IGxpdmUgb2JqZWN0IG5ld2x5IGNyZWF0ZWQgYmVmb3JlIHRoaXMgIDEgMCAgICAgID0+ICAgICAg MSAwICAgICAgICA9PiAgICAgICAxIDEgICAgICAgPT4gICAgICAgMCAxICAgID0+IGxpdmUKKyAg ICAvLyBUaGUgZGVhZCBvYmplY3QgbmV3bHkgY3JlYXRlZCBiZWZvcmUgdGhpcyAgMSAwICAgICAg PT4gICAgICAxIDAgICAgICAgID0+ICAgICAgIDEgMCAgICAgICA9PiAgICAgICAwIDAgICAgPT4g ZGVhZAorICAgIC8vICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4K KyAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgVGhpcyBpcyBlbnN1cmVkIHNpbmNlIHRoaXMgZnVuY3Rpb24gaXMgdXNlZCBv bmx5IGZvciBmdWxsIEdDLgorICAgIG1faXNOZXdseUFsbG9jYXRlZCB8PSBpc01hcmtlZCgpOwor ICAgIG1faXNNYXJrZWQuc3RvcmUoZmFsc2UsIHN0ZDo6bWVtb3J5X29yZGVyX3JlbGF4ZWQpOwog fQogCiBib29sIFByZWNpc2VBbGxvY2F0aW9uOjppc0VtcHR5KCkK 409178 2020-09-18 16:32:30 -0700 2020-09-18 17:36:35 -0700 Patch bug-216717-20200918163229.patch text/plain 4148 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NGMyYTZkM2E3MGIwMzNmOWJhYTRiZTQyNTJlYzI2NjQwNjRlYjY4Li42YzdkM2RhZTU3YTAzNGUw NzA1NGQ0MGE0YmEyOWFlZGExZmYwYTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wOS0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFByZWNpc2VBbGxvY2F0aW9uJ3MgaXNOZXdseUFsbG9jYXRlZCBm bGFnIHNob3VsZCBiZSBwcm9wYWdhdGVkIGZyb20gaXNNYXJrZWQgYXQgR0MgYmVnaW4gcGhhc2Ug dG8gbWFrZSBpc0xpdmUgY29ycmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE2NzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiBzdGFydGluZyBmdWxsIEdDLCBhdCBiZWdpbk1hcmtpbmcsIFBy ZWNpc2VBbGxvY2F0aW9uJ3MgbWFyayBiaXQgaXMgY2xlYXJlZCB0byBiZSB1c2FibGUgZm9yIHVw Y29taW5nIG1hcmtpbmcuCisgICAgICAgIEhvd2V2ZXIsIHRoaXMgbWVhbnMgdGhhdCBIZWFwQ2Vs bDo6aXNMaXZlIHdpbGwgc2VlIHRoaXMgb2JqZWN0IGFzIGRlYWQgdW50aWwgaXQgaXMgbWFya2Vk LgorICAgICAgICBMZXQncyBjb25zaWRlciB0aGF0IHRoaXMgb2JqZWN0IGlzIG5vdCBuZXdseSBh bGxvY2F0ZWQgb25lLiBUaGVuLCBpdHMgaXNOZXdseUFsbG9jYXRlZCBpcyBmYWxzZS4gQW5kIG5v dyBtYXJrIGJpdAorICAgICAgICBpcyBhbHNvIGNsZWFyZWQuIFNpbmNlIFByZWNpc2VBbGxvY2F0 aW9uOjppc0xpdmUgaXMgaXNOZXdseUFsbG9jYXRlZCB8fCBpc01hcmtlZCwgdGhlbiBpdCBsb29r cyBkZWFkLCB3aGlsZSBpdCBpcyBsaXZlLgorICAgICAgICBUaGlzIGNvbmZ1c2VzIEhlYXBDZWxs OmlzTGl2ZSBmdW5jdGlvbiBhbmQgbWFrZXMgc29tZSBvZiB3YXRjaHBvaW50cyBwZXJmb3JtIHdy b25nIGRlY2lzaW9ucyAoZS5nLiB0aGlzIGNvbmRpdGlvbiBpcworICAgICAgICBubyBsb25nZXIg dmFsaWQsIGxldCdzIGp1c3QgZGlzY2FyZCBpdCkuCisgICAgICAgIEF0IHRoZSBiZWdpbm5pbmcg b2YgZnVsbCBjb2xsZWN0aW9uLCB3ZSBzaG91bGQgcHJvcGFnYXRlIHRoZSBvbGQgbWFyayBiaXQg dG8gaXNOZXdseUFsbG9jYXRlZCBzbyB0aGF0IGl0IGxvb2tzIGxpdmUKKyAgICAgICAgZHVyaW5n IG1hcmtpbmcuIFRoaXMgaXMgc2ltaWxhciB0cmljayB0byBNYXJrZWRCbG9jazo6YWJvdXRUb01h cmsuCisKKyAgICAgICAgKiBoZWFwL1ByZWNpc2VBbGxvY2F0aW9uLmNwcDoKKyAgICAgICAgKEpT Qzo6UHJlY2lzZUFsbG9jYXRpb246OmZsaXApOgorCiAyMDIwLTA5LTE3ICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQXN5bmMgZ2VuZXJhdG9yIGRl ZmF1bHQtZXhwb3J0IGlzIG5vdCBoYW5kbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9QcmVjaXNlQWxsb2NhdGlvbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9QcmVjaXNlQWxsb2NhdGlvbi5jcHAKaW5kZXggNDg4MTdjOTVjZjVkMDdjZWRlMDIwNGVk NTlkNzFlODFhZDVlNmYwOC4uOWJhZWM0ZWE5OWQ1MzQ2YmJjYTc3YmY5MmE1MWFiYWVhZDE5Mjlj NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUHJlY2lzZUFsbG9jYXRp b24uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1ByZWNpc2VBbGxvY2F0aW9u LmNwcApAQCAtMjEzLDcgKzIxMywyNiBAQCB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpyZWFwV2Vh a1NldCgpCiB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpmbGlwKCkKIHsKICAgICBBU1NFUlQoaGVh cCgpLT5jb2xsZWN0aW9uU2NvcGUoKSA9PSBDb2xsZWN0aW9uU2NvcGU6OkZ1bGwpOwotICAgIGNs ZWFyTWFya2VkKCk7CisgICAgLy8gUHJvcGFnYXRlIHRoZSBsYXN0IHRpbWUncyBtYXJrIGJpdCB0 byBtX2lzTmV3bHlBbGxvY2F0ZWQgc28gdGhhdCBgaXNMaXZlYCB3aWxsIHNheSAieWVzIiB1bnRp bCB0aGlzIEdDIGN5Y2xlIGZpbmlzaGVzLgorICAgIC8vIEFmdGVyIHRoYXQsIG1faXNOZXdseUFs bG9jYXRlZCBpcyBjbGVhcmVkIGFnYWluLiBTbyBvbmx5IHByZXZpb3VzbHkgbWFya2VkIG9yIGFj dHVhbGx5IG5ld2x5IGNyZWF0ZWQgb2JqZWN0cyBzdXJ2aXZlLgorICAgIC8vIFdlIGRvIG5vdCBu ZWVkIHRvIGNhcmUgYWJvdXQgY29uY3VycmVuY3kgaGVyZSBzaW5jZSBtYXJraW5nIHRocmVhZCBp cyBzdG9wcGVkIHJpZ2h0IG5vdy4gVGhpcyBpcyBlcXVpdmFsZW50IHRvIHRoZSBsb2dpYworICAg IC8vIG9mIE1hcmtlZEJsb2NrOjphYm91dFRvTWFya1Nsb3cuCisgICAgLy8gV2UgaW52b2tlIHRo aXMgZnVuY3Rpb24gb25seSB3aGVuIHRoaXMgaXMgZnVsbCBjb2xsZWN0aW9uLiBUaGlzIGVuc3Vy ZXMgdGhhdCBhdCB0aGUgZW5kIG9mIHVwY29taW5nIGN5Y2xlLCB3ZSB3aWxsCisgICAgLy8gY2xl YXIgTmV3bHlBbGxvY2F0ZWQgYml0cyBvZiBhbGwgb2JqZWN0cy4gU28gdGhpcyB3b3JrcyBjb3Jy ZWN0bHkuCisgICAgLy8KKyAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgTjogTmV3bHlBbGxvY2F0ZWQsIE06IE1hcmtlZAorICAgIC8vICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFmdGVyIHRoaXMgICAgICAgICBhdCB0aGUg ZW5kICAgICAgICBXaGVuIGN5Y2xlCisgICAgLy8gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIE4gTSAgZnVuY3Rpb24gICAgTiBNICAgICBvZiBjeWNsZSAgICBOIE0g IGlzIGZpbmlzaGVkICAgTiBNCisgICAgLy8gVGhlIGxpdmUgb2JqZWN0IHN1cnZpdmVzIHRoZSBs YXN0IGN5Y2xlICAgIDAgMSAgICAgID0+ICAgICAgMSAwICAgICAgICA9PiAgICAgICAxIDEgICAg ICAgPT4gICAgICAgMCAxICAgID0+IGxpdmUKKyAgICAvLyBUaGUgZGVhZCBvYmplY3QgaW4gdGhl IGxhc3QgY3ljbGUgICAgICAgICAgMCAwICAgICAgPT4gICAgICAwIDAgICAgICAgID0+ICAgICAg IDAgMCAgICAgICA9PiAgICAgICAwIDAgICAgPT4gZGVhZAorICAgIC8vIFRoZSBsaXZlIG9iamVj dCBuZXdseSBjcmVhdGVkIGFmdGVyIHRoaXMgICAgICAgICAgICA9PiAgICAgIDEgMCAgICAgICAg PT4gICAgICAgMSAxICAgICAgID0+ICAgICAgIDAgMSAgICA9PiBsaXZlCisgICAgLy8gVGhlIGRl YWQgb2JqZWN0IG5ld2x5IGNyZWF0ZWQgYWZ0ZXIgdGhpcyAgICAgICAgICAgID0+ICAgICAgMSAw ICAgICAgICA9PiAgICAgICAxIDAgICAgICAgPT4gICAgICAgMCAwICAgID0+IGRlYWQKKyAgICAv LyBUaGUgbGl2ZSBvYmplY3QgbmV3bHkgY3JlYXRlZCBiZWZvcmUgdGhpcyAgMSAwICAgICAgPT4g ICAgICAxIDAgICAgICAgID0+ICAgICAgIDEgMSAgICAgICA9PiAgICAgICAwIDEgICAgPT4gbGl2 ZQorICAgIC8vIFRoZSBkZWFkIG9iamVjdCBuZXdseSBjcmVhdGVkIGJlZm9yZSB0aGlzICAxIDAg ICAgICA9PiAgICAgIDEgMCAgICAgICAgPT4gICAgICAgMSAwICAgICAgID0+ICAgICAgIDAgMCAg ICA9PiBkZWFkCisgICAgLy8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXgorICAgIC8vICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBUaGlzIGlzIGVuc3VyZWQgc2luY2UgdGhpcyBmdW5jdGlvbiBpcyB1 c2VkIG9ubHkgZm9yIGZ1bGwgR0MuCisgICAgbV9pc05ld2x5QWxsb2NhdGVkIHw9IGlzTWFya2Vk KCk7CisgICAgbV9pc01hcmtlZC5zdG9yZShmYWxzZSwgc3RkOjptZW1vcnlfb3JkZXJfcmVsYXhl ZCk7CiB9CiAKIGJvb2wgUHJlY2lzZUFsbG9jYXRpb246OmlzRW1wdHkoKQo=