216710 2020-09-18 12:03:40 -0700 Implementation for AXIsolatedObject::nextSibling and previousSibling. 2020-09-21 11:48:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1689897 0 andresg_22 2020-09-18 12:03:40 -0700 Implementation for AXIsolatedObject::nextSibling and previousSibling. 1689912 1 409161 andresg_22 2020-09-18 12:29:27 -0700 Created attachment 409161 Patch 1689915 2 409161 cfleizach 2020-09-18 12:32:05 -0700 Comment on attachment 409161 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409161&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347 > + AXObjectCache* objectCache; is this an improvement in style? 1689921 3 andresg_22 2020-09-18 12:43:09 -0700 (In reply to chris fleizach from comment #2) > Comment on attachment 409161 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409161&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347 > > + AXObjectCache* objectCache; > > is this an improvement in style? I guess not... First tried to have just one return statement, that I think was the style improvement, but then I added the check for the object cache which can be null and it is a bit cryptic now. 1689928 4 409166 andresg_22 2020-09-18 12:52:14 -0700 Created attachment 409166 Patch 1689930 5 andresg_22 2020-09-18 12:54:33 -0700 (In reply to chris fleizach from comment #2) > Comment on attachment 409161 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409161&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347 > > + AXObjectCache* objectCache; > > is this an improvement in style? I think it's better in latest revision. Thanks. 1690103 6 ews-feeder 2020-09-19 11:52:40 -0700 Committed r267320: <https://trac.webkit.org/changeset/267320> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409166. 1690367 7 webkit-bug-importer 2020-09-21 11:48:54 -0700 <rdar://problem/69317496> 409161 2020-09-18 12:29:27 -0700 2020-09-18 12:52:12 -0700 Patch bug-216710-20200918152926.patch text/plain 7421 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNhZDRiYTQyZWE3ZTZm NDIxMDQyMWJkYTY2YThjYjMzZTIxZTU1ZC4uZmQ3ZjQ4N2QyZjFjZWQ1NDdjOGE1Nzg5MmQ1OTQ4 OWE4MzQwYzc2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTA5LTE4ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnRh dGlvbiBmb3IgQVhJc29sYXRlZE9iamVjdDo6bmV4dFNpYmxpbmcgYW5kIHByZXZpb3VzU2libGlu Zy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjcx MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxl bWVudGF0aW9uIGZvciBBWElzb2xhdGVkT2JqZWN0OjpwcmV2aW91c1NpYmxpbmcgYW5kIG5leHRT aWJsaW5nIHdoaWNoCisgICAgICAgIGFyZSBpbnZva2VkIGJ5IFZvaWNlT3ZlciBpbiBTYWZhcmkg UmVhZGVyIG1vZGUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dDo6cHJldmlvdXNTaWJsaW5nIGNvbnN0KToKKyAgICAgICAgLSBGaXhlZCBjcmFzaCBjYXVzZWQg YnkgZGVyZWZlcmVuY2luZyBtX3JlbmRlcmVyLT5wYXJlbnQoKSB3aGljaCBjYW4gYmUgbnVsbC4K KyAgICAgICAgLSBTb21lIGNvZGUgc3R5bGUgY2xlYW51cC4KKyAgICAgICAgKFdlYkNvcmU6OkFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6Om5leHRTaWJsaW5nIGNvbnN0KToKKyAgICAgICAgLSBD b2RlIHN0eWxlIGNsZWFudXAuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUv QVhJc29sYXRlZE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0 Ojppbml0aWFsaXplQXR0cmlidXRlRGF0YSk6CisgICAgICAgIC0gQWRkZWQgY2FjaGluZyBvZiBu ZXh0L3ByZXZpb3VzU2libGxpbmcgb2JqZWN0cy4KKyAgICAgICAgKFdlYkNvcmU6OkFYSXNvbGF0 ZWRPYmplY3Q6OnByZXZpb3VzU2libGluZyBjb25zdCk6IElubGluZWQgaW4gaGVhZGVyLi4KKyAg ICAgICAgKFdlYkNvcmU6OkFYSXNvbGF0ZWRPYmplY3Q6Om5leHRTaWJsaW5nIGNvbnN0KTogSW5s aW5lZCBpbiBoZWFkZXIuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJ c29sYXRlZE9iamVjdC5oOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FY SXNvbGF0ZWRUcmVlLmg6CisKIDIwMjAtMDktMTggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIE1vdmUgY29tcHV0ZWRMaW5lTG9naWNhbFJlY3Qg dG8gSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApp bmRleCA4NDc2ODY3NGE0NWI1ZGY2OGQ4OWFkZDhkYzI4MWE3MGExODFjMjVmLi5iMGJjYTc0Y2Mx OTUxMjg1MWQ5OTU5ZjU4NTUwMTFkYTVhNDI2MzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAg LTM0MSwxMyArMzQxLDExIEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3Q6OnByZXZpb3VzU2libGluZygpIGNvbnN0CiAKICAgICAvLyBDYXNlIDQ6IFRoaXMg bm9kZSBoYXMgbm8gcHJldmlvdXMgc2libGluZ3MsIGJ1dCBpdHMgcGFyZW50IGlzIGFuIGlubGlu ZSwKICAgICAvLyBhbmQgaXMgYW5vdGhlciBub2RlJ3MgaW5saW5lIGNvbnRpbnV0YXRpb24uIEZv bGxvdyB0aGUgY29udGludWF0aW9uIGNoYWluLgotICAgIGVsc2UgaWYgKGlzPFJlbmRlcklubGlu ZT4oKm1fcmVuZGVyZXItPnBhcmVudCgpKSAmJiAoc3RhcnRPZkNvbnRzID0gc3RhcnRPZkNvbnRp bnVhdGlvbnMoKm1fcmVuZGVyZXItPnBhcmVudCgpKSkpCisgICAgZWxzZSBpZiAoaXM8UmVuZGVy SW5saW5lPihtX3JlbmRlcmVyLT5wYXJlbnQoKSkgJiYgKHN0YXJ0T2ZDb250cyA9IHN0YXJ0T2ZD b250aW51YXRpb25zKCptX3JlbmRlcmVyLT5wYXJlbnQoKSkpKQogICAgICAgICBwcmV2aW91c1Np YmxpbmcgPSBjaGlsZEJlZm9yZUNvbnNpZGVyaW5nQ29udGludWF0aW9ucyhzdGFydE9mQ29udHMs IG1fcmVuZGVyZXItPnBhcmVudCgpLT5maXJzdENoaWxkKCkpOwogCi0gICAgaWYgKCFwcmV2aW91 c1NpYmxpbmcpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotICAgIAotICAgIHJldHVybiBheE9i amVjdENhY2hlKCktPmdldE9yQ3JlYXRlKHByZXZpb3VzU2libGluZyk7CisgICAgQVhPYmplY3RD YWNoZSogb2JqZWN0Q2FjaGU7CisgICAgcmV0dXJuIHByZXZpb3VzU2libGluZyAmJiAob2JqZWN0 Q2FjaGUgPSBheE9iamVjdENhY2hlKCkpID8gb2JqZWN0Q2FjaGUtPmdldE9yQ3JlYXRlKHByZXZp b3VzU2libGluZykgOiBudWxscHRyOwogfQogCiBzdGF0aWMgaW5saW5lIGJvb2wgbGFzdENoaWxk SGFzQ29udGludWF0aW9uKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQpAQCAtNDEwLDEzICs0MDgs MTcgQEAgQWNjZXNzaWJpbGl0eU9iamVjdCogQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6bmV4 dFNpYmxpbmcoKSBjb25zdAogCiAgICAgaWYgKCFuZXh0U2libGluZykKICAgICAgICAgcmV0dXJu IG51bGxwdHI7Ci0gICAgCisKKyAgICBhdXRvKiBvYmplY3RDYWNoZSA9IGF4T2JqZWN0Q2FjaGUo KTsKKyAgICBpZiAoIW9iamVjdENhY2hlKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAg IC8vIE1ha2Ugc3VyZSBuZXh0IHNpYmxpbmcgaGFzIHRoZSBzYW1lIHBhcmVudC4KLSAgICBBY2Nl c3NpYmlsaXR5T2JqZWN0KiBuZXh0T2JqID0gYXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShu ZXh0U2libGluZyk7Ci0gICAgaWYgKG5leHRPYmogJiYgbmV4dE9iai0+cGFyZW50T2JqZWN0KCkg IT0gdGhpcy0+cGFyZW50T2JqZWN0KCkpCisgICAgYXV0byogbmV4dE9iamVjdCA9IG9iamVjdENh Y2hlLT5nZXRPckNyZWF0ZShuZXh0U2libGluZyk7CisgICAgaWYgKG5leHRPYmplY3QgJiYgbmV4 dE9iamVjdC0+cGFyZW50T2JqZWN0KCkgIT0gdGhpcy0+cGFyZW50T2JqZWN0KCkpCiAgICAgICAg IHJldHVybiBudWxscHRyOwotICAgIAotICAgIHJldHVybiBuZXh0T2JqOworCisgICAgcmV0dXJu IG5leHRPYmplY3Q7CiB9CiAKIHN0YXRpYyBSZW5kZXJCb3hNb2RlbE9iamVjdCogbmV4dENvbnRp bnVhdGlvbihSZW5kZXJPYmplY3QmIHJlbmRlcmVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNw cAppbmRleCAzZWNmMWE2MTBkZjMwYzg4ZDA4NjAxMDI2YTIxZjBhNjI5M2M2YzBmLi44YjAyODE2 ZjkyZmVmMGVjODlkYjFhZjdiNTQwYjQzOTM0MjBhYWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2Jq ZWN0LmNwcApAQCAtMjA2LDcgKzIwNiw3IEBAIHZvaWQgQVhJc29sYXRlZE9iamVjdDo6aW5pdGlh bGl6ZUF0dHJpYnV0ZURhdGEoQVhDb3JlT2JqZWN0JiBvYmplY3QsIGJvb2wgaXNSb290CiAgICAg c2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OkF1dG9Db21wbGV0ZVZhbHVlLCBvYmplY3QuYXV0 b0NvbXBsZXRlVmFsdWUoKSk7CiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OlNwZWFr QXMsIG9iamVjdC5zcGVha0FzUHJvcGVydHkoKSk7CiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0 eU5hbWU6OlN0cmluZ1ZhbHVlLCBvYmplY3Quc3RyaW5nVmFsdWUoKS5pc29sYXRlZENvcHkoKSk7 Ci0jaWYgUExBVEZPUk0oQ09DT0EpICYmICFQTEFURk9STShJT1NfRkFNSUxZKQorI2lmIFBMQVRG T1JNKE1BQykKICAgICBzZXRQcm9wZXJ0eShBWFByb3BlcnR5TmFtZTo6Q2FyZXRCcm93c2luZ0Vu YWJsZWQsIG9iamVjdC5jYXJldEJyb3dzaW5nRW5hYmxlZCgpKTsKICNlbmRpZgogICAgIHNldE9i amVjdFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpGb2N1c2FibGVBbmNlc3Rvciwgb2JqZWN0LmZv Y3VzYWJsZUFuY2VzdG9yKCkpOwpAQCAtMjI5LDcgKzIyOSw5IEBAIHZvaWQgQVhJc29sYXRlZE9i amVjdDo6aW5pdGlhbGl6ZUF0dHJpYnV0ZURhdGEoQVhDb3JlT2JqZWN0JiBvYmplY3QsIGJvb2wg aXNSb290CiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6Okhhc1BsYWluVGV4dCwgb2Jq ZWN0Lmhhc1BsYWluVGV4dCgpKTsKICAgICBzZXRQcm9wZXJ0eShBWFByb3BlcnR5TmFtZTo6SGFz VW5kZXJsaW5lLCBvYmplY3QuaGFzVW5kZXJsaW5lKCkpOwogICAgIHNldFByb3BlcnR5KEFYUHJv cGVydHlOYW1lOjpJc0tleWJvYXJkRm9jdXNhYmxlLCBvYmplY3QuaXNLZXlib2FyZEZvY3VzYWJs ZSgpKTsKLSAgICAKKyAgICBzZXRPYmplY3RQcm9wZXJ0eShBWFByb3BlcnR5TmFtZTo6TmV4dFNp YmxpbmcsIG9iamVjdC5uZXh0U2libGluZygpKTsKKyAgICBzZXRPYmplY3RQcm9wZXJ0eShBWFBy b3BlcnR5TmFtZTo6UHJldmlvdXNTaWJsaW5nLCBvYmplY3QucHJldmlvdXNTaWJsaW5nKCkpOwor CiAgICAgaWYgKG9iamVjdC5pc1RhYmxlKCkpIHsKICAgICAgICAgc2V0UHJvcGVydHkoQVhQcm9w ZXJ0eU5hbWU6OklzVGFibGUsIHRydWUpOwogICAgICAgICBzZXRQcm9wZXJ0eShBWFByb3BlcnR5 TmFtZTo6SXNFeHBvc2FibGUsIG9iamVjdC5pc0V4cG9zYWJsZSgpKTsKQEAgLTE0MjMsMTggKzE0 MjUsNiBAQCBBWENvcmVPYmplY3QqIEFYSXNvbGF0ZWRPYmplY3Q6Omxhc3RDaGlsZCgpIGNvbnN0 CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKLUFYQ29yZU9iamVjdCogQVhJc29sYXRlZE9iamVj dDo6cHJldmlvdXNTaWJsaW5nKCkgY29uc3QKLXsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK LSAgICByZXR1cm4gbnVsbHB0cjsKLX0KLQotQVhDb3JlT2JqZWN0KiBBWElzb2xhdGVkT2JqZWN0 OjpuZXh0U2libGluZygpIGNvbnN0Ci17Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAg cmV0dXJuIG51bGxwdHI7Ci19Ci0KIEFYQ29yZU9iamVjdCogQVhJc29sYXRlZE9iamVjdDo6bmV4 dFNpYmxpbmdVbmlnbm9yZWQoaW50KSBjb25zdAogewogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUv QVhJc29sYXRlZE9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRl ZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oCmluZGV4IGE2ZjYyYjZiMjJlNWE3MTJhY2YyN2FkNGEy ZDU3ZTU2MTI4ODdmMTcuLjk1MmNjZTA4YzgxMGYyYmNhZmU3MTllY2FjMDBkMWE0NjU4OWU4NTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FY SXNvbGF0ZWRPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xh dGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmgKQEAgLTU0MSw4ICs1NDEsOCBAQCBwcml2YXRlOgog ICAgIEFYQ29yZU9iamVjdCogZWxlbWVudEFjY2Vzc2liaWxpdHlIaXRUZXN0KGNvbnN0IEludFBv aW50JikgY29uc3Qgb3ZlcnJpZGU7CiAgICAgQVhDb3JlT2JqZWN0KiBmaXJzdENoaWxkKCkgY29u c3Qgb3ZlcnJpZGU7CiAgICAgQVhDb3JlT2JqZWN0KiBsYXN0Q2hpbGQoKSBjb25zdCBvdmVycmlk ZTsKLSAgICBBWENvcmVPYmplY3QqIHByZXZpb3VzU2libGluZygpIGNvbnN0IG92ZXJyaWRlOwot ICAgIEFYQ29yZU9iamVjdCogbmV4dFNpYmxpbmcoKSBjb25zdCBvdmVycmlkZTsKKyAgICBBWENv cmVPYmplY3QqIHByZXZpb3VzU2libGluZygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIG9iamVj dEF0dHJpYnV0ZVZhbHVlKEFYUHJvcGVydHlOYW1lOjpQcmV2aW91c1NpYmxpbmcpOyB9CisgICAg QVhDb3JlT2JqZWN0KiBuZXh0U2libGluZygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIG9iamVj dEF0dHJpYnV0ZVZhbHVlKEFYUHJvcGVydHlOYW1lOjpOZXh0U2libGluZyk7IH0KICAgICBBWENv cmVPYmplY3QqIG5leHRTaWJsaW5nVW5pZ25vcmVkKGludCBsaW1pdCkgY29uc3Qgb3ZlcnJpZGU7 CiAgICAgQVhDb3JlT2JqZWN0KiBwcmV2aW91c1NpYmxpbmdVbmlnbm9yZWQoaW50IGxpbWl0KSBj b25zdCBvdmVycmlkZTsKICAgICBBWENvcmVPYmplY3QqIHBhcmVudE9iamVjdElmRXhpc3RzKCkg Y29uc3Qgb3ZlcnJpZGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuaAppbmRleCAyZTNiYTNhOTY2ZDQyYmNk NmRjM2RmZGQ4OGFiNzQ4MWE5YzM3NDQzLi41MThjNDFmZDBlNGUxMTNkNDE3MDViM2YwMGRlYjkw ODZiMmZlYWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xh dGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmgKQEAgLTI0NywxMCArMjQ3LDEyIEBAIGVu dW0gY2xhc3MgQVhQcm9wZXJ0eU5hbWUgOiB1aW50MTZfdCB7CiAgICAgTWF0aFN1cGVyc2NyaXB0 T2JqZWN0LAogICAgIE1heFZhbHVlRm9yUmFuZ2UsCiAgICAgTWluVmFsdWVGb3JSYW5nZSwKKyAg ICBOZXh0U2libGluZywKICAgICBPcmllbnRhdGlvbiwKICAgICBQYXRoLAogICAgIFBsYWNlaG9s ZGVyVmFsdWUsCiAgICAgUHJlc3NlZElzUHJlc2VudCwKKyAgICBQcmV2aW91c1NpYmxpbmcsCiAg ICAgUG9wdXBWYWx1ZSwKICAgICBQb3NJblNldCwKICAgICBQcmV2ZW50S2V5Ym9hcmRET01FdmVu dERpc3BhdGNoLAo= 409166 2020-09-18 12:52:14 -0700 2020-09-19 11:52:40 -0700 Patch bug-216710-20200918155213.patch text/plain 7431 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNhZDRiYTQyZWE3ZTZm NDIxMDQyMWJkYTY2YThjYjMzZTIxZTU1ZC4uNDBjOTAzNjNiNzczMDhjMjZkNTk1MTAwZTQzNjA0 ZGM0MWNlYzA2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTA5LTE4ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnRh dGlvbiBmb3IgQVhJc29sYXRlZE9iamVjdDo6bmV4dFNpYmxpbmcgYW5kIHByZXZpb3VzU2libGlu Zy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjcx MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxl bWVudGF0aW9uIGZvciBBWElzb2xhdGVkT2JqZWN0OjpwcmV2aW91c1NpYmxpbmcgYW5kIG5leHRT aWJsaW5nIHdoaWNoCisgICAgICAgIGFyZSBpbnZva2VkIGJ5IFZvaWNlT3ZlciBpbiBTYWZhcmkg UmVhZGVyIG1vZGUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dDo6cHJldmlvdXNTaWJsaW5nIGNvbnN0KToKKyAgICAgICAgLSBGaXhlZCBjcmFzaCBjYXVzZWQg YnkgZGVyZWZlcmVuY2luZyBtX3JlbmRlcmVyLT5wYXJlbnQoKSB3aGljaCBjYW4gYmUgbnVsbC4K KyAgICAgICAgLSBBZGRlZCBjaGVjayBmb3IgdGhlIEFYT2JqZWN0Q2FjaGUgdGhhdCBjYW4gYmVj b21lIG51bGwuCisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojpu ZXh0U2libGluZyBjb25zdCk6CisgICAgICAgIC0gQ29kZSBzdHlsZSBjbGVhbnVwLgorICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6aW5pdGlhbGl6ZUF0dHJpYnV0ZURhdGEp OgorICAgICAgICAtIEFkZGVkIGNhY2hpbmcgb2YgbmV4dC9wcmV2aW91c1NpYmxsaW5nIG9iamVj dHMuCisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0OjpwcmV2aW91c1NpYmxpbmcg Y29uc3QpOiBJbmxpbmVkIGluIGhlYWRlci4uCisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVk T2JqZWN0OjpuZXh0U2libGluZyBjb25zdCk6IElubGluZWQgaW4gaGVhZGVyLgorICAgICAgICAq IGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaDoKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oOgorCiAyMDIwLTA5 LTE4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZD XSBNb3ZlIGNvbXB1dGVkTGluZUxvZ2ljYWxSZWN0IHRvIElubGluZUZvcm1hdHRpbmdDb250ZXh0 OjpHZW9tZXRyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKaW5kZXggODQ3Njg2NzRhNDViNWRmNjhkODlh ZGQ4ZGMyODFhNzBhMTgxYzI1Zi4uZTFlMTI5ZmE0OTgzNWViNDMzNDNhYzFhNGZmYWUwMjhlNzA1 NzEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCkBAIC0zNDEsMTMgKzM0MSwxNiBAQCBBY2Nlc3Np YmlsaXR5T2JqZWN0KiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpwcmV2aW91c1NpYmxpbmco KSBjb25zdAogCiAgICAgLy8gQ2FzZSA0OiBUaGlzIG5vZGUgaGFzIG5vIHByZXZpb3VzIHNpYmxp bmdzLCBidXQgaXRzIHBhcmVudCBpcyBhbiBpbmxpbmUsCiAgICAgLy8gYW5kIGlzIGFub3RoZXIg bm9kZSdzIGlubGluZSBjb250aW51dGF0aW9uLiBGb2xsb3cgdGhlIGNvbnRpbnVhdGlvbiBjaGFp bi4KLSAgICBlbHNlIGlmIChpczxSZW5kZXJJbmxpbmU+KCptX3JlbmRlcmVyLT5wYXJlbnQoKSkg JiYgKHN0YXJ0T2ZDb250cyA9IHN0YXJ0T2ZDb250aW51YXRpb25zKCptX3JlbmRlcmVyLT5wYXJl bnQoKSkpKQorICAgIGVsc2UgaWYgKGlzPFJlbmRlcklubGluZT4obV9yZW5kZXJlci0+cGFyZW50 KCkpICYmIChzdGFydE9mQ29udHMgPSBzdGFydE9mQ29udGludWF0aW9ucygqbV9yZW5kZXJlci0+ cGFyZW50KCkpKSkKICAgICAgICAgcHJldmlvdXNTaWJsaW5nID0gY2hpbGRCZWZvcmVDb25zaWRl cmluZ0NvbnRpbnVhdGlvbnMoc3RhcnRPZkNvbnRzLCBtX3JlbmRlcmVyLT5wYXJlbnQoKS0+Zmly c3RDaGlsZCgpKTsKIAogICAgIGlmICghcHJldmlvdXNTaWJsaW5nKQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKLSAgICAKLSAgICByZXR1cm4gYXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShw cmV2aW91c1NpYmxpbmcpOworCisgICAgaWYgKGF1dG8qIG9iamVjdENhY2hlID0gYXhPYmplY3RD YWNoZSgpKQorICAgICAgICByZXR1cm4gb2JqZWN0Q2FjaGUtPmdldE9yQ3JlYXRlKHByZXZpb3Vz U2libGluZyk7CisKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogc3RhdGljIGlubGluZSBib29s IGxhc3RDaGlsZEhhc0NvbnRpbnVhdGlvbihSZW5kZXJFbGVtZW50JiByZW5kZXJlcikKQEAgLTQx MCwxMyArNDEzLDE3IEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3Q6Om5leHRTaWJsaW5nKCkgY29uc3QKIAogICAgIGlmICghbmV4dFNpYmxpbmcpCiAgICAg ICAgIHJldHVybiBudWxscHRyOwotICAgIAorCisgICAgYXV0byogb2JqZWN0Q2FjaGUgPSBheE9i amVjdENhY2hlKCk7CisgICAgaWYgKCFvYmplY3RDYWNoZSkKKyAgICAgICAgcmV0dXJuIG51bGxw dHI7CisKICAgICAvLyBNYWtlIHN1cmUgbmV4dCBzaWJsaW5nIGhhcyB0aGUgc2FtZSBwYXJlbnQu Ci0gICAgQWNjZXNzaWJpbGl0eU9iamVjdCogbmV4dE9iaiA9IGF4T2JqZWN0Q2FjaGUoKS0+Z2V0 T3JDcmVhdGUobmV4dFNpYmxpbmcpOwotICAgIGlmIChuZXh0T2JqICYmIG5leHRPYmotPnBhcmVu dE9iamVjdCgpICE9IHRoaXMtPnBhcmVudE9iamVjdCgpKQorICAgIGF1dG8qIG5leHRPYmplY3Qg PSBvYmplY3RDYWNoZS0+Z2V0T3JDcmVhdGUobmV4dFNpYmxpbmcpOworICAgIGlmIChuZXh0T2Jq ZWN0ICYmIG5leHRPYmplY3QtPnBhcmVudE9iamVjdCgpICE9IHRoaXMtPnBhcmVudE9iamVjdCgp KQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICAKLSAgICByZXR1cm4gbmV4dE9iajsKKwor ICAgIHJldHVybiBuZXh0T2JqZWN0OwogfQogCiBzdGF0aWMgUmVuZGVyQm94TW9kZWxPYmplY3Qq IG5leHRDb250aW51YXRpb24oUmVuZGVyT2JqZWN0JiByZW5kZXJlcikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRl ZE9iamVjdC5jcHAKaW5kZXggM2VjZjFhNjEwZGYzMGM4OGQwODYwMTAyNmEyMWYwYTYyOTNjNmMw Zi4uOGIwMjgxNmY5MmZlZjBlYzg5ZGIxYWY3YjU0MGI0MzkzNDIwYWFlOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVj dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJ c29sYXRlZE9iamVjdC5jcHAKQEAgLTIwNiw3ICsyMDYsNyBAQCB2b2lkIEFYSXNvbGF0ZWRPYmpl Y3Q6OmluaXRpYWxpemVBdHRyaWJ1dGVEYXRhKEFYQ29yZU9iamVjdCYgb2JqZWN0LCBib29sIGlz Um9vdAogICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpBdXRvQ29tcGxldGVWYWx1ZSwg b2JqZWN0LmF1dG9Db21wbGV0ZVZhbHVlKCkpOwogICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlO YW1lOjpTcGVha0FzLCBvYmplY3Quc3BlYWtBc1Byb3BlcnR5KCkpOwogICAgIHNldFByb3BlcnR5 KEFYUHJvcGVydHlOYW1lOjpTdHJpbmdWYWx1ZSwgb2JqZWN0LnN0cmluZ1ZhbHVlKCkuaXNvbGF0 ZWRDb3B5KCkpOwotI2lmIFBMQVRGT1JNKENPQ09BKSAmJiAhUExBVEZPUk0oSU9TX0ZBTUlMWSkK KyNpZiBQTEFURk9STShNQUMpCiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OkNhcmV0 QnJvd3NpbmdFbmFibGVkLCBvYmplY3QuY2FyZXRCcm93c2luZ0VuYWJsZWQoKSk7CiAjZW5kaWYK ICAgICBzZXRPYmplY3RQcm9wZXJ0eShBWFByb3BlcnR5TmFtZTo6Rm9jdXNhYmxlQW5jZXN0b3Is IG9iamVjdC5mb2N1c2FibGVBbmNlc3RvcigpKTsKQEAgLTIyOSw3ICsyMjksOSBAQCB2b2lkIEFY SXNvbGF0ZWRPYmplY3Q6OmluaXRpYWxpemVBdHRyaWJ1dGVEYXRhKEFYQ29yZU9iamVjdCYgb2Jq ZWN0LCBib29sIGlzUm9vdAogICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpIYXNQbGFp blRleHQsIG9iamVjdC5oYXNQbGFpblRleHQoKSk7CiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0 eU5hbWU6Okhhc1VuZGVybGluZSwgb2JqZWN0Lmhhc1VuZGVybGluZSgpKTsKICAgICBzZXRQcm9w ZXJ0eShBWFByb3BlcnR5TmFtZTo6SXNLZXlib2FyZEZvY3VzYWJsZSwgb2JqZWN0LmlzS2V5Ym9h cmRGb2N1c2FibGUoKSk7Ci0gICAgCisgICAgc2V0T2JqZWN0UHJvcGVydHkoQVhQcm9wZXJ0eU5h bWU6Ok5leHRTaWJsaW5nLCBvYmplY3QubmV4dFNpYmxpbmcoKSk7CisgICAgc2V0T2JqZWN0UHJv cGVydHkoQVhQcm9wZXJ0eU5hbWU6OlByZXZpb3VzU2libGluZywgb2JqZWN0LnByZXZpb3VzU2li bGluZygpKTsKKwogICAgIGlmIChvYmplY3QuaXNUYWJsZSgpKSB7CiAgICAgICAgIHNldFByb3Bl cnR5KEFYUHJvcGVydHlOYW1lOjpJc1RhYmxlLCB0cnVlKTsKICAgICAgICAgc2V0UHJvcGVydHko QVhQcm9wZXJ0eU5hbWU6OklzRXhwb3NhYmxlLCBvYmplY3QuaXNFeHBvc2FibGUoKSk7CkBAIC0x NDIzLDE4ICsxNDI1LDYgQEAgQVhDb3JlT2JqZWN0KiBBWElzb2xhdGVkT2JqZWN0OjpsYXN0Q2hp bGQoKSBjb25zdAogICAgIHJldHVybiBudWxscHRyOwogfQogCi1BWENvcmVPYmplY3QqIEFYSXNv bGF0ZWRPYmplY3Q6OnByZXZpb3VzU2libGluZygpIGNvbnN0Ci17Ci0gICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7Ci0gICAgcmV0dXJuIG51bGxwdHI7Ci19Ci0KLUFYQ29yZU9iamVjdCogQVhJc29s YXRlZE9iamVjdDo6bmV4dFNpYmxpbmcoKSBjb25zdAotewotICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOwotICAgIHJldHVybiBudWxscHRyOwotfQotCiBBWENvcmVPYmplY3QqIEFYSXNvbGF0ZWRP YmplY3Q6Om5leHRTaWJsaW5nVW5pZ25vcmVkKGludCkgY29uc3QKIHsKICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNv bGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaAppbmRleCBhNmY2MmI2YjIyZTVhNzEy YWNmMjdhZDRhMmQ1N2U1NjEyODg3ZjE3Li45NTJjY2UwOGM4MTBmMmJjYWZlNzE5ZWNhYzAwZDFh NDY1ODllODUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xh dGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oCkBAIC01NDEsOCArNTQxLDggQEAg cHJpdmF0ZToKICAgICBBWENvcmVPYmplY3QqIGVsZW1lbnRBY2Nlc3NpYmlsaXR5SGl0VGVzdChj b25zdCBJbnRQb2ludCYpIGNvbnN0IG92ZXJyaWRlOwogICAgIEFYQ29yZU9iamVjdCogZmlyc3RD aGlsZCgpIGNvbnN0IG92ZXJyaWRlOwogICAgIEFYQ29yZU9iamVjdCogbGFzdENoaWxkKCkgY29u c3Qgb3ZlcnJpZGU7Ci0gICAgQVhDb3JlT2JqZWN0KiBwcmV2aW91c1NpYmxpbmcoKSBjb25zdCBv dmVycmlkZTsKLSAgICBBWENvcmVPYmplY3QqIG5leHRTaWJsaW5nKCkgY29uc3Qgb3ZlcnJpZGU7 CisgICAgQVhDb3JlT2JqZWN0KiBwcmV2aW91c1NpYmxpbmcoKSBjb25zdCBvdmVycmlkZSB7IHJl dHVybiBvYmplY3RBdHRyaWJ1dGVWYWx1ZShBWFByb3BlcnR5TmFtZTo6UHJldmlvdXNTaWJsaW5n KTsgfQorICAgIEFYQ29yZU9iamVjdCogbmV4dFNpYmxpbmcoKSBjb25zdCBvdmVycmlkZSB7IHJl dHVybiBvYmplY3RBdHRyaWJ1dGVWYWx1ZShBWFByb3BlcnR5TmFtZTo6TmV4dFNpYmxpbmcpOyB9 CiAgICAgQVhDb3JlT2JqZWN0KiBuZXh0U2libGluZ1VuaWdub3JlZChpbnQgbGltaXQpIGNvbnN0 IG92ZXJyaWRlOwogICAgIEFYQ29yZU9iamVjdCogcHJldmlvdXNTaWJsaW5nVW5pZ25vcmVkKGlu dCBsaW1pdCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgQVhDb3JlT2JqZWN0KiBwYXJlbnRPYmplY3RJ ZkV4aXN0cygpIGNvbnN0IG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuaCBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmgKaW5kZXggMmUzYmEz YTk2NmQ0MmJjZDZkYzNkZmRkODhhYjc0ODFhOWMzNzQ0My4uNTE4YzQxZmQwZTRlMTEzZDQxNzA1 YjNmMDBkZWI5MDg2YjJmZWFkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oCkBAIC0yNDcsMTAgKzI0 NywxMiBAQCBlbnVtIGNsYXNzIEFYUHJvcGVydHlOYW1lIDogdWludDE2X3QgewogICAgIE1hdGhT dXBlcnNjcmlwdE9iamVjdCwKICAgICBNYXhWYWx1ZUZvclJhbmdlLAogICAgIE1pblZhbHVlRm9y UmFuZ2UsCisgICAgTmV4dFNpYmxpbmcsCiAgICAgT3JpZW50YXRpb24sCiAgICAgUGF0aCwKICAg ICBQbGFjZWhvbGRlclZhbHVlLAogICAgIFByZXNzZWRJc1ByZXNlbnQsCisgICAgUHJldmlvdXNT aWJsaW5nLAogICAgIFBvcHVwVmFsdWUsCiAgICAgUG9zSW5TZXQsCiAgICAgUHJldmVudEtleWJv YXJkRE9NRXZlbnREaXNwYXRjaCwK