216694 2020-09-18 03:47:20 -0700 [LFC][FFC] Add flex box/item to showLayoutTree 2020-09-19 05:45:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1689756 0 zalan 2020-09-18 03:47:20 -0700 ssia 1689758 1 409125 zalan 2020-09-18 03:49:55 -0700 Created attachment 409125 Patch 1689849 2 409125 sam 2020-09-18 10:32:23 -0700 Comment on attachment 409125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409125&action=review > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:453 > + stream << "Fkex box"; typo. Fkex -> Flex 1689850 3 zalan 2020-09-18 10:33:36 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 409125 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409125&action=review > > > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:453 > > + stream << "Fkex box"; > > typo. Fkex -> Flex never post patches at 4am. 1689993 4 409179 zalan 2020-09-18 16:47:48 -0700 Created attachment 409179 Patch 1690007 5 ews-feeder 2020-09-18 17:40:44 -0700 Committed r267303: <https://trac.webkit.org/changeset/267303> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409179. 1690008 6 webkit-bug-importer 2020-09-18 17:41:15 -0700 <rdar://problem/69185543> 1690031 7 simon.fraser 2020-09-18 20:10:35 -0700 Layout::Boxes need a virtual String debugDescription() const so they can print themselves. 1690061 8 zalan 2020-09-19 05:45:54 -0700 (In reply to Simon Fraser (smfr) from comment #7) > Layout::Boxes need a virtual String debugDescription() const so they can > print themselves. Since the LayoutBox has a rather flat class hierarchy (LFC tree is not typed as heavily as the render tree) we would probably end up with a big switch in Layout::Box. I'd rather keep it separate for now. 409125 2020-09-18 03:49:55 -0700 2020-09-18 16:47:47 -0700 Patch bug-216694-20200918034954.patch text/plain 1924 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgzMjIyMGQwZjkzMDdj MTQwOWViYWQ5NmEwNjA0YWExMTQ2ZTNmZS4uYTY0ZDExNDVkMzQ2MmE4ZDBlMGE0MTZhNzg5NmY4 NzZmMWJhYzdiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA5LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRkZDXSBBZGQgZmxl eCBib3gvaXRlbSB0byBzaG93TGF5b3V0VHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6Om91dHB1dExheW91dEJveCk6ICdUYWJs ZSBwcmluY2lwYWwnIC0+ICdUYWJsZSB3cmFwcGVyIGJveCcgZm9yIGNvbnNpc3RlbmN5IHNha2Uu CisKIDIwMjAtMDktMTggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIFhIUi50aW1lb3V0IGlzIGFmZmVjdGVkIGJ5IGxvbmcgdGFza3MKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcAppbmRl eCAxOTVkYjViNTM5MGE3MGZkNjhjNGUyOGUwYTJhNGUwMDU1MDRhMzVlLi5lMmI5MTA4NDE5N2Zk MDk3Y2FlOTU5MjRjN2JmYTk3MjEyZmJhNjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCkBAIC00MzAsNyArNDMw LDcgQEAgc3RhdGljIHZvaWQgb3V0cHV0TGF5b3V0Qm94KFRleHRTdHJlYW0mIHN0cmVhbSwgY29u c3QgQm94JiBsYXlvdXRCb3gsIGNvbnN0IEJveEcKICAgICBlbHNlIGlmIChsYXlvdXRCb3guaXNC b2R5Qm94KCkpCiAgICAgICAgIHN0cmVhbSA8PCAiQk9EWSI7CiAgICAgZWxzZSBpZiAobGF5b3V0 Qm94LmlzVGFibGVXcmFwcGVyQm94KCkpCi0gICAgICAgIHN0cmVhbSA8PCAiVEFCTEUgcHJpbmNp cGFsIjsKKyAgICAgICAgc3RyZWFtIDw8ICJUQUJMRSB3cmFwcGVyIGJveCI7CiAgICAgZWxzZSBp ZiAobGF5b3V0Qm94LmlzVGFibGVCb3goKSkKICAgICAgICAgc3RyZWFtIDw8ICJUQUJMRSI7CiAg ICAgZWxzZSBpZiAobGF5b3V0Qm94LmlzVGFibGVDYXB0aW9uKCkpCkBAIC00NDksNiArNDQ5LDEw IEBAIHN0YXRpYyB2b2lkIG91dHB1dExheW91dEJveChUZXh0U3RyZWFtJiBzdHJlYW0sIGNvbnN0 IEJveCYgbGF5b3V0Qm94LCBjb25zdCBCb3hHCiAgICAgICAgIHN0cmVhbSA8PCAiVEQiOwogICAg IGVsc2UgaWYgKGxheW91dEJveC5pc1RhYmxlUm93KCkpCiAgICAgICAgIHN0cmVhbSA8PCAiVFIi OworICAgIGVsc2UgaWYgKGxheW91dEJveC5pc0ZsZXhCb3goKSkKKyAgICAgICAgc3RyZWFtIDw8 ICJGa2V4IGJveCI7CisgICAgZWxzZSBpZiAobGF5b3V0Qm94LmlzRmxleEl0ZW0oKSkKKyAgICAg ICAgc3RyZWFtIDw8ICJGbGV4IGl0ZW0iOwogICAgIGVsc2UgaWYgKGxheW91dEJveC5pc0lubGlu ZUxldmVsQm94KCkpIHsKICAgICAgICAgaWYgKGxheW91dEJveC5pc0Fub255bW91cygpKQogICAg ICAgICAgICAgc3RyZWFtIDw8ICJhbm9ueW1vdXMgaW5saW5lIGJveCI7Cg== 409179 2020-09-18 16:47:48 -0700 2020-09-18 17:40:45 -0700 Patch bug-216694-20200918164748.patch text/plain 1940 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3Mjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdkYTAyM2U2ZGY2MjZl ODQyNGE5ZjA1MzE5OTM3MTBhMDZlNGZjMi4uOTRlOWQwYzEzY2ZmYzRhZGFhYjFhMmRhMmY5ZGVk MzcwOWEwZWRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA5LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRkZDXSBBZGQgZmxl eCBib3gvaXRlbSB0byBzaG93TGF5b3V0VHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdl aW5pZy4KKworICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6b3V0cHV0TGF5b3V0Qm94KTogJ1RhYmxlIHBy aW5jaXBhbCcgLT4gJ1RhYmxlIHdyYXBwZXIgYm94JyBmb3IgY29uc2lzdGVuY3kgc2FrZS4KKwog MjAyMC0wOS0xOCAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAg ICAgRGF0ZS90aW1lIGlucHV0cyBzaG91bGQgbm90IHVzZSB1c2VyLXNwZWNpZmllZCBmb3JtYXRz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVl QnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVl QnVpbGRlci5jcHAKaW5kZXggMTk1ZGI1YjUzOTBhNzBmZDY4YzRlMjhlMGEyYTRlMDA1NTA0YTM1 ZS4uZDRjYmMzMDE4NDA0NTIwMWVlY2M0Y2E4N2NmMDQ3NzcwZTc2ODEyMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNw cApAQCAtNDMwLDcgKzQzMCw3IEBAIHN0YXRpYyB2b2lkIG91dHB1dExheW91dEJveChUZXh0U3Ry ZWFtJiBzdHJlYW0sIGNvbnN0IEJveCYgbGF5b3V0Qm94LCBjb25zdCBCb3hHCiAgICAgZWxzZSBp ZiAobGF5b3V0Qm94LmlzQm9keUJveCgpKQogICAgICAgICBzdHJlYW0gPDwgIkJPRFkiOwogICAg IGVsc2UgaWYgKGxheW91dEJveC5pc1RhYmxlV3JhcHBlckJveCgpKQotICAgICAgICBzdHJlYW0g PDwgIlRBQkxFIHByaW5jaXBhbCI7CisgICAgICAgIHN0cmVhbSA8PCAiVEFCTEUgd3JhcHBlciBi b3giOwogICAgIGVsc2UgaWYgKGxheW91dEJveC5pc1RhYmxlQm94KCkpCiAgICAgICAgIHN0cmVh bSA8PCAiVEFCTEUiOwogICAgIGVsc2UgaWYgKGxheW91dEJveC5pc1RhYmxlQ2FwdGlvbigpKQpA QCAtNDQ5LDYgKzQ0OSwxMCBAQCBzdGF0aWMgdm9pZCBvdXRwdXRMYXlvdXRCb3goVGV4dFN0cmVh bSYgc3RyZWFtLCBjb25zdCBCb3gmIGxheW91dEJveCwgY29uc3QgQm94RwogICAgICAgICBzdHJl YW0gPDwgIlREIjsKICAgICBlbHNlIGlmIChsYXlvdXRCb3guaXNUYWJsZVJvdygpKQogICAgICAg ICBzdHJlYW0gPDwgIlRSIjsKKyAgICBlbHNlIGlmIChsYXlvdXRCb3guaXNGbGV4Qm94KCkpCisg ICAgICAgIHN0cmVhbSA8PCAiRmxleCBib3giOworICAgIGVsc2UgaWYgKGxheW91dEJveC5pc0Zs ZXhJdGVtKCkpCisgICAgICAgIHN0cmVhbSA8PCAiRmxleCBpdGVtIjsKICAgICBlbHNlIGlmIChs YXlvdXRCb3guaXNJbmxpbmVMZXZlbEJveCgpKSB7CiAgICAgICAgIGlmIChsYXlvdXRCb3guaXNB bm9ueW1vdXMoKSkKICAgICAgICAgICAgIHN0cmVhbSA8PCAiYW5vbnltb3VzIGlubGluZSBib3gi Owo=