216674 2020-09-17 16:44:27 -0700 Per-app accent color overrides are broken 2020-09-17 17:58:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton darin webkit-bug-importer wenson_hsieh oldest_to_newest 1689648 0 thorton 2020-09-17 16:44:27 -0700 Per-app accent color overrides are broken 1689649 1 409086 thorton 2020-09-17 16:44:43 -0700 Created attachment 409086 Patch 1689650 2 thorton 2020-09-17 16:44:45 -0700 <rdar://problem/67745464> 1689667 3 409086 darin 2020-09-17 17:49:36 -0700 Comment on attachment 409086 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409086&action=review > Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h:39 > @property (copy, setter=_setAccentColor:) NSColor *_accentColor; Can we remove this, too? 1689668 4 ews-feeder 2020-09-17 17:50:22 -0700 Committed r267215: <https://trac.webkit.org/changeset/267215> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409086. 1689674 5 thorton 2020-09-17 17:58:52 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 409086 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409086&action=review > > > Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h:39 > > @property (copy, setter=_setAccentColor:) NSColor *_accentColor; > > Can we remove this, too? No, we can't, we still use the setter! 409086 2020-09-17 16:44:43 -0700 2020-09-17 17:50:22 -0700 Patch bug-216674-20200917164442.patch text/plain 2987 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA5YjI1NmRm NDFjNDQzODYyODkwYTI2NDgzNDBhNTFiOTAwMjI4Y2YwLi4zNjdlMDBkNzQxNzhlMzIwMTk2MmNh NDRjMmQ5NzIyOTQyMTU0NTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMC0wOS0xNyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg ICAgICBQZXItYXBwIGFjY2VudCBjb2xvciBvdmVycmlkZXMgYXJlIGJyb2tlbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2Njc0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82Nzc0NTQ2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEkuaDoKKwogMjAy MC0wOS0xNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJlbW92ZSB1bm5lZWRlZCBIQVZFX0ZPVU5EQVRJT05fV0lUSF9TQVZFX0NPT0tJRVNf V0lUSF9DT01QTEVUSU9OX0hBTkRMRVIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZjExMDJkNDMxODYzNjViODcxN2M5 N2U5ZjIwMTNjOGVhNzIyYjk1Ny4uOGQwM2RjYzdiZWRhMTBkMmIxOWZkYjI3YjE5MjM0ODFhMDUy ZjdhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wOS0xNyAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBQZXItYXBwIGFjY2VudCBjb2xv ciBvdmVycmlkZXMgYXJlIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE2Njc0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82Nzc0NTQ2ND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHM7IEkndmUgbm8gaWRlYSBob3cgdG8gd3JpdGUgYSB0ZXN0IHRoYXQgd291bGQgaGF2ZSBj YXVnaHQgdGhpczsKKyAgICAgICAgYW55IHRlc3QgSSBjYW4gaW1hZ2luZSB3b3VsZCBoYXZlIGFs c28gd3JpdHRlbiB0byBfYWNjZW50Q29sb3IgYW5kIHdvcmtlZCBmaW5lLgorCisgICAgICAgICog VUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbE1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UGFn ZUNsaWVudEltcGw6OmFjY2VudENvbG9yKToKKyAgICAgICAgQXBwS2l0IGNoYW5nZWQgdGhlIG1l YW5pbmcgb2YgdGhlIElQSS4gVXNlIHRoZSBjb3JyZWN0IHZlcnNpb24uCisgICAgICAgIFdlIHN0 aWxsIHdyaXRlIHRvIF9hY2NlbnRDb2xvcjsgaXQgaXMgbm93IHB1cmVseSBhbiBvdmVycmlkZS4K KwogMjAyMC0wOS0xNyAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4K IAogICAgICAgICBFbmFibGUgSVRQIGluIFdLV2ViVmlld3MgZm9yIGFwcHMgd2l0aCB0aGUgZnVs bCBicm93c2VyIGVudGl0bGVtZW50IHdobyBhcmUgbm90IGxpbmtlZCB0byBpT1MgMTQuMApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEku aCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9uU1BJLmgKaW5k ZXggM2JkMmNlNjRkNjhkMTFiMzk2ZWE2OGQ0NzdjMjQ1ZjU3ZjM1OTIxNy4uNmI5MTVjMzFmOTFj YWIyOWE1ZDA4YTdkZjg1NDFiY2Q1NjEyZWU1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv UEFML3BhbC9zcGkvbWFjL05TQXBwbGljYXRpb25TUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Q QUwvcGFsL3NwaS9tYWMvTlNBcHBsaWNhdGlvblNQSS5oCkBAIC0zNyw2ICszNyw3IEBACiAKIC8v IENvbmRpdGlvbmFsbHkgZGVmaW5lIHRoaXMgb25seSBmb3IgIVVTRV9BUFBMRV9JTlRFUk5BTF9T REsgd2hlbiA8cmRhcjovL3Byb2JsZW0vNjM4NjQ3MTE+IGlzIGZpeGVkLgogQHByb3BlcnR5IChj b3B5LCBzZXR0ZXI9X3NldEFjY2VudENvbG9yOikgTlNDb2xvciAqX2FjY2VudENvbG9yOworQHBy b3BlcnR5IChyZWFkb25seSwgY29weSkgTlNDb2xvciAqX2VmZmVjdGl2ZUFjY2VudENvbG9yOwog CiBAZW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9QYWdlQ2xp ZW50SW1wbE1hYy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1w bE1hYy5tbQppbmRleCAwZDVkNTEzNDNkZmJkM2VkNDRlYjRkNjY3OTRhYjI0OGMwZjU5Y2Y0Li5k OWJhNGQwMDBiOTQzNTcyODc0MzRjNzUwYmJhZTY2Y2E2YjFkNDMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGxNYWMubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsTWFjLm1tCkBAIC05NzMsNyArOTcz LDcgQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6cmVxdWVzdERPTVBhc3RlQWNjZXNzKGNvbnN0IFdl YkNvcmU6OkludFJlY3QmIGVsZW1lbnRSZWN0LAogI2lmIEhBVkUoQVBQX0FDQ0VOVF9DT0xPUlMp CiBXZWJDb3JlOjpDb2xvciBQYWdlQ2xpZW50SW1wbDo6YWNjZW50Q29sb3IoKQogewotICAgIHJl dHVybiBXZWJDb3JlOjpjb2xvckZyb21OU0NvbG9yKFtOU0FwcCBfYWNjZW50Q29sb3JdKTsKKyAg ICByZXR1cm4gV2ViQ29yZTo6Y29sb3JGcm9tTlNDb2xvcihbTlNBcHAgX2VmZmVjdGl2ZUFjY2Vu dENvbG9yXSk7CiB9CiAjZW5kaWYKIAo=