216660 2020-09-17 13:12:39 -0700 WKWebView._tryClose should return whether it succeeded or not 2020-09-18 13:18:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen sam thorton webkit-bug-importer oldest_to_newest 1689571 0 achristensen 2020-09-17 13:12:39 -0700 WKWebView._tryClose should return whether it succeeded or not 1689572 1 409059 achristensen 2020-09-17 13:16:34 -0700 Created attachment 409059 Patch 1689621 2 409059 sam 2020-09-17 16:04:50 -0700 Comment on attachment 409059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409059&action=review > Source/WebKit/ChangeLog:9 > + The return value of WKPageTryClose is used by Safari. > + In order to migrate to WKWebView _tryClose, we need to expose this return value. API test? 1689856 3 409144 achristensen 2020-09-18 10:37:34 -0700 Created attachment 409144 Patch 1689939 4 ews-feeder 2020-09-18 13:17:14 -0700 Committed r267279: <https://trac.webkit.org/changeset/267279> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409144. 1689940 5 webkit-bug-importer 2020-09-18 13:18:19 -0700 <rdar://problem/69171188> 409059 2020-09-17 13:16:34 -0700 2020-09-18 10:37:33 -0700 Patch bug-216660-20200917131633.patch text/plain 2185 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjcyMDUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTE3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV0tXZWJWaWV3Ll90 cnlDbG9zZSBzaG91bGQgcmV0dXJuIHdoZXRoZXIgaXQgc3VjY2VlZGVkIG9yIG5vdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NjYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHJldHVybiB2YWx1 ZSBvZiBXS1BhZ2VUcnlDbG9zZSBpcyB1c2VkIGJ5IFNhZmFyaS4KKyAgICAgICAgSW4gb3JkZXIg dG8gbWlncmF0ZSB0byBXS1dlYlZpZXcgX3RyeUNsb3NlLCB3ZSBuZWVkIHRvIGV4cG9zZSB0aGlz IHJldHVybiB2YWx1ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3RyeUNsb3NlXSk6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmg6CisKIDIwMjAtMDktMTcgIEhvYSBEaW5o ICA8ZHZoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgU2hvdWxkQWxsb3dFeHRlcm5hbFNj aGVtZXMgdG8gU2hvdWxkQWxsb3dFeHRlcm5hbFNjaGVtZXNCdXROb3RBcHBMaW5rcyB0byBjbGFy aWZ5IHdoYXQgdGhpcyBlbnVtIHZhbHVlIGlzIGZvci4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkocmV2aXNpb24gMjY3MTQ3KQorKysg U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkod29ya2luZyBj b3B5KQpAQCAtMjA5NCw5ICsyMDk0LDkgQEAgLSAodm9pZClfY2xvc2UKICAgICBfcGFnZS0+Y2xv c2UoKTsKIH0KIAotLSAodm9pZClfdHJ5Q2xvc2UKKy0gKEJPT0wpX3RyeUNsb3NlCiB7Ci0gICAg X3BhZ2UtPnRyeUNsb3NlKCk7CisgICAgcmV0dXJuIF9wYWdlLT50cnlDbG9zZSgpOwogfQogCiAt IChCT09MKV9pc0Nsb3NlZApJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCShyZXZpc2lvbiAyNjcxNDcpCisrKyBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0xOTksNyArMTk5LDcgQEAgZm9yIHRoaXMgcHJvcGVydHkuCiBAcHJvcGVydHkg KG5vbmF0b21pYywgcmVhZG9ubHksIGdldHRlcj1faXNTaG93aW5nTmF2aWdhdGlvbkdlc3R1cmVT bmFwc2hvdCkgQk9PTCBfc2hvd2luZ05hdmlnYXRpb25HZXN0dXJlU25hcHNob3Q7CiAKIC0gKHZv aWQpX2Nsb3NlOwotLSAodm9pZClfdHJ5Q2xvc2UgV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19N QUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKKy0gKEJPT0wpX3RyeUNsb3NlIFdLX0FQSV9BVkFJ TEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAtIChCT09MKV9pc0Ns b3NlZCBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkp OwogCiAtICh2b2lkKV91cGRhdGVXZWJzaXRlUG9saWNpZXM6KF9XS1dlYnNpdGVQb2xpY2llcyAq KXdlYnNpdGVQb2xpY2llcyBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCItX3Vw ZGF0ZVdlYnBhZ2VQcmVmZXJlbmNlczoiLCBtYWNvcygxMC4xMywgV0tfTUFDX1RCQSksIGlvcygx MS4zLCBXS19JT1NfVEJBKSk7Cg== 409144 2020-09-18 10:37:34 -0700 2020-09-18 13:17:14 -0700 Patch bug-216660-20200918103734.patch text/plain 3878 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjcyMzgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTE4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV0tXZWJWaWV3Ll90 cnlDbG9zZSBzaG91bGQgcmV0dXJuIHdoZXRoZXIgaXQgc3VjY2VlZGVkIG9yIG5vdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NjYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHJldHVybiB2YWx1 ZSBvZiBXS1BhZ2VUcnlDbG9zZSBpcyB1c2VkIGJ5IFNhZmFyaS4KKyAgICAgICAgSW4gb3JkZXIg dG8gbWlncmF0ZSB0byBXS1dlYlZpZXcgX3RyeUNsb3NlLCB3ZSBuZWVkIHRvIGV4cG9zZSB0aGlz IHJldHVybiB2YWx1ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3RyeUNsb3NlXSk6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmg6CisKIDIwMjAtMDktMTggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVuaWZpZWQgYnVpbGQgZml4ZXMg aW4gbWVkaWEgY29kZQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tCShyZXZpc2lvbiAyNjcyMzgpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDk0LDkgKzIw OTQsOSBAQCAtICh2b2lkKV9jbG9zZQogICAgIF9wYWdlLT5jbG9zZSgpOwogfQogCi0tICh2b2lk KV90cnlDbG9zZQorLSAoQk9PTClfdHJ5Q2xvc2UKIHsKLSAgICBfcGFnZS0+dHJ5Q2xvc2UoKTsK KyAgICByZXR1cm4gX3BhZ2UtPnRyeUNsb3NlKCk7CiB9CiAKIC0gKEJPT0wpX2lzQ2xvc2VkCklu ZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXdQcml2YXRlLmgJKHJldmlzaW9uIDI2NzIzOCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE5OSw3ICsx OTksNyBAQCBmb3IgdGhpcyBwcm9wZXJ0eS4KIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25s eSwgZ2V0dGVyPV9pc1Nob3dpbmdOYXZpZ2F0aW9uR2VzdHVyZVNuYXBzaG90KSBCT09MIF9zaG93 aW5nTmF2aWdhdGlvbkdlc3R1cmVTbmFwc2hvdDsKIAogLSAodm9pZClfY2xvc2U7Ci0tICh2b2lk KV90cnlDbG9zZSBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9T X1RCQSkpOworLSAoQk9PTClfdHJ5Q2xvc2UgV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19NQUNf VEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKIC0gKEJPT0wpX2lzQ2xvc2VkIFdLX0FQSV9BVkFJTEFC TEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAKIC0gKHZvaWQpX3VwZGF0 ZVdlYnNpdGVQb2xpY2llczooX1dLV2Vic2l0ZVBvbGljaWVzICopd2Vic2l0ZVBvbGljaWVzIFdL X0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoIi1fdXBkYXRlV2VicGFnZVByZWZlcmVu Y2VzOiIsIG1hY29zKDEwLjEzLCBXS19NQUNfVEJBKSwgaW9zKDExLjMsIFdLX0lPU19UQkEpKTsK SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NzI0OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA5LTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgV0tXZWJWaWV3Ll90cnlDbG9zZSBzaG91bGQgcmV0dXJuIHdo ZXRoZXIgaXQgc3VjY2VlZGVkIG9yIG5vdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL09wZW5B bmRDbG9zZVdpbmRvdy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIwLTA5LTE4ICBEaWVnbyBQ aW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2V3c10gU2V0IG9ubHkg b25lIHdvcmtlciBmb3IgSlNDIEFSTXY3IGJ1aWxkZXIgYW5kIHRlc3RlciBxdWV1ZXMKSW5kZXg6 IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvT3BlbkFuZENsb3NlV2luZG93 Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev T3BlbkFuZENsb3NlV2luZG93Lm1tCShyZXZpc2lvbiAyNjcyMzgpCisrKyBUb29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL09wZW5BbmRDbG9zZVdpbmRvdy5tbQkod29ya2luZyBj b3B5KQpAQCAtMjYsMTAgKzI2LDExIEBACiAjaW1wb3J0ICJjb25maWcuaCIKIAogI2ltcG9ydCAi UGxhdGZvcm1VdGlsaXRpZXMuaCIKKyNpbXBvcnQgIlRlc3RXS1dlYlZpZXcuaCIKICNpbXBvcnQg PFdlYktpdC9XS1ByZWZlcmVuY2VzLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tVSURlbGVnYXRlUHJp dmF0ZS5oPgotI2ltcG9ydCA8V2ViS2l0L1dLV2ViVmlldy5oPgogI2ltcG9ydCA8V2ViS2l0L1dL V2ViVmlld0NvbmZpZ3VyYXRpb24uaD4KKyNpbXBvcnQgPFdlYktpdC9XS1dlYlZpZXdQcml2YXRl Lmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tXaW5kb3dGZWF0dXJlc1ByaXZhdGUuaD4KICNpbXBvcnQg PHd0Zi9SZXRhaW5QdHIuaD4KIApAQCAtMzM5LDMgKzM0MCwxMiBAQCBURVNUKFdlYktpdCwgT3Bl bkZpbGVVUkxXaXRoSG9zdCkKICAgICB3aGlsZSAoIVtbW3dlYlZpZXcgVVJMXSBhYnNvbHV0ZVN0 cmluZ10gaGFzUHJlZml4OkAiZmlsZTovLy8iXSkKICAgICAgICAgVGVzdFdlYktpdEFQSTo6VXRp bDo6c3BpblJ1bkxvb3AoKTsKIH0KKworVEVTVChXZWJLaXQsIFRyeUNsb3NlKQoreworICAgIGF1 dG8gd2ViVmlldyA9IGFkb3B0TlMoW1Rlc3RXS1dlYlZpZXcgbmV3XSk7CisgICAgW3dlYlZpZXcg c3luY2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOkAibG9hZCBzb21ldGhpbmciXTsKKyAgICBFWFBF Q1RfVFJVRShbd2ViVmlldyBfdHJ5Q2xvc2VdKTsKKyAgICBbd2ViVmlldyBzeW5jaHJvbm91c2x5 TG9hZEhUTUxTdHJpbmc6QCI8Ym9keSBvbnVubG9hZD0ncnVuU2NyaXB0VGhhdERvZXNOb3ROZWVk VG9FeGlzdCgpJy8+Il07CisgICAgRVhQRUNUX0ZBTFNFKFt3ZWJWaWV3IF90cnlDbG9zZV0pOwor fQo=