216655 2020-09-17 10:51:37 -0700 Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0 2020-09-17 13:42:58 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham webkit-bug-importer wilander oldest_to_newest 1689509 0 katherine_cheney 2020-09-17 10:51:37 -0700 Apps with the full browser entitlement who are not linked to iOS 14.0 should have ITP enabled in WKWebViews, and should not be treated as a full web browser in other WebKit cases until upgrading to iOS 14.0. 1689510 1 webkit-bug-importer 2020-09-17 10:52:00 -0700 <rdar://problem/69081227> 1689527 2 409051 katherine_cheney 2020-09-17 11:22:45 -0700 Created attachment 409051 Patch 1689539 3 409051 wilander 2020-09-17 11:54:24 -0700 Comment on attachment 409051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409051&action=review > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:246 > + return appWasLinkedOnOrAfter && isFullWebBrowser(WebCore::applicationBundleIdentifier()); Couldn't this be return linkedOnOrAfter(SDKVersion::FirstWithSessionCleanupByDefault, AssumeSafariIsAlwaysLinkedOnAfter::Yes) && isFullWebBrowser(WebCore::applicationBundleIdentifier())? 1689540 4 409051 bfulgham 2020-09-17 11:54:45 -0700 Comment on attachment 409051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409051&action=review I don't think this is quite right (see inline comments) > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:109 > + if (isFullWebBrowser(bundleIdentifier) && !appWasLinkedOnOrAfter) Instead of this new test, I think we should change the existing linkedOnOrAfter check to only bail out if the default browser entitlement was NOT used. if (!appWasLinkedOnOrAfter && !isFullWebBrowser(bundleIdentifier)) return false; This way, we fall through and use the User's choice about ITP state for a default browser, even if it was built against the older SDK. > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:246 > + return appWasLinkedOnOrAfter && isFullWebBrowser(WebCore::applicationBundleIdentifier()); After thinking about it, I don't think we need this check. We don't care if the app was linked against an older SDK. We just want to make sure that default browsers honor the user's ITP setting which you handle in your change to 'determineITPStateInternal'. 1689549 5 409056 katherine_cheney 2020-09-17 12:19:41 -0700 Created attachment 409056 Patch 1689561 6 409056 bfulgham 2020-09-17 12:55:26 -0700 Comment on attachment 409056 Patch Looks good! r=me 1689587 7 ews-feeder 2020-09-17 13:42:57 -0700 Committed r267208: <https://trac.webkit.org/changeset/267208> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409056. 409051 2020-09-17 11:22:45 -0700 2020-09-17 12:19:40 -0700 Patch bug-216655-20200917112244.patch text/plain 2692 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU1MWY2NGNiMWYwOGJlMDI3 NzI5ZmFhOGYxZTliMjVhYTczZTc0NWMuLjU4MGViYzM3NWRkNTllNGMwYzc5MTZlZTlkNmRmNDcy MDU1MDg4YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjAtMDktMTcgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIElUUCBp biBXS1dlYlZpZXdzIGZvciBhcHBzIHdpdGggdGhlIGZ1bGwgYnJvd3NlciBlbnRpdGxlbWVudCB3 aG8gYXJlIG5vdCBsaW5rZWQgdG8gaU9TIDE0LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjY1NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjkw ODEyMjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXBwcyB3aXRoIHRoZSBmdWxsIGJyb3dzZXIgZW50aXRsZW1lbnQgd2hvIGFyZSBub3QgbGlua2Vk IHRvIGlPUyAxNC4wCisgICAgICAgIHNob3VsZCBoYXZlIElUUCBlbmFibGVkIGluIFdLV2ViVmll d3MsIGFuZCBzaG91bGQgbm90IGJlIHRyZWF0ZWQgYXMgYQorICAgICAgICBmdWxsIHdlYiBicm93 c2VyIGluIG90aGVyIFdlYktpdCBjYXNlcyB1bnRpbCB1cGdyYWRpbmcgdG8gaU9TIDE0LjAuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyB3YXkgY3VycmVudGx5IHRvIHRlc3QgYXBwcyB3aXRo IGRpZmZlcmVudCBpT1MKKyAgICAgICAgdmVyc2lvbnMuIFRlc3RlZCBtYW51YWxseS4KKworICAg ICAgICAqIFNoYXJlZC9Db2NvYS9EZWZhdWx0V2ViQnJvd3NlckNoZWNrcy5tbToKKyAgICAgICAg KFdlYktpdDo6ZGV0ZXJtaW5lSVRQU3RhdGVJbnRlcm5hbCk6CisgICAgICAgIFJldHVybiB0cnVl IHRvIGVuYWJsZSBJVFAgYWx3YXlzIGZvciBhcHBzIHdpdGggYSBmdWxsIGJyb3dzZXIKKyAgICAg ICAgZW50aXRsZW1lbnQgbm90IGxpbmtlZCBvbiBvciBhZnRlciBpT1MgMTQuMC4gVGhlIFRDQyB0 b2dnbGUgdG8gZGlzYWJsZQorICAgICAgICBJVFAgd2lsbCBub3Qgd29yayBmb3IgYXBwcyB1bnRp bCB0aGV5IHVwZGF0ZSB0aGVpciB2ZXJzaW9uIHRvIGlPUyAxNC4wLgorCisgICAgICAgIChXZWJL aXQ6OmlzRnVsbFdlYkJyb3dzZXIpOgorICAgICAgICBGb3IgYWxsIG90aGVyIHVzZSBjYXNlcyBv ZiB0aGUgaXNGdWxsV2ViQnJvd3NlcigpIGNoZWNrLCBlLmcuIGZvcgorICAgICAgICBhcHAtYm91 bmQgZG9tYWlucywgb25seSByZXR1cm4gdHJ1ZSBpZiB0aGUgYXBwIHdhcyBsaW5rZWQgb24gb3Ig YWZ0ZXIKKyAgICAgICAgaU9TIDE0LjAuCisKIDIwMjAtMDktMTYgIEthdGUgQ2hlbmV5ICA8a2F0 aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IF9zZXRJZ25vcmVzQXBw Qm91bmREb21haW5zIFNQSSB0byBjb21waWxlIGZvciBtYWNPUwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9TaGFyZWQvQ29jb2EvRGVmYXVsdFdlYkJyb3dzZXJDaGVja3MubW0gYi9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9Db2NvYS9EZWZhdWx0V2ViQnJvd3NlckNoZWNrcy5tbQppbmRleCA4MzA0 N2MxOWI0MzgwY2E3ZGY0MTcxNDUyMjU2NjdkMWZmZjZjYTY5Li44ZTgwMTkwZWFkNGE5MGNjMjFk YmZlY2IxMzgxMTJhMGE1YmZjZTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9D b2NvYS9EZWZhdWx0V2ViQnJvd3NlckNoZWNrcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9Db2NvYS9EZWZhdWx0V2ViQnJvd3NlckNoZWNrcy5tbQpAQCAtMTA2LDYgKzEwNiw5IEBAIHN0 YXRpYyBib29sIGRldGVybWluZUlUUFN0YXRlSW50ZXJuYWwoYm9vbCBhcHBXYXNMaW5rZWRPbk9y QWZ0ZXIsIGNvbnN0IFN0cmluZyYKICAgICBBU1NFUlQoIVJ1bkxvb3A6OmlzTWFpbigpKTsKICAg ICBBU1NFUlQoIWlzSW5XZWJLaXRDaGlsZFByb2Nlc3MoKSk7CiAKKyAgICBpZiAoaXNGdWxsV2Vi QnJvd3NlcihidW5kbGVJZGVudGlmaWVyKSAmJiAhYXBwV2FzTGlua2VkT25PckFmdGVyKQorICAg ICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIGlmICghYXBwV2FzTGlua2VkT25PckFmdGVyKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTIzOSw3ICsyNDIsOCBAQCBib29sIGlzRnVsbFdlYkJy b3dzZXIoKQogICAgIEFTU0VSVCghaXNJbldlYktpdENoaWxkUHJvY2VzcygpKTsKICAgICBBU1NF UlQoUnVuTG9vcDo6aXNNYWluKCkpOwogCi0gICAgcmV0dXJuIGlzRnVsbFdlYkJyb3dzZXIoV2Vi Q29yZTo6YXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKCkpOworICAgIGJvb2wgYXBwV2FzTGlu a2VkT25PckFmdGVyID0gbGlua2VkT25PckFmdGVyKFNES1ZlcnNpb246OkZpcnN0V2l0aFNlc3Np b25DbGVhbnVwQnlEZWZhdWx0LCBBc3N1bWVTYWZhcmlJc0Fsd2F5c0xpbmtlZE9uQWZ0ZXI6Olll cyk7CisgICAgcmV0dXJuIGFwcFdhc0xpbmtlZE9uT3JBZnRlciAmJiBpc0Z1bGxXZWJCcm93c2Vy KFdlYkNvcmU6OmFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllcigpKTsKIH0KIAogfSAvLyBuYW1l c3BhY2UgV2ViS2l0Cg== 409056 2020-09-17 12:19:41 -0700 2020-09-17 13:42:58 -0700 Patch bug-216655-20200917121941.patch text/plain 1961 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU1MWY2NGNiMWYwOGJlMDI3 NzI5ZmFhOGYxZTliMjVhYTczZTc0NWMuLmI0NmI3NTU0ZDE2NjBkOWEwNWU3MTM1YWI3ZTg5MjIw ZmUwNjEyMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDktMTcgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIElUUCBp biBXS1dlYlZpZXdzIGZvciBhcHBzIHdpdGggdGhlIGZ1bGwgYnJvd3NlciBlbnRpdGxlbWVudCB3 aG8gYXJlIG5vdCBsaW5rZWQgdG8gaU9TIDE0LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjY1NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjkw ODEyMjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXBwcyB3aXRoIHRoZSBmdWxsIGJyb3dzZXIgZW50aXRsZW1lbnQgd2hvIGFyZSBub3QgbGlua2Vk IHRvIGlPUyAxNC4wCisgICAgICAgIHNob3VsZCBoYXZlIElUUCBlbmFibGVkIGluIFdLV2ViVmll d3MgYnkgZGVmYXVsdC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIHdheSBjdXJyZW50bHkg dG8gdGVzdCBhcHBzIHdpdGggZGlmZmVyZW50IGlPUworICAgICAgICB2ZXJzaW9ucy4gVGVzdGVk IG1hbnVhbGx5LgorCisgICAgICAgICogU2hhcmVkL0NvY29hL0RlZmF1bHRXZWJCcm93c2VyQ2hl Y2tzLm1tOgorICAgICAgICAoV2ViS2l0OjpkZXRlcm1pbmVJVFBTdGF0ZUludGVybmFsKToKKyAg ICAgICAgSWdub3JlIHRoZSBlYXJseSByZXR1cm4gZm9yIHRoZSBsaW5rZWQtb24tb3ItYWZ0ZXIg Y2hlY2sgaWYgdGhlCisgICAgICAgIGFwcCBoYXMgdGhlIGRlZmF1bHQgYnJvd3NlciBlbnRpdGxl bWVudCBzbyB3ZSBzdGlsbCBlbmFibGUgSVRQIGJhc2VkCisgICAgICAgIG9uIHRoZSB1c2VyJ3Mg cHJlZmVyZW5jZS4KKwogMjAyMC0wOS0xNiAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZlcnQgX3NldElnbm9yZXNBcHBCb3VuZERvbWFpbnMg U1BJIHRvIGNvbXBpbGUgZm9yIG1hY09TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9Db2NvYS9EZWZhdWx0V2ViQnJvd3NlckNoZWNrcy5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk L0NvY29hL0RlZmF1bHRXZWJCcm93c2VyQ2hlY2tzLm1tCmluZGV4IDgzMDQ3YzE5YjQzODBjYTdk ZjQxNzE0NTIyNTY2N2QxZmZmNmNhNjkuLmM0YzYzYzE5NjBkNDQ1YzI4ZDk0ZWZjNjI3NDIyYmVj YjJmZjY2ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL0RlZmF1bHRX ZWJCcm93c2VyQ2hlY2tzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL0RlZmF1 bHRXZWJCcm93c2VyQ2hlY2tzLm1tCkBAIC0xMDYsNyArMTA2LDcgQEAgc3RhdGljIGJvb2wgZGV0 ZXJtaW5lSVRQU3RhdGVJbnRlcm5hbChib29sIGFwcFdhc0xpbmtlZE9uT3JBZnRlciwgY29uc3Qg U3RyaW5nJgogICAgIEFTU0VSVCghUnVuTG9vcDo6aXNNYWluKCkpOwogICAgIEFTU0VSVCghaXNJ bldlYktpdENoaWxkUHJvY2VzcygpKTsKIAotICAgIGlmICghYXBwV2FzTGlua2VkT25PckFmdGVy KQorICAgIGlmICghYXBwV2FzTGlua2VkT25PckFmdGVyICYmICFpc0Z1bGxXZWJCcm93c2VyKGJ1 bmRsZUlkZW50aWZpZXIpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoIWlzRnVs bFdlYkJyb3dzZXIoYnVuZGxlSWRlbnRpZmllcikgJiYgIWhhc1JlcXVlc3RlZENyb3NzV2Vic2l0 ZVRyYWNraW5nUGVybWlzc2lvbigpKQo=