216637 2020-09-16 23:00:26 -0700 [JSC] Optimize Promise#finally by avoiding creating multiple environments 2020-09-17 01:07:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist joepeck keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1689340 0 ysuzuki 2020-09-16 23:00:26 -0700 [JSC] Optimize Promise#finally by avoiding creating multiple environments 1689342 1 408992 ysuzuki 2020-09-16 23:07:21 -0700 Created attachment 408992 Patch 1689350 2 408992 ross.kirsling 2020-09-16 23:35:56 -0700 Comment on attachment 408992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408992&action=review Seems fine to me. > Source/JavaScriptCore/builtins/PromisePrototype.js:74 > + thenFinally = (0, /* prevent function name inference */ (value) => { nit: Seems like this could be a line comment above? But I don't feel that strongly. 1689360 3 408992 ysuzuki 2020-09-16 23:54:29 -0700 Comment on attachment 408992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408992&action=review >> Source/JavaScriptCore/builtins/PromisePrototype.js:74 >> + thenFinally = (0, /* prevent function name inference */ (value) => { > > nit: Seems like this could be a line comment above? But I don't feel that strongly. I think this is because `(0, expr)` looks super tricky, and this inlined comment helps readers to understand why this comma expression exists. I think this prefixed comment is nice for consistency since we are using this style in the other places. 1689382 4 ews-feeder 2020-09-17 01:06:05 -0700 Committed r267184: <https://trac.webkit.org/changeset/267184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408992. 1689383 5 webkit-bug-importer 2020-09-17 01:07:21 -0700 <rdar://problem/69049394> 408992 2020-09-16 23:07:21 -0700 2020-09-17 01:06:05 -0700 Patch bug-216637-20200916230720.patch text/plain 3083 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YWU0NzU3OGVlNGMzNmI3YjA2YzI2ZjEzYzdhYzM3ZTZkMzQ1ODUzLi5mYzYzYTY1ZThjMWQ4NzQz MTdiOWRjNGNmNGY3YTA3MDg1Mjc1NTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wOS0xNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIE9wdGltaXplIFByb21pc2UjZmluYWxseSBieSBhdm9pZGluZyBj cmVhdGluZyBtdWx0aXBsZSBlbnZpcm9ubWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjYzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIExldCdzIGp1c3QgY3JlYXRlIGZ1bmN0aW9ucyBpbnNpZGUg UHJvbWlzZSNmaW5hbGx5LiBUaGlzIGF2b2lkcyBjcmVhdGluZworICAgICAgICBtdWx0aXBsZSBs ZXhpY2FsIGVudmlyb25tZW50cyB0aGF0IGFyZSBjYXB0dXJlZCBieSBlYWNoIGZ1bmN0aW9uLgor CisgICAgICAgICogYnVpbHRpbnMvUHJvbWlzZVByb3RvdHlwZS5qczoKKyAgICAgICAgKGZpbmFs bHkpOgorICAgICAgICAoZ2xvYmFsUHJpdmF0ZS5nZXRUaGVuRmluYWxseSk6IERlbGV0ZWQuCisg ICAgICAgIChnbG9iYWxQcml2YXRlLmdldENhdGNoRmluYWxseSk6IERlbGV0ZWQuCisKIDIwMjAt MDktMTYgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3Qg SUMgYSBudWxsIGN1c3RvbSBhY2Nlc3Nvci92YWx1ZSBzZXR0ZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9Qcm9taXNlUHJvdG90eXBlLmpzIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J1aWx0aW5zL1Byb21pc2VQcm90b3R5cGUuanMKaW5kZXggMDI0M2Q1MGU4 NmMyZjVmMTliMzE4YjliZmM3OTg1MzAyMmRmM2EzZC4uZGZmMmNkNGJiZTZmMDNhMGVhYTdlMzM5 MDVjMDQ1ODczZmQwMGQ3OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL1Byb21pc2VQcm90b3R5cGUuanMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL1Byb21pc2VQcm90b3R5cGUuanMKQEAgLTcxLDQzICs3MSwyNSBAQCBmdW5jdGlvbiBmaW5h bGx5KG9uRmluYWxseSkKICAgICAgICAgdGhlbkZpbmFsbHkgPSBvbkZpbmFsbHk7CiAgICAgICAg IGNhdGNoRmluYWxseSA9IG9uRmluYWxseTsKICAgICB9IGVsc2UgewotICAgICAgICB0aGVuRmlu YWxseSA9IEBnZXRUaGVuRmluYWxseShvbkZpbmFsbHksIGNvbnN0cnVjdG9yKTsKLSAgICAgICAg Y2F0Y2hGaW5hbGx5ID0gQGdldENhdGNoRmluYWxseShvbkZpbmFsbHksIGNvbnN0cnVjdG9yKTsK LSAgICB9CisgICAgICAgIHRoZW5GaW5hbGx5ID0gKDAsIC8qIHByZXZlbnQgZnVuY3Rpb24gbmFt ZSBpbmZlcmVuY2UgKi8gKHZhbHVlKSA9PiB7CisgICAgICAgICAgICBAYXNzZXJ0KEBpc0NhbGxh YmxlKG9uRmluYWxseSkpOworICAgICAgICAgICAgdmFyIHJlc3VsdCA9IG9uRmluYWxseSgpOwog Ci0gICAgcmV0dXJuIHRoaXMudGhlbih0aGVuRmluYWxseSwgY2F0Y2hGaW5hbGx5KTsKLX0KKyAg ICAgICAgICAgIEBhc3NlcnQoQGlzQ29uc3RydWN0b3IoY29uc3RydWN0b3IpKTsKKyAgICAgICAg ICAgIHZhciBwcm9taXNlID0gQHByb21pc2VSZXNvbHZlKGNvbnN0cnVjdG9yLCByZXN1bHQpOwog Ci1AZ2xvYmFsUHJpdmF0ZQotZnVuY3Rpb24gZ2V0VGhlbkZpbmFsbHkob25GaW5hbGx5LCBjb25z dHJ1Y3RvcikKLXsKLSAgICAidXNlIHN0cmljdCI7Ci0KLSAgICByZXR1cm4gKHZhbHVlKSA9Pgot ICAgIHsKLSAgICAgICAgQGFzc2VydChAaXNDYWxsYWJsZShvbkZpbmFsbHkpKTsKLSAgICAgICAg dmFyIHJlc3VsdCA9IG9uRmluYWxseSgpOworICAgICAgICAgICAgcmV0dXJuIHByb21pc2UudGhl bigoKSA9PiB2YWx1ZSk7CisgICAgICAgIH0pOworICAgICAgICBjYXRjaEZpbmFsbHkgPSAoMCwg LyogcHJldmVudCBmdW5jdGlvbiBuYW1lIGluZmVyZW5jZSAqLyAocmVhc29uKSA9PiB7CisgICAg ICAgICAgICBAYXNzZXJ0KEBpc0NhbGxhYmxlKG9uRmluYWxseSkpOworICAgICAgICAgICAgdmFy IHJlc3VsdCA9IG9uRmluYWxseSgpOwogCi0gICAgICAgIEBhc3NlcnQoQGlzQ29uc3RydWN0b3Io Y29uc3RydWN0b3IpKTsKLSAgICAgICAgdmFyIHByb21pc2UgPSBAcHJvbWlzZVJlc29sdmUoY29u c3RydWN0b3IsIHJlc3VsdCk7CisgICAgICAgICAgICBAYXNzZXJ0KEBpc0NvbnN0cnVjdG9yKGNv bnN0cnVjdG9yKSk7CisgICAgICAgICAgICB2YXIgcHJvbWlzZSA9IEBwcm9taXNlUmVzb2x2ZShj b25zdHJ1Y3RvciwgcmVzdWx0KTsKIAotICAgICAgICByZXR1cm4gcHJvbWlzZS50aGVuKCgpID0+ IHZhbHVlKTsKKyAgICAgICAgICAgIHJldHVybiBwcm9taXNlLnRoZW4oKCkgPT4geyB0aHJvdyBy ZWFzb247IH0pOworICAgICAgICB9KTsKICAgICB9Ci19CiAKLUBnbG9iYWxQcml2YXRlCi1mdW5j dGlvbiBnZXRDYXRjaEZpbmFsbHkob25GaW5hbGx5LCBjb25zdHJ1Y3RvcikKLXsKLSAgICAidXNl IHN0cmljdCI7Ci0KLSAgICByZXR1cm4gKHJlYXNvbikgPT4KLSAgICB7Ci0gICAgICAgIEBhc3Nl cnQoQGlzQ2FsbGFibGUob25GaW5hbGx5KSk7Ci0gICAgICAgIHZhciByZXN1bHQgPSBvbkZpbmFs bHkoKTsKLQotICAgICAgICBAYXNzZXJ0KEBpc0NvbnN0cnVjdG9yKGNvbnN0cnVjdG9yKSk7Ci0g ICAgICAgIHZhciBwcm9taXNlID0gQHByb21pc2VSZXNvbHZlKGNvbnN0cnVjdG9yLCByZXN1bHQp OwotCi0gICAgICAgIHJldHVybiBwcm9taXNlLnRoZW4oKCkgPT4geyB0aHJvdyByZWFzb247IH0p OwotICAgIH0KKyAgICByZXR1cm4gdGhpcy50aGVuKHRoZW5GaW5hbGx5LCBjYXRjaEZpbmFsbHkp OwogfQo=