216606 2020-09-16 03:32:56 -0700 [Flatpak SDK] bwrap: add pipewire socket as bind mount 2020-09-17 11:08:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vjaquez vjaquez aperez pnormand webkit-bug-importer oldest_to_newest 1689053 0 vjaquez 2020-09-16 03:32:56 -0700 Add pipewire socket to bwrap as bind mount. 1689054 1 408910 vjaquez 2020-09-16 03:42:32 -0700 Created attachment 408910 Patch 1689055 2 vjaquez 2020-09-16 03:43:40 -0700 pipewire 0.3 is already merged in Debian testing 1689088 3 408910 pnormand 2020-09-16 07:44:39 -0700 Comment on attachment 408910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408910&action=review > Tools/ChangeLog:9 > + pipewire server version is bigger than 0.3 Why is it needed to check the version? 1689118 4 vjaquez 2020-09-16 09:08:41 -0700 (In reply to Philippe Normand from comment #3) > Comment on attachment 408910 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408910&action=review > > > Tools/ChangeLog:9 > > + pipewire server version is bigger than 0.3 > > Why is it needed to check the version? I thought it would be cumbersome to add a binding mountpoint to an useless socket (or does the client support back compatibility?). But still, the drawback of it, as far as I'm aware, is it should be upgraded when the pipewire protocol is upgraded. 1689120 5 408910 pnormand 2020-09-16 09:16:58 -0700 Comment on attachment 408910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408910&action=review >>> Tools/ChangeLog:9 >>> + pipewire server version is bigger than 0.3 >> >> Why is it needed to check the version? > > I thought it would be cumbersome to add a binding mountpoint to an useless socket (or does the client support back compatibility?). > > But still, the drawback of it, as far as I'm aware, is it should be upgraded when the pipewire protocol is upgraded. Another option could be to add it in `try_bind_mounts` and let bwrap itself check the existence of the socket. 1689487 6 409047 vjaquez 2020-09-17 10:05:06 -0700 Created attachment 409047 Patch 1689519 7 ews-feeder 2020-09-17 11:07:50 -0700 Committed r267200: <https://trac.webkit.org/changeset/267200> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409047. 1689520 8 webkit-bug-importer 2020-09-17 11:08:16 -0700 <rdar://problem/69082181> 408910 2020-09-16 03:42:32 -0700 2020-09-17 10:05:02 -0700 Patch bug-216606-20200916124231.patch text/plain 2282 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGZhNzA5NDdjMzgzODJmYzAzMGMyMWFlN2U2YmUyNWUx YjI2ZWUzZS4uYWViNzJmMTc5YzAzYjc2ZGY0Mzg4YWNlNDZmYWEzZTE1MDY1YTJkYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA5LTE2ICBWw61jdG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGln YWxpYS5jb20+CisKKyAgICAgICAgW0ZsYXRwYWsgU0RLXSBid3JhcDogYWRkIHBpcGV3aXJlIHNv Y2tldCBhcyBiaW5kIG1vdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTY2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgcGlwZXdpcmUgc29ja2V0IHRvIGJ3cmFwIGFzIGJpbmRpbmcgbW91bnQg aWYgYXZhaWxhYmxlIGFuZAorICAgICAgICBwaXBld2lyZSBzZXJ2ZXIgdmVyc2lvbiBpcyBiaWdn ZXIgdGhhbiAwLjMKKworICAgICAgICAqIGZsYXRwYWsvd2Via2l0LWJ3cmFwOgorCiAyMDIwLTA5 LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBb RmxhdHBhayBTREtdIENoZXJyeS1waWNrIE1lc2EgdXNlLWFmdGVyLWZyZWUgZml4ZXMKZGlmZiAt LWdpdCBhL1Rvb2xzL2ZsYXRwYWsvd2Via2l0LWJ3cmFwIGIvVG9vbHMvZmxhdHBhay93ZWJraXQt YndyYXAKaW5kZXggMTIzODEyMWJmMGY3NzgyZGIzNzdkYThjMTQxZDZjMzFjODNkMjU0ZS4uY2Uy Y2FhMDFiNTIyYTRkNDgxYmE3NGI1YjE4NWIxY2U4ZTUwNGU0NCAxMDA3NTUKLS0tIGEvVG9vbHMv ZmxhdHBhay93ZWJraXQtYndyYXAKKysrIGIvVG9vbHMvZmxhdHBhay93ZWJraXQtYndyYXAKQEAg LTE3LDkgKzE3LDExIEBACiAjIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJh bmtsaW4gU3QsIEZpZnRoIEZsb29yLAogIyBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KIAor aW1wb3J0IHBhdGhsaWIKIGltcG9ydCBvcwogaW1wb3J0IHNobGV4CiBpbXBvcnQgc3lzCitpbXBv cnQgc3VicHJvY2VzcwogaW1wb3J0IHRlbXBmaWxlCiAKIHNjcmlwdGRpciA9IG9zLnBhdGguYWJz cGF0aChvcy5wYXRoLmRpcm5hbWUoX19maWxlX18pKQpAQCAtMzQsNiArMzYsMjIgQEAgZGVmIG1h aW4oYXJnczogbGlzdCkgLT4gaW50OgogICAgICAgICAiL3J1bi9zaG0iOiAiL2Rldi9zaG0iLAog ICAgIH0KIAorICAgIHhkZ19ydW50aW1lX2RpciA9IG9zLmVudmlyb24uZ2V0KCJYREdfUlVOVElN RV9ESVIiKQorICAgIGlmIHhkZ19ydW50aW1lX2RpcjoKKyAgICAgICAgcHdfc29ja2V0ID0gb3Mu cGF0aC5qb2luKHhkZ19ydW50aW1lX2RpciwgInBpcGV3aXJlLTAiKQorICAgICAgICBpZiBwYXRo bGliLlBhdGgocHdfc29ja2V0KS5pc19zb2NrZXQoKToKKyAgICAgICAgICAgIGRlZiBjb21wYXJh YmxlX3ZlcnNpb24odmVyc2lvbik6CisgICAgICAgICAgICAgICAgcmV0dXJuIHR1cGxlKG1hcChp bnQsICh2ZXJzaW9uLnNwbGl0KCIuIikpKSkKKworICAgICAgICAgICAgdHJ5OgorICAgICAgICAg ICAgICAgIHdpdGggb3Blbihvcy5kZXZudWxsLCAndycpIGFzIGRldm51bGw6CisgICAgICAgICAg ICAgICAgICAgIG91dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KCgicHctY2xpIiwgIi0t dmVyc2lvbiIpLCBzdGRlcnI9ZGV2bnVsbCkKKyAgICAgICAgICAgICAgICAgICAgcHdfdmVyc2lv biA9IG91dHB1dC5kZWNvZGUoInV0Zi04Iikuc3RyaXAoKS5zcGxpdCgiXG4iKVsxXS5zcGxpdCgi ICIpWy0xXQorICAgICAgICAgICAgICAgICAgICBpZiBjb21wYXJhYmxlX3ZlcnNpb24ocHdfdmVy c2lvbikgPj0gY29tcGFyYWJsZV92ZXJzaW9uICgiMC4zIik6CisgICAgICAgICAgICAgICAgICAg ICAgICBiaW5kX21vdW50c1twd19zb2NrZXRdID0gcHdfc29ja2V0CisgICAgICAgICAgICBleGNl cHQgc3VicHJvY2Vzcy5DYWxsZWRQcm9jZXNzRXJyb3I6CisgICAgICAgICAgICAgICAgcGFzcwor CiAgICAgZmxhdHBha191c2VyX2RpciA9IG9zLmVudmlyb24uZ2V0KCJXRUJLSVRfRkxBVFBBS19V U0VSX0RJUiIpCiAgICAgaWYgZmxhdHBha191c2VyX2RpcjoKICAgICAgICAgYmluZF9tb3VudHNb Ii92YXIvdG1wIl0gPSBvcy5wYXRoLmpvaW4oZmxhdHBha191c2VyX2RpciwgInZhciIsICJ0bXAi KQo= 409047 2020-09-17 10:05:06 -0700 2020-09-17 11:07:50 -0700 Patch bug-216606-20200917190505.patch text/plain 1384 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE3MmUzZjdhMTI5MDhmYTI2MGQ1ZGRlMTkzNjQ5MDVh NTgwMWRhNC4uM2YxYTNiMGYzYTZjZTQ5ZWE2Y2M4NDY0MjMxNGVmMzcwOTU1N2VhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA5LTE2ICBWw61jdG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGln YWxpYS5jb20+CisKKyAgICAgICAgW0ZsYXRwYWsgU0RLXSBid3JhcDogYWRkIHBpcGV3aXJlIHNv Y2tldCBhcyBiaW5kIG1vdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTY2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgcGlwZXdpcmUgc29ja2V0IHRvIGJ3cmFwIGFzIGEgdHJ5IGJpbmRpbmcg bW91bnQuCisKKyAgICAgICAgKiBmbGF0cGFrL3dlYmtpdC1id3JhcDoKKwogMjAyMC0wOS0xNyAg RGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVu cmV2aWV3ZWQgZ2FyZGVuaW5nLiBBUEkgdGVzdCBXZWJLaXRXZWJJbnNwZWN0b3JTZXJ2ZXIvdGVz dC1wYWdlLWxpc3QgaXMgZmxha3kuCmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL3dlYmtpdC1i d3JhcCBiL1Rvb2xzL2ZsYXRwYWsvd2Via2l0LWJ3cmFwCmluZGV4IDk2NDdlYWUzMjgzOGVkNWU3 Zjg1ZmIzNWU1OTI1MDcwYjFmNGM1MzQuLjJiMzY5MDBjZTI4MjNlNTc4MWExYWNlNDU2OWUwZjg0 YTdmZDEzYjYgMTAwNzU1Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvd2Via2l0LWJ3cmFwCisrKyBiL1Rv b2xzL2ZsYXRwYWsvd2Via2l0LWJ3cmFwCkBAIC01Miw2ICs1MiwxMSBAQCBkZWYgbWFpbihhcmdz OiBsaXN0KSAtPiBpbnQ6CiAgICAgaWYgY29yZWR1bXBzX2RpcjoKICAgICAgICAgdHJ5X2JpbmRf bW91bnRzW2NvcmVkdW1wc19kaXJdID0gY29yZWR1bXBzX2RpcgogCisgICAgeGRnX3J1bnRpbWVf ZGlyID0gb3MuZW52aXJvbi5nZXQoIlhER19SVU5USU1FX0RJUiIpCisgICAgaWYgeGRnX3J1bnRp bWVfZGlyOgorICAgICAgICBwd19zb2NrZXQgPSBvcy5wYXRoLmpvaW4oeGRnX3J1bnRpbWVfZGly LCAicGlwZXdpcmUtMCIpCisgICAgICAgIHRyeV9iaW5kX21vdW50c1twd19zb2NrZXRdID0gcHdf c29ja2V0CisKICAgICBid3JhcF9hcmdzID0gWyJid3JhcCIsIF0KICAgICBmb3IgZHN0LCBzcmMg aW4gYmluZF9tb3VudHMuaXRlbXMoKToKICAgICAgICAgYndyYXBfYXJncy5leHRlbmQoKCItLWJp bmQiLCBzcmMsIGRzdCkpCg==