216604 2020-09-16 01:23:15 -0700 [GTK][WPE] Missing support for multi-word $WEBKIT_MINI_BROWSER_PREFIX 2020-09-21 12:26:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand aperez ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1689040 0 pnormand 2020-09-16 01:23:15 -0700 Currently if this var contains more than one word (like "gdb -args" or "perf record") a python traceback is spewed. 1689041 1 408904 pnormand 2020-09-16 01:25:24 -0700 Created attachment 408904 Patch 1689417 2 408904 aperez 2020-09-17 04:37:20 -0700 Comment on attachment 408904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408904&action=review > Tools/Scripts/webkitpy/port/gtk.py:272 > + command = os.environ["WEBKIT_MINI_BROWSER_PREFIX"].split() + command Is there any reason to not use shlex.split() here? That would allow for specifying parameters in the environment variable which have themselves spaces, by carefully quoting things around. For example: WEBKIT_MINI_BROWSER_PREFIX="'/opt/dev tools v1/bin/gdb' --args" \ run-minibrowser […] Using a plain str.split() would completely prevent such usage. Not that I expect quoting of parameters inside the environment variable to be needed often, but it does not hurt to have our backs covered :) 1689462 3 pnormand 2020-09-17 08:59:34 -0700 In your example would the string with spaces inside need to be quoted again then to result in: ['"/opt/dev tools v1/bin/gdb"', '--args'] ¿ 1689771 4 aperez 2020-09-18 05:23:03 -0700 (In reply to Philippe Normand from comment #3) > In your example would the string with spaces inside need to be quoted again > then to result in: > > ['"/opt/dev tools v1/bin/gdb"', '--args'] > > ¿ Note that “shlex.split()” uses the same parsing rules as the Bourne shell, so it results in the correct thing: >>> import shlex >>> shlex.split('"/opt/dev tools v1/bin/gdb" --args') ['/opt/dev tools v1/bin/gdb', '--args'] >>> shlex.split('"/opt/dev tools v1/bin/gdb" --args') ['/opt/dev tools v1/bin/gdb', '--args'] >>> ;-) 1690064 5 409200 pnormand 2020-09-19 07:00:13 -0700 Created attachment 409200 Patch 1690378 6 ews-feeder 2020-09-21 11:59:02 -0700 Committed r267350: <https://trac.webkit.org/changeset/267350> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409200. 1690433 7 webkit-bug-importer 2020-09-21 12:26:23 -0700 <rdar://problem/69319805> 408904 2020-09-16 01:25:24 -0700 2020-09-19 07:00:08 -0700 Patch bug-216604-20200916012523.patch text/plain 2542 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGZhNzA5NDdjMzgzODJmYzAzMGMyMWFlN2U2YmUyNWUx YjI2ZWUzZS4uZDllMzcyZWU5ZWY4MmFiZWNmMTRhOTU3NmViNjAwYTI1NzUwOTZjNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA5LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXVtXUEVdIE1pc3Npbmcgc3VwcG9ydCBmb3IgbXVsdGktd29yZCAkV0VC S0lUX01JTklfQlJPV1NFUl9QUkVGSVgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNjYwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEdyYWNlZnVsbHkgaGFuZGxlIGNhc2VzIHdoZXJlIHRoZSBlbnYgdmFy IGNvbnRhaW5zIG11bHRpcGxlIHdvcmRzLCBieSBzcGxpdHRpbmcgaXRzIGNvbnRlbnRzCisgICAg ICAgIHRvIGEgbGlzdCBhbmQgaW5zZXJ0aW5nIGl0IGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGZp bmFsIG1pbmlicm93c2VyIGNvbW1hbmQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bv cnQvZ3RrLnB5OgorICAgICAgICAoR3RrUG9ydC5ydW5fbWluaWJyb3dzZXIpOgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHk6CisgICAgICAgIChXUEVQb3J0LnJ1bl9taW5p YnJvd3Nlcik6CisKIDIwMjAtMDktMTYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtGbGF0cGFrIFNES10gQ2hlcnJ5LXBpY2sgTWVzYSB1c2UtYWZ0 ZXItZnJlZSBmaXhlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0 ay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkKaW5kZXggMzFlNDM5ZGRk NGQ4ZDgwNTAzOTMyZmFjOWZhZGYyMmRlMjJhY2E5OC4uNzlhMGU2MjZkN2U0MTI5MTQ1MGRhZGJm N2ZiNmYxMzc1NGI3NTVmMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2d0ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CkBAIC0yNjks NyArMjY5LDggQEAgY2xhc3MgR3RrUG9ydChQb3J0KToKICAgICAgICAgICAgIHJldHVybiAxCiAg ICAgICAgIGNvbW1hbmQgPSBbbWluaUJyb3dzZXJdCiAgICAgICAgIGlmIG9zLmVudmlyb24uZ2V0 KCJXRUJLSVRfTUlOSV9CUk9XU0VSX1BSRUZJWCIpOgotICAgICAgICAgICAgY29tbWFuZC5pbnNl cnQoMCwgb3MuZW52aXJvblsiV0VCS0lUX01JTklfQlJPV1NFUl9QUkVGSVgiXSkKKyAgICAgICAg ICAgIGNvbW1hbmQgPSBvcy5lbnZpcm9uWyJXRUJLSVRfTUlOSV9CUk9XU0VSX1BSRUZJWCJdLnNw bGl0KCkgKyBjb21tYW5kCisKICAgICAgICAgaWYgc2VsZi5fc2hvdWxkX3VzZV9qaGJ1aWxkKCk6 CiAgICAgICAgICAgICBjb21tYW5kID0gc2VsZi5famhidWlsZF93cmFwcGVyICsgY29tbWFuZAog ICAgICAgICByZXR1cm4gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKGNvbW1hbmQgKyBhcmdz LCBjd2Q9c2VsZi53ZWJraXRfYmFzZSgpLCBzdGRvdXQ9Tm9uZSwgcmV0dXJuX3N0ZGVycj1GYWxz ZSwgZGVjb2RlX291dHB1dD1GYWxzZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC93cGUucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5CmluZGV4 IDZmNjQ0NjRhYjhkMTFkOGNiMGU3MDBhMzNiNWMyYjRmMjM2N2YxYzkuLmU2MDRjMmVhNTQ4ZGYz NjIzNzk5ZWExY2M0YzllNTg1OGU2ZGYwYjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC93cGUucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZS5w eQpAQCAtMTQ2LDcgKzE0Niw4IEBAIGNsYXNzIFdQRVBvcnQoUG9ydCk6CiAgICAgICAgICAgICBy ZXR1cm4gMQogICAgICAgICBjb21tYW5kID0gW21pbmlCcm93c2VyXQogICAgICAgICBpZiBvcy5l bnZpcm9uLmdldCgiV0VCS0lUX01JTklfQlJPV1NFUl9QUkVGSVgiKToKLSAgICAgICAgICAgIGNv bW1hbmQuaW5zZXJ0KDAsIG9zLmVudmlyb25bIldFQktJVF9NSU5JX0JST1dTRVJfUFJFRklYIl0p CisgICAgICAgICAgICBjb21tYW5kID0gb3MuZW52aXJvblsiV0VCS0lUX01JTklfQlJPV1NFUl9Q UkVGSVgiXS5zcGxpdCgpICsgY29tbWFuZAorCiAgICAgICAgIGlmIHNlbGYuX3Nob3VsZF91c2Vf amhidWlsZCgpOgogICAgICAgICAgICAgY29tbWFuZCA9IHNlbGYuX2poYnVpbGRfd3JhcHBlciAr IGNvbW1hbmQKICAgICAgICAgcmV0dXJuIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChjb21t YW5kICsgYXJncywgY3dkPXNlbGYud2Via2l0X2Jhc2UoKSwgc3Rkb3V0PU5vbmUsIHJldHVybl9z dGRlcnI9RmFsc2UsIGRlY29kZV9vdXRwdXQ9RmFsc2UpCg== 409200 2020-09-19 07:00:13 -0700 2020-09-21 11:59:02 -0700 Patch bug-216604-20200919070012.patch text/plain 2960 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MzEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU2MzA0M2FlOTJiMjQwMTQyMTE3NGRkY2RhN2ZlZmFl YWRkY2QyYS4uZWNjYzdkYTg4OTI2NzhjMjc3OGMyM2I1M2FhNTEzNDc1ZTczMmMyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA5LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXVtXUEVdIE1pc3Npbmcgc3VwcG9ydCBmb3IgbXVsdGktd29yZCAkV0VC S0lUX01JTklfQlJPV1NFUl9QUkVGSVgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNjYwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEdyYWNlZnVsbHkgaGFuZGxlIGNhc2VzIHdoZXJlIHRoZSBlbnYgdmFy IGNvbnRhaW5zIG11bHRpcGxlIHdvcmRzLCBieSBzcGxpdHRpbmcgaXRzIGNvbnRlbnRzCisgICAg ICAgIHRvIGEgbGlzdCBhbmQgaW5zZXJ0aW5nIGl0IGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGZp bmFsIG1pbmlicm93c2VyIGNvbW1hbmQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bv cnQvZ3RrLnB5OgorICAgICAgICAoR3RrUG9ydC5ydW5fbWluaWJyb3dzZXIpOgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHk6CisgICAgICAgIChXUEVQb3J0LnJ1bl9taW5p YnJvd3Nlcik6CisKIDIwMjAtMDktMTggIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBBUEkgdGVzdCAvd2Via2l0L1dlYktpdFdlYlZpZXcvdXNl cm1lZGlhLWVudW1lcmF0ZWRldmljZXMtcGVybWlzc2lvbi1jaGVjayBpcyBjcmFzaGluZwpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9ndGsucHkKaW5kZXggMzFlNDM5ZGRkNGQ4ZDgwNTAzOTMyZmFjOWZh ZGYyMmRlMjJhY2E5OC4uMjk0ZDc1ZTU1MzZjYTRmY2EyZDlkMjM2ZWVjOGYxZjFjYWJiNWQ1OCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CkBAIC0zMSw2ICszMSw3IEBACiBpbXBvcnQg b3MKIGltcG9ydCB1dWlkCiBpbXBvcnQgbG9nZ2luZworaW1wb3J0IHNobGV4CiAKIGZyb20gd2Vi a2l0cHkuY29tbW9uLnN5c3RlbSBpbXBvcnQgcGF0aAogZnJvbSB3ZWJraXRweS5jb21tb24ubWVt b2l6ZWQgaW1wb3J0IG1lbW9pemVkCkBAIC0yNjksNyArMjcwLDggQEAgY2xhc3MgR3RrUG9ydChQ b3J0KToKICAgICAgICAgICAgIHJldHVybiAxCiAgICAgICAgIGNvbW1hbmQgPSBbbWluaUJyb3dz ZXJdCiAgICAgICAgIGlmIG9zLmVudmlyb24uZ2V0KCJXRUJLSVRfTUlOSV9CUk9XU0VSX1BSRUZJ WCIpOgotICAgICAgICAgICAgY29tbWFuZC5pbnNlcnQoMCwgb3MuZW52aXJvblsiV0VCS0lUX01J TklfQlJPV1NFUl9QUkVGSVgiXSkKKyAgICAgICAgICAgIGNvbW1hbmQgPSBzaGxleC5zcGxpdChv cy5lbnZpcm9uWyJXRUJLSVRfTUlOSV9CUk9XU0VSX1BSRUZJWCJdKSArIGNvbW1hbmQKKwogICAg ICAgICBpZiBzZWxmLl9zaG91bGRfdXNlX2poYnVpbGQoKToKICAgICAgICAgICAgIGNvbW1hbmQg PSBzZWxmLl9qaGJ1aWxkX3dyYXBwZXIgKyBjb21tYW5kCiAgICAgICAgIHJldHVybiBzZWxmLl9l eGVjdXRpdmUucnVuX2NvbW1hbmQoY29tbWFuZCArIGFyZ3MsIGN3ZD1zZWxmLndlYmtpdF9iYXNl KCksIHN0ZG91dD1Ob25lLCByZXR1cm5fc3RkZXJyPUZhbHNlLCBkZWNvZGVfb3V0cHV0PUZhbHNl KQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZS5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHkKaW5kZXggNmY2NDQ2NGFiOGQxMWQ4Y2IwZTcw MGEzM2I1YzJiNGYyMzY3ZjFjOS4uOGEyMGNmNDkzMTE3YWY0ZTJlNjUzZmNlMjAwNThhM2JkYjQx Y2I3NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZS5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5CkBAIC0yNyw2ICsyNyw3IEBACiAj IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCiAKIGltcG9ydCBvcworaW1wb3J0IHNobGV4CiAKIGZyb20gd2Via2l0cHku Y29tbW9uLnN5c3RlbSBpbXBvcnQgcGF0aAogZnJvbSB3ZWJraXRweS5jb21tb24ubWVtb2l6ZWQg aW1wb3J0IG1lbW9pemVkCkBAIC0xNDYsNyArMTQ3LDggQEAgY2xhc3MgV1BFUG9ydChQb3J0KToK ICAgICAgICAgICAgIHJldHVybiAxCiAgICAgICAgIGNvbW1hbmQgPSBbbWluaUJyb3dzZXJdCiAg ICAgICAgIGlmIG9zLmVudmlyb24uZ2V0KCJXRUJLSVRfTUlOSV9CUk9XU0VSX1BSRUZJWCIpOgot ICAgICAgICAgICAgY29tbWFuZC5pbnNlcnQoMCwgb3MuZW52aXJvblsiV0VCS0lUX01JTklfQlJP V1NFUl9QUkVGSVgiXSkKKyAgICAgICAgICAgIGNvbW1hbmQgPSBzaGxleC5zcGxpdChvcy5lbnZp cm9uWyJXRUJLSVRfTUlOSV9CUk9XU0VSX1BSRUZJWCJdKSArIGNvbW1hbmQKKwogICAgICAgICBp ZiBzZWxmLl9zaG91bGRfdXNlX2poYnVpbGQoKToKICAgICAgICAgICAgIGNvbW1hbmQgPSBzZWxm Ll9qaGJ1aWxkX3dyYXBwZXIgKyBjb21tYW5kCiAgICAgICAgIHJldHVybiBzZWxmLl9leGVjdXRp dmUucnVuX2NvbW1hbmQoY29tbWFuZCArIGFyZ3MsIGN3ZD1zZWxmLndlYmtpdF9iYXNlKCksIHN0 ZG91dD1Ob25lLCByZXR1cm5fc3RkZXJyPUZhbHNlLCBkZWNvZGVfb3V0cHV0PUZhbHNlKQo=