216566 2020-09-15 09:51:19 -0700 [ews] Improve failure summary string for AnalyzeCompileWebKitResults step 2020-09-21 10:26:52 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215174 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard webkit-bug-importer oldest_to_newest 1688730 0 aakash_jain 2020-09-15 09:51:19 -0700 Improve failure summary string for AnalyzeCompileWebKitResults step. In case of failure it currently says: "analyze-compile-webkit-results (failure)". Instead, it should be something like: "Patch 407575 does not build". e.g.: https://ews-build.webkit.org/#/builders/29/builds/18342 Note that this was working fine earlier, and probably broke with r265302. 1688737 1 408826 aakash_jain 2020-09-15 10:06:56 -0700 Created attachment 408826 Patch 1688768 2 aakash_jain 2020-09-15 11:24:54 -0700 Tested in: https://ews-build.webkit-uat.org/#/builders/35/builds/6169 https://ews-build.webkit-uat.org/#/builders/35/builds/6175 1689226 3 ews-feeder 2020-09-16 14:52:56 -0700 Committed r267161: <https://trac.webkit.org/changeset/267161> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408826. 1689227 4 webkit-bug-importer 2020-09-16 14:53:17 -0700 <rdar://problem/69016168> 1689766 5 aakash_jain 2020-09-18 04:52:26 -0700 Restarted buildbot to pick up this change. 1690343 6 aakash_jain 2020-09-21 10:26:52 -0700 Working fine, e.g.: https://ews-build.webkit.org/#/builders/29/builds/19951 408826 2020-09-15 10:06:56 -0700 2020-09-16 14:52:56 -0700 Patch bug-216566-20200915130655.patch text/plain 2025 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NzA4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA5LTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIGZhaWx1cmUgc3VtbWFyeSBzdHJpbmcgZm9yIEFu YWx5emVDb21waWxlV2ViS2l0UmVzdWx0cyBzdGVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY1NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weToKKyAgICAgICAgKEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cy5hbmFseXplUmVzdWx0 cyk6IE1vdmUgc2VsZi5maW5pc2hlZCgpIGFmdGVyIHNldHRpbmcgc2VsZi5kZXNjcmlwdGlvbkRv bmUuCisKIDIwMjAtMDktMTUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBNb3ZlIFdlYlNvY2tldCBUTFMgYnlwYXNzIFNQSSBmcm9tIFdlYlBy b2Nlc3NQb29sIHRvIFdlYnNpdGVEYXRhU3RvcmUKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI2NzA4OSkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTQzOCwy MCArMTQzOCwyMCBAQCBjbGFzcyBBbmFseXplQ29tcGlsZVdlYktpdFJlc3VsdHMoYnVpbGRzCiAg ICAgICAgIGNvbXBpbGVfd2l0aG91dF9wYXRjaF9yZXN1bHQgPSBzZWxmLmdldFN0ZXBSZXN1bHQo Y29tcGlsZV93aXRob3V0X3BhdGNoX3N0ZXApCiAKICAgICAgICAgaWYgY29tcGlsZV93aXRob3V0 X3BhdGNoX3Jlc3VsdCA9PSBGQUlMVVJFOgotICAgICAgICAgICAgc2VsZi5maW5pc2hlZChGQUlM VVJFKQogICAgICAgICAgICAgbWVzc2FnZSA9ICdVbmFibGUgdG8gYnVpbGQgV2ViS2l0IHdpdGhv dXQgcGF0Y2gsIHJldHJ5aW5nIGJ1aWxkJwogICAgICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRv bmUgPSBtZXNzYWdlCiAgICAgICAgICAgICBzZWxmLnNlbmRfZW1haWxfZm9yX3ByZWV4aXN0aW5n X2J1aWxkX2ZhaWx1cmUoKQorICAgICAgICAgICAgc2VsZi5maW5pc2hlZChGQUlMVVJFKQogICAg ICAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFttZXNzYWdlXSwgUkVUUlkpCiAgICAg ICAgICAgICByZXR1cm4gZGVmZXIuc3VjY2VlZChOb25lKQogCi0gICAgICAgIHNlbGYuZmluaXNo ZWQoRkFJTFVSRSkKICAgICAgICAgc2VsZi5idWlsZC5yZXN1bHRzID0gRkFJTFVSRQogICAgICAg ICBwYXRjaF9pZCA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJycpCiAgICAgICAgIG1l c3NhZ2UgPSAnUGF0Y2gge30gZG9lcyBub3QgYnVpbGQnLmZvcm1hdChwYXRjaF9pZCkKICAgICAg ICAgc2VsZi5zZW5kX2VtYWlsX2Zvcl9uZXdfYnVpbGRfZmFpbHVyZSgpCiAKICAgICAgICAgc2Vs Zi5kZXNjcmlwdGlvbkRvbmUgPSBtZXNzYWdlCisgICAgICAgIHNlbGYuZmluaXNoZWQoRkFJTFVS RSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRfZmluaXNoX3N1bW1hcnknLCBtZXNz YWdlKQogICAgICAgICBpZiBzZWxmLmdldFByb3BlcnR5KCdidWlsZGVybmFtZScsICcnKS5sb3dl cigpID09ICdjb21taXQtcXVldWUnOgogICAgICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVn emlsbGFfY29tbWVudF90ZXh0JywgbWVzc2FnZSkK