216559 2020-09-15 09:25:28 -0700 Remove runtime setting for enabling/disabling the Cache API? 2020-09-22 09:26:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 216512 1 sam webkit-unassigned koivisto webkit-bug-importer webkit-unassigned oldest_to_newest 1688714 0 sam 2020-09-15 09:25:28 -0700 Remove runtime setting for enabling/disabling the Cache API. It should always be enabled at this point. 1689676 1 sam 2020-09-17 18:16:56 -0700 Looking at the implementation, it looks like this feature was never implemented for WebKitLegacy and seems to be intertwined with the network disk cache in WebKit2. Antti, Chris, can you remind me why the disk cache logic was put into WebKit2? Is it something we could bring into WebCore at some point and use for both WebKitLegacy and WebKit2? 1689806 2 koivisto 2020-09-18 09:02:32 -0700 It was easier to make it WK2 only. It is not clear that risking breaking legacy clients by changing cache behavior is even desirable. The feature was introduced for WK2 clients with linked-on-or-after check. We have plenty of other APIs that are not supported in WK1, right? 1689808 3 sam 2020-09-18 09:07:07 -0700 (In reply to Antti Koivisto from comment #2) > It was easier to make it WK2 only. It is not clear that risking breaking > legacy clients by changing cache behavior is even desirable. The feature was > introduced for WK2 clients with linked-on-or-after check. > > We have plenty of other APIs that are not supported in WK1, right? I don't know. We certainly don't have it well documented what works in WebKit1 vs. WebKit2, which seems lie a pretty big potential footgun waiting to happen. 1690731 4 webkit-bug-importer 2020-09-22 09:26:15 -0700 <rdar://problem/69374740>