216527 2020-09-14 22:22:40 -0700 preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command 2020-09-15 14:44:15 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham cdumez darin pvollan stephan.szabo webkit-bug-importer oldest_to_newest 1688592 0 fujii 2020-09-14 22:22:40 -0700 preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command 1688594 1 408794 fujii 2020-09-14 22:35:43 -0700 Created attachment 408794 Patch 1688746 2 408794 stephan.szabo 2020-09-15 10:38:36 -0700 Comment on attachment 408794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review > Source/WebCore/bindings/scripts/preprocessor.pm:73 > + if ($preprocessorAndFlags[0] =~ "cl.exe") { It seems strange to me to assume that only a cl.exe invocation would be in a windows path. Or that you didn't (for example) have a non-cygwin windows build of clang that might need a windows path to the filename even if the perl being run is cygwin perl. 1688808 3 408794 fujii 2020-09-15 12:54:26 -0700 Comment on attachment 408794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review >> Source/WebCore/bindings/scripts/preprocessor.pm:73 >> + if ($preprocessorAndFlags[0] =~ "cl.exe") { > > It seems strange to me to assume that only a cl.exe invocation would be in a windows path. Or that you didn't (for example) have a non-cygwin windows build of clang that might need a windows path to the filename even if the perl being run is cygwin perl. Yup, this code can support only cl.exe and clang-cl.exe for Windows path, others (gcc and g++) for Cygwin path. 1688818 4 408794 fujii 2020-09-15 13:12:42 -0700 Comment on attachment 408794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review > Source/WebCore/bindings/scripts/preprocessor.pm:74 > + $preprocessorAndFlags[0] = Cygwin::win_to_posix_path($preprocessorAndFlags[0]); Theoretically, I should always do this part "$preprocessorAndFlags[0] = Cygwin::win_to_posix_path($preprocessorAndFlags[0]);" for Cygwin perl even for cl.exe. Will fix. 1688832 5 408857 fujii 2020-09-15 13:51:48 -0700 Created attachment 408857 Patch 1688858 6 408857 fujii 2020-09-15 14:43:37 -0700 Comment on attachment 408857 Patch Clearing flags on attachment: 408857 Committed r267101: <https://trac.webkit.org/changeset/267101> 1688859 7 fujii 2020-09-15 14:43:41 -0700 All reviewed patches have been landed. Closing bug. 1688860 8 webkit-bug-importer 2020-09-15 14:44:15 -0700 <rdar://problem/68942823> 408794 2020-09-14 22:35:43 -0700 2020-09-15 13:51:45 -0700 Patch bug-216527-20200915143541.patch text/plain 2212 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY0NTNlM2RmNjlhYmQz ZDMwYjg5OTRkNDYwNDMwM2MzOTc5YWUwMy4uMzVjY2I4NmI1OGQ5NDhmNWQ4M2Q1YTRkNzg0ZWM2 ZDM1MDE4YjE0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTE0ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIHByZXByb2Nl c3Nvci5wbTogVXNlIEN5Z3dpbjo6d2luX3RvX3Bvc2l4X3BhdGggYW5kIEN5Z3dpbjo6cG9zaXhf dG9fd2luX3BhdGggaW5zdGVhZCBvZiBjeWdwYXRoIGNvbW1hbmQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjUyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9j ZXNzb3IucG06CisgICAgICAgIChhcHBseVByZXByb2Nlc3Nvcik6IFVzZSBzaGVsbHdvcmRzKCkg dG8gc3BsaXQgdGhlICRwcmVwcm9jZXNzb3IuCisgICAgICAgIFVzZSBDeWd3aW4gUGVybCdzIGJ1 aWx0aW4gZnVuY3Rpb25zIGluc3RlYWQgb2Ygc3Bhd25pbmcgcHJvY2Vzcy4KKwogMjAyMC0wOS0x MyAgU2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYklETF0gUmVt b3ZlIG5lZWQgZm9yIFtNYXlUaHJvd0V4Y2VwdGlvbl0gb24gY29uc3RydWN0b3JzIGFuZCBsZWdh Y3kgZmFjdG9yeSBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9wcmVwcm9jZXNzb3IucG0KaW5kZXggNTQ3ZTk1NmYwNWFhOTNkODFhNzAyNzIzZTNmN2IxZDM5 Zjc1YmY2Ni4uYTVlYTdmOTgzMjZhOThiZjg1MDI3MTAyOGRkNTA3OGFmNzA0ZjE4NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KQEAgLTY5 LDE0ICs2OSwxMCBAQCBzdWIgYXBwbHlQcmVwcm9jZXNzb3IKICAgICBteSAkcGlkID0gMDsKICAg ICBpZiAoJENvbmZpZ3tvc25hbWV9IGVxICJjeWd3aW4iKSB7CiAgICAgICAgICRFTlZ7UEFUSH0g PSAiJEVOVntQQVRIfTovY3lnZHJpdmUvYy9jeWd3aW4vYmluIjsKLSAgICAgICAgbXkgQHByZXBy b2Nlc3NvckFuZEZsYWdzOwotICAgICAgICBpZiAoJHByZXByb2Nlc3NvciBlcSAiL3Vzci9iaW4v Z2NjIikgewotICAgICAgICAgICAgQHByZXByb2Nlc3NvckFuZEZsYWdzID0gc3BsaXQoJyAnLCAk cHJlcHJvY2Vzc29yKTsKLSAgICAgICAgfSBlbHNlIHsgICAgICAgIAotICAgICAgICAgICAgJHBy ZXByb2Nlc3NvciA9fiAvIiguKikiLzsKLSAgICAgICAgICAgIGNob21wKG15ICRwcmVwcm9jZXNz b3IgPSBgY3lncGF0aCAtdSAnJDEnYCkgaWYgKGRlZmluZWQgJDEpOwotICAgICAgICAgICAgY2hv bXAoJGZpbGVOYW1lID0gYGN5Z3BhdGggLXcgJyRmaWxlTmFtZSdgKTsKLSAgICAgICAgICAgIEBw cmVwcm9jZXNzb3JBbmRGbGFncyA9ICgkcHJlcHJvY2Vzc29yLCAiL25vbG9nbyIsICIvRVAiKTsK KyAgICAgICAgbXkgQHByZXByb2Nlc3NvckFuZEZsYWdzID0gc2hlbGx3b3JkcygkcHJlcHJvY2Vz c29yKTsKKyAgICAgICAgaWYgKCRwcmVwcm9jZXNzb3JBbmRGbGFnc1swXSA9fiAiY2wuZXhlIikg eworICAgICAgICAgICAgJHByZXByb2Nlc3NvckFuZEZsYWdzWzBdID0gQ3lnd2luOjp3aW5fdG9f cG9zaXhfcGF0aCgkcHJlcHJvY2Vzc29yQW5kRmxhZ3NbMF0pOworICAgICAgICAgICAgJGZpbGVO YW1lID0gQ3lnd2luOjpwb3NpeF90b193aW5fcGF0aCgkZmlsZU5hbWUpOwogICAgICAgICB9CiAg ICAgICAgICMgVGhpcyBjYWxsIGNhbiBmYWlsIGlmIFdpbmRvd3MgcmViYXNlcyBjeWd3aW4sIHNv IHJldHJ5IGEgZmV3IHRpbWVzIHVudGlsIGl0IHN1Y2NlZWRzLgogICAgICAgICBmb3IgKG15ICR0 cmllcyA9IDA7ICEkcGlkICYmICgkdHJpZXMgPCAyMCk7ICR0cmllcysrKSB7Cg== 408857 2020-09-15 13:51:48 -0700 2020-09-15 14:43:37 -0700 Patch bug-216527-20200916055147.patch text/plain 2201 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGJhZWI5MzNhYjc5Zjk5 Mzg3ZDI2ZmZjMzg1MGYyOTU1OGY1ODFmMi4uZGQ2MWE0ZTM0NzU0NWQwOTA1NGEyZDM1OTdhODkz ZjIwOWRhMmU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTE1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIHByZXByb2Nl c3Nvci5wbTogVXNlIEN5Z3dpbjo6d2luX3RvX3Bvc2l4X3BhdGggYW5kIEN5Z3dpbjo6cG9zaXhf dG9fd2luX3BhdGggaW5zdGVhZCBvZiBjeWdwYXRoIGNvbW1hbmQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjUyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9j ZXNzb3IucG06CisgICAgICAgIChhcHBseVByZXByb2Nlc3Nvcik6IFVzZSBzaGVsbHdvcmRzKCkg dG8gc3BsaXQgdGhlICRwcmVwcm9jZXNzb3IuCisgICAgICAgIFVzZSBDeWd3aW4gUGVybCdzIGJ1 aWx0aW4gZnVuY3Rpb25zIGluc3RlYWQgb2Ygc3Bhd25pbmcgcHJvY2Vzcy4KKwogMjAyMC0wOS0x NCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBb V2luQ2Fpcm9dIFVucmV2aWV3ZWQgZGVidWcgYnVpbGQgZml4IGFmdGVyIHIyNjcwNzMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KaW5kZXggNTQ3 ZTk1NmYwNWFhOTNkODFhNzAyNzIzZTNmN2IxZDM5Zjc1YmY2Ni4uZjU3Yzc2NmFiOGVkMDAwMmFm ZTQxY2Y2NTU0MTRhNDc3NWI3ZDhlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KQEAgLTY5LDE1ICs2OSwxMSBAQCBzdWIgYXBwbHlQcmVw cm9jZXNzb3IKICAgICBteSAkcGlkID0gMDsKICAgICBpZiAoJENvbmZpZ3tvc25hbWV9IGVxICJj eWd3aW4iKSB7CiAgICAgICAgICRFTlZ7UEFUSH0gPSAiJEVOVntQQVRIfTovY3lnZHJpdmUvYy9j eWd3aW4vYmluIjsKLSAgICAgICAgbXkgQHByZXByb2Nlc3NvckFuZEZsYWdzOwotICAgICAgICBp ZiAoJHByZXByb2Nlc3NvciBlcSAiL3Vzci9iaW4vZ2NjIikgewotICAgICAgICAgICAgQHByZXBy b2Nlc3NvckFuZEZsYWdzID0gc3BsaXQoJyAnLCAkcHJlcHJvY2Vzc29yKTsKLSAgICAgICAgfSBl bHNlIHsgICAgICAgIAotICAgICAgICAgICAgJHByZXByb2Nlc3NvciA9fiAvIiguKikiLzsKLSAg ICAgICAgICAgIGNob21wKG15ICRwcmVwcm9jZXNzb3IgPSBgY3lncGF0aCAtdSAnJDEnYCkgaWYg KGRlZmluZWQgJDEpOwotICAgICAgICAgICAgY2hvbXAoJGZpbGVOYW1lID0gYGN5Z3BhdGggLXcg JyRmaWxlTmFtZSdgKTsKLSAgICAgICAgICAgIEBwcmVwcm9jZXNzb3JBbmRGbGFncyA9ICgkcHJl cHJvY2Vzc29yLCAiL25vbG9nbyIsICIvRVAiKTsKKyAgICAgICAgbXkgQHByZXByb2Nlc3NvckFu ZEZsYWdzID0gc2hlbGx3b3JkcygkcHJlcHJvY2Vzc29yKTsKKyAgICAgICAgaWYgKCRwcmVwcm9j ZXNzb3JBbmRGbGFnc1swXSA9fiAiY2wuZXhlIikgeworICAgICAgICAgICAgJGZpbGVOYW1lID0g Q3lnd2luOjpwb3NpeF90b193aW5fcGF0aCgkZmlsZU5hbWUpOwogICAgICAgICB9CisgICAgICAg ICRwcmVwcm9jZXNzb3JBbmRGbGFnc1swXSA9IEN5Z3dpbjo6d2luX3RvX3Bvc2l4X3BhdGgoJHBy ZXByb2Nlc3NvckFuZEZsYWdzWzBdKTsKICAgICAgICAgIyBUaGlzIGNhbGwgY2FuIGZhaWwgaWYg V2luZG93cyByZWJhc2VzIGN5Z3dpbiwgc28gcmV0cnkgYSBmZXcgdGltZXMgdW50aWwgaXQgc3Vj Y2VlZHMuCiAgICAgICAgIGZvciAobXkgJHRyaWVzID0gMDsgISRwaWQgJiYgKCR0cmllcyA8IDIw KTsgJHRyaWVzKyspIHsKICAgICAgICAgICAgIGV2YWwgewo=