216517 2020-09-14 18:11:39 -0700 [macOS] Update date picker appearance to match system date pickers 2020-10-08 12:13:39 -0700 1 1 1 Unclassified WebKit Forms Safari Technology Preview Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi akeerthi cdumez m.kurz+webkitbugs thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1688524 0 akeerthi 2020-09-14 18:11:39 -0700 Date pickers on macOS do not use NSVisualEffectView. 1688525 1 akeerthi 2020-09-14 18:12:07 -0700 <rdar://problem/68890678> 1688526 2 408778 akeerthi 2020-09-14 18:17:41 -0700 Created attachment 408778 Patch 1688685 3 ews-feeder 2020-09-15 07:35:14 -0700 Committed r267085: <https://trac.webkit.org/changeset/267085> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408778. 408778 2020-09-14 18:17:41 -0700 2020-09-15 07:35:14 -0700 Patch bug-216517-20200914211740.patch text/plain 5774 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyYzNlNTVhMGNiMTM0Nzk4 YmNkMGFlYmE0NWRiNDg4NzQ4OWZiMDUuLmRiOTQ1ZDg5ZWE3NDcyZjNiNjZmOGQyNGUwODM0YmVi NmYxOTUwNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDktMTQgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gVXBkYXRlIGRh dGUgcGlja2VyIGFwcGVhcmFuY2UgdG8gbWF0Y2ggc3lzdGVtIGRhdGUgcGlja2VycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NTE3CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82ODg5MDY3OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTeXN0ZW0gZGF0ZSBwaWNrZXJzIGluIG1hY09TIGRvIG5vdCB1 c2UgTlNWaXN1YWxFZmZlY3RWaWV3LiBJbnN0ZWFkLCB1c2UKKyAgICAgICAgYSBzb2xpZCBiYWNr Z3JvdW5kIHZpZXcgd2l0aCB0aHJlZSByb3VuZGVkIGNvcm5lcnMuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvbWFjL1dlYkRhdGVUaW1lUGlja2VyTWFjLm1tOgorICAgICAgICAoLVtXS0RhdGVUaW1l UGlja2VyV2luZG93IGluaXRXaXRoQ29udGVudFJlY3Q6c3R5bGVNYXNrOmJhY2tpbmc6ZGVmZXI6 XSk6CisgICAgICAgICgtW1dLRGF0ZVRpbWVQaWNrZXJCYWNrZHJvcFZpZXcgZHJhd1JlY3Q6XSk6 CisgICAgICAgICgtW1dLRGF0ZVRpbWVQaWNrZXIgaW5pdFdpdGhQYXJhbXM6aW5WaWV3Ol0pOgor CiAyMDIwLTA5LTE0ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbbWFjT1NdIERvIG5vdCBkaXNtaXNzIGRhdGUgcGlja2VyIHdoZW4gYSB2YWx1ZSBpcyBz ZWxlY3RlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYkRhdGVU aW1lUGlja2VyTWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dlYkRhdGVUaW1l UGlja2VyTWFjLm1tCmluZGV4IGZhOWYzZDZmY2U2ZTRjYmU1MWIzOWEzZmM4NzBhMTI5NDUxMzA4 MmQuLmFjZmIwYWI0MTdhY2E4Zjk4ODJjZWU2NjE5ZDE3MDgwMWVlYzc3YmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJEYXRlVGltZVBpY2tlck1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViRGF0ZVRpbWVQaWNrZXJNYWMubW0KQEAg LTMzLDYgKzMzLDcgQEAKIAogY29uc3RleHByIENHRmxvYXQga0NhbGVuZGFyV2lkdGggPSAxMzk7 CiBjb25zdGV4cHIgQ0dGbG9hdCBrQ2FsZW5kYXJIZWlnaHQgPSAxNDg7Citjb25zdGV4cHIgQ0dG bG9hdCBrQ2FsZW5kYXJDb3JuZXJSYWRpdXMgPSAxMDsKIGNvbnN0ZXhwciBOU1N0cmluZyAqIGtE YXRlRm9ybWF0U3RyaW5nID0gQCJ5eXl5LU1NLWRkIjsKIGNvbnN0ZXhwciBOU1N0cmluZyAqIGtE YXRlVGltZUZvcm1hdFN0cmluZyA9IEAieXl5eS1NTS1kZCdUJ0hIOm1tIjsKIGNvbnN0ZXhwciBO U1N0cmluZyAqIGtEYXRlVGltZVdpdGhTZWNvbmRzRm9ybWF0U3RyaW5nID0gQCJ5eXl5LU1NLWRk J1QnSEg6bW06c3MiOwpAQCAtNTIsNiArNTMsOSBAQCBAZW5kCiBAaW50ZXJmYWNlIFdLRGF0ZVRp bWVQaWNrZXJXaW5kb3cgOiBOU1dpbmRvdwogQGVuZAogCitAaW50ZXJmYWNlIFdLRGF0ZVRpbWVQ aWNrZXJCYWNrZHJvcFZpZXcgOiBOU1ZpZXcKK0BlbmQKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAK IFJlZjxXZWJEYXRlVGltZVBpY2tlck1hYz4gV2ViRGF0ZVRpbWVQaWNrZXJNYWM6OmNyZWF0ZShX ZWJQYWdlUHJveHkmIHBhZ2UsIE5TVmlldyAqdmlldykKQEAgLTk4LDkgKzEwMiw4IEBAIHZvaWQg V2ViRGF0ZVRpbWVQaWNrZXJNYWM6OmRpZENob29zZURhdGUoU3RyaW5nVmlldyBkYXRlKQogCiB9 IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAotLy8gRklYTUU6IFNoYXJlIHRoaXMgaW1wbGVtZW50YXRp b24gd2l0aCBXS0RhdGFMaXN0U3VnZ2VzdGlvbldpbmRvdy4KIEBpbXBsZW1lbnRhdGlvbiBXS0Rh dGVUaW1lUGlja2VyV2luZG93IHsKLSAgICBSZXRhaW5QdHI8TlNWaXN1YWxFZmZlY3RWaWV3PiBf YmFja2Ryb3BWaWV3OworICAgIFJldGFpblB0cjxXS0RhdGVUaW1lUGlja2VyQmFja2Ryb3BWaWV3 PiBfYmFja2Ryb3BWaWV3OwogfQogCiAtIChpZClpbml0V2l0aENvbnRlbnRSZWN0OihOU1JlY3Qp Y29udGVudFJlY3Qgc3R5bGVNYXNrOihOU1VJbnRlZ2VyKXN0eWxlTWFzayBiYWNraW5nOihOU0Jh Y2tpbmdTdG9yZVR5cGUpYmFja2luZ1N0b3JlVHlwZSBkZWZlcjooQk9PTClkZWZlcgpAQCAtMTE3 LDEyICsxMjAsOCBAQCAtIChpZClpbml0V2l0aENvbnRlbnRSZWN0OihOU1JlY3QpY29udGVudFJl Y3Qgc3R5bGVNYXNrOihOU1VJbnRlZ2VyKXN0eWxlTWFzayBiYQogICAgIHNlbGYuYmFja2dyb3Vu ZENvbG9yID0gW05TQ29sb3IgY2xlYXJDb2xvcl07CiAgICAgc2VsZi5vcGFxdWUgPSBOTzsKIAot ICAgIF9iYWNrZHJvcFZpZXcgPSBhZG9wdE5TKFtbTlNWaXN1YWxFZmZlY3RWaWV3IGFsbG9jXSBp bml0V2l0aEZyYW1lOmNvbnRlbnRSZWN0XSk7CisgICAgX2JhY2tkcm9wVmlldyA9IGFkb3B0TlMo W1tXS0RhdGVUaW1lUGlja2VyQmFja2Ryb3BWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOmNvbnRl bnRSZWN0XSk7CiAgICAgW19iYWNrZHJvcFZpZXcgc2V0QXV0b3Jlc2l6aW5nTWFzazpOU1ZpZXdX aWR0aFNpemFibGUgfCBOU1ZpZXdIZWlnaHRTaXphYmxlXTsKLSAgICBbX2JhY2tkcm9wVmlldyBz ZXRNYXRlcmlhbDpOU1Zpc3VhbEVmZmVjdE1hdGVyaWFsTWVudV07Ci0gICAgW19iYWNrZHJvcFZp ZXcgc2V0U3RhdGU6TlNWaXN1YWxFZmZlY3RTdGF0ZUFjdGl2ZV07Ci0gICAgW19iYWNrZHJvcFZp ZXcgc2V0QmxlbmRpbmdNb2RlOk5TVmlzdWFsRWZmZWN0QmxlbmRpbmdNb2RlQmVoaW5kV2luZG93 XTsKLQogICAgIFtzZWxmIHNldENvbnRlbnRWaWV3Ol9iYWNrZHJvcFZpZXcuZ2V0KCldOwogCiAg ICAgcmV0dXJuIHNlbGY7CkBAIC0xNDUsNiArMTQ0LDM3IEBAIC0gKE5TV2luZG93U2hhZG93T3B0 aW9ucylzaGFkb3dPcHRpb25zCiAKIEBlbmQKIAorQGltcGxlbWVudGF0aW9uIFdLRGF0ZVRpbWVQ aWNrZXJCYWNrZHJvcFZpZXcKKworLSAodm9pZClkcmF3UmVjdDooTlNSZWN0KWRpcnR5UmVjdAor eworICAgIFtOU0dyYXBoaWNzQ29udGV4dCBzYXZlR3JhcGhpY3NTdGF0ZV07CisKKyAgICBbW05T Q29sb3IgY29udHJvbEJhY2tncm91bmRDb2xvcl0gc2V0RmlsbF07CisKKyAgICBOU1JlY3QgZnJh bWUgPSBzZWxmLmZyYW1lOworICAgIE5TUG9pbnQgdG9wTGVmdCA9IE5TTWFrZVBvaW50KE5TTWlu WChmcmFtZSksIE5TTWF4WShmcmFtZSkpOworICAgIE5TUG9pbnQgdG9wUmlnaHQgPSBOU01ha2VQ b2ludChOU01heFgoZnJhbWUpLCBOU01heFkoZnJhbWUpKTsKKyAgICBOU1BvaW50IGJvdHRvbVJp Z2h0ID0gTlNNYWtlUG9pbnQoTlNNYXhYKGZyYW1lKSwgTlNNaW5ZKGZyYW1lKSk7CisgICAgTlNQ b2ludCBib3R0b21MZWZ0ID0gTlNNYWtlUG9pbnQoTlNNaW5YKGZyYW1lKSwgTlNNaW5ZKGZyYW1l KSk7CisKKyAgICBOU0JlemllclBhdGggKnBhdGggPSBbTlNCZXppZXJQYXRoIGJlemllclBhdGhd OworICAgIFtwYXRoIG1vdmVUb1BvaW50OnRvcExlZnRdOworICAgIFtwYXRoIGxpbmVUb1BvaW50 Ok5TTWFrZVBvaW50KHRvcFJpZ2h0LnggLSBrQ2FsZW5kYXJDb3JuZXJSYWRpdXMsIHRvcFJpZ2h0 LnkpXTsKKyAgICBbcGF0aCBjdXJ2ZVRvUG9pbnQ6TlNNYWtlUG9pbnQodG9wUmlnaHQueCwgdG9w UmlnaHQueSAtIGtDYWxlbmRhckNvcm5lclJhZGl1cykgY29udHJvbFBvaW50MTp0b3BSaWdodCBj b250cm9sUG9pbnQyOnRvcFJpZ2h0XTsKKyAgICBbcGF0aCBsaW5lVG9Qb2ludDpOU01ha2VQb2lu dChib3R0b21SaWdodC54LCBib3R0b21SaWdodC55ICsga0NhbGVuZGFyQ29ybmVyUmFkaXVzKV07 CisgICAgW3BhdGggY3VydmVUb1BvaW50Ok5TTWFrZVBvaW50KGJvdHRvbVJpZ2h0LnggLSBrQ2Fs ZW5kYXJDb3JuZXJSYWRpdXMsIGJvdHRvbVJpZ2h0LnkpIGNvbnRyb2xQb2ludDE6Ym90dG9tUmln aHQgY29udHJvbFBvaW50Mjpib3R0b21SaWdodF07CisgICAgW3BhdGggbGluZVRvUG9pbnQ6TlNN YWtlUG9pbnQoYm90dG9tTGVmdC54ICsga0NhbGVuZGFyQ29ybmVyUmFkaXVzLCBib3R0b21MZWZ0 LnkpXTsKKyAgICBbcGF0aCBjdXJ2ZVRvUG9pbnQ6TlNNYWtlUG9pbnQoYm90dG9tTGVmdC54LCBi b3R0b21MZWZ0LnkgKyBrQ2FsZW5kYXJDb3JuZXJSYWRpdXMpIGNvbnRyb2xQb2ludDE6Ym90dG9t TGVmdCBjb250cm9sUG9pbnQyOmJvdHRvbUxlZnRdOworICAgIFtwYXRoIGxpbmVUb1BvaW50OnRv cExlZnRdOworCisgICAgW3BhdGggZmlsbF07CisKKyAgICBbTlNHcmFwaGljc0NvbnRleHQgcmVz dG9yZUdyYXBoaWNzU3RhdGVdOworfQorCitAZW5kCisKIEBpbXBsZW1lbnRhdGlvbiBXS0RhdGVU aW1lUGlja2VyIHsKICAgICBXZWFrUHRyPFdlYktpdDo6V2ViRGF0ZVRpbWVQaWNrZXJNYWM+IF9w aWNrZXI7CiAgICAgV2ViQ29yZTo6RGF0ZVRpbWVDaG9vc2VyUGFyYW1ldGVycyBfcGFyYW1zOwpA QCAtMTczLDEwICsyMDMsMTIgQEAgLSAoaWQpaW5pdFdpdGhQYXJhbXM6KFdlYkNvcmU6OkRhdGVU aW1lQ2hvb3NlclBhcmFtZXRlcnMmJilwYXJhbXMgaW5WaWV3OihOU1ZpZXcKICAgICAvLyB1c2Vk IHRvIHJldHVybiB0aGUgZGF0ZS4KICAgICBOU1RpbWVab25lICp0aW1lWm9uZSA9IFtOU1RpbWVa b25lIHRpbWVab25lV2l0aE5hbWU6a0RlZmF1bHRUaW1lWm9uZUlkZW50aWZpZXJdOwogCi0gICAg X2VuY2xvc2luZ1dpbmRvdyA9IGFkb3B0TlMoW1tXS0RhdGVUaW1lUGlja2VyV2luZG93IGFsbG9j XSBpbml0V2l0aENvbnRlbnRSZWN0Ok5TWmVyb1JlY3Qgc3R5bGVNYXNrOihOU1dpbmRvd1N0eWxl TWFza1RpdGxlZCB8IE5TV2luZG93U3R5bGVNYXNrRnVsbFNpemVDb250ZW50VmlldykgYmFja2lu ZzpOU0JhY2tpbmdTdG9yZUJ1ZmZlcmVkIGRlZmVyOk5PXSk7CisgICAgX2VuY2xvc2luZ1dpbmRv dyA9IGFkb3B0TlMoW1tXS0RhdGVUaW1lUGlja2VyV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRl bnRSZWN0Ok5TWmVyb1JlY3Qgc3R5bGVNYXNrOk5TV2luZG93U3R5bGVNYXNrQm9yZGVybGVzcyBi YWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dKTsKICAgICBbX2VuY2xvc2lu Z1dpbmRvdyBzZXRGcmFtZTp3aW5kb3dSZWN0IGRpc3BsYXk6WUVTXTsKIAogICAgIF9kYXRlUGlj a2VyID0gYWRvcHROUyhbW05TRGF0ZVBpY2tlciBhbGxvY10gaW5pdFdpdGhGcmFtZTpbX2VuY2xv c2luZ1dpbmRvdyBjb250ZW50Vmlld10uYm91bmRzXSk7CisgICAgW19kYXRlUGlja2VyIHNldEJl emVsZWQ6Tk9dOworICAgIFtfZGF0ZVBpY2tlciBzZXREcmF3c0JhY2tncm91bmQ6Tk9dOwogICAg IFtfZGF0ZVBpY2tlciBzZXREYXRlUGlja2VyU3R5bGU6TlNEYXRlUGlja2VyU3R5bGVDbG9ja0Fu ZENhbGVuZGFyXTsKICAgICBbX2RhdGVQaWNrZXIgc2V0RGF0ZVBpY2tlckVsZW1lbnRzOk5TRGF0 ZVBpY2tlckVsZW1lbnRGbGFnWWVhck1vbnRoRGF5XTsKICAgICBbX2RhdGVQaWNrZXIgc2V0VGlt ZVpvbmU6dGltZVpvbmVdOwo=