216501 2020-09-14 16:19:10 -0700 Segfault in WebCore::IDBKey::createBinary 2020-10-01 08:02:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216960 InRadar P2 Normal --- 1 msaboff msaboff aakash_jain alecflett beidson ews-watchlist jsbell saam tsavell webkit-bug-importer youennf ysuzuki oldest_to_newest 1688464 0 msaboff 2020-09-14 16:19:10 -0700 The script below crashes due to code IDBKey::createBinary(JSC::JSArrayBufferView&) not handling the case where we can't get a buffer view due to running out of memory. -- test.html -- <script> const a = []; a.length = 2**30 a.__proto__ = {}; Object.defineProperty(a, 0, { get: foo }); function foo() { new Uint8Array(a); } try { foo(); } catch {} try { while(1) { new ArrayBuffer(2**20); } } catch {} let u8 = new Uint8Array(); IDBKeyRange.only(u8); </script> Steps To Reproduce: DYLD_FRAMEWORK_PATH=<WEBKIT_PATH>/WebKitBuild/Debug <WEBKIT_PATH>/WebKitBuild/Debug/WebKitTestRunner test.html Results: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000020 Exception Note: EXC_CORPSE_NOTIFY Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00000004a14631fa WebCore::IDBKey::createBinary(JSC::JSArrayBufferView&) + 42 1 com.apple.WebCore 0x00000004a19abe62 WebCore::createIDBKeyFromValue(JSC::JSGlobalObject&, JSC::JSValue, WTF::Vector<JSC::JSArray*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&) + 2178 2 com.apple.WebCore 0x00000004a197ee62 WebCore::scriptValueToIDBKey(JSC::JSGlobalObject&, JSC::JSValue) + 34 3 com.apple.WebCore 0x00000004a147098a WebCore::IDBKeyRange::only(JSC::JSGlobalObject&, JSC::JSValue) + 122 4 com.apple.WebCore 0x00000004a097090f WebCore::jsIDBKeyRangeConstructorFunctionOnly(JSC::JSGlobalObject*, JSC::CallFrame*) + 287 5 ??? 0x0000251383201178 0 + 40765734523256 6 com.apple.JavaScriptCore 0x00000004a9a451b1 llint_entry + 120103 1688465 1 msaboff 2020-09-14 16:19:37 -0700 <rdar://problem/68498785> 1688887 2 408869 msaboff 2020-09-15 15:47:40 -0700 Created attachment 408869 Patch 1688962 3 408869 ysuzuki 2020-09-15 19:00:39 -0700 Comment on attachment 408869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408869&action=review > LayoutTests/storage/indexeddb/IDBKey-create-array-buffer-view-oom.html:44 > +shouldBeTrue("exceptionString == undefined || exceptionString === 'DataError: Provided data is inadequate.'"); If this happened, shouldn't we throw out-of-memory error instead of DataError? 1688965 4 msaboff 2020-09-15 19:16:47 -0700 (In reply to Yusuke Suzuki from comment #3) > Comment on attachment 408869 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408869&action=review > > > LayoutTests/storage/indexeddb/IDBKey-create-array-buffer-view-oom.html:44 > > +shouldBeTrue("exceptionString == undefined || exceptionString === 'DataError: Provided data is inadequate.'"); > > If this happened, shouldn't we throw out-of-memory error instead of > DataError? That error is existing when the key range source is invalid. This fix uses that existing error path. The test code catches and throws away two out-of-memory errors before getting to this point. We could specifically throw out-of-memory, but I suspect that would be a riskier fix. 1689023 5 408869 youennf 2020-09-16 00:10:11 -0700 Comment on attachment 408869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408869&action=review > Source/WebCore/Modules/indexeddb/IDBKey.cpp:56 > + return adoptRef(*new IDBKey()); Can we try returning nullptr here as a RefPtr<IDBKey>? If we are low on memory, it seems best to not allocate a new object. Might be a bigger change though. 1689151 6 408869 saam 2020-09-16 10:30:44 -0700 Comment on attachment 408869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408869&action=review >> Source/WebCore/Modules/indexeddb/IDBKey.cpp:56 >> + return adoptRef(*new IDBKey()); > > Can we try returning nullptr here as a RefPtr<IDBKey>? > If we are low on memory, it seems best to not allocate a new object. > Might be a bigger change though. I agree this seems cleaner, given this now can fail. It's nicer to document things using nullability. 1689290 7 msaboff 2020-09-16 18:09:39 -0700 (In reply to youenn fablet from comment #5) > Comment on attachment 408869 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408869&action=review > > > Source/WebCore/Modules/indexeddb/IDBKey.cpp:56 > > + return adoptRef(*new IDBKey()); > > Can we try returning nullptr here as a RefPtr<IDBKey>? > If we are low on memory, it seems best to not allocate a new object. > Might be a bigger change though. Are you suggesting we change Ref<IDBKey> createBinary(JSC::JSArrayBufferView&) to RefPtr<IDBKey> createBinary(JSC::JSArrayBufferView&) If so, it seems weird to have two different return types for the overloaded createBinary(...) methods. If not, there isn't a way to convert a RefPtr<IDBKey>(nullptr) into a Ref<IDBKey>. This code is only being called by createIDBKeyFromValue() (via createIDBKeyFromValue()) which return IDBKey::createInvalid() aka adoptRef(*new IDBKey()) for a key with the value of RefPtr<IDBKey>(nullptr). So we aren't avoiding the allocation, only delaying it. 1689343 8 408869 youennf 2020-09-16 23:21:48 -0700 Comment on attachment 408869 Patch > Are you suggesting we change > Ref<IDBKey> createBinary(JSC::JSArrayBufferView&) > to > RefPtr<IDBKey> createBinary(JSC::JSArrayBufferView&) > > If so, it seems weird to have two different return types for the overloaded createBinary(...) methods. We could introduce tryCreateBinary. Or at least return IDBKey::createInvalid() which seems a bit clearer. 1689461 9 msaboff 2020-09-17 08:51:59 -0700 (In reply to youenn fablet from comment #8) > Comment on attachment 408869 [details] > Patch > > > Are you suggesting we change > > Ref<IDBKey> createBinary(JSC::JSArrayBufferView&) > > to > > RefPtr<IDBKey> createBinary(JSC::JSArrayBufferView&) > > > > If so, it seems weird to have two different return types for the overloaded createBinary(...) methods. > > We could introduce tryCreateBinary. > Or at least return IDBKey::createInvalid() which seems a bit clearer. Let's go with IDBKey::createInvalid(). 1689480 10 409043 msaboff 2020-09-17 09:49:12 -0700 Created attachment 409043 Updated Patch 1689560 11 msaboff 2020-09-17 12:52:46 -0700 Committed r267205: <https://trac.webkit.org/changeset/267205> 1689975 12 tsavell 2020-09-18 15:35:33 -0700 It looks like the new test storage/indexeddb/IDBKey-create-array-buffer-view-oom.html added in https://trac.webkit.org/changeset/267205/webkit is a flaky timeout History: https://results.webkit.org/?suite=layout-tests&test=storage%2Findexeddb%2FIDBKey-create-array-buffer-view-oom.html 1693745 13 aakash_jain 2020-10-01 08:02:41 -0700 (In reply to Truitt Savell from comment #12) > It looks like the new test storage/indexeddb/IDBKey-create-array-buffer-view-oom.html added in https://trac.webkit.org/changeset/267205/webkit > is a flaky timeout This test has been very flaky and slowing down EWS. e.g.: https://ews-build.webkit.org/#/builders/24/builds/27172 https://ews-build.webkit.org/#/builders/10/builds/37806 https://ews-build.webkit.org/#/builders/10/builds/37803 https://ews-build.webkit.org/#/builders/24/builds/27145 https://ews-build.webkit.org/#/builders/24/builds/27122 https://ews-build.webkit.org/#/builders/10/builds/37769 https://ews-build.webkit.org/#/builders/24/builds/27100 https://ews-build.webkit.org/#/builders/24/builds/27086 https://ews-build.webkit.org/#/builders/10/builds/37699 https://ews-build.webkit.org/#/builders/24/builds/27069 https://ews-build.webkit.org/#/builders/24/builds/27053 https://ews-build.webkit.org/#/builders/10/builds/37671 https://ews-build.webkit.org/#/builders/24/builds/27018 https://ews-build.webkit.org/#/builders/10/builds/37644 408869 2020-09-15 15:47:40 -0700 2020-09-17 09:49:12 -0700 Patch 216501.patch text/plain 4675 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NzEwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA5LTE0ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFNlZ2ZhdWx0IGluIFdlYkNv cmU6OklEQktleTo6Y3JlYXRlQmluYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTY1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJZiB3ZSBjYW4ndCBnZXQgYSBjb3B5IG9mIHRoZSBKU0J1ZmZlclZp ZXcsIHJldHVybiBhbiBpbnZhbGlkIElEQktleS4KKyAgICAgICAgVGhpcyBjYW4gaGFwcGVuIGlm IHdlIGFyZSBsb3cgb24gbWVtb3J5LiAgVGhlIGV4aXN0aW5nIGNhbGxpbmcgY29kZSBhbHJlYWR5 CisgICAgICAgIGhhbmRsZXMgdGhlIGNhc2Ugd2hlcmUgd2UgbWlnaHQgcHJvZHVjZSBhbiBpbnZh bGlkIElEQktleS4KKworICAgICAgICBUZXN0OiBzdG9yYWdlL2luZGV4ZWRkYi9JREJLZXktY3Jl YXRlLWFycmF5LWJ1ZmZlci12aWV3LW9vbS5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4 ZWRkYi9JREJLZXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCS2V5OjpjcmVhdGVCaW5hcnkp OgorCiAyMDIwLTA5LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgU2NyaXB0UHJvY2Vzc29yTm9kZSBzaG91bGQgdGhyb3cgd2hlbiB0cnlpbmcgdG8gY2hhbmdl IGl0cyBjaGFubmVsIGNvdW50IG9yIGNoYW5uZWwgY291bnQgbW9kZQpJbmRleDogU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJLZXkuY3BwCShyZXZpc2lvbiAyNjcxMDcpCisr KyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJLZXkuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01Miw2ICs1Miw4IEBAIFJlZjxJREJLZXk+IElEQktleTo6Y3JlYXRlQmluYXJ5KEpT Qzo6SlMKIFJlZjxJREJLZXk+IElEQktleTo6Y3JlYXRlQmluYXJ5KEpTQzo6SlNBcnJheUJ1ZmZl clZpZXcmIGFycmF5QnVmZmVyVmlldykKIHsKICAgICBhdXRvIGJ1ZmZlclZpZXcgPSBhcnJheUJ1 ZmZlclZpZXcucG9zc2libHlTaGFyZWRJbXBsKCk7CisgICAgaWYgKCFidWZmZXJWaWV3KQorICAg ICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBJREJLZXkoKSk7CiAgICAgcmV0dXJuIGFkb3B0UmVm KCpuZXcgSURCS2V5KFRocmVhZFNhZmVEYXRhQnVmZmVyOjpjb3B5RGF0YShidWZmZXJWaWV3LT5k YXRhKCksIGJ1ZmZlclZpZXctPmJ5dGVMZW5ndGgoKSkpKTsKIH0KIApJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMjY3MTA3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMjAtMDktMTQgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CisKKyAgICAgICAgU2VnZmF1bHQgaW4gV2ViQ29yZTo6SURCS2V5OjpjcmVhdGVCaW5hcnkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjUwMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyB0ZXN0 LiAgU2luY2UgdGhpcyB0ZXN0IGlzIGxvb2tpbmcgZm9yIHRoZSBvdXQgb2YgbWVtb3J5IGNvbmRp dGlvbiwgdGhlIHRlc3QgaXMgd3JpdHRlbgorICAgICAgICB0byBhdm9pZCBmYWxzZSBmYWlsdXJl cyBpbiB0aGUgY2FzZSB3ZSBjYW4ndCBhY2hpZXZlIG91dCBvZiBtZW1vcnkuICBUaGF0IGlzIHdo ZW4gdGhlCisgICAgICAgIGV4cGVjdGVkIGV4Y2VwdGlvbiBpcyBub3QgdGhyb3duLgorCisgICAg ICAgICogc3RvcmFnZS9pbmRleGVkZGIvSURCS2V5LWNyZWF0ZS1hcnJheS1idWZmZXItdmlldy1v b20tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9JREJL ZXktY3JlYXRlLWFycmF5LWJ1ZmZlci12aWV3LW9vbS5odG1sOiBBZGRlZC4KKwogMjAyMC0wOS0x NSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFNjcmlwdFByb2Nl c3Nvck5vZGUgc2hvdWxkIHRocm93IHdoZW4gdHJ5aW5nIHRvIGNoYW5nZSBpdHMgY2hhbm5lbCBj b3VudCBvciBjaGFubmVsIGNvdW50IG1vZGUKSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL0lEQktleS1jcmVhdGUtYXJyYXktYnVmZmVyLXZpZXctb29tLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9JREJLZXktY3JlYXRl LWFycmF5LWJ1ZmZlci12aWV3LW9vbS1leHBlY3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5 b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvSURCS2V5LWNyZWF0ZS1hcnJheS1idWZmZXItdmll dy1vb20tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3Qg SW5kZXhlZERCIElEQktleVJhbmdlIHdoZW4gd2UgYXJlIE91dCBvZiBNZW1vcnkuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGV4Y2VwdGlvblN0cmluZyA9PSB1bmRlZmlu ZWQgfHwgZXhjZXB0aW9uU3RyaW5nID09PSAnRGF0YUVycm9yOiBQcm92aWRlZCBkYXRhIGlzIGlu YWRlcXVhdGUuJyBpcyB0cnVlCitQQVNTIElEQktleVJhbmdlLm9ubHkgZGlkbid0IGNyYXNoCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDog TGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvSURCS2V5LWNyZWF0ZS1hcnJheS1idWZmZXIt dmlldy1vb20uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRk Yi9JREJLZXktY3JlYXRlLWFycmF5LWJ1ZmZlci12aWV3LW9vbS5odG1sCShub25leGlzdGVudCkK KysrIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL0lEQktleS1jcmVhdGUtYXJyYXktYnVm ZmVyLXZpZXctb29tLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0OSBAQAorPCEtLSB3 ZWJraXQtdGVzdC1ydW5uZXIgWyB1c2VFcGhlbWVyYWxTZXNzaW9uPXRydWUgXSAtLT4KKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMv anMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+CitkZXNjcmlw dGlvbigiVGVzdCBJbmRleGVkREIgSURCS2V5UmFuZ2Ugd2hlbiB3ZSBhcmUgT3V0IG9mIE1lbW9y eS4iKTsKKworLy8gU2luY2Ugd2UgYXJlIGxvdyBvbiBtZW1vcnksIGl0IGlzIGRpZmZpY3VsdCB0 byB1c2UgdGhlIGV4Y2VwdGlvbiB0ZXN0IGhlbHBlcnMuCitsZXQgZXhjZXB0aW9uU3RyaW5nID0g dW5kZWZpbmVkOworCitjb25zdCBhID0gW107CithLmxlbmd0aCA9IDIqKjMwOworYS5fX3Byb3Rv X18gPSB7fTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0eShhLCAwLCB7IGdldDogZm9vIH0pOworZnVu Y3Rpb24gZm9vKCkgeworICAgIG5ldyBVaW50OEFycmF5KGEpOworfQorCit0cnkgeworICAgIGZv bygpOworfSBjYXRjaCB7IH0KKwordHJ5IHsKKyAgICB3aGlsZSgxKQorICAgICAgICBuZXcgQXJy YXlCdWZmZXIoMioqMjgpOworfSBjYXRjaCB7IH0KKworbGV0IHU4ID0gbmV3IFVpbnQ4QXJyYXko KTsKKwordHJ5IHsKKyAgICBJREJLZXlSYW5nZS5vbmx5KHU4KTsKK30gY2F0Y2goZSkgeworICAg IGV4Y2VwdGlvblN0cmluZyA9IGUudG9TdHJpbmcoKTsKK30KKworLy8gVHJ5IHRvIGZyZWUgdXAg c29tZSBtZW1vcnkgdG8gY2hlY2sgb3VyIGV4Y2VwdGlvbgordTggPSB1bmRlZmluZWQ7CitnYygp OworCisvLyBTaW5jZSB3ZSBjYW4ndCByZWxpYWJseSBwcm9kdWNlIGFuIG91dCBvZiBtZW1vcnkg ZXZlcnl0aW1lLCBubyBleGNlcHRpb24gaXMgYWxzbyBhIHBhc3MuCitzaG91bGRCZVRydWUoImV4 Y2VwdGlvblN0cmluZyA9PSB1bmRlZmluZWQgfHwgZXhjZXB0aW9uU3RyaW5nID09PSAnRGF0YUVy cm9yOiBQcm92aWRlZCBkYXRhIGlzIGluYWRlcXVhdGUuJyIpOworCit0ZXN0UGFzc2VkKCJJREJL ZXlSYW5nZS5vbmx5IGRpZG4ndCBjcmFzaCIpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg== 409043 2020-09-17 09:49:12 -0700 2020-09-17 10:04:57 -0700 Updated Patch 216501-2.patch text/plain 4601 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NzE5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA5LTE3ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFNlZ2ZhdWx0IGluIFdlYkNv cmU6OklEQktleTo6Y3JlYXRlQmluYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTY1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJZiB3ZSBjYW4ndCBnZXQgYSBjb3B5IG9mIHRoZSBKU0J1ZmZlclZp ZXcsIHJldHVybiBhbiBpbnZhbGlkIElEQktleS4KKyAgICAgICAgVGhpcyBjYW4gaGFwcGVuIGlm IHdlIGFyZSBsb3cgb24gbWVtb3J5LiAgVGhlIGV4aXN0aW5nIGNhbGxpbmcgY29kZSBhbHJlYWR5 CisgICAgICAgIGhhbmRsZXMgdGhlIGNhc2Ugd2hlcmUgd2UgbWlnaHQgcHJvZHVjZSBhbiBpbnZh bGlkIElEQktleS4KKworICAgICAgICBUZXN0OiBzdG9yYWdlL2luZGV4ZWRkYi9JREJLZXktY3Jl YXRlLWFycmF5LWJ1ZmZlci12aWV3LW9vbS5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4 ZWRkYi9JREJLZXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCS2V5OjpjcmVhdGVCaW5hcnkp OgorCiAyMDIwLTA5LTE3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBTdHlsZTo6Q2hhbmdlIHNob3VsZCBiZSBlbnVtIGNsYXNzCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJLZXkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleS5jcHAJKHJldmlzaW9uIDI2NzE5MikKKysr IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTUyLDYgKzUyLDggQEAgUmVmPElEQktleT4gSURCS2V5OjpjcmVhdGVCaW5hcnkoSlND OjpKUwogUmVmPElEQktleT4gSURCS2V5OjpjcmVhdGVCaW5hcnkoSlNDOjpKU0FycmF5QnVmZmVy VmlldyYgYXJyYXlCdWZmZXJWaWV3KQogewogICAgIGF1dG8gYnVmZmVyVmlldyA9IGFycmF5QnVm ZmVyVmlldy5wb3NzaWJseVNoYXJlZEltcGwoKTsKKyAgICBpZiAoIWJ1ZmZlclZpZXcpCisgICAg ICAgIHJldHVybiBjcmVhdGVJbnZhbGlkKCk7CiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgSURC S2V5KFRocmVhZFNhZmVEYXRhQnVmZmVyOjpjb3B5RGF0YShidWZmZXJWaWV3LT5kYXRhKCksIGJ1 ZmZlclZpZXctPmJ5dGVMZW5ndGgoKSkpKTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjY3MTky KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMjAtMDktMTcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAg ICAgICAgU2VnZmF1bHQgaW4gV2ViQ29yZTo6SURCS2V5OjpjcmVhdGVCaW5hcnkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjUwMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyB0ZXN0LiAgU2luY2Ug dGhpcyB0ZXN0IGlzIGxvb2tpbmcgZm9yIHRoZSBvdXQgb2YgbWVtb3J5IGNvbmRpdGlvbiwgdGhl IHRlc3QgaXMgd3JpdHRlbgorICAgICAgICB0byBhdm9pZCBmYWxzZSBmYWlsdXJlcyBpbiB0aGUg Y2FzZSB3ZSBjYW4ndCBhY2hpZXZlIG91dCBvZiBtZW1vcnkuICBUaGF0IGlzIHdoZW4gdGhlCisg ICAgICAgIGV4cGVjdGVkIGV4Y2VwdGlvbiBpcyBub3QgdGhyb3duLgorCisgICAgICAgICogc3Rv cmFnZS9pbmRleGVkZGIvSURCS2V5LWNyZWF0ZS1hcnJheS1idWZmZXItdmlldy1vb20tZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9JREJLZXktY3JlYXRl LWFycmF5LWJ1ZmZlci12aWV3LW9vbS5odG1sOiBBZGRlZC4KKwogMjAyMC0wOS0xNyAgRGllZ28g UGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHTElCXSBVbnJldmll d3dlZCB0ZXN0IGdhcmRlbmluZy4gVXBkYXRlIGJhc2VsaW5lcyBhZnRlciBXUFQgdXBkYXRlIGlu IHIyNjcxNjcuCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9JREJLZXktY3Jl YXRlLWFycmF5LWJ1ZmZlci12aWV3LW9vbS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvSURCS2V5LWNyZWF0ZS1hcnJheS1idWZmZXItdmll dy1vb20tZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL0lEQktleS1jcmVhdGUtYXJyYXktYnVmZmVyLXZpZXctb29tLWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDExIEBACitUZXN0IEluZGV4ZWREQiBJREJLZXlS YW5nZSB3aGVuIHdlIGFyZSBPdXQgb2YgTWVtb3J5LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworUEFTUyBleGNlcHRpb25TdHJpbmcgPT0gdW5kZWZpbmVkIHx8IGV4Y2VwdGlvblN0 cmluZyA9PT0gJ0RhdGFFcnJvcjogUHJvdmlkZWQgZGF0YSBpcyBpbmFkZXF1YXRlLicgaXMgdHJ1 ZQorUEFTUyBJREJLZXlSYW5nZS5vbmx5IGRpZG4ndCBjcmFzaAorUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL0lEQktleS1jcmVhdGUtYXJyYXktYnVmZmVyLXZpZXctb29tLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvSURCS2V5LWNyZWF0ZS1h cnJheS1idWZmZXItdmlldy1vb20uaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9JREJLZXktY3JlYXRlLWFycmF5LWJ1ZmZlci12aWV3LW9vbS5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDkgQEAKKzwhLS0gd2Via2l0LXRlc3QtcnVubmVy IFsgdXNlRXBoZW1lcmFsU2Vzc2lvbj10cnVlIF0gLS0+Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3QgSW5kZXhl ZERCIElEQktleVJhbmdlIHdoZW4gd2UgYXJlIE91dCBvZiBNZW1vcnkuIik7CisKKy8vIFNpbmNl IHdlIGFyZSBsb3cgb24gbWVtb3J5LCBpdCBpcyBkaWZmaWN1bHQgdG8gdXNlIHRoZSBleGNlcHRp b24gdGVzdCBoZWxwZXJzLgorbGV0IGV4Y2VwdGlvblN0cmluZyA9IHVuZGVmaW5lZDsKKworY29u c3QgYSA9IFtdOworYS5sZW5ndGggPSAyKiozMDsKK2EuX19wcm90b19fID0ge307CitPYmplY3Qu ZGVmaW5lUHJvcGVydHkoYSwgMCwgeyBnZXQ6IGZvbyB9KTsKK2Z1bmN0aW9uIGZvbygpIHsKKyAg ICBuZXcgVWludDhBcnJheShhKTsKK30KKwordHJ5IHsKKyAgICBmb28oKTsKK30gY2F0Y2ggeyB9 CisKK3RyeSB7CisgICAgd2hpbGUoMSkKKyAgICAgICAgbmV3IEFycmF5QnVmZmVyKDIqKjIwKTsK K30gY2F0Y2ggeyB9CisKK2xldCB1OCA9IG5ldyBVaW50OEFycmF5KCk7CisKK3RyeSB7CisgICAg SURCS2V5UmFuZ2Uub25seSh1OCk7Cit9IGNhdGNoKGUpIHsKKyAgICBleGNlcHRpb25TdHJpbmcg PSBlLnRvU3RyaW5nKCk7Cit9CisKKy8vIFRyeSB0byBmcmVlIHVwIHNvbWUgbWVtb3J5IHRvIGNo ZWNrIG91ciBleGNlcHRpb24KK3U4ID0gdW5kZWZpbmVkOworZ2MoKTsKKworLy8gU2luY2Ugd2Ug Y2FuJ3QgcmVsaWFibHkgcHJvZHVjZSBhbiBvdXQgb2YgbWVtb3J5IGV2ZXJ5dGltZSwgbm8gZXhj ZXB0aW9uIGlzIGFsc28gYSBwYXNzLgorc2hvdWxkQmVUcnVlKCJleGNlcHRpb25TdHJpbmcgPT0g dW5kZWZpbmVkIHx8IGV4Y2VwdGlvblN0cmluZyA9PT0gJ0RhdGFFcnJvcjogUHJvdmlkZWQgZGF0 YSBpcyBpbmFkZXF1YXRlLiciKTsKKwordGVzdFBhc3NlZCgiSURCS2V5UmFuZ2Uub25seSBkaWRu J3QgY3Jhc2giKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=