216488 2020-09-14 12:07:23 -0700 Web Inspector: docking buttons don't work when already docked if window is too small 2020-09-14 12:54:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi ews-watchlist hi inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1688354 0 hi 2020-09-14 12:07:23 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. dock/attach Web Inspector 3. make the window small 4. press the other docking button # EXPECTED Docking/Attachment configuration changes # ACTUAL Nothing 😢 1688355 1 hi 2020-09-14 12:07:40 -0700 <rdar://problem/68242717> 1688360 2 408734 hi 2020-09-14 12:17:14 -0700 Created attachment 408734 Patch 1688381 3 ews-feeder 2020-09-14 12:54:25 -0700 Committed r267031: <https://trac.webkit.org/changeset/267031> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408734. 408734 2020-09-14 12:17:14 -0700 2020-09-14 12:54:27 -0700 Patch bug-216488-20200914121713.patch text/plain 4330 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4NTNkM2NmMzcwYmE2ZGM1NWYyZjgxMzAwZGYx MGQ0Nzk4NDA5OGEuLmM1MmRlMjdiOWM5MDk1YTc1ZGFlMTFmM2QyY2JlZDg5NzM3NjVkNWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTE0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBk b2NraW5nIGJ1dHRvbnMgZG9uJ3Qgd29yayB3aGVuIGFscmVhZHkgZG9ja2VkIGlmIHdpbmRvdyBp cyB0b28gc21hbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNjQ4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjgyNDI3MTc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jh c2UvTWFpbi5qczoKKyAgICAgICAgKFdJLnVwZGF0ZURvY2tpbmdBdmFpbGFiaWxpdHkpOgorICAg ICAgICAoV0kudXBkYXRlRG9ja2VkU3RhdGUpOgorICAgICAgICAoV0kuX3VwZGF0ZURvY2tOYXZp Z2F0aW9uSXRlbXMpOgorICAgICAgICBBbHdheXMgYmUgc3VyZSB0byB1cGRhdGUgdGhlIGRvY2tp bmcgbmF2aWdhdGlvbiBpdGVtcyB3aGVuIGRvY2tpbmcgYmVjb21lcyB1bmF2YWlsYWJsZQorICAg ICAgICBpbnN0ZWFkIG9mIGp1c3QgZm9yY2luZyBXZWIgSW5zcGVjdG9yIHRvIHVuZG9jayBhcyBp ZiBXZWIgSW5zcGVjdG9yIGlzIGFscmVhZHkgdW5kb2NrZWQKKyAgICAgICAgdGhlbiBub25lIG9m IHRoZSBkb2NraW5nIG5hdmlnYXRpb24gaXRlbXMgd2lsbCBiZSB1cGRhdGVkLiBUaGlzIG1ha2Vz IGl0IHNvIHRoYXQgdGhlCisgICAgICAgIGRvY2tpbmcgbmF2aWdhdGlvbiBpdGVtcyBhcmUgaGlk ZGVuIHdoZW4gZG9ja2luZyBiZWNvbWVzIHVuYXZhaWxhYmxlIHdoaWxlIHVuZG9ja2VkLgorCiAy MDIwLTA5LTEwICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBtb2Rlcm5pemUgZ2VuZXJhdGVkIGJhY2tlbmQgcHJvdG9jb2wgY29kZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZwppbmRleCAxNGM4ZTMzYTIxZmVkZDlmMzliMDkyYjQ4ODgyOThmNGY1NDQ5NjA2Li42YTQy NTc1MGI3ZTkyNDFkYjVjMzg1OTI0NjRjNTg1OTc4YmQ4MWNkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDIwLTA5LTE0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBkb2NraW5nIGJ1dHRvbnMgZG9uJ3Qgd29yayB3aGVuIGFs cmVhZHkgZG9ja2VkIGlmIHdpbmRvdyBpcyB0b28gc21hbGwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjQ4OAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjgyNDI3MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclByb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OmF0dGFjaCk6CisgICAgICAgIChXZWJLaXQ6 OldlYkluc3BlY3RvclByb3h5OjphdHRhY2hBdmFpbGFiaWxpdHlDaGFuZ2VkKToKKyAgICAgICAg SWYgV2ViIEluc3BlY3RvciBpcyBhbHJlYWR5IGF0dGFjaGVkLCBpdCBjYW4gcmUtYXR0YWNoIHdp dGggYSBkaWZmZXJlbnQgY29uZmlndXJhdGlvbi4KKwogMjAyMC0wOS0xMSAgQWxleCBDaHJpc3Rl bnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgX3NldENvb2tp ZUFjY2VwdFBvbGljeSB0byBXS0hUVFBDb29raWVTdG9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDVlMjQ5ZTMxNDc5NWY3MTRh NGFjNDYzYzJmNjMzYjY2YmRhZDczMDEuLjI0NzUxMjExM2VjOGM3ODQ1MzMxOWQ4ZWFiNTBiNWY0 NGE0MDc4N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKQEAgLTgyOCwxMiArODI4LDEwIEBAIFdJLnVwZGF0ZURvY2tpbmdBdmFpbGFi aWxpdHkgPSBmdW5jdGlvbihhdmFpbGFibGUpCiB7CiAgICAgV0kuX2RvY2tpbmdBdmFpbGFibGUg PSBhdmFpbGFibGU7CiAKLSAgICBpZiAoIVdJLl9kb2NraW5nQXZhaWxhYmxlKSB7Ci0gICAgICAg IFdJLnVwZGF0ZURvY2tlZFN0YXRlKFdJLkRvY2tDb25maWd1cmF0aW9uLlVuZG9ja2VkKTsKLSAg ICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIFdJLl91cGRhdGVEb2NrTmF2aWdhdGlvbkl0ZW1z KCk7CisKKyAgICBpZiAoIVdJLl9kb2NraW5nQXZhaWxhYmxlKQorICAgICAgICBXSS51cGRhdGVE b2NrZWRTdGF0ZShXSS5Eb2NrQ29uZmlndXJhdGlvbi5VbmRvY2tlZCk7CiB9OwogCiBXSS51cGRh dGVEb2NrZWRTdGF0ZSA9IGZ1bmN0aW9uKHNpZGUpCkBAIC04NzUsOCArODczLDYgQEAgV0kudXBk YXRlRG9ja2VkU3RhdGUgPSBmdW5jdGlvbihzaWRlKQogCiAgICAgV0kuX3VwZGF0ZURvY2tOYXZp Z2F0aW9uSXRlbXMoKTsKIAotICAgIFdJLnRhYkJhci5yZXNldENhY2hlZFdpZHRocygpOwotCiAg ICAgaWYgKCFXSS5kb2NrZWRDb25maWd1cmF0aW9uU3VwcG9ydHNTcGxpdENvbnRlbnRCcm93c2Vy KCkgJiYgIVdJLmRvZXNDdXJyZW50VGFiU3VwcG9ydFNwbGl0Q29udGVudEJyb3dzZXIoKSkKICAg ICAgICAgV0kuaGlkZVNwbGl0Q29uc29sZSgpOwogCkBAIC0xOTAxLDYgKzE4OTcsOCBAQCBXSS5f dXBkYXRlRG9ja05hdmlnYXRpb25JdGVtcyA9IGZ1bmN0aW9uKCkKICAgICB9CiAKICAgICBXSS5f dXBkYXRlVGFiQmFyRGl2aWRlcnMoKTsKKworICAgIFdJLnRhYkJhci5yZXNldENhY2hlZFdpZHRo cygpOwogfTsKIAogV0kuX3RhYkJyb3dzZXJTaXplRGlkQ2hhbmdlID0gZnVuY3Rpb24oKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclBy b3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JQ cm94eS5jcHAKaW5kZXggNzkyMWZiMTM2NzAxYjhhNWZmMWY1OTcwNTZlNjAwOTM1MTFlZTJmZC4u N2IyYzZhMmU0NDg0MzAyMDhjNDU4ZGIxNGVjNGZhYWMyYjVlYmIxMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclByb3h5LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVjdG9yUHJveHkuY3Bw CkBAIC0yOTAsNyArMjkwLDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6YXR0YWNoTGVmdCgp CiB2b2lkIFdlYkluc3BlY3RvclByb3h5OjphdHRhY2goQXR0YWNobWVudFNpZGUgc2lkZSkKIHsK ICAgICBBU1NFUlQobV9pbnNwZWN0b3JQYWdlKTsKLSAgICBpZiAoIW1faW5zcGVjdGVkUGFnZSB8 fCAhbV9pbnNwZWN0b3JQYWdlIHx8ICFwbGF0Zm9ybUNhbkF0dGFjaChjYW5BdHRhY2goKSkpCisg ICAgaWYgKCFtX2luc3BlY3RlZFBhZ2UgfHwgIW1faW5zcGVjdG9yUGFnZSB8fCAoIW1faXNBdHRh Y2hlZCAmJiAhcGxhdGZvcm1DYW5BdHRhY2gobV9jYW5BdHRhY2gpKSkKICAgICAgICAgcmV0dXJu OwogCiAgICAgbV9pc0F0dGFjaGVkID0gdHJ1ZTsKQEAgLTU4OSw3ICs1ODksNyBAQCB2b2lkIFdl Ykluc3BlY3RvclByb3h5OjphdHRhY2hBdmFpbGFiaWxpdHlDaGFuZ2VkKGJvb2wgYXZhaWxhYmxl KQogewogICAgIGJvb2wgcHJldmlvdXNDYW5BdHRhY2ggPSBtX2NhbkF0dGFjaDsKIAotICAgIG1f Y2FuQXR0YWNoID0gcGxhdGZvcm1DYW5BdHRhY2goYXZhaWxhYmxlKTsKKyAgICBtX2NhbkF0dGFj aCA9IG1faXNBdHRhY2hlZCB8fCBwbGF0Zm9ybUNhbkF0dGFjaChhdmFpbGFibGUpOwogCiAgICAg aWYgKHByZXZpb3VzQ2FuQXR0YWNoID09IG1fY2FuQXR0YWNoKQogICAgICAgICByZXR1cm47Cg==