216486 2020-09-14 11:26:41 -0700 Web Inspector: REGRESSION(r266885): dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb 2021-02-17 08:53:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179847 https://bugs.webkit.org/show_bug.cgi?id=216675 InRadar P2 Normal --- 216302 1 hi hi bburg ebrahim ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller m13590491852 marcos mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1688329 0 hi 2020-09-14 11:26:41 -0700 ``` dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb Referenced from: /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector Expected in: ~/dev/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore in /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector ``` 1688334 1 408729 hi 2020-09-14 11:31:11 -0700 Created attachment 408729 Patch 1688336 2 408729 joepeck 2020-09-14 11:34:59 -0700 Comment on attachment 408729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408729&action=review rs=me > Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:201 > + sendResponse(requestId, result.releaseNonNull(), false); Should it send the `bool` passed into this function, even though it is "unused"? 1688337 3 408729 hi 2020-09-14 11:38:14 -0700 Comment on attachment 408729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408729&action=review >> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:201 >> + sendResponse(requestId, result.releaseNonNull(), false); > > Should it send the `bool` passed into this function, even though it is "unused"? IIRC this `bool` only exists to differentiate this `sendResponse` from the `sendResponse` in <https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/inspector/cocoa/DeprecatedInspectorValues.cpp#L195>. This also matches the behavior before r266885. 1688366 4 ews-feeder 2020-09-14 12:30:16 -0700 Committed r267028: <https://trac.webkit.org/changeset/267028> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408729. 1688367 5 webkit-bug-importer 2020-09-14 12:31:16 -0700 <rdar://problem/68871288> 1708983 6 marcos 2020-11-18 22:24:08 -0800 This seems to have regressed again... STR: 1. build-webkit --debug 2. run-safari --debug Expected: Safari to start up Actual: ``` Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/mcaceres/dev/WebKit/WebKitBuild/Debug. dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb Referenced from: /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector Expected in: /Users/mcaceres/dev/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore in /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector ``` 1729979 7 bburg 2021-02-16 15:29:19 -0800 Marcos, this is fallout from JavaScriptCore breaking ABI compatibility. For this to not be hit will require the changes in WebInspector.framework to be in your system library. This won't happen until you update Safari. The fix for this should be in Safari 14.1 beta, which is available via here: https://developer.apple.com/safari/download/ 1730103 8 marcos 2021-02-16 20:02:17 -0800 Thanks, BJ. Appreciate the update! I'll give the beta a go. 1730302 9 bburg 2021-02-17 08:53:56 -0800 *** Bug 221528 has been marked as a duplicate of this bug. *** 408729 2020-09-14 11:31:11 -0700 2020-09-14 12:30:17 -0700 Patch bug-216486-20200914113110.patch text/plain 3432 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRmZmViMDRhZjAxMWFkZDY4MGMxYjcwNDVkZDBj MzBlNjA4Y2M1ZDQuLmM2OGI2ODI1OTA4OGMwYzQ1NzBkNjY2YzE3NjhjNDdmYzI3MDgxYzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTE0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNjY4ODUpOiBkeWxkOiBTeW1ib2wgbm90IGZvdW5kOiBfX1pOOUluc3BlY3Rv cjE3QmFja2VuZERpc3BhdGNoZXIxMnNlbmRSZXNwb25zZUVsT04zV1RGNlJlZlB0cklOUzFfOEpT T05JbXBsNk9iamVjdEVOUzFfMTNEdW1iUHRyVHJhaXRzSVM0X0VFRUViCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY0ODYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JC YWNrZW5kRGlzcGF0Y2hlci5oOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5k RGlzcGF0Y2hlci5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6OkJhY2tlbmREaXNwYXRjaGVyOjpz ZW5kUmVzcG9uc2UpOgorICAgICAgICBBZGQgYmFjayBvdmVybG9hZHMgcmVtb3ZlZCBpbiByMjY2 ODg1IHNvIHRoYXQgdGhlIHN5bWJvbHMgZXhpc3QuCisKIDIwMjAtMDktMTAgIFl1c3VrZSBTdXp1 a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBjdXN0b21HZXR0ZXJTZXR0 ZXJGdW5jdGlvbkNhbGwgc2hvdWxkIGhhdmUgcHJvcGVyIGV4Y2VwdGlvbiBjaGVja2luZwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5k RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckJhY2tlbmREaXNwYXRjaGVyLmNwcAppbmRleCBmNzgzZGNjNGI0MDIwM2U1MjVhMzM3MTYzZjBi ZTNkYzJlNTBjYTY2Li4wYWJjMmNhYzIzYjU2NzlhOTc3MWE1Y2M2MTk1OTlmNmUwZjM3NDRmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luc3BlY3RvckJhY2tl bmREaXNwYXRjaGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmNwcApAQCAtMTg3LDYgKzE4NywyMCBAQCB2b2lkIEJh Y2tlbmREaXNwYXRjaGVyOjpkaXNwYXRjaChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiAgICAgfQog fQogCisvLyBGSVhNRTogcmVtb3ZlIHRoaXMgZnVuY3Rpb24gd2hlbiBsZWdhY3kgSW5zcGVjdG9y T2JqZWN0IHN5bWJvbHMgYXJlIG5vIGxvbmdlciBuZWVkZWQgPGh0dHA6Ly93ZWJraXQub3JnL2Iv MTc5ODQ3Pi4KK3ZvaWQgQmFja2VuZERpc3BhdGNoZXI6OnNlbmRSZXNwb25zZShsb25nIHJlcXVl c3RJZCwgUmVmUHRyPEpTT046Ok9iamVjdD4mJiByZXN1bHQpCit7CisgICAgQVNTRVJUKHJlc3Vs dCk7CisgICAgc2VuZFJlc3BvbnNlKHJlcXVlc3RJZCwgcmVzdWx0LnJlbGVhc2VOb25OdWxsKCks IGZhbHNlKTsKK30KKworLy8gRklYTUU6IHJlbW92ZSB0aGlzIGZ1bmN0aW9uIHdoZW4gbGVnYWN5 IEluc3BlY3Rvck9iamVjdCBzeW1ib2xzIGFyZSBubyBsb25nZXIgbmVlZGVkIDxodHRwOi8vd2Vi a2l0Lm9yZy9iLzE3OTg0Nz4uCit2b2lkIEJhY2tlbmREaXNwYXRjaGVyOjpzZW5kUmVzcG9uc2Uo bG9uZyByZXF1ZXN0SWQsIFJlZlB0cjxKU09OOjpPYmplY3Q+JiYgcmVzdWx0LCBib29sKQorewor ICAgIEFTU0VSVChyZXN1bHQpOworICAgIHNlbmRSZXNwb25zZShyZXF1ZXN0SWQsIHJlc3VsdC5y ZWxlYXNlTm9uTnVsbCgpLCBmYWxzZSk7Cit9CisKIC8vIEZJWE1FOiByZW1vdmUgdGhpcyBmdW5j dGlvbiB3aGVuIGxlZ2FjeSBJbnNwZWN0b3JPYmplY3Qgc3ltYm9scyBhcmUgbm8gbG9uZ2VyIG5l ZWRlZCA8aHR0cDovL3dlYmtpdC5vcmcvYi8xNzk4NDc+Lgogdm9pZCBCYWNrZW5kRGlzcGF0Y2hl cjo6c2VuZFJlc3BvbnNlKGxvbmcgcmVxdWVzdElkLCBSZWY8SlNPTjo6T2JqZWN0PiYmIHJlc3Vs dCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQmFja2VuZERpc3BhdGNoZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIuaAppbmRleCAwMmM5NmQ3MjYzOGMyMjJmMDMwZDE0 OTFjYzliOTI2MmIwOGJlY2JhLi44YTVlZmIzMTZlOWQwOTMzN2FkYTIzMjNkYzZmOTI2MDU2YTlj MmY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckJhY2tlbmREaXNwYXRjaGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5oCkBAIC04OSw4ICs4OSwxMCBAQCBwdWJsaWM6 CiAgICAgLy8gTm90ZSB0aGF0ICd1bnVzZWQnIGlzIGEgd29ya2Fyb3VuZCBzbyB0aGUgY29tcGls ZXIgY2FuIHBpY2sgdGhlIHJpZ2h0IHNlbmRSZXNwb25zZSBiYXNlZCBvbiBhcml0eS4KICAgICAv LyBXaGVuIDxodHRwOi8vd2Via2l0Lm9yZy9iLzE3OTg0Nz4gaXMgZml4ZWQgb3IgdGhpcyBjbGFz cyBpcyByZW5hbWVkIGZvciB0aGUgSlNPTjo6T2JqZWN0IGNhc2UsCiAgICAgLy8gdGhlbiB0aGlz IGFsdGVybmF0ZSBtZXRob2Qgd2l0aCBhIGR1bW15IHBhcmFtZXRlciBjYW4gYmUgcmVtb3ZlZCBp biBmYXZvciBvZiB0aGUgb25lIHdpdGhvdXQgaXQuCi0gICAgdm9pZCBzZW5kUmVzcG9uc2UobG9u ZyByZXF1ZXN0SWQsIFJlZjxKU09OOjpPYmplY3Q+JiYgcmVzdWx0LCBib29sIHVudXNlZCk7Cisg ICAgdm9pZCBzZW5kUmVzcG9uc2UobG9uZyByZXF1ZXN0SWQsIFJlZlB0cjxKU09OOjpPYmplY3Q+ JiYgcmVzdWx0KTsKKyAgICB2b2lkIHNlbmRSZXNwb25zZShsb25nIHJlcXVlc3RJZCwgUmVmUHRy PEpTT046Ok9iamVjdD4mJiByZXN1bHQsIGJvb2wgdW51c2VkKTsKICAgICB2b2lkIHNlbmRSZXNw b25zZShsb25nIHJlcXVlc3RJZCwgUmVmPEpTT046Ok9iamVjdD4mJiByZXN1bHQpOworICAgIHZv aWQgc2VuZFJlc3BvbnNlKGxvbmcgcmVxdWVzdElkLCBSZWY8SlNPTjo6T2JqZWN0PiYmIHJlc3Vs dCwgYm9vbCB1bnVzZWQpOwogICAgIHZvaWQgc2VuZFBlbmRpbmdFcnJvcnMoKTsKIAogICAgIHZv aWQgcmVwb3J0UHJvdG9jb2xFcnJvcihDb21tb25FcnJvckNvZGUsIGNvbnN0IFN0cmluZyYgZXJy b3JNZXNzYWdlKTsK