216485 2020-09-14 11:25:19 -0700 Remove bogus asserts in FTLLower that assume programs are compiled with sensible speculations 2020-09-14 13:06:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont jsc32 keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1688327 0 saam 2020-09-14 11:25:19 -0700 ... 1688339 1 saam 2020-09-14 11:40:03 -0700 <rdar://problem/68562804> 1688341 2 408731 saam 2020-09-14 11:45:27 -0700 Created attachment 408731 patch 1688348 3 408731 keith_miller 2020-09-14 11:52:11 -0700 Comment on attachment 408731 patch r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit loop but I guess we should solve that with a fuzzing flag to try to detect it. 1688378 4 saam 2020-09-14 12:51:55 -0700 (In reply to Keith Miller from comment #3) > Comment on attachment 408731 [details] > patch > > r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit > loop but I guess we should solve that with a fuzzing flag to try to detect > it. I agree about your fuzzier idea, but nothing about this patch has to do with OSR exit loops. Nothing here proves we would or wouldn’t have a loop 1688382 5 ews-feeder 2020-09-14 13:06:28 -0700 Committed r267032: <https://trac.webkit.org/changeset/267032> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408731. 408731 2020-09-14 11:45:27 -0700 2020-09-14 13:06:29 -0700 patch b-backup.diff text/plain 4867 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjcwMjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSBib2d1cyBhc3NlcnRzIGluIEZUTExvd2VyIHRoYXQgYXNz dW1lIHByb2dyYW1zIGFyZSBjb21waWxlZCB3aXRoIHNlbnNpYmxlIHNwZWN1bGF0aW9ucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NDg1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82ODU2MjgwND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9mdGwtc2hvdWxkLW5vdC1hc3N1bWUtc3Bl Y3VsYXRpb25zLWFyZS1zZW5zaWJsZS5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorCiAyMDIw LTA5LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0 IGFzc3VtZSBieXRlIGNvZGUgb3BlcmFuZHMgYXJlIHVpbnQzMiBKU1ZhbHVlcwpJbmRleDogSlNU ZXN0cy9zdHJlc3MvZnRsLXNob3VsZC1ub3QtYXNzdW1lLXNwZWN1bGF0aW9ucy1hcmUtc2Vuc2li bGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvZnRsLXNob3VsZC1ub3QtYXNzdW1l LXNwZWN1bGF0aW9ucy1hcmUtc2Vuc2libGUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9z dHJlc3MvZnRsLXNob3VsZC1ub3QtYXNzdW1lLXNwZWN1bGF0aW9ucy1hcmUtc2Vuc2libGUuanMJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxOCBAQAorbGV0IGEzID0ge3o6IDEwMDB9OworbGV0 IGExID0gW107CithMVswXSA9IDA7CisKK2Z1bmN0aW9uIGZvbyh4LCB5KSB7CisgICAgJ3VzZSBz dHJpY3QnOworICAgIGZvciAobGV0IGkgPSAwOyBpIDwgMjA7ICsraSkgeworICAgICAgICBmb3Ig KGxldCBqID0gMDsgaiA8IHguejsgKytqKSB7CisgICAgICAgICAgICBmb28oMCwgaSk7CisgICAg ICAgICAgICB5WzBdID0gdW5kZWZpbmVkOworICAgICAgICB9CisgICAgfQorfQorCitmb28oYTMs IFtdKTsKK2ZvciAobGV0IGkgPSAwOyBpIDwgMjsgKytpKSB7CisgICAgZm9vKGEzLCBhMSk7Cit9 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NzAxOCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwzOSBA QAorMjAyMC0wOS0xNCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAg ICBSZW1vdmUgYm9ndXMgYXNzZXJ0cyBpbiBGVExMb3dlciB0aGF0IGFzc3VtZSBwcm9ncmFtcyBh cmUgY29tcGlsZWQgd2l0aCBzZW5zaWJsZSBzcGVjdWxhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjQ4NQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNjg1NjI4MDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgaGFkIGFuIGFzc2VydCBpbnNpZGUgbG93Q2VsbCB0aGF0IGlmIGEgdmFsdWUg d2FzIG5vdCBwYXJ0IG9mIHRoZSBKU1ZhbHVlCisgICAgICAgIGhhc2htYXAgb2YgdmFsdWVzLCB0 aGVuIHRoZSB0eXBlIG11c3Qgbm90IGNvbmZvcm0gdG8gYmVpbmcgYSBjZWxsLiBIb3dldmVyLAor ICAgICAgICBjb25zaWRlciBhIHByb2dyYW0gbGlrZSB0aGlzOgorICAgICAgICAKKyAgICAgICAg YGBgCisgICAgICAgIHggPSBBcml0aEFkZChpMzIsIGkzMikgPC0tIHggaXMgYW4gaTMyIGhlcmUK KyAgICAgICAgaWYgKGIpIHsKKyAgICAgICAgICAgIENoZWNrKENlbGw6QHgpCisgICAgICAgICAg ICBBcnJheWlmeVRvU3RydWN0dXJlKEB4LCB0aGluZ3kpCisgICAgICAgIH0KKyAgICAgICAgPC0t IEhFUkUKKyAgICAgICAgYGBgCisgICAgICAgIAorICAgICAgICBAeCB3aWxsIGxpdmUgaW4gRlRM TG93ZXIncyBpMzIgaGFzaG1hcCwgYnV0IGJlY2F1c2Ugb2YgdGhlIEFJIHJ1bGUgZm9yCisgICAg ICAgIEFycmF5aWZ5VG9TdHJ1Y3R1cmUsIGl0IHdpbGwgYWxzbyBoYXZlIFNwZWNDZWxsIGluIGl0 cyB0eXBlLiBUaGlzIGlzIHRvdGFsbHkKKyAgICAgICAgdmFsaWQsIGFuZCBhc3NlcnRpbmcgdGhh dCB0aGlzIGlzbid0IHBvc3NpYmxlIGlzIHdyb25nLiAoT2J2aW91c2x5IHRoZSBhYm92ZQorICAg ICAgICBzcGVjdWxhdGlvbiBpcyBzdHVwaWQsIGFzIHdlIHdpbGwgYWx3YXlzIGV4aXQgYXQgdGhl IENoZWNrLCBidXQgaXQncyB2YWxpZCBJUi4pCisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNo IHJlbW92ZXMgdGhpcyBhc3NlcnRpb24gZnJvbSBsb3dDZWxsLCBhbmQgcmVtb3ZlcyBzaW1pbGFy IGFzc2VydGlvbnMKKyAgICAgICAgZnJvbSBvdGhlciBsb3cqIGZ1bmN0aW9ucy4KKworICAgICAg ICAqIGZ0bC9GVExMb3dlckRGR1RvQjMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93 ZXJERkdUb0IzOjpsb3dJbnQzMik6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1Rv QjM6Omxvd0ludDUyKToKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6bG93 Q2VsbCk6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6Omxvd0Jvb2xlYW4p OgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpsb3dEb3VibGUpOgorCiAy MDIwLTA5LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIERv bid0IGFzc3VtZSBieXRlIGNvZGUgb3BlcmFuZHMgYXJlIHVpbnQzMiBKU1ZhbHVlcwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAkocmV2aXNp b24gMjY3MDE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzAxNSw3ICsxNzAxNSw2IEBAIHByaXZhdGU6CiAgICAg ICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgICAgICB9CiAKLSAgICAgICAgREZHX0FTU0VSVCht X2dyYXBoLCBtX25vZGUsICEocHJvdmVuVHlwZShlZGdlKSAmIFNwZWNJbnQzMk9ubHkpLCBwcm92 ZW5UeXBlKGVkZ2UpKTsKICAgICAgICAgaWYgKG1heUhhdmVUeXBlQ2hlY2soZWRnZS51c2VLaW5k KCkpKQogICAgICAgICAgICAgdGVybWluYXRlKFVuY291bnRhYmxlKTsKICAgICAgICAgcmV0dXJu IG1fb3V0LmludDMyWmVybzsKQEAgLTE3MDUwLDcgKzE3MDQ5LDYgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKLSAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBt X25vZGUsICFwcm92ZW5UeXBlKGVkZ2UpLCBwcm92ZW5UeXBlKGVkZ2UpKTsKICAgICAgICAgaWYg KG1heUhhdmVUeXBlQ2hlY2soZWRnZS51c2VLaW5kKCkpKQogICAgICAgICAgICAgdGVybWluYXRl KFVuY291bnRhYmxlKTsKICAgICAgICAgcmV0dXJuIG1fb3V0LmludDY0WmVybzsKQEAgLTE3MTIy LDcgKzE3MTIwLDYgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIHJldHVybiB1bmNoZWNrZWRWYWx1 ZTsKICAgICAgICAgfQogICAgICAgICAKLSAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBtX25v ZGUsICEocHJvdmVuVHlwZShlZGdlKSAmIFNwZWNDZWxsQ2hlY2spLCBwcm92ZW5UeXBlKGVkZ2Up KTsKICAgICAgICAgaWYgKG1heUhhdmVUeXBlQ2hlY2soZWRnZS51c2VLaW5kKCkpKQogICAgICAg ICAgICAgdGVybWluYXRlKFVuY291bnRhYmxlKTsKICAgICAgICAgcmV0dXJuIG1fb3V0LmludFB0 clplcm87CkBAIC0xNzI4Myw3ICsxNzI4MCw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICByZXR1 cm4gcmVzdWx0OwogICAgICAgICB9CiAKLSAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBtX25v ZGUsICEocHJvdmVuVHlwZShlZGdlKSAmIFNwZWNCb29sZWFuKSwgcHJvdmVuVHlwZShlZGdlKSk7 CiAgICAgICAgIGlmIChtYXlIYXZlVHlwZUNoZWNrKGVkZ2UudXNlS2luZCgpKSkKICAgICAgICAg ICAgIHRlcm1pbmF0ZShVbmNvdW50YWJsZSk7CiAgICAgICAgIHJldHVybiBtX291dC5ib29sZWFu RmFsc2U7CkBAIC0xNzI5Niw3ICsxNzI5Miw2IEBAIHByaXZhdGU6CiAgICAgICAgIExvd2VyZWRO b2RlVmFsdWUgdmFsdWUgPSBtX2RvdWJsZVZhbHVlcy5nZXQoZWRnZS5ub2RlKCkpOwogICAgICAg ICBpZiAoaXNWYWxpZCh2YWx1ZSkpCiAgICAgICAgICAgICByZXR1cm4gdmFsdWUudmFsdWUoKTsK LSAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBtX25vZGUsICFwcm92ZW5UeXBlKGVkZ2UpLCBw cm92ZW5UeXBlKGVkZ2UpKTsKICAgICAgICAgaWYgKG1heUhhdmVUeXBlQ2hlY2soZWRnZS51c2VL aW5kKCkpKQogICAgICAgICAgICAgdGVybWluYXRlKFVuY291bnRhYmxlKTsKICAgICAgICAgcmV0 dXJuIG1fb3V0LmRvdWJsZVplcm87Cg==