216470 2020-09-13 20:10:48 -0700 [TestRunnerShared] Make UIScriptContext not directly call UIScriptController::create which are defined in DRT and WTR 2020-09-14 12:51:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii simon.fraser webkit-bug-importer oldest_to_newest 1688171 0 fujii 2020-09-13 20:10:48 -0700 [TestRunnerShared] Make UIScriptContext not directly call UIScriptController::create which are defined in DRT and WTR I'd like to make TestRunnerShared as a stand alone library which doesn't depend on DRT and WTR (Bug 216465). 1688173 1 408676 fujii 2020-09-13 20:15:11 -0700 Created attachment 408676 Patch 1688375 2 408676 fujii 2020-09-14 12:50:36 -0700 Comment on attachment 408676 Patch Clearing flags on attachment: 408676 Committed r267030: <https://trac.webkit.org/changeset/267030> 1688376 3 fujii 2020-09-14 12:50:39 -0700 All reviewed patches have been landed. Closing bug. 1688377 4 webkit-bug-importer 2020-09-14 12:51:14 -0700 <rdar://problem/68872753> 408676 2020-09-13 20:15:11 -0700 2020-09-14 12:50:36 -0700 Patch bug-216470-20200914121509.patch text/plain 6211 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MDA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjYyODhkZDA1Nzc5MmFlZDllMGVjYTY0ZWQwOGNhMzU0 YmM5OTE0OS4uZTQzYmM0OWI0OTExNDAyZTZkYTM4NDhkMTc3MzA5YzlhM2EyZWVkYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDIwLTA5LTEzICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtUZXN0UnVubmVyU2hhcmVkXSBNYWtlIFVJU2NyaXB0Q29udGV4dCBub3Qg ZGlyZWN0bHkgY2FsbCBVSVNjcmlwdENvbnRyb2xsZXI6OmNyZWF0ZSB3aGljaCBhcmUgZGVmaW5l ZCBpbiBEUlQgYW5kIFdUUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjE2NDcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVUlTY3JpcHRDb250ZXh0IGNvbnN0cnVjdG9yIGRpcmVjdGx5IGNhbGxlZAorICAg ICAgICBVSVNjcmlwdENvbnRyb2xsZXI6OmNyZWF0ZSB3aGljaCBhcmUgZGVmaW5lZCBpbiBEUlQg YW5kIFdUUi4gSSdkCisgICAgICAgIGxpa2UgdG8gbWFrZSBUZXN0UnVubmVyU2hhcmVkIGFzIGEg c3RhbmQgYWxvbmUgbGlicmFyeSB3aGljaAorICAgICAgICBkb2Vzbid0IGRlcGVuZCBvbiBEUlQg YW5kIFdUUiAoQnVnIDIxNjQ2NSkuIE1ha2UgVUlTY3JpcHRDb250ZXh0CisgICAgICAgIHRha2Ug YSBmYWN0b3J5IGZ1bmN0aW9uIHRvIGNyZWF0ZSBVSVNjcmlwdENvbnRyb2xsZXIuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmNwcDoKKyAgICAgICAgKFRlc3RSdW5uZXI6 OnJ1blVJU2NyaXB0KToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmg6Cisg ICAgICAgICogVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0 LmNwcDoKKyAgICAgICAgKFVJU2NyaXB0Q29udGV4dDo6VUlTY3JpcHRDb250ZXh0KToKKyAgICAg ICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRleHQuaDoK KyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRy b2xsZXJTaGFyZWQuY3BwOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENvbnRyb2xsZXI6OmNyZWF0 ZSk6IERlbGV0ZWQuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5j cHA6CisgICAgICAgIChXVFI6OlRlc3RJbnZvY2F0aW9uOjpydW5VSVNpZGVTY3JpcHQpOgorCiAy MDIwLTA5LTEzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAg IE1vdmUgYmxvY2stc3BhbW1lcnMgdG9vbCB0byBweXRob24gMwpkaWZmIC0tZ2l0IGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvVGVzdFJ1bm5lci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0 UnVubmVyLmNwcAppbmRleCA5NDUyZTRhMGM0YmJhODU3ODBiOWFhYjM2NjUwOGE1ZWJiODM1OWRi Li41ZTUzNWFmMWRlYWQ4NDJkMmVmNGY1Zjc2NjAyYzgzYTk1MGI3NjUyIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9UZXN0UnVubmVyLmNwcApAQCAtMjQ2Nyw3ICsyNDY3LDcgQEAgdm9pZCBUZXN0UnVubmVy OjpydW5VSVNjcmlwdChKU0NvbnRleHRSZWYgY29udGV4dCwgSlNTdHJpbmdSZWYgc2NyaXB0LCBK U1ZhbHVlUmUKICAgICBjYWNoZVRlc3RSdW5uZXJDYWxsYmFjayhjYWxsYmFja0lELCBjYWxsYmFj ayk7CiAKICAgICBpZiAoIW1fVUlTY3JpcHRDb250ZXh0KQotICAgICAgICBtX1VJU2NyaXB0Q29u dGV4dCA9IG1ha2VVbmlxdWVXaXRob3V0RmFzdE1hbGxvY0NoZWNrPFdUUjo6VUlTY3JpcHRDb250 ZXh0PigqdGhpcyk7CisgICAgICAgIG1fVUlTY3JpcHRDb250ZXh0ID0gbWFrZVVuaXF1ZVdpdGhv dXRGYXN0TWFsbG9jQ2hlY2s8V1RSOjpVSVNjcmlwdENvbnRleHQ+KCp0aGlzLCBXVFI6OlVJU2Ny aXB0Q29udHJvbGxlcjo6Y3JlYXRlKTsKIAogICAgIFN0cmluZyBzY3JpcHRTdHJpbmcocmVpbnRl cnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KEpTU3RyaW5nR2V0Q2hhcmFjdGVyc1B0cihzY3JpcHQp KSwgSlNTdHJpbmdHZXRMZW5ndGgoc2NyaXB0KSk7CiAgICAgbV9VSVNjcmlwdENvbnRleHQtPnJ1 blVJU2NyaXB0KHNjcmlwdFN0cmluZywgY2FsbGJhY2tJRCk7CmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVu bmVyLmgKaW5kZXggMTNkOTVkOGYxNGQ3M2RjZjk0ZGQzOGU2OTkwZmIxOWYzZDA4MGFlYi4uNjk2 MzI2N2NhZmNmY2RjOThhZTg3ZWJlM2VmODU2NGJjNWJmYWNkNyAxMDA2NDQKLS0tIGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvVGVzdFJ1bm5lci5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3RSdW5uZXIuaApAQCAtMjksNiArMjksNyBAQAogI3ByYWdtYSBvbmNlCiAKICNpbmNsdWRlICJV SVNjcmlwdENvbnRleHQuaCIKKyNpbmNsdWRlICJVSVNjcmlwdENvbnRyb2xsZXIuaCIKICNpbmNs dWRlIDxKYXZhU2NyaXB0Q29yZS9KU09iamVjdFJlZi5oPgogI2luY2x1ZGUgPG1hcD4KICNpbmNs dWRlIDxzZXQ+CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29u dGV4dC9VSVNjcmlwdENvbnRleHQuY3BwIGIvVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlw dENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmNwcAppbmRleCA5NzE5MWEwNTI1YWQxMzhmMTkwYzc0 NTc3YWMyOGQ0NzUxZDlhNTk2Li4yNzA1YjM5YTI0N2RkMjU3ZDVjNmQ1OGM0NzBlOTYzM2E5MTlk ZmQ0IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9V SVNjcmlwdENvbnRleHQuY3BwCisrKyBiL1Rvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRD b250ZXh0L1VJU2NyaXB0Q29udGV4dC5jcHAKQEAgLTM4LDExICszOCwxMSBAQCBzdGF0aWMgaW5s aW5lIGJvb2wgaXNQZXJzaXN0ZW50Q2FsbGJhY2tJRCh1bnNpZ25lZCBjYWxsYmFja0lEKQogICAg IHJldHVybiBjYWxsYmFja0lEIDwgZmlyc3ROb25QZXJzaXN0ZW50Q2FsbGJhY2tJRDsKIH0KIAot VUlTY3JpcHRDb250ZXh0OjpVSVNjcmlwdENvbnRleHQoVUlTY3JpcHRDb250ZXh0RGVsZWdhdGUm IGRlbGVnYXRlKQorVUlTY3JpcHRDb250ZXh0OjpVSVNjcmlwdENvbnRleHQoVUlTY3JpcHRDb250 ZXh0RGVsZWdhdGUmIGRlbGVnYXRlLCBVSVNjcmlwdENvbnRyb2xsZXJGYWN0b3J5IGZhY3Rvcnkp CiAgICAgOiBtX2NvbnRleHQoYWRvcHQoSlNHbG9iYWxDb250ZXh0Q3JlYXRlKG51bGxwdHIpKSkK ICAgICAsIG1fZGVsZWdhdGUoZGVsZWdhdGUpCiB7Ci0gICAgbV9jb250cm9sbGVyID0gVUlTY3Jp cHRDb250cm9sbGVyOjpjcmVhdGUoKnRoaXMpOworICAgIG1fY29udHJvbGxlciA9IGZhY3Rvcnko KnRoaXMpOwogCiAgICAgSlNPYmplY3RSZWYgZ2xvYmFsT2JqZWN0ID0gSlNDb250ZXh0R2V0R2xv YmFsT2JqZWN0KG1fY29udGV4dC5nZXQoKSk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSdW5u ZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5oIGIvVG9vbHMvVGVzdFJ1 bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmgKaW5kZXggZWQ5YTRj YjY1OTk0MDYxZWZhMDQ5ODg5MDZlMTAzNjE0NmVkYTIwYy4uZmJhMzJjOTM3YjI5ODMxZTAyNmY5 OTEzODYwYjJlMDcyMWUwZjI1NCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9V SVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmgKKysrIGIvVG9vbHMvVGVzdFJ1bm5lclNo YXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmgKQEAgLTMwLDcgKzMwLDcgQEAK IAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTUmV0YWluUHRyLmg+CiAjaW5jbHVkZSA8d3Rm L0hhc2hNYXAuaD4KLSNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CisjaW5jbHVkZSA8d3RmL1JlZi5o PgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CkBAIC03Miw3ICs3Miw5IEBAIGNsYXNzIFVJU2NyaXB0Q29udGV4dCB7CiAgICAgV1RGX01BS0Vf RkFTVF9BTExPQ0FURUQ7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoVUlTY3JpcHRDb250ZXh0 KTsKIHB1YmxpYzoKLSAgICBVSVNjcmlwdENvbnRleHQoVUlTY3JpcHRDb250ZXh0RGVsZWdhdGUm KTsKKyAgICB1c2luZyBVSVNjcmlwdENvbnRyb2xsZXJGYWN0b3J5ID0gUmVmPFVJU2NyaXB0Q29u dHJvbGxlcj4gKCopKFVJU2NyaXB0Q29udGV4dCYpOworCisgICAgVUlTY3JpcHRDb250ZXh0KFVJ U2NyaXB0Q29udGV4dERlbGVnYXRlJiwgVUlTY3JpcHRDb250cm9sbGVyRmFjdG9yeSk7CiAgICAg flVJU2NyaXB0Q29udGV4dCgpOwogCiAgICAgdm9pZCBydW5VSVNjcmlwdChjb25zdCBTdHJpbmcm IHNjcmlwdCwgdW5zaWduZWQgc2NyaXB0Q2FsbGJhY2tJRCk7CmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRyb2xsZXJTaGFyZWQu Y3BwIGIvVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250 cm9sbGVyU2hhcmVkLmNwcAppbmRleCA0MGM0YjZkMDJiNTYxNjAwYmUyY2ZmZjAyZDgzNjhlYWZj ZTk5YzcxLi5jNmViMTQwYWEzNTZjNjZkOGM0NTAyMTRlN2RiMmM4NWFkM2E3MWEzIDEwMDY0NAot LS0gYS9Ub29scy9UZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRy b2xsZXJTaGFyZWQuY3BwCisrKyBiL1Rvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250 ZXh0L1VJU2NyaXB0Q29udHJvbGxlclNoYXJlZC5jcHAKQEAgLTU4LDEzICs1OCw2IEBAIERldmlj ZU9yaWVudGF0aW9uKiB0b0RldmljZU9yaWVudGF0aW9uKEpTQ29udGV4dFJlZiBjb250ZXh0LCBK U1ZhbHVlUmVmIHZhbHVlKQogICAgIHJldHVybiBudWxscHRyOwogfQogCi0jaWYgIVBMQVRGT1JN KEdUSykgJiYgIVBMQVRGT1JNKENPQ09BKSAmJiAhUExBVEZPUk0oV0lOKSAmJiAhUExBVEZPUk0o V1BFKQotUmVmPFVJU2NyaXB0Q29udHJvbGxlcj4gVUlTY3JpcHRDb250cm9sbGVyOjpjcmVhdGUo VUlTY3JpcHRDb250ZXh0JiBjb250ZXh0KQotewotICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFVJ U2NyaXB0Q29udHJvbGxlcihjb250ZXh0KSk7Ci19Ci0jZW5kaWYKLQogVUlTY3JpcHRDb250cm9s bGVyOjpVSVNjcmlwdENvbnRyb2xsZXIoVUlTY3JpcHRDb250ZXh0JiBjb250ZXh0KQogICAgIDog bV9jb250ZXh0KCZjb250ZXh0KQogewpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9UZXN0SW52b2NhdGlvbi5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0 aW9uLmNwcAppbmRleCA5YWVhZjZlYTZlNTE2ODE4MDQ3ZmU4N2M1YWIwY2UyZTQxMzczZGIzLi5h NWI2ZGQwNTU4MGFlMGMyZDk1NzA3N2RmZTQ1MGE0ODZlNmQwMWVjIDEwMDY0NAotLS0gYS9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcApAQCAtMTg5NSw3ICsxODk1LDcgQEAgdm9pZCBU ZXN0SW52b2NhdGlvbjo6cnVuVUlTaWRlU2NyaXB0KFdLU3RyaW5nUmVmIHNjcmlwdCwgdW5zaWdu ZWQgc2NyaXB0Q2FsbGJhY2sKICAgICBtX3BlbmRpbmdVSVNjcmlwdEludm9jYXRpb25EYXRhID0g bnVsbHB0cjsKIAogICAgIGlmICghbV9VSVNjcmlwdENvbnRleHQpCi0gICAgICAgIG1fVUlTY3Jp cHRDb250ZXh0ID0gbWFrZVVuaXF1ZTxVSVNjcmlwdENvbnRleHQ+KCp0aGlzKTsKKyAgICAgICAg bV9VSVNjcmlwdENvbnRleHQgPSBtYWtlVW5pcXVlPFVJU2NyaXB0Q29udGV4dD4oKnRoaXMsIFVJ U2NyaXB0Q29udHJvbGxlcjo6Y3JlYXRlKTsKICAgICAKICAgICBtX1VJU2NyaXB0Q29udGV4dC0+ cnVuVUlTY3JpcHQodG9XVEZTdHJpbmcoc2NyaXB0KSwgc2NyaXB0Q2FsbGJhY2tJRCk7CiB9Cg==