216464 2020-09-13 12:36:08 -0700 Enable WebGL2 by default 2020-09-14 12:09:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino sam webkit-bug-importer oldest_to_newest 1688131 0 dino 2020-09-13 12:36:08 -0700 Enable WebGL2 by default 1688132 1 webkit-bug-importer 2020-09-13 12:38:10 -0700 <rdar://problem/68811378> 1688134 2 408662 dino 2020-09-13 12:43:13 -0700 Created attachment 408662 Patch 1688135 3 dino 2020-09-13 12:43:29 -0700 I think Sam or Anders should review this. 1688136 4 408662 sam 2020-09-13 12:45:09 -0700 Comment on attachment 408662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408662&action=review > Source/WebKit/Shared/WebPreferences.yaml:1461 > WebGL2Enabled: > type: bool > - defaultValue: false > + defaultValue: true > humanReadableName: "WebGL 2.0" > humanReadableDescription: "WebGL 2 prototype" > category: experimental Not that I actually understand the rules for experimental, but should this still be experimental if it is on by default? 1688317 5 408662 dino 2020-09-14 11:04:53 -0700 Comment on attachment 408662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408662&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1461 >> category: experimental > > Not that I actually understand the rules for experimental, but should this still be experimental if it is on by default? The original plan was that experimental features should be off by default, but people also wanted a way to toggle off features that were about to ship. Maybe we need yet another form of feature? "Candidate"? 1688356 6 dino 2020-09-14 12:09:21 -0700 Committed r267027: <https://trac.webkit.org/changeset/267027> 408662 2020-09-13 12:43:13 -0700 2020-09-13 12:45:09 -0700 Patch bug-216464-20200914054311.patch text/plain 5426 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2OTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhMjIxZDIxMjQ2ZDFh OWUzZTNjNWI1MzRiY2M3N2Y5NDY5ZjI1ZS4uZWM1YjQ1YjZmZDc5MzYwNmNmOWY0ODNkZWE5ZmVk ZmRmZDU4NzhlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTEzICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBFbmFibGUgV2ViR0wyIGJ5IGRl ZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NjQ2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjg4MTEzNzg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3VyIFdlYkdMMiBpbXBsZW1lbnRhdGlv biBpcyBpbiBnb29kIGVub3VnaCBzaGFwZSB0aGF0IHdlIHNob3VsZAorICAgICAgICBlbmFibGUg aXQgYnkgZGVmYXVsdCBmb3IgYnJvYWRlciB0ZXN0aW5nLgorCisgICAgICAgICogcGFnZS9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmg6CisKIDIwMjAtMDktMTIgIFNhbSBXZWluaWcgIDx3ZWluaWdA YXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJJRExdIFJlbW92ZSBuZWVkIGZvciBbTWF5VGhyb3dF eGNlcHRpb25dIG9uIG5hbWVkIGRlbGV0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE0YzhlMzNhMjFmZWRkOWYz OWIwOTJiNDg4ODI5OGY0ZjU0NDk2MDYuLjE4NzE5NTg3MmM0M2MxMjJkZmQxODgyNWJiNjg3MmI4 OTg1NDUyMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDktMTMgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBXZWJHTDIgYnkgZGVmYXVs dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NDY0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82ODgxMTM3OD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXIgV2ViR0wyIGltcGxlbWVudGF0aW9uIGlz IGluIGdvb2QgZW5vdWdoIHNoYXBlIHRoYXQgd2Ugc2hvdWxkCisgICAgICAgIGVuYWJsZSBpdCBi eSBkZWZhdWx0IGZvciBicm9hZGVyIHRlc3RpbmcuCisKKyAgICAgICAgUmVtb3ZlICJkZWZhdWx0 V2ViR0wyRW5hYmxlZCIgc2luY2UgaXQgd2Fzbid0IGJlaW5nIHVzZWQgYW55d2hlcmUuCisKKyAg ICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKyAgICAgICAgKiBTaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6ZGVmYXVsdFdl YkdMMkVuYWJsZWQpOiBEZWxldGVkLgorICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0Rl ZmF1bHRWYWx1ZXMuaDoKKwogMjAyMC0wOS0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgX3NldENvb2tpZUFjY2VwdFBvbGljeSB0 byBXS0hUVFBDb29raWVTdG9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCmluZGV4IGU2YWIw OTlkNTg1N2JmMzZjNTBiMGE5Nzc1ZGZmZDdhMTU3NDhkYTEuLmQxOTA4MWJlMTI4NjBjN2YwODAz MGI5MWVlZjE1ZTlmOWMwMjUxOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFj L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wOS0xMyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgRW5hYmxlIFdlYkdMMiBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY0NjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzY4ODExMzc4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE91ciBXZWJHTDIgaW1wbGVtZW50YXRpb24gaXMgaW4gZ29vZCBlbm91Z2ggc2hhcGUgdGhh dCB3ZSBzaG91bGQKKyAgICAgICAgZW5hYmxlIGl0IGJ5IGRlZmF1bHQgZm9yIGJyb2FkZXIgdGVz dGluZy4KKworICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW06CisgICAgICAgICgr W1dlYlByZWZlcmVuY2VzIGluaXRpYWxpemVdKToKKwogMjAyMC0wOS0xMCAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjY2 ODQyIGFuZCByMjY2ODgzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1l RW5hYmxlZEZlYXR1cmVzLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1bnRpbWVFbmFibGVkRmVh dHVyZXMuaAppbmRleCA4ZDYxMjcwNmUzNGQ3OGY2OGQ4ZmE1OGRlODRlZWIzNmZlMDQ4MjBjLi4x ZWNjNGY2ZDJkY2QxYmI3NmU3ODgwMGNkMzk0YzRhMTI4MTJlZWM0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaApAQCAtMzg2LDcgKzM4Niw3IEBAIHBy aXZhdGU6CiAgICAgYm9vbCBtX2lzVHJhbnNmb3JtU3RyZWFtQVBJRW5hYmxlZCB7IGZhbHNlIH07 CiAKICNpZiBFTkFCTEUoV0VCR0wyKQotICAgIGJvb2wgbV9pc1dlYkdMMkVuYWJsZWQgeyBmYWxz ZSB9OworICAgIGJvb2wgbV9pc1dlYkdMMkVuYWJsZWQgeyB0cnVlIH07CiAjZW5kaWYKIAogI2lm IEVOQUJMRShXRUJHUFUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVm ZXJlbmNlcy55YW1sIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApp bmRleCA3MTJiYjQyOTQzN2ExNWQ4MTExN2FkOTM1M2JjODI4MGZiYzU2Y2VjLi4wZjI3MDdkZjk3 Zjg1N2UzMWIxYWIyZGQyYWMzMGE3M2JlNGU5NzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dl YlByZWZlcmVuY2VzLnlhbWwKQEAgLTE0NTUsNyArMTQ1NSw3IEBAIFdlYkFuaW1hdGlvbnNNdXRh YmxlVGltZWxpbmVzRW5hYmxlZDoKIAogV2ViR0wyRW5hYmxlZDoKICAgdHlwZTogYm9vbAotICBk ZWZhdWx0VmFsdWU6IGZhbHNlCisgIGRlZmF1bHRWYWx1ZTogdHJ1ZQogICBodW1hblJlYWRhYmxl TmFtZTogIldlYkdMIDIuMCIKICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiV2ViR0wgMiBw cm90b3R5cGUiCiAgIGNhdGVnb3J5OiBleHBlcmltZW50YWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuY3BwCmluZGV4IDI3ZjQ5MDA3 ZjBiOWQzYTBhNjdlMWFkMGRlMTVhY2IzNTQ3NjRhMTkuLjIwMGZiOGU2ZmQ1ZTc2MDI3YTE3YTJk MjIwOWU3MTJiNzM3MmY2ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmNwcApAQCAtMTg0LDE5ICsxODQsNiBAQCBib29sIGRl ZmF1bHRXZWJSVENDb2RlY3NJbkdQVVByb2Nlc3MoKQogCiAjZW5kaWYgLy8gRU5BQkxFKFdFQl9S VEMpCiAKLSNpZiBFTkFCTEUoV0VCR0wyKQotCi1ib29sIGRlZmF1bHRXZWJHTDJFbmFibGVkKCkK LXsKLSNpZiBIQVZFKFNZU1RFTV9GRUFUVVJFX0ZMQUdTKQotICAgIHJldHVybiBpc0ZlYXR1cmVG bGFnRW5hYmxlZCgiV2ViR0wyIik7Ci0jZW5kaWYKLQotICAgIHJldHVybiBmYWxzZTsKLX0KLQot I2VuZGlmIC8vIEVOQUJMRShXRUJHTDIpCi0KICNpZiBFTkFCTEUoV0VCR1BVKQogCiBib29sIGRl ZmF1bHRXZWJHUFVFbmFibGVkKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dl YlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl ZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgKaW5kZXggYzhmNThhZWE3MDhkZjhiZTNhYTBiMmU3ZTg3 MDUyNDJiNDJkZWJkZC4uYjA3NzY1MzdkMmViYjEyZjM4M2MxZDgwZWQ0ODY0YjI2ODI2MzE4NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFs dWVzLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFs dWVzLmgKQEAgLTM1MCwxMCArMzUwLDYgQEAgYm9vbCBkZWZhdWx0Q2FwdHVyZVZpZGVvSW5HUFVQ cm9jZXNzRW5hYmxlZCgpOwogYm9vbCBkZWZhdWx0V2ViUlRDQ29kZWNzSW5HUFVQcm9jZXNzKCk7 CiAjZW5kaWYKIAotI2lmIEVOQUJMRShXRUJHTDIpCi1ib29sIGRlZmF1bHRXZWJHTDJFbmFibGVk KCk7Ci0jZW5kaWYKLQogI2lmIEVOQUJMRShXRUJHUFUpCiBib29sIGRlZmF1bHRXZWJHUFVFbmFi bGVkKCk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZp ZXcvV2ViUHJlZmVyZW5jZXMubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dl YlByZWZlcmVuY2VzLm1tCmluZGV4IGQ4MTNjMmRlM2QzZmViNjA4Nzg1NThjNDY1ZWFiZGIwMDI3 NzBlMGQuLmVhMDc0MmNmYTdiYmVmNDRkNWQxNjVhZDM4MzliMDUwYTRkMjRkOWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0KKysr IGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQpAQCAt NjQyLDcgKzY0Miw3IEBAIHB1YmxpYzoKICAgICAgICAgQFlFUywgV2ViS2l0TGF5b3V0Rm9ybWF0 dGluZ0NvbnRleHRJbnRlZ3JhdGlvbkVuYWJsZWRQcmVmZXJlbmNlS2V5LAogCiAjaWYgRU5BQkxF KFdFQkdMMikKLSAgICAgICAgQE5PLCBXZWJLaXRXZWJHTDJFbmFibGVkUHJlZmVyZW5jZUtleSwK KyAgICAgICAgQFlFUywgV2ViS2l0V2ViR0wyRW5hYmxlZFByZWZlcmVuY2VLZXksCiAjZW5kaWYK ICNpZiBFTkFCTEUoV0VCR1BVKQogICAgICAgICBATk8sIFdlYktpdFdlYkdQVUVuYWJsZWRQcmVm ZXJlbmNlS2V5LAo=