216455 2020-09-13 00:27:44 -0700 [GTK][WPE] Build fails when -DENABLE_SERVICE_WORKER=OFF 2020-09-13 01:14:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra berto cgarcia ews-watchlist gustavo webkit-bug-importer oldest_to_newest 1688071 0 psaavedra 2020-09-13 00:27:44 -0700 SSIA 1688072 1 408644 psaavedra 2020-09-13 00:30:35 -0700 Created attachment 408644 patch 1688073 2 ews-watchlist 2020-09-13 00:31:41 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1688074 3 ews-feeder 2020-09-13 01:13:18 -0700 Committed r266990: <https://trac.webkit.org/changeset/266990> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408644. 1688075 4 webkit-bug-importer 2020-09-13 01:14:17 -0700 <rdar://problem/68792772> 408644 2020-09-13 00:30:35 -0700 2020-09-13 01:13:18 -0700 patch bug-216455-20200913092841.patch text/plain 4742 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE0YzhlMzNhMjFmZWRkOWYz OWIwOTJiNDg4ODI5OGY0ZjU0NDk2MDYuLmQ3ZWVhZWU5Zjc5NjE5YjJhNjExYzRhYjA5YmU2MGI5 Zjc3ZjVmZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDktMTMgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBCdWls ZCBmYWlscyB3aGVuIC1ERU5BQkxFX1NFUlZJQ0VfV09SS0VSPU9GRgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NDU1CisKKyAgICAgICAgVW5yZXZp ZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2Vi c2l0ZURhdGEuY3BwOgorICAgICAgICAocmVjb3JkQ29udGFpbnNTdXBwb3J0ZWREYXRhVHlwZXMp OgorICAgICAgICAodG9XZWJLaXRXZWJzaXRlRGF0YVR5cGVzKToKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2dsaWIvV2ViS2l0V2Vic2l0ZURhdGFNYW5hZ2VyLmNwcDoKKyAgICAgICAgKHRvV2Vi c2l0ZURhdGFUeXBlcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0 cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxl TG9hZCk6CisKIDIwMjAtMDktMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIF9zZXRDb29raWVBY2NlcHRQb2xpY3kgdG8gV0tIVFRQ Q29va2llU3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFdlYnNpdGVEYXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFdlYnNpdGVEYXRhLmNwcAppbmRleCAyZjdlNDRmZTY0MDA0MWE3MjA0MzUyYmJiYzY4 NmIxOWYzY2ZjMDYxLi5kZjA5MzA1YjZjYmM5NTVhMDc5OWFhN2JhYzcyMWY1YWQzOThhMGMyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJzaXRl RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2Vi c2l0ZURhdGEuY3BwCkBAIC03Nyw3ICs3Nyw5IEBAIHN0YXRpYyBib29sIHJlY29yZENvbnRhaW5z U3VwcG9ydGVkRGF0YVR5cGVzKGNvbnN0IFdlYnNpdGVEYXRhUmVjb3JkJiByZWNvcmQpCiAgICAg ICAgIFdlYnNpdGVEYXRhVHlwZTo6Q29va2llcywKICAgICAgICAgV2Vic2l0ZURhdGFUeXBlOjpE ZXZpY2VJZEhhc2hTYWx0LAogICAgICAgICBXZWJzaXRlRGF0YVR5cGU6OlJlc291cmNlTG9hZFN0 YXRpc3RpY3MsCisjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQogICAgICAgICBXZWJzaXRlRGF0 YVR5cGU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25zLAorI2VuZGlmCiAgICAgICAgIFdlYnNp dGVEYXRhVHlwZTo6RE9NQ2FjaGUKICAgICB9KTsKIH0KQEAgLTEwNyw4ICsxMDksMTAgQEAgc3Rh dGljIFdlYktpdFdlYnNpdGVEYXRhVHlwZXMgdG9XZWJLaXRXZWJzaXRlRGF0YVR5cGVzKE9wdGlv blNldDxXZWJzaXRlRGF0YVR5cGUKICAgICAgICAgcmV0dXJuVmFsdWUgfD0gV0VCS0lUX1dFQlNJ VEVfREFUQV9ERVZJQ0VfSURfSEFTSF9TQUxUOwogICAgIGlmICh0eXBlcy5jb250YWlucyhXZWJz aXRlRGF0YVR5cGU6OlJlc291cmNlTG9hZFN0YXRpc3RpY3MpKQogICAgICAgICByZXR1cm5WYWx1 ZSB8PSBXRUJLSVRfV0VCU0lURV9EQVRBX0lUUDsKKyNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIp CiAgICAgaWYgKHR5cGVzLmNvbnRhaW5zKFdlYnNpdGVEYXRhVHlwZTo6U2VydmljZVdvcmtlclJl Z2lzdHJhdGlvbnMpKQogICAgICAgICByZXR1cm5WYWx1ZSB8PSBXRUJLSVRfV0VCU0lURV9EQVRB X1NFUlZJQ0VfV09SS0VSX1JFR0lTVFJBVElPTlM7CisjZW5kaWYKICAgICBpZiAodHlwZXMuY29u dGFpbnMoV2Vic2l0ZURhdGFUeXBlOjpET01DYWNoZSkpCiAgICAgICAgIHJldHVyblZhbHVlIHw9 IFdFQktJVF9XRUJTSVRFX0RBVEFfRE9NX0NBQ0hFOwogICAgIHJldHVybiBzdGF0aWNfY2FzdDxX ZWJLaXRXZWJzaXRlRGF0YVR5cGVzPihyZXR1cm5WYWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2Vic2l0ZURhdGFNYW5hZ2Vy LmNwcAppbmRleCBiZWZiYzYzZjIwZGM0ZWU0ZTA5YmYxYjkzOWQzYzVlN2U1ZWEzZjM4Li5lNDhj NzA1NzA5NGIzYWIxMTliYjU1NzA3OTY2MGNkM2M1MWU5MDZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYnNpdGVEYXRhTWFu YWdlci5jcHAKQEAgLTkzNCw4ICs5MzQsMTAgQEAgc3RhdGljIE9wdGlvblNldDxXZWJzaXRlRGF0 YVR5cGU+IHRvV2Vic2l0ZURhdGFUeXBlcyhXZWJLaXRXZWJzaXRlRGF0YVR5cGVzIHR5cGUKICAg ICAgICAgcmV0dXJuVmFsdWUuYWRkKFdlYnNpdGVEYXRhVHlwZTo6RGV2aWNlSWRIYXNoU2FsdCk7 CiAgICAgaWYgKHR5cGVzICYgV0VCS0lUX1dFQlNJVEVfREFUQV9JVFApCiAgICAgICAgIHJldHVy blZhbHVlLmFkZChXZWJzaXRlRGF0YVR5cGU6OlJlc291cmNlTG9hZFN0YXRpc3RpY3MpOworI2lm IEVOQUJMRShTRVJWSUNFX1dPUktFUikKICAgICBpZiAodHlwZXMgJiBXRUJLSVRfV0VCU0lURV9E QVRBX1NFUlZJQ0VfV09SS0VSX1JFR0lTVFJBVElPTlMpCiAgICAgICAgIHJldHVyblZhbHVlLmFk ZChXZWJzaXRlRGF0YVR5cGU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25zKTsKKyNlbmRpZgog ICAgIGlmICh0eXBlcyAmIFdFQktJVF9XRUJTSVRFX0RBVEFfRE9NX0NBQ0hFKQogICAgICAgICBy ZXR1cm5WYWx1ZS5hZGQoV2Vic2l0ZURhdGFUeXBlOjpET01DYWNoZSk7CiAgICAgcmV0dXJuIHJl dHVyblZhbHVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsv V2ViTG9hZGVyU3RyYXRlZ3kuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsv V2ViTG9hZGVyU3RyYXRlZ3kuY3BwCmluZGV4IDUwNjljOTVhYTRkYjU5YjY4MzFmODQ0MzcwMTM5 NTBmYzAxMWI3MjAuLjZmMTdhNGVhZWI4ZGU0OWQyZDM0N2NlOTUzYzc4YWRmMDEwZjgwNWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0 ZWd5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJT dHJhdGVneS5jcHAKQEAgLTIyOCwxMiArMjI4LDE0IEBAIHZvaWQgV2ViTG9hZGVyU3RyYXRlZ3k6 OnNjaGVkdWxlTG9hZChSZXNvdXJjZUxvYWRlciYgcmVzb3VyY2VMb2FkZXIsIENhY2hlZFJlc291 CiAgICAgaWYgKCF0cnlMb2FkaW5nVXNpbmdVUkxTY2hlbWVIYW5kbGVyKHJlc291cmNlTG9hZGVy LCB0cmFja2luZ1BhcmFtZXRlcnMpKSB7CiAgICAgICAgIFdFQkxPQURFUlNUUkFURUdZX1JFTEVB U0VfTE9HX0lGX0FMTE9XRUQoInNjaGVkdWxlTG9hZDogVVJMIHdpbGwgYmUgc2NoZWR1bGVkIHdp dGggdGhlIE5ldHdvcmtQcm9jZXNzIik7CiAKKyNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCiAg ICAgICAgIGlmICghcmVzb3VyY2VMb2FkZXIub3B0aW9ucygpLnNlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb25JZGVudGlmaWVyICYmIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbldlYktpdDo6c2hvdWxk SW50ZXJjZXB0UmVxdWVzdChyZXNvdXJjZUxvYWRlci5mcmFtZSgpLCByZXNvdXJjZUxvYWRlci5y ZXF1ZXN0KCkpKSB7CiAgICAgICAgICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb25XZWJLaXQ6 OmludGVyY2VwdFJlcXVlc3QocmVzb3VyY2VMb2FkZXIsIFt0aGlzLCBwcm90ZWN0ZWRSZXNvdXJj ZUxvYWRlciA9IG1ha2VSZWZQdHIoJnJlc291cmNlTG9hZGVyKSwgdHJhY2tpbmdQYXJhbWV0ZXJz LCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0LCByZXNvdXJjZV0oY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KSB7CiAgICAgICAgICAgICAgICAgc2NoZWR1bGVM b2FkRnJvbU5ldHdvcmtQcm9jZXNzKCpwcm90ZWN0ZWRSZXNvdXJjZUxvYWRlciwgcmVxdWVzdCwg dHJhY2tpbmdQYXJhbWV0ZXJzLCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGly ZWN0LCBtYXhpbXVtQnVmZmVyaW5nVGltZShyZXNvdXJjZSkpOwogICAgICAgICAgICAgfSk7CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KKyNlbmRpZgogICAgICAgICBzY2hlZHVsZUxv YWRGcm9tTmV0d29ya1Byb2Nlc3MocmVzb3VyY2VMb2FkZXIsIHJlc291cmNlTG9hZGVyLnJlcXVl c3QoKSwgdHJhY2tpbmdQYXJhbWV0ZXJzLCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRU UFJlZGlyZWN0LCBtYXhpbXVtQnVmZmVyaW5nVGltZShyZXNvdXJjZSkpOwogICAgICAgICByZXR1 cm47CiAgICAgfQo=