21645 2008-10-16 10:34:57 -0700 REGRESSION (r37469-r37605): File Input not Uploaded in Multipart/Form-data Form 2020-05-10 10:54:33 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED https://www.jakks.net/test.php Regression P2 Major --- 1 jmgrogg darin adele darin grahamperrin pizted rwbaskette staikos webkit zimmermann oldest_to_newest 95547 0 jmgrogg 2008-10-16 10:34:57 -0700 The $_FILES variable in php is not getting populated at all when a multipart/form-data ecntype form is submitted. It works fine in the shipped version of Safari 3.1.2, but the nightly build fails to populate it (which tells me the form is not being submitted properly?). 95701 1 webkit 2008-10-16 22:47:08 -0700 Last working nightly r37469. Confirmed. I saw the bug for the first time in Textpattern control panel during trying uploading file with multipart/form-data form. Possible duplication: bug 21518. 95752 2 webkit 2008-10-17 10:23:53 -0700 Possible duplication: bug 21707 95867 3 webkit 2008-10-18 03:51:15 -0700 Possible duplication: bug 21730 95894 4 timothy 2008-10-18 17:33:24 -0700 This prevents uploading patches to Bugzilla too. Sam thinks it was a change Darin did. 95899 5 darin 2008-10-18 18:52:20 -0700 Should be very quick to fix. 95901 6 24497 darin 2008-10-18 19:05:20 -0700 Created attachment 24497 test 95902 7 24498 darin 2008-10-18 19:09:11 -0700 Created attachment 24498 patch 95903 8 24498 mitz 2008-10-18 19:11:54 -0700 Comment on attachment 24498 patch + This "two at a time" a confusing way to do things, which explains why I got Typo (missing "is"?). r=me 95904 9 darin 2008-10-18 19:12:57 -0700 http://trac.webkit.org/changeset/37685 95912 10 mrowe 2008-10-18 22:28:37 -0700 *** Bug 21707 has been marked as a duplicate of this bug. *** 95914 11 mrowe 2008-10-18 22:28:44 -0700 *** Bug 21734 has been marked as a duplicate of this bug. *** 95916 12 mrowe 2008-10-18 22:29:10 -0700 *** Bug 21730 has been marked as a duplicate of this bug. *** 103192 13 jmgrogg 2008-12-22 09:49:02 -0800 It appears that this bug has reappeared in in r39433. The $_FILES variable in php is not getting populated on form submit if no files are chosen for the file form elements. Works fine in the current release of Safari and Firefox, but is broken in the nightly build. 103207 14 darin 2008-12-22 12:39:44 -0800 I understand that a bug was introduced by the new check-in, but I think that reopening this old bug report wasn't the best way to deal with that. Even though the symptom is the same. 103208 15 darin 2008-12-22 12:41:19 -0800 Nico, George, it looks like the refactoring broke file uploading. 103227 16 staikos 2008-12-22 14:58:37 -0800 Oops. We could back out, or fix it later today. Which do you prefer? 103231 17 zimmermann 2008-12-22 15:11:16 -0800 (In reply to comment #16) > Oops. We could back out, or fix it later today. Which do you prefer? > I'll investigate in the problem. We clearly need a layout test (!) - it bothers me stuff like that is not covered by layout tests. 103237 18 darin 2008-12-22 15:47:39 -0800 (In reply to comment #17) > I'll investigate in the problem. We clearly need a layout test (!) - it bothers > me stuff like that is not covered by layout tests. Me too. I'm hoping this is quick to fix -- we probably don't need to back out if we can figure it out today. 103238 19 26217 darin 2008-12-22 15:48:52 -0800 Created attachment 26217 test 103240 20 darin 2008-12-22 15:52:06 -0800 Hmm, a single file upload to bugzilla just worked for me. So this new bug does not have the same scope as the old one. Could someone please file a new bug report instead of reopening this one, since the new bug seems quite different from the old? 103248 21 zimmermann 2008-12-22 16:22:36 -0800 (In reply to comment #20) > Hmm, a single file upload to bugzilla just worked for me. So this new bug does > not have the same scope as the old one. Could someone please file a new bug > report instead of reopening this one, since the new bug seems quite different > from the old? > I think I found the bug, I'll file a new seperated one. 103253 22 zimmermann 2008-12-22 17:01:45 -0800 (In reply to comment #21) > (In reply to comment #20) > > Hmm, a single file upload to bugzilla just worked for me. So this new bug does > > not have the same scope as the old one. Could someone please file a new bug > > report instead of reopening this one, since the new bug seems quite different > > from the old? > > > > I think I found the bug, I'll file a new seperated one. Bug 22971 will cover this new seperated issue. Let's move there. 24497 2008-10-18 19:05:20 -0700 2008-10-18 19:09:11 -0700 test upload-test.txt text/plain 20 darin VGhpcyBpcyBqdXN0IGEgdGVzdC4= 24498 2008-10-18 19:09:11 -0700 2008-10-18 19:11:54 -0700 patch FileInputPatch.txt text/plain 5029 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzY4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMTAtMTggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY0NQorICAgICAgICAg IFJFR1JFU1NJT04gKHIzNzQ2OS1yMzc2MDUpOiBGaWxlIElucHV0IG5vdCBVcGxvYWRlZCBpbiBN dWx0aXBhcnQvRm9ybS1kYXRhIEZvcm0KKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6Zm9ybURhdGEpOgorICAg ICAgICBGaXggbG9vcCB0aGF0IGdvZXMgdGhyb3VnaCB0aGUgRm9ybURhdGFMaXN0IHRvIGdvIHR3 byBhdCBhIHRpbWUgaW4gYSBjbGVhcmVyCisgICAgICAgIHdheS4gTXkgbGFzdCBwYXRjaCBzY3Jl d2VkIHVwIHRoZSB3YXkgaXQgZ290IGZvcm0gY29udGVudCBmcm9tIHRoZSBpdGVtcy4KKyAgICAg ICAgVGhpcyAidHdvIGF0IGEgdGltZSIgYSBjb25mdXNpbmcgd2F5IHRvIGRvIHRoaW5ncywgd2hp Y2ggZXhwbGFpbnMgd2h5IEkgZ290CisgICAgICAgIGl0IHdyb25nIGxhc3QgdGltZSB0aHJvdWdo LCBidXQgSSBkZWNpZGVkIHRvIGp1c3QgZml4IGl0IGxvY2FsbHkgZm9yIG5vdworICAgICAgICBy YXRoZXIgdGhhbiBjaGFuZ2luZyB0aGUgZGVzaWduIG9mIEZvcm1EYXRhTGlzdC4KKwogMjAwOC0x MC0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQ2FtZXJvbiBad2FyaWNoLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAJKHJldmlz aW9uIDM3Njc4KQorKysgV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI0NiwyMCArMjQ2LDIyIEBAIFBhc3NSZWZQdHI8Rm9ybURhdGE+IEhUTUxGb3Jt RWxlbWVudDo6Zm8KICAgICAgICAgRm9ybURhdGFMaXN0IGxpc3QoZW5jb2RpbmcpOwogCiAgICAg ICAgIGlmICghY29udHJvbC0+ZGlzYWJsZWQoKSAmJiBjb250cm9sLT5hcHBlbmRGb3JtRGF0YShs aXN0LCBtX211bHRpcGFydCkpIHsKLSAgICAgICAgICAgIHNpemVfdCBsbiA9IGxpc3QubGlzdCgp LnNpemUoKTsKLSAgICAgICAgICAgIGZvciAoc2l6ZV90IGogPSAwOyBqIDwgbG47ICsraikgewot ICAgICAgICAgICAgICAgIGNvbnN0IEZvcm1EYXRhTGlzdDo6SXRlbSYgaXRlbSA9IGxpc3QubGlz dCgpW2pdOworICAgICAgICAgICAgc2l6ZV90IGZvcm1EYXRhTGlzdFNpemUgPSBsaXN0Lmxpc3Qo KS5zaXplKCk7CisgICAgICAgICAgICBBU1NFUlQoZm9ybURhdGFMaXN0U2l6ZSAlIDIgPT0gMCk7 CisgICAgICAgICAgICBmb3IgKHNpemVfdCBqID0gMDsgaiA8IGZvcm1EYXRhTGlzdFNpemU7IGog Kz0gMikgeworICAgICAgICAgICAgICAgIGNvbnN0IEZvcm1EYXRhTGlzdDo6SXRlbSYga2V5ID0g bGlzdC5saXN0KClbal07CisgICAgICAgICAgICAgICAgY29uc3QgRm9ybURhdGFMaXN0OjpJdGVt JiB2YWx1ZSA9IGxpc3QubGlzdCgpW2ogKyAxXTsKICAgICAgICAgICAgICAgICBpZiAoIW1fbXVs dGlwYXJ0KSB7CiAgICAgICAgICAgICAgICAgICAgIC8vIE9taXQgdGhlIG5hbWUgImlzaW5kZXgi IGlmIGl0J3MgdGhlIGZpcnN0IGZvcm0gZGF0YSBlbGVtZW50LgogICAgICAgICAgICAgICAgICAg ICAvLyBGSVhNRTogV2h5IGlzIHRoaXMgYSBnb29kIHJ1bGU/IElzIHRoaXMgb2Jzb2xldGUgbm93 PwotICAgICAgICAgICAgICAgICAgICBpZiAoZW5jb2RlZERhdGEuaXNFbXB0eSgpICYmIGl0ZW0u ZGF0YSgpID09ICJpc2luZGV4IikKLSAgICAgICAgICAgICAgICAgICAgICAgIGFwcGVuZEVuY29k ZWRTdHJpbmcoZW5jb2RlZERhdGEsIGxpc3QubGlzdCgpWysral0uZGF0YSgpKTsKKyAgICAgICAg ICAgICAgICAgICAgaWYgKGVuY29kZWREYXRhLmlzRW1wdHkoKSAmJiBrZXkuZGF0YSgpID09ICJp c2luZGV4IikKKyAgICAgICAgICAgICAgICAgICAgICAgIGFwcGVuZEVuY29kZWRTdHJpbmcoZW5j b2RlZERhdGEsIHZhbHVlLmRhdGEoKSk7CiAgICAgICAgICAgICAgICAgICAgIGVsc2UgewogICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKCFlbmNvZGVkRGF0YS5pc0VtcHR5KCkpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZW5jb2RlZERhdGEuYXBwZW5kKCcmJyk7Ci0gICAgICAgICAg ICAgICAgICAgICAgICBhcHBlbmRFbmNvZGVkU3RyaW5nKGVuY29kZWREYXRhLCBpdGVtLmRhdGEo KSk7CisgICAgICAgICAgICAgICAgICAgICAgICBhcHBlbmRFbmNvZGVkU3RyaW5nKGVuY29kZWRE YXRhLCBrZXkuZGF0YSgpKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGVuY29kZWREYXRhLmFw cGVuZCgnPScpOwotICAgICAgICAgICAgICAgICAgICAgICAgYXBwZW5kRW5jb2RlZFN0cmluZyhl bmNvZGVkRGF0YSwgbGlzdC5saXN0KClbKytqXS5kYXRhKCkpOworICAgICAgICAgICAgICAgICAg ICAgICAgYXBwZW5kRW5jb2RlZFN0cmluZyhlbmNvZGVkRGF0YSwgdmFsdWUuZGF0YSgpKTsKICAg ICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAg ICAgICAgICAgIFZlY3RvcjxjaGFyPiBoZWFkZXI7CkBAIC0yNjcsMTUgKzI2OSwxNSBAQCBQYXNz UmVmUHRyPEZvcm1EYXRhPiBIVE1MRm9ybUVsZW1lbnQ6OmZvCiAgICAgICAgICAgICAgICAgICAg IGFwcGVuZFN0cmluZyhoZWFkZXIsIGJvdW5kYXJ5KTsKICAgICAgICAgICAgICAgICAgICAgYXBw ZW5kU3RyaW5nKGhlYWRlciwgIlxyXG4iKTsKICAgICAgICAgICAgICAgICAgICAgYXBwZW5kU3Ry aW5nKGhlYWRlciwgIkNvbnRlbnQtRGlzcG9zaXRpb246IGZvcm0tZGF0YTsgbmFtZT1cIiIpOwot ICAgICAgICAgICAgICAgICAgICBoZWFkZXIuYXBwZW5kKGl0ZW0uZGF0YSgpLmRhdGEoKSwgaXRl bS5kYXRhKCkubGVuZ3RoKCkpOworICAgICAgICAgICAgICAgICAgICBoZWFkZXIuYXBwZW5kKGtl eS5kYXRhKCkuZGF0YSgpLCBrZXkuZGF0YSgpLmxlbmd0aCgpKTsKICAgICAgICAgICAgICAgICAg ICAgaGVhZGVyLmFwcGVuZCgnIicpOwogCiAgICAgICAgICAgICAgICAgICAgIGJvb2wgc2hvdWxk R2VuZXJhdGVGaWxlID0gZmFsc2U7CiAgICAgICAgICAgICAgICAgICAgIC8vIGlmIHRoZSBjdXJy ZW50IHR5cGUgaXMgRklMRSwgdGhlbiB3ZSBhbHNvIG5lZWQgdG8KICAgICAgICAgICAgICAgICAg ICAgLy8gaW5jbHVkZSB0aGUgZmlsZW5hbWUKLSAgICAgICAgICAgICAgICAgICAgaWYgKGl0ZW0u ZmlsZSgpKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBTdHJpbmcmIHBhdGggPSBp dGVtLmZpbGUoKS0+cGF0aCgpOwotICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nIGZpbGVu YW1lID0gaXRlbS5maWxlKCktPmZpbGVOYW1lKCk7CisgICAgICAgICAgICAgICAgICAgIGlmICh2 YWx1ZS5maWxlKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFN0cmluZyYgcGF0 aCA9IHZhbHVlLmZpbGUoKS0+cGF0aCgpOworICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5n IGZpbGVuYW1lID0gdmFsdWUuZmlsZSgpLT5maWxlTmFtZSgpOwogCiAgICAgICAgICAgICAgICAg ICAgICAgICAvLyBMZXQgdGhlIGFwcGxpY2F0aW9uIHNwZWNpZnkgYSBmaWxlbmFtZSBpZiBpdCdz IGdvaW5nIHRvIGdlbmVyYXRlIGEgcmVwbGFjZW1lbnQgZmlsZSBmb3IgdGhlIHVwbG9hZC4KICAg ICAgICAgICAgICAgICAgICAgICAgIGlmICghcGF0aC5pc0VtcHR5KCkpIHsKQEAgLTMxMiwxMSAr MzE0LDEwIEBAIFBhc3NSZWZQdHI8Rm9ybURhdGE+IEhUTUxGb3JtRWxlbWVudDo6Zm8KIAogICAg ICAgICAgICAgICAgICAgICAvLyBhcHBlbmQgYm9keQogICAgICAgICAgICAgICAgICAgICByZXN1 bHQtPmFwcGVuZERhdGEoaGVhZGVyLmRhdGEoKSwgaGVhZGVyLnNpemUoKSk7Ci0gICAgICAgICAg ICAgICAgICAgIGNvbnN0IEZvcm1EYXRhTGlzdDo6SXRlbSYgaXRlbSA9IGxpc3QubGlzdCgpW2og KyAxXTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKHNpemVfdCBkYXRhU2l6ZSA9IGl0ZW0uZGF0 YSgpLmxlbmd0aCgpKQotICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LT5hcHBlbmREYXRh KGl0ZW0uZGF0YSgpLmRhdGEoKSwgZGF0YVNpemUpOwotICAgICAgICAgICAgICAgICAgICBlbHNl IGlmIChpdGVtLmZpbGUoKSAmJiAhaXRlbS5maWxlKCktPnBhdGgoKS5pc0VtcHR5KCkpCi0gICAg ICAgICAgICAgICAgICAgICAgICByZXN1bHQtPmFwcGVuZEZpbGUoaXRlbS5maWxlKCktPnBhdGgo KSwgc2hvdWxkR2VuZXJhdGVGaWxlKTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKHNpemVfdCBk YXRhU2l6ZSA9IHZhbHVlLmRhdGEoKS5sZW5ndGgoKSkKKyAgICAgICAgICAgICAgICAgICAgICAg IHJlc3VsdC0+YXBwZW5kRGF0YSh2YWx1ZS5kYXRhKCkuZGF0YSgpLCBkYXRhU2l6ZSk7CisgICAg ICAgICAgICAgICAgICAgIGVsc2UgaWYgKHZhbHVlLmZpbGUoKSAmJiAhdmFsdWUuZmlsZSgpLT5w YXRoKCkuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LT5hcHBlbmRG aWxlKHZhbHVlLmZpbGUoKS0+cGF0aCgpLCBzaG91bGRHZW5lcmF0ZUZpbGUpOwogICAgICAgICAg ICAgICAgICAgICByZXN1bHQtPmFwcGVuZERhdGEoIlxyXG4iLCAyKTsKIAogICAgICAgICAgICAg ICAgICAgICArK2o7Cg== 26217 2008-12-22 15:48:52 -0800 2008-12-22 15:48:52 -0800 test empty-file.txt text/plain 10 darin ZW1wdHkgZmlsZQ==