216438 2020-09-12 09:36:04 -0700 Make CanvasRenderingContext2D functions parameters not default to undefined 2020-09-13 11:48:14 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis cdumez changseok dino esprehn+autocc ews-watchlist gyuyoung.kim hi kondapallykalyan sam webkit-bug-importer oldest_to_newest 1687934 0 rbuis 2020-09-12 09:36:04 -0700 Some string parameters default to "undefined", however the code path is the same when no default is given and implicitly a null string is passed, so remove the default values. 1687935 1 408601 rbuis 2020-09-12 09:37:20 -0700 Created attachment 408601 Patch 1688081 2 408646 rbuis 2020-09-13 02:48:49 -0700 Created attachment 408646 Patch 1688125 3 ews-feeder 2020-09-13 11:47:36 -0700 Committed r267000: <https://trac.webkit.org/changeset/267000> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408646. 1688126 4 webkit-bug-importer 2020-09-13 11:48:14 -0700 <rdar://problem/68809745> 408601 2020-09-12 09:37:20 -0700 2020-09-13 02:48:43 -0700 Patch bug-216438-20200912183719.patch text/plain 2536 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2OTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFiYmJiNTlhMGI1Zjdm Y2ZiNzZkMzk3MTAzMzE4ZWQ2Nzg1N2U5Ni4uNWY2MWUxN2ExYzdkYjIxOTZjNzM3OWFhNTFmMzYy ZGMyYTMzZmEwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTEyICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBDYW52YXNSZW5kZXJpbmdD b250ZXh0MkQgZnVuY3Rpb25zIHBhcmFtZXRlcnMgbm90IGRlZmF1bHQgdG8gdW5kZWZpbmVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY0MzgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHN0cmlu ZyBwYXJhbWV0ZXJzIGRlZmF1bHQgdG8gInVuZGVmaW5lZCIsIGhvd2V2ZXIgdGhlIGNvZGUgcGF0 aCBpcyB0aGUgc2FtZSB3aGVuCisgICAgICAgIG5vIGRlZmF1bHQgaXMgZ2l2ZW4gYW5kIGltcGxp Y2l0bHkgYSBudWxsIHN0cmluZyBpcyBwYXNzZWQsIHNvIHJlbW92ZSB0aGUgZGVmYXVsdAorICAg ICAgICB2YWx1ZXMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQuaWRsOgorCiAyMDIwLTA5LTEyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkcmVzc2luZyBmZWVkYmFjayBvbiByMjY2OTM2CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJELmlkbAppbmRleCA5NWFjNzliODBhZDdlOGJiMDA3ZTk3NjcxZWRlMWVlNmRjYjA5MGJlLi5h OTY5Y2UwMmViZGIyM2Y5ODY5ZDc1NTA4NjQxYzE5ZTI4OTlmYWVmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuaWRsCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5pZGwK QEAgLTM0LDcgKzM0LDcgQEAKIAogICAgIC8vIE5vbi1zdGFuZGFyZCBsZWdhY3kgYWxpYXNlcyAo Q29tcG9zaXRpbmcpLgogICAgIFtJbXBsZW1lbnRlZEFzPXNldEdsb2JhbEFscGhhXSB1bmRlZmlu ZWQgc2V0QWxwaGEob3B0aW9uYWwgdW5yZXN0cmljdGVkIGZsb2F0IGFscGhhID0gTmFOKTsKLSAg ICBbSW1wbGVtZW50ZWRBcz1zZXRHbG9iYWxDb21wb3NpdGVPcGVyYXRpb25dIHVuZGVmaW5lZCBz ZXRDb21wb3NpdGVPcGVyYXRpb24ob3B0aW9uYWwgRE9NU3RyaW5nIGNvbXBvc2l0ZU9wZXJhdGlv biA9ICJ1bmRlZmluZWQiKTsgLy8gRklYTUU6IFVzaW5nICJ1bmRlZmluZWQiIGFzIGRlZmF1bHQg cGFyYW1ldGVyIHZhbHVlIGlzIHdyb25nLgorICAgIFtJbXBsZW1lbnRlZEFzPXNldEdsb2JhbENv bXBvc2l0ZU9wZXJhdGlvbl0gdW5kZWZpbmVkIHNldENvbXBvc2l0ZU9wZXJhdGlvbihvcHRpb25h bCBET01TdHJpbmcgY29tcG9zaXRlT3BlcmF0aW9uKTsKIAogICAgIC8vIE5vbi1zdGFuZGFyZCBm dW5jdGlvbmFsaXR5IChDYW52YXNEcmF3SW1hZ2UpLgogICAgIHVuZGVmaW5lZCBkcmF3SW1hZ2VG cm9tUmVjdChIVE1MSW1hZ2VFbGVtZW50IGltYWdlLApAQCAtNjAsOCArNjAsOCBAQAogCiAgICAg Ly8gTm9uLXN0YW5kYXJkIGxlZ2FjeSBhbGlhc2VzIChDYW52YXNQYXRoRHJhd2luZ1N0eWxlcyku CiAgICAgdW5kZWZpbmVkIHNldExpbmVXaWR0aChvcHRpb25hbCB1bnJlc3RyaWN0ZWQgZmxvYXQg d2lkdGggPSBOYU4pOwotICAgIHVuZGVmaW5lZCBzZXRMaW5lQ2FwKG9wdGlvbmFsIERPTVN0cmlu ZyBjYXAgPSAidW5kZWZpbmVkIik7IC8vIEZJWE1FOiBVc2luZyAidW5kZWZpbmVkIiBhcyBkZWZh dWx0IHBhcmFtZXRlciB2YWx1ZSBpcyB3cm9uZy4KLSAgICB1bmRlZmluZWQgc2V0TGluZUpvaW4o b3B0aW9uYWwgRE9NU3RyaW5nIGpvaW4gPSAidW5kZWZpbmVkIik7IC8vIEZJWE1FOiBVc2luZyAi dW5kZWZpbmVkIiBhcyBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZSBpcyB3cm9uZy4KKyAgICB1bmRl ZmluZWQgc2V0TGluZUNhcChvcHRpb25hbCBET01TdHJpbmcgY2FwKTsKKyAgICB1bmRlZmluZWQg c2V0TGluZUpvaW4ob3B0aW9uYWwgRE9NU3RyaW5nIGpvaW4pOwogICAgIHVuZGVmaW5lZCBzZXRN aXRlckxpbWl0KG9wdGlvbmFsIHVucmVzdHJpY3RlZCBmbG9hdCBsaW1pdCA9IE5hTik7CiAgICAg YXR0cmlidXRlIHNlcXVlbmNlPHVucmVzdHJpY3RlZCBmbG9hdD4gd2Via2l0TGluZURhc2g7CiAg ICAgW0ltcGxlbWVudGVkQXM9bGluZURhc2hPZmZzZXRdIGF0dHJpYnV0ZSB1bnJlc3RyaWN0ZWQg ZmxvYXQgd2Via2l0TGluZURhc2hPZmZzZXQ7Cg== 408646 2020-09-13 02:48:49 -0700 2020-09-13 11:47:36 -0700 Patch bug-216438-20200913114847.patch text/plain 4291 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2OTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWJiNTNjM2Y3ZmMzZmNh MjdjNTg1M2U2ZTlkNDM2Y2FhNGIwNTJjMS4uNWU0YTMyZjE3MDEwMTYyOWNmMTg3Y2Q4OTk1ODVj ZGJhYmFjZWZjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTEzICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBDYW52YXNSZW5kZXJpbmdD b250ZXh0MkQgZnVuY3Rpb25zIHBhcmFtZXRlcnMgbm90IGRlZmF1bHQgdG8gdW5kZWZpbmVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY0MzgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHN0cmlu ZyBwYXJhbWV0ZXJzIGRlZmF1bHQgdG8gInVuZGVmaW5lZCIsIGhvd2V2ZXIgdGhlIGNvZGUgcGF0 aCBpcyB0aGUgc2FtZSB3aGVuCisgICAgICAgIG5vIGRlZmF1bHQgaXMgZ2l2ZW4gYW5kIGltcGxp Y2l0bHkgYSBudWxsIHN0cmluZyBpcyBwYXNzZWQsIHNvIHJlbW92ZSB0aGUgZGVmYXVsdAorICAg ICAgICB2YWx1ZXMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQuaWRsOgorCiAyMDIwLTA5LTEzICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAK ICAgICAgICAgQ2xlYW4gdXAgTGF6eUxvYWRJbWFnZU9ic2VydmVyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuaWRsIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmlkbAppbmRl eCA5NWFjNzliODBhZDdlOGJiMDA3ZTk3NjcxZWRlMWVlNmRjYjA5MGJlLi5hOTY5Y2UwMmViZGIy M2Y5ODY5ZDc1NTA4NjQxYzE5ZTI4OTlmYWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuaWRsCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5pZGwKQEAgLTM0LDcgKzM0 LDcgQEAKIAogICAgIC8vIE5vbi1zdGFuZGFyZCBsZWdhY3kgYWxpYXNlcyAoQ29tcG9zaXRpbmcp LgogICAgIFtJbXBsZW1lbnRlZEFzPXNldEdsb2JhbEFscGhhXSB1bmRlZmluZWQgc2V0QWxwaGEo b3B0aW9uYWwgdW5yZXN0cmljdGVkIGZsb2F0IGFscGhhID0gTmFOKTsKLSAgICBbSW1wbGVtZW50 ZWRBcz1zZXRHbG9iYWxDb21wb3NpdGVPcGVyYXRpb25dIHVuZGVmaW5lZCBzZXRDb21wb3NpdGVP cGVyYXRpb24ob3B0aW9uYWwgRE9NU3RyaW5nIGNvbXBvc2l0ZU9wZXJhdGlvbiA9ICJ1bmRlZmlu ZWQiKTsgLy8gRklYTUU6IFVzaW5nICJ1bmRlZmluZWQiIGFzIGRlZmF1bHQgcGFyYW1ldGVyIHZh bHVlIGlzIHdyb25nLgorICAgIFtJbXBsZW1lbnRlZEFzPXNldEdsb2JhbENvbXBvc2l0ZU9wZXJh dGlvbl0gdW5kZWZpbmVkIHNldENvbXBvc2l0ZU9wZXJhdGlvbihvcHRpb25hbCBET01TdHJpbmcg Y29tcG9zaXRlT3BlcmF0aW9uKTsKIAogICAgIC8vIE5vbi1zdGFuZGFyZCBmdW5jdGlvbmFsaXR5 IChDYW52YXNEcmF3SW1hZ2UpLgogICAgIHVuZGVmaW5lZCBkcmF3SW1hZ2VGcm9tUmVjdChIVE1M SW1hZ2VFbGVtZW50IGltYWdlLApAQCAtNjAsOCArNjAsOCBAQAogCiAgICAgLy8gTm9uLXN0YW5k YXJkIGxlZ2FjeSBhbGlhc2VzIChDYW52YXNQYXRoRHJhd2luZ1N0eWxlcykuCiAgICAgdW5kZWZp bmVkIHNldExpbmVXaWR0aChvcHRpb25hbCB1bnJlc3RyaWN0ZWQgZmxvYXQgd2lkdGggPSBOYU4p OwotICAgIHVuZGVmaW5lZCBzZXRMaW5lQ2FwKG9wdGlvbmFsIERPTVN0cmluZyBjYXAgPSAidW5k ZWZpbmVkIik7IC8vIEZJWE1FOiBVc2luZyAidW5kZWZpbmVkIiBhcyBkZWZhdWx0IHBhcmFtZXRl ciB2YWx1ZSBpcyB3cm9uZy4KLSAgICB1bmRlZmluZWQgc2V0TGluZUpvaW4ob3B0aW9uYWwgRE9N U3RyaW5nIGpvaW4gPSAidW5kZWZpbmVkIik7IC8vIEZJWE1FOiBVc2luZyAidW5kZWZpbmVkIiBh cyBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZSBpcyB3cm9uZy4KKyAgICB1bmRlZmluZWQgc2V0TGlu ZUNhcChvcHRpb25hbCBET01TdHJpbmcgY2FwKTsKKyAgICB1bmRlZmluZWQgc2V0TGluZUpvaW4o b3B0aW9uYWwgRE9NU3RyaW5nIGpvaW4pOwogICAgIHVuZGVmaW5lZCBzZXRNaXRlckxpbWl0KG9w dGlvbmFsIHVucmVzdHJpY3RlZCBmbG9hdCBsaW1pdCA9IE5hTik7CiAgICAgYXR0cmlidXRlIHNl cXVlbmNlPHVucmVzdHJpY3RlZCBmbG9hdD4gd2Via2l0TGluZURhc2g7CiAgICAgW0ltcGxlbWVu dGVkQXM9bGluZURhc2hPZmZzZXRdIGF0dHJpYnV0ZSB1bnJlc3RyaWN0ZWQgZmxvYXQgd2Via2l0 TGluZURhc2hPZmZzZXQ7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzliNjNiZTgyNTE4MTQzNjViNDM2MDVlNjc5NDU2OWEz MWI0NmM4Ny4uOTYwYmE5ZGMwYTU4NGQwMDhjODY5NWY0Njc1MTdlOTdjYTQ3NjBiMyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTEzICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+ CisKKyAgICAgICAgTWFrZSBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQgZnVuY3Rpb25zIHBhcmFt ZXRlcnMgbm90IGRlZmF1bHQgdG8gdW5kZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGp1c3QgZXhwZWN0ZWQgdGVzdCByZXN1bHQuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvY2FudmFzL3JlY29yZGluZy0yZC1mdWxsLWV4cGVjdGVkLnR4dDoK KwogMjAyMC0wOS0xMiAgVHlsZXIgV2lsY29jayA8dHdpbGNvLm9AcHJvdG9ubWFpbC5jb20+CiAK ICAgICAgICAgU2FmZWx5IGhhbmRsZSBvdmVybHktbG9uZyBDU1MgdmFyaWFibGUgdmFsdWVzCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29yZGluZy0yZC1mdWxs LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLTJk LWZ1bGwtZXhwZWN0ZWQudHh0CmluZGV4IGI3MTY4YTQ3MTY2MGQyZGQwNWI4NjBkMDZlNTU0ZGE1 MzU0OTkxMTcuLmIwMTJkMmUwMjBlZDc1NGJmMDkyNGZkYjczZjQ0Y2ZjY2Y3MDlmOWIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLTJkLWZ1bGwtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLTJk LWZ1bGwtZXhwZWN0ZWQudHh0CkBAIC02NTIsNyArNjUyLDcgQEAgZnJhbWVzOgogICAgICAgICAx OiAoYW5vbnltb3VzIGZ1bmN0aW9uKQogICAgICAgICAyOiBleGVjdXRlRnJhbWVGdW5jdGlvbgog ICA0ODogKGR1cmF0aW9uKQotICAgIDA6IHNldENvbXBvc2l0ZU9wZXJhdGlvbigidW5kZWZpbmVk IikKKyAgICAwOiBzZXRDb21wb3NpdGVPcGVyYXRpb24oIiIpCiAgICAgICBzd2l6emxlVHlwZXM6 IFtTdHJpbmddCiAgICAgICB0cmFjZToKICAgICAgICAgMDogc2V0Q29tcG9zaXRlT3BlcmF0aW9u CkBAIC03MDIsNyArNzAyLDcgQEAgZnJhbWVzOgogICAgICAgICAxOiAoYW5vbnltb3VzIGZ1bmN0 aW9uKQogICAgICAgICAyOiBleGVjdXRlRnJhbWVGdW5jdGlvbgogICA1MDogKGR1cmF0aW9uKQot ICAgIDA6IHNldExpbmVDYXAoInVuZGVmaW5lZCIpCisgICAgMDogc2V0TGluZUNhcCgiIikKICAg ICAgIHN3aXp6bGVUeXBlczogW1N0cmluZ10KICAgICAgIHRyYWNlOgogICAgICAgICAwOiBzZXRM aW5lQ2FwCkBAIC03MjIsNyArNzIyLDcgQEAgZnJhbWVzOgogICAgICAgICAxOiAoYW5vbnltb3Vz IGZ1bmN0aW9uKQogICAgICAgICAyOiBleGVjdXRlRnJhbWVGdW5jdGlvbgogICA1MjogKGR1cmF0 aW9uKQotICAgIDA6IHNldExpbmVKb2luKCJ1bmRlZmluZWQiKQorICAgIDA6IHNldExpbmVKb2lu KCIiKQogICAgICAgc3dpenpsZVR5cGVzOiBbU3RyaW5nXQogICAgICAgdHJhY2U6CiAgICAgICAg IDA6IHNldExpbmVKb2luCg==