216434 2020-09-12 07:22:25 -0700 [LFC][IFC] Simplify LineBox offset computation 2020-09-12 12:31:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1687919 0 zalan 2020-09-12 07:22:25 -0700 now that we have proper line and line box height 1687920 1 408593 zalan 2020-09-12 07:27:51 -0700 Created attachment 408593 Patch 1687954 2 ews-feeder 2020-09-12 12:30:05 -0700 Committed r266979: <https://trac.webkit.org/changeset/266979> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408593. 1687955 3 webkit-bug-importer 2020-09-12 12:31:16 -0700 <rdar://problem/68773874> 408593 2020-09-12 07:27:51 -0700 2020-09-12 12:30:05 -0700 Patch bug-216434-20200912072751.patch text/plain 3135 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIxMmU1MWUyZGJmOTgy OTkzMjQ2NTZhODZkM2ZkMmM1ZWYzODc3NS4uMDUxMDYxNzNmZDY4OTk2ZmE2NDJmZmVjZTJhMmVh NzBhODQ3MWQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBTaW1wbGlm eSBMaW5lQm94IG9mZnNldCBjb21wdXRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NDM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBzdGlsbCBpbmxpbmUgd2l0aCB0aGUgaGFsZiBs ZWFkaW5nIGxvZ2ljIHdoZXJlIHRoZSBhc2NlbnQgKyBkZXNjZW50IChMaW5lQm94IGhlaWdodCkg YW5kIHRoZSBsaW5lIHNwYWNpbmcgYXJlCisgICAgICAgIHVzZWQgdG8gcG9zaXRpb24gdGhlIGlu bGluZSBjb250ZW50LgorCisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5l Rm9ybWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVG b3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZWRMaW5lTG9naWNhbFJlY3QgY29uc3QpOgorCiAyMDIw LTA5LTEyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11b SUZDXSBBZGQgc3VwcG9ydCBmb3Igbm9uLXJvb3QtaW5saW5lLWJveCBsaW5lIHNwYWNpbmcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZv cm1hdHRpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcAppbmRleCBhZjZlMDI1MzczYjY5ZDE5N2Q5 MzRkOGZhMTkxYmY4OGE4MTQzZWFkLi5lMjcxNGY3NmFlMGJmMWQyMGMwNzkxMGVkOWU5N2ZkOTYy MDkzMzM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGlu Zy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCkBAIC00MTQsMTEg KzQxNCwxMSBAQCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6TGluZVJlY3RBbmRMaW5lQm94T2Zm c2V0IElubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdQogICAgICAgICByZXR1cm4geyB7IH0s IHsgbGluZUNvbnRlbnQubG9naWNhbFRvcExlZnQsIGxpbmVDb250ZW50LmxpbmVMb2dpY2FsV2lk dGgsIHsgfSB9IH07CiAKICAgICBhdXRvJiByb290U3R5bGUgPSByb290KCkuc3R5bGUoKTsKKyAg ICBhdXRvIGxpbmVCb3hMb2dpY2FsSGVpZ2h0ID0gbGluZUJveC5sb2dpY2FsSGVpZ2h0KCk7CiAg ICAgYXV0byBsaW5lTG9naWNhbEhlaWdodCA9IElubGluZUxheW91dFVuaXQgeyB9OwogICAgIGlm IChyb290U3R5bGUubGluZUhlaWdodCgpLmlzTmVnYXRpdmUoKSkgewogICAgICAgICAvLyBOZWdh dGl2ZSBsaW5lIGhlaWdodCB2YWx1ZSBtZWFucyB0aGUgbGluZSBoZWlnaHQgaXMgZHJpdmVuIGJ5 IHRoZSBjb250ZW50LgogICAgICAgICBhdXRvIHVzZWRMaW5lU3BhY2luZyA9IFsmXSB7Ci0gICAg ICAgICAgICBhdXRvIGxpbmVCb3hMb2dpY2FsSGVpZ2h0ID0gbGluZUJveC5sb2dpY2FsSGVpZ2h0 KCk7CiAgICAgICAgICAgICBhdXRvIGxvZ2ljYWxUb3BXaXRoTGluZVNwYWNpbmcgPSBJbmxpbmVM YXlvdXRVbml0IHsgfTsKICAgICAgICAgICAgIGF1dG8gbG9naWNhbEJvdHRvbVdpdGhMaW5lU3Bh Y2luZyA9IGxpbmVCb3hMb2dpY2FsSGVpZ2h0OwogICAgICAgICAgICAgZm9yIChhdXRvJiBpbmxp bmVCb3ggOiBsaW5lQm94LmlubGluZUJveExpc3QoKSkgewpAQCAtNDM1LDE2ICs0MzUsOCBAQCBJ bmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6TGluZVJlY3RBbmRMaW5lQm94T2Zmc2V0IElubGluZUZv cm1hdHRpbmdDb250ZXh0Ojpjb21wdQogICAgICAgICBsaW5lTG9naWNhbEhlaWdodCA9IHJvb3RT dHlsZS5jb21wdXRlZExpbmVIZWlnaHQoKTsKIAogICAgIGF1dG8gbG9naWNhbFJlY3QgPSBEaXNw bGF5OjpJbmxpbmVSZWN0IHsgbGluZUNvbnRlbnQubG9naWNhbFRvcExlZnQsIGxpbmVDb250ZW50 LmxpbmVMb2dpY2FsV2lkdGgsIGxpbmVMb2dpY2FsSGVpZ2h0fTsKLSAgICBhdXRvIGhhbGZMZWFk aW5nT2Zmc2V0ID0gWyZdIHsKLSAgICAgICAgYXV0byYgZm9udE1ldHJpY3MgPSByb290U3R5bGUu Zm9udE1ldHJpY3MoKTsKLSAgICAgICAgSW5saW5lTGF5b3V0VW5pdCBhc2NlbnQgPSBmb250TWV0 cmljcy5hc2NlbnQoKTsKLSAgICAgICAgSW5saW5lTGF5b3V0VW5pdCBkZXNjZW50ID0gZm9udE1l dHJpY3MuZGVzY2VudCgpOwotICAgICAgICAvLyAxMC44LjEgTGVhZGluZyBhbmQgaGFsZi1sZWFk aW5nCi0gICAgICAgIGF1dG8gaGFsZkxlYWRpbmcgPSAobGluZUxvZ2ljYWxIZWlnaHQgLSAoYXNj ZW50ICsgZGVzY2VudCkpIC8gMjsKLSAgICAgICAgLy8gSW5saW5lIHRyZWUgaGVpZ2h0IGlzIGFs bCBpbnRlZ2VyIGJhc2VkLgotICAgICAgICByZXR1cm4gZmxvb3JmKGFzY2VudCArIGhhbGZMZWFk aW5nKTsKLSAgICB9KCk7Ci0gICAgYXV0byBsaW5lQm94T2Zmc2V0ID0gbG9naWNhbFJlY3QuaGVp Z2h0KCkgPT0gbGluZUJveC5sb2dpY2FsSGVpZ2h0KCkgPyBJbmxpbmVMYXlvdXRVbml0KCkgOiBo YWxmTGVhZGluZ09mZnNldCAtIGxpbmVCb3guYWxpZ25tZW50QmFzZWxpbmUoKTsKKyAgICAvLyBJ bmxpbmUgdHJlZSBoZWlnaHQgaXMgYWxsIGludGVnZXIgYmFzZWQuCisgICAgYXV0byBsaW5lQm94 T2Zmc2V0ID0gZmxvb3JmKChsaW5lTG9naWNhbEhlaWdodCAtIGxpbmVCb3hMb2dpY2FsSGVpZ2h0 KSAvIDIpOwogICAgIHJldHVybiB7IGxpbmVCb3hPZmZzZXQsIGxvZ2ljYWxSZWN0IH07CiB9CiAK