216410 2020-09-11 10:01:57 -0700 styleDidChange functions should all check for nullptr oldStyle 2020-09-11 11:10:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1687746 0 zalan 2020-09-11 10:01:57 -0700 ssia 1687749 1 408541 zalan 2020-09-11 10:09:05 -0700 Created attachment 408541 Patch 1687766 2 ews-feeder 2020-09-11 11:09:09 -0700 Committed r266930: <https://trac.webkit.org/changeset/266930> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408541. 1687769 3 webkit-bug-importer 2020-09-11 11:10:35 -0700 <rdar://problem/68720533> 408541 2020-09-11 10:09:05 -0700 2020-09-11 11:09:10 -0700 Patch bug-216410-20200911100904.patch text/plain 5972 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE4YjQ0Y2Y3ODc0N2U0 ZTI1ZWU0MzczZDJjM2M2MzBhNzQyNTNkNS4uYzJlMzZkN2FkMTUyMTNhYzkyZDE2YjE0OTcyNmRj NDJlMGQyZjg2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA5LTExICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgc3R5bGVEaWRDaGFuZ2UgZnVu Y3Rpb25zIHNob3VsZCBhbGwgY2hlY2sgZm9yIG51bGxwdHIgb2xkU3R5bGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjQxMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHNvbWUgb2YgdGhlc2Ug Y2FsbHMgYXJlIHByb3RlY3RlZCBieSB0aGUgU3R5bGVEaWZmZXJlbmNlIHZhbHVlIGNoZWNrICgh U3R5bGVEaWZmZXJlbmNlOjpOZXdTdHlsZSksIGFuIHVuc2FmZSBjb2RlIHJlZmFjdG9yaW5nIGNv dWxkIHJlc3VsdCBpbiBudWxsIGRlcmVmLiAKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckVsZW1lbnQ6OnN0eWxlRGlkQ2hh bmdlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVySW1hZ2U6OnN0eWxlRGlkQ2hhbmdlKToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXll ck1vZGVsT2JqZWN0OjpzdHlsZURpZENoYW5nZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clJlcGxhY2VkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclJlcGxhY2VkOjpzdHlsZURp ZENoYW5nZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlQ29sLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ29sOjpzdHlsZURpZENoYW5nZSk6CisKIDIwMjAtMDkt MTEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTiAoQXN5bmMgb3ZlcmZsb3cgc2Nyb2xsKTogTW91c2Ugd2hlZWwgc2Nyb2xsaW5nIG92 ZXIgYW4gImFsd2F5cy1vbiIgb3ZlcmZsb3cgc2Nyb2xsYmFyIGRvZXNuJ3Qgd29yawpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCmluZGV4IGQ0OGViOGQ5NmNhZDNi YmQ0NzYyNmY0ZGMwZDZlMDk5ZWZhZWQ5MzAuLmQ2MzU4MTE5YjRjYzcxNGUxZGU1ODE2NDYzODVj YmVlMzJkYzg1MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJF bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5j cHAKQEAgLTkxMCw3ICs5MTAsNyBAQCB2b2lkIFJlbmRlckVsZW1lbnQ6OnN0eWxlRGlkQ2hhbmdl KFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkUwogICAgICAgICAv LyB0byBtYXJrIHRoZSBuZXcgY29udGFpbmluZyBibG9ja3MgZm9yIGxheW91dC4gVGhlIGNoYW5n ZSB0aGF0IGNhbgogICAgICAgICAvLyBkaXJlY3RseSBhZmZlY3QgdGhlIGNvbnRhaW5pbmcgYmxv Y2sgb2YgdGhpcyBvYmplY3QgaXMgYSBjaGFuZ2UgdG8KICAgICAgICAgLy8gdGhlIHBvc2l0aW9u IHN0eWxlLgotICAgICAgICBpZiAobmVlZHNMYXlvdXQoKSAmJiBvbGRTdHlsZS0+cG9zaXRpb24o KSAhPSBtX3N0eWxlLnBvc2l0aW9uKCkpCisgICAgICAgIGlmIChuZWVkc0xheW91dCgpICYmIG9s ZFN0eWxlICYmIG9sZFN0eWxlLT5wb3NpdGlvbigpICE9IG1fc3R5bGUucG9zaXRpb24oKSkKICAg ICAgICAgICAgIG1hcmtDb250YWluaW5nQmxvY2tzRm9yTGF5b3V0KCk7CiAKICAgICAgICAgaWYg KGRpZmYgPT0gU3R5bGVEaWZmZXJlbmNlOjpMYXlvdXQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckltYWdlLmNwcAppbmRleCA3NGZmMWIzNGFjNjRhNjdiMjEwZjljODMwZTAzMGM2ODcw ODBiNTQ1Li5hM2E5Y2M4YmIxMjUzYWFhNzc4MWMxOThiNDA1NDJmMjg2YjcyOTgzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKQEAgLTIyNywxMSArMjI3LDExIEBA IHZvaWQgUmVuZGVySW1hZ2U6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBj b25zdCBSZW5kZXJTdHlsZSogb2xkU3R5CiAgICAgICAgICAgICByZXBhaW50T3JNYXJrRm9yTGF5 b3V0KEltYWdlU2l6ZUNoYW5nZUZvckFsdFRleHQpOwogICAgICAgICBtX25lZWRzVG9TZXRTaXpl Rm9yQWx0VGV4dCA9IGZhbHNlOwogICAgIH0KLSAgICBpZiAoZGlmZiA9PSBTdHlsZURpZmZlcmVu Y2U6OkxheW91dCAmJiBvbGRTdHlsZS0+aW1hZ2VPcmllbnRhdGlvbigpICE9IHN0eWxlKCkuaW1h Z2VPcmllbnRhdGlvbigpKQorICAgIGlmIChkaWZmID09IFN0eWxlRGlmZmVyZW5jZTo6TGF5b3V0 ICYmIG9sZFN0eWxlICYmIG9sZFN0eWxlLT5pbWFnZU9yaWVudGF0aW9uKCkgIT0gc3R5bGUoKS5p bWFnZU9yaWVudGF0aW9uKCkpCiAgICAgICAgIHJldHVybiByZXBhaW50T3JNYXJrRm9yTGF5b3V0 KEltYWdlU2l6ZUNoYW5nZU5vbmUpOwogCiAjaWYgRU5BQkxFKENTU19JTUFHRV9SRVNPTFVUSU9O KQotICAgIGlmIChkaWZmID09IFN0eWxlRGlmZmVyZW5jZTo6TGF5b3V0CisgICAgaWYgKGRpZmYg PT0gU3R5bGVEaWZmZXJlbmNlOjpMYXlvdXQgJiYgb2xkU3R5bGUKICAgICAgICAgJiYgKG9sZFN0 eWxlLT5pbWFnZVJlc29sdXRpb24oKSAhPSBzdHlsZSgpLmltYWdlUmVzb2x1dGlvbigpCiAgICAg ICAgICAgICB8fCBvbGRTdHlsZS0+aW1hZ2VSZXNvbHV0aW9uU25hcCgpICE9IHN0eWxlKCkuaW1h Z2VSZXNvbHV0aW9uU25hcCgpCiAgICAgICAgICAgICB8fCBvbGRTdHlsZS0+aW1hZ2VSZXNvbHV0 aW9uU291cmNlKCkgIT0gc3R5bGUoKS5pbWFnZVJlc29sdXRpb25Tb3VyY2UoKSkpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5jcHAKaW5k ZXggYjZlMGFiYzcxOGQ1MmYwY2JlZDllMzY2YjY1YmQ3ZmQ1MDRjODFmYy4uY2ZlY2FlNDRkM2Rk ODg2YWQ2NDc0OTdiOWExMWI4NDBlNGQxNWQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyTW9kZWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmNwcApAQCAtMTQxLDcgKzE0MSw3IEBA IHZvaWQgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJl bmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0CiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKGxheWVy KCkgJiYgbGF5ZXIoKS0+cGFyZW50KCkpIHsKICNpZiBFTkFCTEUoQ1NTX0NPTVBPU0lUSU5HKQot ICAgICAgICBpZiAob2xkU3R5bGUtPmhhc0JsZW5kTW9kZSgpKQorICAgICAgICBpZiAob2xkU3R5 bGUgJiYgb2xkU3R5bGUtPmhhc0JsZW5kTW9kZSgpKQogICAgICAgICAgICAgbGF5ZXIoKS0+d2ls bFJlbW92ZUNoaWxkV2l0aEJsZW5kTW9kZSgpOwogI2VuZGlmCiAgICAgICAgIHNldEhhc1RyYW5z Zm9ybVJlbGF0ZWRQcm9wZXJ0eShmYWxzZSk7IC8vIEFsbCB0cmFuc2Zvcm0tcmVsYXRlZCBwcm9w ZXJ0aWVzIGZvcmNlIGxheWVycywgc28gd2Uga25vdyB3ZSBkb24ndCBoYXZlIG9uZSBvciB0aGUg b2JqZWN0IGRvZXNuJ3Qgc3VwcG9ydCB0aGVtLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJSZXBsYWNlZC5jcHAKaW5kZXggNjBjNjkwZWU5MmU5YzViZGY3MTcwODRmNjcxMWEwYWFi ZGZjNmEyZC4uMjU3MWI2NTQyYTQ2ZWI2NTVhMDMyZWQxZTlmMDFhZTc3ODY3MjAxZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwCkBAIC04NiwxMCArODYs OCBAQCB2b2lkIFJlbmRlclJlcGxhY2VkOjp3aWxsQmVEZXN0cm95ZWQoKQogdm9pZCBSZW5kZXJS ZXBsYWNlZDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRl clN0eWxlKiBvbGRTdHlsZSkKIHsKICAgICBSZW5kZXJCb3g6OnN0eWxlRGlkQ2hhbmdlKGRpZmYs IG9sZFN0eWxlKTsKLQotICAgIGJvb2wgaGFkU3R5bGUgPSAob2xkU3R5bGUgIT0gMCk7Ci0gICAg ZmxvYXQgb2xkWm9vbSA9IGhhZFN0eWxlID8gb2xkU3R5bGUtPmVmZmVjdGl2ZVpvb20oKSA6IFJl bmRlclN0eWxlOjppbml0aWFsWm9vbSgpOwotICAgIGlmIChzdHlsZSgpLmVmZmVjdGl2ZVpvb20o KSAhPSBvbGRab29tKQorICAgIGF1dG8gcHJldmlvdXNFZmZlY3RpdmVab29tID0gb2xkU3R5bGUg PyBvbGRTdHlsZS0+ZWZmZWN0aXZlWm9vbSgpIDogUmVuZGVyU3R5bGU6OmluaXRpYWxab29tKCk7 CisgICAgaWYgKHByZXZpb3VzRWZmZWN0aXZlWm9vbSAhPSBzdHlsZSgpLmVmZmVjdGl2ZVpvb20o KSkKICAgICAgICAgaW50cmluc2ljU2l6ZUNoYW5nZWQoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ29sLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUYWJsZUNvbC5jcHAKaW5kZXggY2NkOGU4YmY1ZWFlOTZjNjFlNjYz NmFkMTc4MDEyYjk4ZTRlMzY4Ny4uMWRjMDU3ZTZlYzBmZGU4ZDViNTE3MjFhYjc0MmU0Mjc2NjFi MTEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ29s LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDb2wuY3BwCkBA IC02Miw5ICs2MiwxMyBAQCB2b2lkIFJlbmRlclRhYmxlQ29sOjpzdHlsZURpZENoYW5nZShTdHls ZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZAogICAgIGlmICghdGFibGUp CiAgICAgICAgIHJldHVybjsKICAgICAvLyBJZiBib3JkZXIgd2FzIGNoYW5nZWQsIG5vdGlmeSB0 YWJsZS4KLSAgICBpZiAob2xkU3R5bGUgJiYgb2xkU3R5bGUtPmJvcmRlcigpICE9IHN0eWxlKCku Ym9yZGVyKCkpCisgICAgaWYgKCFvbGRTdHlsZSkKKyAgICAgICAgcmV0dXJuOworICAgIGlmIChv bGRTdHlsZS0+Ym9yZGVyKCkgIT0gc3R5bGUoKS5ib3JkZXIoKSkgewogICAgICAgICB0YWJsZS0+ aW52YWxpZGF0ZUNvbGxhcHNlZEJvcmRlcnMoKTsKLSAgICBlbHNlIGlmIChvbGRTdHlsZS0+d2lk dGgoKSAhPSBzdHlsZSgpLndpZHRoKCkpIHsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBp ZiAob2xkU3R5bGUtPndpZHRoKCkgIT0gc3R5bGUoKS53aWR0aCgpKSB7CiAgICAgICAgIHRhYmxl LT5yZWNhbGNTZWN0aW9uc0lmTmVlZGVkKCk7CiAgICAgICAgIGZvciAoYXV0byYgc2VjdGlvbiA6 IGNoaWxkcmVuT2ZUeXBlPFJlbmRlclRhYmxlU2VjdGlvbj4oKnRhYmxlKSkgewogICAgICAgICAg ICAgdW5zaWduZWQgbkVmZkNvbHMgPSB0YWJsZS0+bnVtRWZmQ29scygpOwo=