216386 2020-09-10 16:23:18 -0700 Don't assume byte code operands are uint32 JSValues 2020-09-14 09:51:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont jsc32 keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1687588 0 saam 2020-09-10 16:23:18 -0700 We might exit from DFG, and they may not be uint32s. 1687591 1 408495 saam 2020-09-10 16:32:40 -0700 Created attachment 408495 patch 1687595 2 408495 ysuzuki 2020-09-10 16:37:56 -0700 Comment on attachment 408495 patch r=me 1687646 3 408495 mark.lam 2020-09-10 20:29:17 -0700 Comment on attachment 408495 patch Nice. 1688276 4 ews-feeder 2020-09-14 09:46:07 -0700 Committed r267017: <https://trac.webkit.org/changeset/267017> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408495. 1688277 5 webkit-bug-importer 2020-09-14 09:47:17 -0700 <rdar://problem/68860613> 1688280 6 mark.lam 2020-09-14 09:51:31 -0700 <rdar://problem/68463767> 408495 2020-09-10 16:32:40 -0700 2020-09-14 09:46:08 -0700 patch b-backup.diff text/plain 4242 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjY4OTcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIwLTA5LTEwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERvbid0IGFzc3VtZSBieXRlIGNvZGUgb3BlcmFuZHMgYXJlIHVpbnQz MiBKU1ZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE2Mzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBzdHJlc3MvZG9udC1hc3N1bWUtYnl0ZWNvZGUtb3BlcmFuZC1pcy11aW50MzIuanM6IEFk ZGVkLgorICAgICAgICAoYXN5bmMgZm9vKToKKwogMjAyMC0wOS0xMCAgQWxleGV5IFNodmF5a2Eg IDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAgICAgICAgUHJvbWlzZS5wcm90b3R5cGUuZmlu YWxseSBzaG91bGQgcGVyZm9ybSBQcm9taXNlUmVzb2x2ZQpJbmRleDogSlNUZXN0cy9zdHJlc3Mv ZG9udC1hc3N1bWUtYnl0ZWNvZGUtb3BlcmFuZC1pcy11aW50MzIuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SlNUZXN0cy9zdHJlc3MvZG9udC1hc3N1bWUtYnl0ZWNvZGUtb3BlcmFuZC1pcy11aW50MzIuanMJ KG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZG9udC1hc3N1bWUtYnl0ZWNvZGUtb3Bl cmFuZC1pcy11aW50MzIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw5IEBACisvL0AgcnVu RGVmYXVsdCgiLS1zZWVkT2ZSYW5kb21pemluZ0Z1enplckFnZW50PTEiLCAiLS1qaXRQb2xpY3lT Y2FsZT0wIiwgIi0tdXNlV2lkZW5pbmdOdW1iZXJQcmVkaWN0aW9uRnV6emVyQWdlbnQ9MSIpCisK K2FzeW5jIGZ1bmN0aW9uIGZvbygpIHsKKyAgICBmb3IgKGxldCBxIGluICdhJy5yZXBlYXQoMTAw MCkpIHsKKyAgICAgIGF3YWl0IE1hdGguZmxvb3IoKTsgCisgICAgICBlZGVuR0MoKTsKKyAgICB9 Cit9Citmb28oKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY2ODk0 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDI1IEBACisyMDIwLTA5LTEwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29t PgorCisgICAgICAgIERvbid0IGFzc3VtZSBieXRlIGNvZGUgb3BlcmFuZHMgYXJlIHVpbnQzMiBK U1ZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE2Mzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIHNsb3cgcGF0aCBmb3IgZW51bWVyYXRvcl9nZW5lcmljX3BuYW1lIHdhcyBhc3N1bWluZyB0 aGF0IGl0cyBpbnB1dCBpbmRleCBvcGVyYW5kCisgICAgICAgIHdvdWxkIGFsd2F5cyBiZSBhIFVJ bnQzMiBKU1ZhbHVlIGJveGVkIGFzIGludDMyLiBIb3dldmVyLCB0aGlzIGFzc3VtcHRpb24gaXNu J3QgdHJ1ZQorICAgICAgICBiZWNhdXNlIHRoYXQgdmFsdWUgY2FuIGhhdmUgZG91YmxlIGZvcm1h dCBpbiB0aGUgREZHLCBhbmQgcmVtYWluIGluIHRoYXQgZm9ybWF0IHdoZW4KKyAgICAgICAgd2Ug ZXhpdCBmcm9tIHRoZSBERkcgdG8gYmFzZWxpbmUvTExJbnQgY29kZS4KKyAgICAgICAgCisgICAg ICAgIFRoaXMgd2FzIGZvdW5kIHZpYSB0aGUgd2lkZW5pbmcgbnVtYmVyIGZ1enppbmcgYWdlbnQu CisgICAgICAgIAorICAgICAgICBJIGFsc28gYXVkaXRlZCB0d28gbW9yZSBwbGFjZXMgdGhhdCBz ZWVtIGxpa2UgdGhleSBzdWZmZXIgZnJvbSB0aGUgc2FtZSBpc3N1ZSwKKyAgICAgICAgYW5kIGFs c28gc3dpdGNoZWQgdGhlbSB0byB1c2luZyB0aGUgYXNVSW50MzJBc0FueUludCBmdW5jdGlvbjoK KyAgICAgICAgLSBlbnVtZXJhdG9yX3N0cnVjdHVyZV9wbmFtZQorICAgICAgICAtIGNyZWF0ZV9y ZXN0CisKKyAgICAgICAgKiBydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHA6CisgICAgICAgIChK U0M6OlNMT1dfUEFUSF9ERUNMKToKKwogMjAyMC0wOS0xMCAgRGV2aW4gUm91c3NvICA8ZHJvdXNz b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbW9kZXJuaXplIGdlbmVyYXRl ZCBiYWNrZW5kIHByb3RvY29sIGNvZGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbW1vblNsb3dQYXRocy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAkocmV2aXNpb24gMjY2ODk0KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTE1NCw3ICsxMTU0LDcgQEAgU0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX2VudW1l cmF0b3Jfc3RydQogICAgIEJFR0lOKCk7CiAgICAgYXV0byBieXRlY29kZSA9IHBjLT5hczxPcEVu dW1lcmF0b3JTdHJ1Y3R1cmVQbmFtZT4oKTsKICAgICBKU1Byb3BlcnR5TmFtZUVudW1lcmF0b3Iq IGVudW1lcmF0b3IgPSBqc0Nhc3Q8SlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9yKj4oR0VUKGJ5dGVj b2RlLm1fZW51bWVyYXRvcikuanNWYWx1ZSgpLmFzQ2VsbCgpKTsKLSAgICB1aW50MzJfdCBpbmRl eCA9IEdFVChieXRlY29kZS5tX2luZGV4KS5qc1ZhbHVlKCkuYXNVSW50MzIoKTsKKyAgICB1aW50 MzJfdCBpbmRleCA9IEdFVChieXRlY29kZS5tX2luZGV4KS5qc1ZhbHVlKCkuYXNVSW50MzJBc0Fu eUludCgpOwogCiAgICAgSlNTdHJpbmcqIHByb3BlcnR5TmFtZSA9IG51bGxwdHI7CiAgICAgaWYg KGluZGV4IDwgZW51bWVyYXRvci0+ZW5kU3RydWN0dXJlUHJvcGVydHlJbmRleCgpKQpAQCAtMTE2 Nyw3ICsxMTY3LDcgQEAgU0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX2VudW1lcmF0b3JfZ2VuZQog ICAgIEJFR0lOKCk7CiAgICAgYXV0byBieXRlY29kZSA9IHBjLT5hczxPcEVudW1lcmF0b3JHZW5l cmljUG5hbWU+KCk7CiAgICAgSlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9yKiBlbnVtZXJhdG9yID0g anNDYXN0PEpTUHJvcGVydHlOYW1lRW51bWVyYXRvcio+KEdFVChieXRlY29kZS5tX2VudW1lcmF0 b3IpLmpzVmFsdWUoKS5hc0NlbGwoKSk7Ci0gICAgdWludDMyX3QgaW5kZXggPSBHRVQoYnl0ZWNv ZGUubV9pbmRleCkuanNWYWx1ZSgpLmFzVUludDMyKCk7CisgICAgdWludDMyX3QgaW5kZXggPSBH RVQoYnl0ZWNvZGUubV9pbmRleCkuanNWYWx1ZSgpLmFzVUludDMyQXNBbnlJbnQoKTsKIAogICAg IEpTU3RyaW5nKiBwcm9wZXJ0eU5hbWUgPSBudWxscHRyOwogICAgIGlmIChlbnVtZXJhdG9yLT5l bmRTdHJ1Y3R1cmVQcm9wZXJ0eUluZGV4KCkgPD0gaW5kZXggJiYgaW5kZXggPCBlbnVtZXJhdG9y LT5lbmRHZW5lcmljUHJvcGVydHlJbmRleCgpKQpAQCAtMTI4NCw3ICsxMjg0LDcgQEAgU0xPV19Q QVRIX0RFQ0woc2xvd19wYXRoX2NyZWF0ZV9yZXN0KQogewogICAgIEJFR0lOKCk7CiAgICAgYXV0 byBieXRlY29kZSA9IHBjLT5hczxPcENyZWF0ZVJlc3Q+KCk7Ci0gICAgdW5zaWduZWQgYXJyYXlT aXplID0gR0VUX0MoYnl0ZWNvZGUubV9hcnJheVNpemUpLmpzVmFsdWUoKS5hc1VJbnQzMigpOwor ICAgIHVuc2lnbmVkIGFycmF5U2l6ZSA9IEdFVF9DKGJ5dGVjb2RlLm1fYXJyYXlTaXplKS5qc1Zh bHVlKCkuYXNVSW50MzJBc0FueUludCgpOwogICAgIFN0cnVjdHVyZSogc3RydWN0dXJlID0gZ2xv YmFsT2JqZWN0LT5yZXN0UGFyYW1ldGVyU3RydWN0dXJlKCk7CiAgICAgdW5zaWduZWQgbnVtUGFy YW1zVG9Ta2lwID0gYnl0ZWNvZGUubV9udW1QYXJhbWV0ZXJzVG9Ta2lwOwogICAgIEpTVmFsdWUq IGFyZ3VtZW50c1RvQ29weVJlZ2lvbiA9IGNhbGxGcmFtZS0+YWRkcmVzc09mQXJndW1lbnRzU3Rh cnQoKSArIG51bVBhcmFtc1RvU2tpcDsK