216384 2020-09-10 16:03:31 -0700 [JSC] Add exception checks to JSCallbackObject 2020-09-10 23:25:09 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1687580 0 ysuzuki 2020-09-10 16:03:31 -0700 [JSC] Add exception checks to JSCallbackObject 1687583 1 408491 ysuzuki 2020-09-10 16:04:11 -0700 Created attachment 408491 Patch 1687584 2 ysuzuki 2020-09-10 16:04:14 -0700 <rdar://problem/68632190> 1687663 3 ews-feeder 2020-09-10 23:25:09 -0700 Committed r266910: <https://trac.webkit.org/changeset/266910> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408491. 408491 2020-09-10 16:04:11 -0700 2020-09-10 23:25:09 -0700 Patch bug-216384-20200910160410.patch text/plain 7585 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ODAwZTY0MzdmNTNjN2U2MTI2NWQ3MGZiN2ZjODUzNTc0ZjM5ZjM0Li5lYTE4YTEzYzkzNTYzYTM4 MGEzMDRiZjU2MzIyZTcwZjgwYzlmMzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAyMC0wOS0xMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBleGNlcHRpb24gY2hlY2tzIHRvIEpTQ2FsbGJhY2tPYmpl Y3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjM4 NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjg2MzIxOTA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIG5lY2Vzc2FyeSBl eGNlcHRpb24gY2hlY2tzIHRvIEpTQ2FsbGJhY2tPYmplY3QgdG8gc3VwcHJlc3MgZXhjZXB0aW9u IHZlcmlmaWVyIGNyYXNoIGluIERlYnVnIGJ1aWxkLgorCisgICAgICAgICogQVBJL0pTQ2FsbGJh Y2tPYmplY3RGdW5jdGlvbnMuaDoKKyAgICAgICAgKEpTQzo6SlNDYWxsYmFja09iamVjdDxQYXJl bnQ+OjpnZXRPd25Qcm9wZXJ0eVNsb3QpOgorICAgICAgICAoSlNDOjpKU0NhbGxiYWNrT2JqZWN0 PFBhcmVudD46OmRlZmF1bHRWYWx1ZSk6CisgICAgICAgIChKU0M6OkpTQ2FsbGJhY2tPYmplY3Q8 UGFyZW50Pjo6cHV0KToKKyAgICAgICAgKEpTQzo6SlNDYWxsYmFja09iamVjdDxQYXJlbnQ+Ojpw dXRCeUluZGV4KToKKyAgICAgICAgKEpTQzo6SlNDYWxsYmFja09iamVjdDxQYXJlbnQ+OjpkZWxl dGVQcm9wZXJ0eSk6CisgICAgICAgIChKU0M6OkpTQ2FsbGJhY2tPYmplY3Q8UGFyZW50Pjo6c3Rh dGljRnVuY3Rpb25HZXR0ZXIpOgorCiAyMDIwLTA5LTEwICBEZXZpbiBSb3Vzc28gIDxkcm91c3Nv QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtb2Rlcm5pemUgZ2VuZXJhdGVk IGJhY2tlbmQgcHJvdG9jb2wgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMuaAppbmRleCAxYjllYjliNzE3ZTE2NzBmN2Y1 YWUxZjA0OWU2MjU3YTdjNTUxMDBmLi40NWU2YWVmOTliOTA2NTBkNTBkNmY0NGVjYzFhNjk3MTZi NjA1MTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tP YmplY3RGdW5jdGlvbnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJh Y2tPYmplY3RGdW5jdGlvbnMuaApAQCAtMTk1LDYgKzE5NSw3IEBAIGJvb2wgSlNDYWxsYmFja09i amVjdDxQYXJlbnQ+OjpnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPYmplY3QqIG9iamVjdCwgSlNHbG9i YWxPYmplCiAgICAgICAgICAgICBpZiAoT3BhcXVlSlNDbGFzc1N0YXRpY1ZhbHVlc1RhYmxlKiBz dGF0aWNWYWx1ZXMgPSBqc0NsYXNzLT5zdGF0aWNWYWx1ZXMoZ2xvYmFsT2JqZWN0KSkgewogICAg ICAgICAgICAgICAgIGlmIChzdGF0aWNWYWx1ZXMtPmNvbnRhaW5zKG5hbWUpKSB7CiAgICAgICAg ICAgICAgICAgICAgIEpTVmFsdWUgdmFsdWUgPSB0aGlzT2JqZWN0LT5nZXRTdGF0aWNWYWx1ZShn bG9iYWxPYmplY3QsIHByb3BlcnR5TmFtZSk7CisgICAgICAgICAgICAgICAgICAgIFJFVFVSTl9J Rl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbHVl KSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBzbG90LnNldFZhbHVlKHRoaXNPYmplY3QsIFBy b3BlcnR5QXR0cmlidXRlOjpSZWFkT25seSB8IFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSwg dmFsdWUpOwogICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0yMTEsNyAr MjEyLDcgQEAgYm9vbCBKU0NhbGxiYWNrT2JqZWN0PFBhcmVudD46OmdldE93blByb3BlcnR5U2xv dChKU09iamVjdCogb2JqZWN0LCBKU0dsb2JhbE9iamUKICAgICAgICAgfQogICAgIH0KIAotICAg IHJldHVybiBQYXJlbnQ6OmdldE93blByb3BlcnR5U2xvdCh0aGlzT2JqZWN0LCBnbG9iYWxPYmpl Y3QsIHByb3BlcnR5TmFtZSwgc2xvdCk7CisgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBQ YXJlbnQ6OmdldE93blByb3BlcnR5U2xvdCh0aGlzT2JqZWN0LCBnbG9iYWxPYmplY3QsIHByb3Bl cnR5TmFtZSwgc2xvdCkpOwogfQogCiB0ZW1wbGF0ZSA8Y2xhc3MgUGFyZW50PgpAQCAtMjQ1LDcg KzI0Niw3IEBAIEpTVmFsdWUgSlNDYWxsYmFja09iamVjdDxQYXJlbnQ+OjpkZWZhdWx0VmFsdWUo Y29uc3QgSlNPYmplY3QqIG9iamVjdCwgSlNHbG9iYWxPCiAgICAgICAgIH0KICAgICB9CiAgICAg Ci0gICAgcmV0dXJuIFBhcmVudDo6ZGVmYXVsdFZhbHVlKG9iamVjdCwgZ2xvYmFsT2JqZWN0LCBo aW50KTsKKyAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIFBhcmVudDo6ZGVmYXVsdFZhbHVl KG9iamVjdCwgZ2xvYmFsT2JqZWN0LCBoaW50KSk7CiB9CiAKIHRlbXBsYXRlIDxjbGFzcyBQYXJl bnQ+CkBAIC0zMDAsOSArMzAxLDEwIEBAIGJvb2wgSlNDYWxsYmFja09iamVjdDxQYXJlbnQ+Ojpw dXQoSlNDZWxsKiBjZWxsLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQCiAgICAgICAg ICAgICAgICAgaWYgKFN0YXRpY0Z1bmN0aW9uRW50cnkqIGVudHJ5ID0gc3RhdGljRnVuY3Rpb25z LT5nZXQobmFtZSkpIHsKICAgICAgICAgICAgICAgICAgICAgUHJvcGVydHlTbG90IGdldFNsb3Qo dGhpc09iamVjdCwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OlZNSW5xdWlyeSwg JnZtKTsKICAgICAgICAgICAgICAgICAgICAgYm9vbCBmb3VuZCA9IFBhcmVudDo6Z2V0T3duUHJv cGVydHlTbG90KHRoaXNPYmplY3QsIGdsb2JhbE9iamVjdCwgcHJvcGVydHlOYW1lLCBnZXRTbG90 KTsKKyAgICAgICAgICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZmFsc2Up OwogICAgICAgICAgICAgICAgICAgICBnZXRTbG90LmRpc2FsbG93Vk1FbnRyeS5yZXNldCgpOwog ICAgICAgICAgICAgICAgICAgICBpZiAoZm91bmQpCi0gICAgICAgICAgICAgICAgICAgICAgICBy ZXR1cm4gUGFyZW50OjpwdXQodGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eU5hbWUs IHZhbHVlLCBzbG90KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIFJFTEVBU0VfQU5EX1JFVFVS TihzY29wZSwgUGFyZW50OjpwdXQodGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eU5h bWUsIHZhbHVlLCBzbG90KSk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChlbnRyeS0+YXR0cmli dXRlcyAmIGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkpCiAgICAgICAgICAgICAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0aGlzT2JqZWN0 LT5KU0NhbGxiYWNrT2JqZWN0PFBhcmVudD46OnB1dERpcmVjdCh2bSwgcHJvcGVydHlOYW1lLCB2 YWx1ZSk7IC8vIHB1dCBhcyBvdmVycmlkZSBwcm9wZXJ0eQpAQCAtMzExLDcgKzMxMyw3IEBAIGJv b2wgSlNDYWxsYmFja09iamVjdDxQYXJlbnQ+OjpwdXQoSlNDZWxsKiBjZWxsLCBKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0LCBQCiAgICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gUGFy ZW50OjpwdXQodGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eU5hbWUsIHZhbHVlLCBz bG90KTsKKyAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIFBhcmVudDo6cHV0KHRoaXNPYmpl Y3QsIGdsb2JhbE9iamVjdCwgcHJvcGVydHlOYW1lLCB2YWx1ZSwgc2xvdCkpOwogfQogCiB0ZW1w bGF0ZSA8Y2xhc3MgUGFyZW50PgpAQCAtMzcxLDcgKzM3Myw3IEBAIGJvb2wgSlNDYWxsYmFja09i amVjdDxQYXJlbnQ+OjpwdXRCeUluZGV4KEpTQ2VsbCogY2VsbCwgSlNHbG9iYWxPYmplY3QqIGds b2JhbE9iCiAgICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gUGFyZW50OjpwdXRCeUluZGV4 KHRoaXNPYmplY3QsIGdsb2JhbE9iamVjdCwgcHJvcGVydHlJbmRleCwgdmFsdWUsIHNob3VsZFRo cm93KTsKKyAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIFBhcmVudDo6cHV0QnlJbmRleCh0 aGlzT2JqZWN0LCBnbG9iYWxPYmplY3QsIHByb3BlcnR5SW5kZXgsIHZhbHVlLCBzaG91bGRUaHJv dykpOwogfQogCiB0ZW1wbGF0ZSA8Y2xhc3MgUGFyZW50PgpAQCAtNDIyLDggKzQyNCw4IEBAIGJv b2wgSlNDYWxsYmFja09iamVjdDxQYXJlbnQ+OjpkZWxldGVQcm9wZXJ0eShKU0NlbGwqIGNlbGws IEpTR2xvYmFsT2JqZWN0KiBnbG9iCiAKICAgICBzdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfZmluYWxf djxKU0NhbGxiYWNrT2JqZWN0PFBhcmVudD4+LCAiRW5zdXJlIG5vIGRlcml2ZWQgY2xhc3NlcyBo YXZlIGN1c3RvbSBkZWxldGVQcm9wZXJ0eUJ5SW5kZXggaW1wbGVtZW50YXRpb24iKTsKICAgICBp ZiAoT3B0aW9uYWw8dWludDMyX3Q+IGluZGV4ID0gcGFyc2VJbmRleChwcm9wZXJ0eU5hbWUpKQot ICAgICAgICByZXR1cm4gUGFyZW50OjpkZWxldGVQcm9wZXJ0eUJ5SW5kZXgodGhpc09iamVjdCwg Z2xvYmFsT2JqZWN0LCBpbmRleC52YWx1ZSgpKTsKLSAgICByZXR1cm4gUGFyZW50OjpkZWxldGVQ cm9wZXJ0eSh0aGlzT2JqZWN0LCBnbG9iYWxPYmplY3QsIHByb3BlcnR5TmFtZSwgc2xvdCk7Cisg ICAgICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29wZSwgUGFyZW50OjpkZWxldGVQcm9wZXJ0eUJ5 SW5kZXgodGhpc09iamVjdCwgZ2xvYmFsT2JqZWN0LCBpbmRleC52YWx1ZSgpKSk7CisgICAgUkVM RUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBQYXJlbnQ6OmRlbGV0ZVByb3BlcnR5KHRoaXNPYmplY3Qs IGdsb2JhbE9iamVjdCwgcHJvcGVydHlOYW1lLCBzbG90KSk7CiB9CiAKIHRlbXBsYXRlIDxjbGFz cyBQYXJlbnQ+CkBAIC02NzIsNiArNjc0LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDYWxsYmFja09i amVjdDxQYXJlbnQ+OjpzdGF0aWNGdW5jdGlvbkdldHRlcihKU0dsb2JhbE9iamVjdCogZ2wKICAg ICAvLyBDaGVjayBmb3IgY2FjaGVkIG9yIG92ZXJyaWRlIHByb3BlcnR5LgogICAgIFByb3BlcnR5 U2xvdCBzbG90Mih0aGlzT2JqLCBQcm9wZXJ0eVNsb3Q6OkludGVybmFsTWV0aG9kVHlwZTo6Vk1J bnF1aXJ5LCAmdm0pOwogICAgIGJvb2wgZm91bmQgPSBQYXJlbnQ6OmdldE93blByb3BlcnR5U2xv dCh0aGlzT2JqLCBnbG9iYWxPYmplY3QsIHByb3BlcnR5TmFtZSwgc2xvdDIpOworICAgIFJFVFVS Tl9JRl9FWENFUFRJT04oc2NvcGUsIHsgfSk7CiAgICAgc2xvdDIuZGlzYWxsb3dWTUVudHJ5LnJl c2V0KCk7CiAgICAgaWYgKGZvdW5kKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHNs b3QyLmdldFZhbHVlKGdsb2JhbE9iamVjdCwgcHJvcGVydHlOYW1lKSk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmFmNzA3 YmY1MjMyYTA3ZDc5YTA3ZGI2NmVlZmY1OTJhZDQ5NmFiMS4uMWUxYmU5Zjk4YTdjMDJkNmQzYzg0 ZmMzMzkxZDcyNTM3MzIyN2YzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTEwICBZ dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gQWRkIGV4 Y2VwdGlvbiBjaGVja3MgdG8gSlNDYWxsYmFja09iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2Mzg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82ODYzMjE5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGpzL2RvbS90by1wcmltaXRpdmUtZXhjZXB0aW9uLWluLWNhbGxiYWNrLW9iamVjdC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL2RvbS90by1wcmltaXRpdmUtZXhjZXB0 aW9uLWluLWNhbGxiYWNrLW9iamVjdC5odG1sOiBBZGRlZC4KKwogMjAyMC0wOS0xMCAgWmFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gQ29uc3RydWN0 IExpbmVCb3g6OklubGluZUJveGVzIGZvciBuZXN0ZWQgaW5saW5lIGxldmVsIGJveGVzIHdoZW4g dGhleSBvdmVybGFwIG11bHRpcGxlIGxpbmVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9k b20vdG8tcHJpbWl0aXZlLWV4Y2VwdGlvbi1pbi1jYWxsYmFjay1vYmplY3QtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvanMvZG9tL3RvLXByaW1pdGl2ZS1leGNlcHRpb24taW4tY2FsbGJhY2st b2JqZWN0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40M2U1ZWVlZGJmMWI0MzVmOTZjM2EyMGJm ODE0MDFhZWU0MzMxOTgxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvanMvZG9tL3Rv LXByaW1pdGl2ZS1leGNlcHRpb24taW4tY2FsbGJhY2stb2JqZWN0LWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDQgQEAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9kb20vdG8tcHJpbWl0aXZlLWV4Y2Vw dGlvbi1pbi1jYWxsYmFjay1vYmplY3QuaHRtbCBiL0xheW91dFRlc3RzL2pzL2RvbS90by1wcmlt aXRpdmUtZXhjZXB0aW9uLWluLWNhbGxiYWNrLW9iamVjdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmVjMWNl MzhmZjJkNjZhNjMzMDkzYmFjZjYwZTY1MGRiZTY2YjU5NjgKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9qcy9kb20vdG8tcHJpbWl0aXZlLWV4Y2VwdGlvbi1pbi1jYWxsYmFjay1vYmpl Y3QuaHRtbApAQCAtMCwwICsxLDE3IEBACis8aHRtbD4KKzwhRE9DVFlQRSBodG1sPjwhLS0gd2Vi a2l0LXRlc3QtcnVubmVyIFsganNjT3B0aW9ucz0tLXZhbGlkYXRlRXhjZXB0aW9uQ2hlY2tzPXRy dWUgXSAtLT4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4KK35hY2Nl c3NpYmlsaXR5Q29udHJvbGxlcjsKK35ldmVudFNlbmRlcjsKK35HQ0NvbnRyb2xsZXI7Cit+dGV4 dElucHV0Q29udHJvbGxlcjsKK350ZXN0UnVubmVyOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==