216376 2020-09-10 13:11:08 -0700 Assertion Failed: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion 2020-09-11 21:01:16 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser sihui_liu ap cdumez hector_i_lopez sihui_liu simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1687516 0 simon.fraser 2020-09-10 13:11:08 -0700 At r266884 I get an assertion when running compositing/iframes/remove-reinsert-webview-with-iframe.html in macOS WK2 WTR: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [13975] VM Regions Near 0xbbadbeef: --> __TEXT 000000010d61d000-000000010d719000 [ 1008K] r-x/r-x SM=COW /Volumes/VOLUME/* Application Specific Information: CRASHING TEST: compositing/iframes/remove-reinsert-webview-with-iframe.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010d99417e WTFCrash + 14 (Assertions.cpp:295) 1 WebKitTestRunner 0x000000010d63f95b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 WebKitTestRunner 0x000000010d6abb7c WTR::UIScriptContext::requestUIScriptCompletion(OpaqueJSString*) + 108 (UIScriptContext.cpp:160) 3 WebKitTestRunner 0x000000010d6ababf WTR::UIScriptContext::runUIScript(WTF::String const&, unsigned int) + 239 (UIScriptContext.cpp:71) 4 WebKitTestRunner 0x000000010d6a5293 WTR::TestInvocation::runUISideScript(OpaqueWKString const*, unsigned int) + 163 (TestInvocation.cpp:1900) 5 WebKitTestRunner 0x000000010d69f5c4 WTR::TestInvocation::runUISideScriptImmediately(OpaqueWKError const*, void*) + 196 (TestInvocation.cpp:1885) 6 WebKitTestRunner 0x000000010d69f4ed WTR::TestInvocation::runUISideScriptAfterUpdateCallback(OpaqueWKError const*, void*) + 29 (TestInvocation.cpp:1891) 7 com.apple.WebKit 0x000000011b9678f7 WKPageCallAfterNextPresentationUpdate::$_5::operator()(WebKit::CallbackBase::Error) const + 119 (WKPage.cpp:2896) 8 com.apple.WebKit 0x000000011b967851 WTF::Detail::CallableWrapper<WKPageCallAfterNextPresentationUpdate::$_5, void, WebKit::CallbackBase::Error>::call(WebKit::CallbackBase::Error) + 49 (Function.h:52) 9 com.apple.WebKit 0x000000011b702d08 WTF::Function<void (WebKit::CallbackBase::Error)>::operator()(WebKit::CallbackBase::Error) const + 152 (Function.h:83) 10 com.apple.WebKit 0x000000011b70f265 WebKit::GenericCallback<>::performCallbackWithReturnValue() + 229 (GenericCallback.h:109) 11 com.apple.WebKit 0x000000011b702125 WebKit::GenericCallback<>::performCallback() + 21 (GenericCallback.h:115) 12 com.apple.WebKit 0x000000011b976109 WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchPresentationCallbacksAfterFlushingLayers(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) + 201 (TiledCoreAnimationDrawingAreaProxy.mm:221) 13 com.apple.WebKit 0x000000011a8fcf50 void IPC::callMemberFunctionImpl<WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&), std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, 0ul>(WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&), std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >&&, std::__1::integer_sequence<unsigned long, 0ul>) + 160 (HandleMessage.h:42) 14 com.apple.WebKit 0x000000011a8fac50 void IPC::callMemberFunction<WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&), std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >&&, WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)) + 112 (HandleMessage.h:48) 15 com.apple.WebKit 0x000000011a8f90ad void IPC::handleMessage<Messages::DrawingAreaProxy::DispatchPresentationCallbacksAfterFlushingLayers, WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)>(IPC::Decoder&, WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)) + 157 (HandleMessage.h:121) 16 com.apple.WebKit 0x000000011a8f8cee WebKit::DrawingAreaProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 318 (DrawingAreaProxyMessageReceiver.cpp:58) 17 com.apple.WebKit 0x000000011a9631b1 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 305 (MessageReceiverMap.cpp:124) 18 com.apple.WebKit 0x000000011b5727ae WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 46 (AuxiliaryProcessProxy.cpp:209) 19 com.apple.WebKit 0x000000011b7b192f WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 47 (WebProcessProxy.cpp:772) 20 com.apple.WebKit 0x000000011a8a981f IPC::Connection::dispatchMessage(IPC::Decoder&) + 431 (Connection.cpp:1002) 21 com.apple.WebKit 0x000000011a8aa150 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 528 22 com.apple.WebKit 0x000000011a8a89a1 IPC::Connection::dispatchIncomingMessages() + 913 (Connection.cpp:1174) 23 com.apple.WebKit 0x000000011a8c9242 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7::operator()() + 66 (Connection.cpp:976) 24 com.apple.WebKit 0x000000011a8c916e WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7, void>::call() + 30 (Function.h:52) 25 com.apple.JavaScriptCore 0x000000010d9bc032 WTF::Function<void ()>::operator()() const + 130 (Function.h:83) 26 com.apple.JavaScriptCore 0x000000010da2e565 WTF::RunLoop::performWork() + 341 (RunLoop.cpp:124) 27 com.apple.JavaScriptCore 0x000000010da31cf1 WTF::RunLoop::performWork(void*) + 33 (RunLoopCF.cpp:47) 28 com.apple.CoreFoundation 0x00007fff34dc7d52 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 29 com.apple.CoreFoundation 0x00007fff34dc7cf1 __CFRunLoopDoSource0 + 103 30 com.apple.CoreFoundation 0x00007fff34dc7b0b __CFRunLoopDoSources0 + 209 31 com.apple.CoreFoundation 0x00007fff34dc683a __CFRunLoopRun + 927 32 com.apple.CoreFoundation 0x00007fff34dc5e3e CFRunLoopRunSpecific + 462 33 com.apple.Foundation 0x00007fff374611c8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212 34 WebKitTestRunner 0x000000010d69452e WTR::TestController::platformRunUntil(bool&, WTF::Seconds) + 302 (TestControllerCocoa.mm:223) 35 WebKitTestRunner 0x000000010d6518ef WTR::TestController::runUntil(bool&, WTF::Seconds) + 79 (TestController.cpp:1907) 36 WebKitTestRunner 0x000000010d69973a WTR::TestInvocation::invoke() + 458 (TestInvocation.cpp:185) 37 WebKitTestRunner 0x000000010d65b8c6 WTR::TestController::runTest(char const*) + 534 (TestController.cpp:1836) 38 WebKitTestRunner 0x000000010d65c366 WTR::TestController::runTestingServerLoop() + 214 (TestController.cpp:1882) 39 WebKitTestRunner 0x000000010d6522f7 WTR::TestController::run() + 39 (TestController.cpp:1890) 40 WebKitTestRunner 0x000000010d651c4f WTR::TestController::TestController(int, char const**) + 831 (TestController.cpp:168) 41 WebKitTestRunner 0x000000010d6523c3 WTR::TestController::TestController(int, char const**) + 35 (TestController.cpp:169) 42 WebKitTestRunner 0x000000010d6242cc main + 108 (main.mm:70) 43 libdyld.dylib 0x00007fff6ee98cc9 start + 1 1687600 1 408498 sihui_liu 2020-09-10 16:50:50 -0700 Created attachment 408498 Patch 1687762 2 408546 sihui_liu 2020-09-11 10:37:16 -0700 Created attachment 408546 Patch 1687820 3 hector_i_lopez 2020-09-11 15:05:43 -0700 pageoverlay/overlay-remove-reinsert-view.html Test is also hitting same ASSERTION FAILURE. First occurrence of a crash is at r266895. History: https://results.webkit.org/?suite=layout-tests&test=pageoverlay%2Foverlay-remove-reinsert-view.html StdErr: ASSERTION FAILED: m_currentScriptCallbackID /Volumes/Data/slave/catalina-debug/build/Tools/TestRunnerShared/UIScriptContext/UIScriptContext.cpp(160) : void WTR::UIScriptContext::requestUIScriptCompletion(JSStringRef) 1 0x106e002a9 WTFCrash 2 0x1023b14ab WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10242339c WTR::UIScriptContext::requestUIScriptCompletion(OpaqueJSString*) 4 0x1024232df WTR::UIScriptContext::runUIScript(WTF::String const&, unsigned int) 5 0x10241af23 WTR::TestInvocation::runUISideScript(OpaqueWKString const*, unsigned int) 6 0x102415254 WTR::TestInvocation::runUISideScriptImmediately(OpaqueWKError const*, void*) 7 0x10241517d WTR::TestInvocation::runUISideScriptAfterUpdateCallback(OpaqueWKError const*, void*) 8 0x10f459a27 WKPageCallAfterNextPresentationUpdate::$_5::operator()(WebKit::CallbackBase::Error) const 9 0x10f459981 WTF::Detail::CallableWrapper<WKPageCallAfterNextPresentationUpdate::$_5, void, WebKit::CallbackBase::Error>::call(WebKit::CallbackBase::Error) 10 0x10f1e7e38 WTF::Function<void (WebKit::CallbackBase::Error)>::operator()(WebKit::CallbackBase::Error) const 11 0x10f1f5205 WebKit::GenericCallback<>::performCallbackWithReturnValue() 12 0x10f1e7255 WebKit::GenericCallback<>::performCallback() 13 0x10f468279 WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchPresentationCallbacksAfterFlushingLayers(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 14 0x10e3b1df0 void IPC::callMemberFunctionImpl<WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&), std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, 0ul>(WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&), std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >&&, std::__1::integer_sequence<unsigned long, 0ul>) 15 0x10e3af980 void IPC::callMemberFunction<WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&), std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >&&, WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)) 16 0x10e3add3d void IPC::handleMessage<Messages::DrawingAreaProxy::DispatchPresentationCallbacksAfterFlushingLayers, WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)>(IPC::Decoder&, WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)) 17 0x10e3ad97e WebKit::DrawingAreaProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 18 0x10e418121 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 19 0x10f0512ce WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 20 0x10f29862f WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 21 0x10e35ca7f IPC::Connection::dispatchMessage(IPC::Decoder&) 22 0x10e35d3b0 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 23 0x10e35bc01 IPC::Connection::dispatchIncomingMessages() 24 0x10e37cfe2 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7::operator()() 25 0x10e37cf0e WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7, void>::call() 26 0x106e2b792 WTF::Function<void ()>::operator()() const 27 0x106ea9025 WTF::RunLoop::performWork() 28 0x106ead6b1 WTF::RunLoop::performWork(void*) 29 0x7fff2f1fbd52 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 30 0x7fff2f1fbcf1 __CFRunLoopDoSource0 I was able to reproduce crash at r266889 but the spade before that is gapped at r266827 at which test passes run-webkit-tests pageoverlay/overlay-remove-reinsert-view.html --iterations 100 --exit-after-n-failures 3 1687893 4 ews-feeder 2020-09-11 21:00:57 -0700 Committed r266971: <https://trac.webkit.org/changeset/266971> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408546. 1687894 5 webkit-bug-importer 2020-09-11 21:01:16 -0700 <rdar://problem/68748403> 408498 2020-09-10 16:50:50 -0700 2020-09-11 10:37:14 -0700 Patch bug-216376-20200910165048.patch text/plain 2526 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2ODg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTM1ODlmYzM0NWYwNzkxNjJlYjg4YmU5NDY3NDRmYTdk YTZiNjBjNi4uZDJmNDZhNTQ1MmRkMDZkMGE3YWNjNzVlNjYxY2RjZDViNWIzOWNmMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA5LTEwICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIEFzc2VydGlvbiBGYWlsZWQ6IG1fY3VycmVudFNjcmlwdENhbGxiYWNrSUQgaW4gVUlTY3Jp cHRDb250ZXh0OjpyZXF1ZXN0VUlTY3JpcHRDb21wbGV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYzNzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgYXN5bmMgdGFzayBpcyBhY3R1 YWxseSBhc3luYywgb3RoZXJ3aXNlIHRoZSBVSVNjcmlwdCBtYXkgYmUgZW5kZWQgYmVmb3JlIGFs bCB0YXNrcyBhcmUgZXhlY3V0ZWQuCisKKyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2Ny aXB0Q29udGV4dC9VSVNjcmlwdENvbnRleHQuY3BwOgorICAgICAgICAoVUlTY3JpcHRDb250ZXh0 OjpydW5VSVNjcmlwdCk6CisKIDIwMjAtMDktMTAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1vZGVybml6ZSBnZW5lcmF0ZWQgYmFj a2VuZCBwcm90b2NvbCBjb2RlCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2Nv Y29hL1VJU2NyaXB0Q29udHJvbGxlckNvY29hLm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9j b2NvYS9VSVNjcmlwdENvbnRyb2xsZXJDb2NvYS5tbQppbmRleCA3MmQzYjhlNWI1MmRkOWYxYTIy NDJlZmExMTRiN2ExOWI4MzdkOGZkLi41NDFiNTA0ODc5NWJiMGNmMjFhM2Y3YzFmMGU0MjA3MTdi MDkzZjZmIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29hL1VJU2NyaXB0 Q29udHJvbGxlckNvY29hLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvY29jb2EvVUlT Y3JpcHRDb250cm9sbGVyQ29jb2EubW0KQEAgLTk4LDExICs5OCwyMiBAQCB2b2lkIFVJU2NyaXB0 Q29udHJvbGxlckNvY29hOjpyZW1vdmVWaWV3RnJvbVdpbmRvdyhKU1ZhbHVlUmVmIGNhbGxiYWNr KQogICAgIG1haW5XZWJWaWV3LT5yZW1vdmVGcm9tV2luZG93KCk7CiAKICNpZiBQTEFURk9STShN QUMpCisgICAgX19ibG9jayBib29sIGlzQXN5bmMgPSBmYWxzZTsKICAgICBbbWFpbldlYlZpZXct PnBsYXRmb3JtVmlldygpIF9kb0FmdGVyQWN0aXZpdHlTdGF0ZVVwZGF0ZTpeewogICAgICAgICBp ZiAoIW1fY29udGV4dCkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgbV9jb250ZXh0LT5h c3luY1Rhc2tDb21wbGV0ZShjYWxsYmFja0lEKTsKKworICAgICAgICBpZiAoaXNBc3luYykgewor ICAgICAgICAgICAgbV9jb250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShjYWxsYmFja0lEKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgZGlzcGF0Y2hf YXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXnsKKyAgICAgICAgICAgIGlmIChtX2Nv bnRleHQpCisgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShjYWxs YmFja0lEKTsKKyAgICAgICAgfSk7CiAgICAgfV07CisgICAgaXNBc3luYyA9IHRydWU7CiAjZW5k aWYgLy8gUExBVEZPUk0oTUFDKQogfQogCkBAIC0xMTgsMTEgKzEyOSwyMiBAQCB2b2lkIFVJU2Ny aXB0Q29udHJvbGxlckNvY29hOjphZGRWaWV3VG9XaW5kb3coSlNWYWx1ZVJlZiBjYWxsYmFjaykK ICAgICBtYWluV2ViVmlldy0+YWRkVG9XaW5kb3coKTsKIAogI2lmIFBMQVRGT1JNKE1BQykKKyAg ICBfX2Jsb2NrIGJvb2wgaXNBc3luYyA9IGZhbHNlOwogICAgIFttYWluV2ViVmlldy0+cGxhdGZv cm1WaWV3KCkgX2RvQWZ0ZXJBY3Rpdml0eVN0YXRlVXBkYXRlOl57CiAgICAgICAgIGlmICghbV9j b250ZXh0KQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBtX2NvbnRleHQtPmFzeW5jVGFz a0NvbXBsZXRlKGNhbGxiYWNrSUQpOworCisgICAgICAgIGlmIChpc0FzeW5jKSB7CisgICAgICAg ICAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxiYWNrSUQpOworICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIAorICAgICAgICBkaXNwYXRjaF9hc3luYyhk aXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBeeworICAgICAgICAgICAgaWYgKG1fY29udGV4dCkK KyAgICAgICAgICAgICAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxiYWNrSUQp OworICAgICAgICB9KTsKICAgICB9XTsKKyAgICBpc0FzeW5jID0gdHJ1ZTsKICNlbmRpZiAvLyBQ TEFURk9STShNQUMpCiB9CiAK 408546 2020-09-11 10:37:16 -0700 2020-09-11 21:00:57 -0700 Patch bug-216376-20200911103715.patch text/plain 3709 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2OTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTUzYzMyMjcyYTkwODZiNjY4ZDM2YjA5ZmQ1ODc4Zjkx MWUxMWVmMS4uNGE2MDZmMzIwMzg5Mjg1Njc2MDAwOWYyN2Q3MTJmZDUxMzA2NWVhMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIwLTA5LTExICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIEFzc2VydGlvbiBGYWlsZWQ6IG1fY3VycmVudFNjcmlwdENhbGxiYWNrSUQgaW4gVUlTY3Jp cHRDb250ZXh0OjpyZXF1ZXN0VUlTY3JpcHRDb21wbGV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYzNzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBjb21wbGV0aW5nIGVhY2ggdGFzaywg d2Ugd2lsbCBlbmQgVUlTY3JpcHQgaWYgdGhlcmUgaXMgbm8gcmVtYWluaW5nIHRhc2suIFdlIG5l ZWQgdG8gbWFrZSBzdXJlIHRhc2sgaXMKKyAgICAgICAgY29tcGxldGVkIGFzeW5jaHJvbm91c2x5 LCBvdGhlcndpc2UgaXQgbWF5IGZpbmlzaCBiZWZvcmUgb3RoZXIgdGFza3MgaW4gdGhlIHNhbWUg c2NyaXB0IGFyZSBzY2hlZHVsZWQgYXMKKyAgICAgICAgc2NyaXB0IGVuZHMgZWFybHkuCisKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2NvY29hL1VJU2NyaXB0Q29udHJvbGxlckNvY29hLmg6 CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9VSVNjcmlwdENvbnRyb2xsZXJDb2Nv YS5tbToKKyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250cm9sbGVyQ29jb2E6OmNvbXBsZXRlVGFz a0FzeW5jaHJvbm91c2x5QWZ0ZXJBY3Rpdml0eVN0YXRlVXBkYXRlKToKKyAgICAgICAgKFdUUjo6 VUlTY3JpcHRDb250cm9sbGVyQ29jb2E6OnJlbW92ZVZpZXdGcm9tV2luZG93KToKKyAgICAgICAg KFdUUjo6VUlTY3JpcHRDb250cm9sbGVyQ29jb2E6OmFkZFZpZXdUb1dpbmRvdyk6CisKIDIwMjAt MDktMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByZXZlcnRpbmcgcjI2Njg0MiBhbmQgcjI2Njg4My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvY29jb2EvVUlTY3JpcHRDb250cm9sbGVyQ29jb2EuaCBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvY29jb2EvVUlTY3JpcHRDb250cm9sbGVyQ29jb2EuaAppbmRleCA3NzY3 Y2FiNmE1NjQwYzI0NzQwMGUzNmZiMWM5NDViNzNiZWUzNjg0Li45OTU2ZmU2ZmU4NzQxNjFhYThj Y2RiZmUyMjJkY2MwYTFkOGU1OGViIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L2NvY29hL1VJU2NyaXB0Q29udHJvbGxlckNvY29hLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9jb2NvYS9VSVNjcmlwdENvbnRyb2xsZXJDb2NvYS5oCkBAIC02Miw2ICs2Miw5IEBAIHB1 YmxpYzoKIHByb3RlY3RlZDoKICAgICBleHBsaWNpdCBVSVNjcmlwdENvbnRyb2xsZXJDb2NvYShV SVNjcmlwdENvbnRleHQmKTsKICAgICBUZXN0UnVubmVyV0tXZWJWaWV3ICp3ZWJWaWV3KCkgY29u c3Q7CisKK3ByaXZhdGU6CisgICAgdm9pZCBjb21wbGV0ZVRhc2tBc3luY2hyb25vdXNseUFmdGVy QWN0aXZpdHlTdGF0ZVVwZGF0ZSh1bnNpZ25lZCBjYWxsYmFja0lEKTsKIH07CiAKIH0gLy8gbmFt ZXNwYWNlIFdUUgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9VSVNj cmlwdENvbnRyb2xsZXJDb2NvYS5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvY29jb2EvVUlT Y3JpcHRDb250cm9sbGVyQ29jb2EubW0KaW5kZXggNzJkM2I4ZTViNTJkZDlmMWEyMjQyZWZhMTE0 YjdhMTliODM3ZDhmZC4uYjM0NWVmYzg1OTFlYzViZTA3OGM0MjgwYmIxMjEwNTYzZDA4YzM4MCAx MDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9VSVNjcmlwdENvbnRyb2xs ZXJDb2NvYS5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29hL1VJU2NyaXB0Q29u dHJvbGxlckNvY29hLm1tCkBAIC04Myw2ICs4MywyMSBAQCB2b2lkIFVJU2NyaXB0Q29udHJvbGxl ckNvY29hOjpkb0FzeW5jVGFzayhKU1ZhbHVlUmVmIGNhbGxiYWNrKQogICAgIH0pOwogfQogCit2 b2lkIFVJU2NyaXB0Q29udHJvbGxlckNvY29hOjpjb21wbGV0ZVRhc2tBc3luY2hyb25vdXNseUFm dGVyQWN0aXZpdHlTdGF0ZVVwZGF0ZSh1bnNpZ25lZCBjYWxsYmFja0lEKQoreworICAgIGRpc3Bh dGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIF57CisgICAgICAgIGF1dG8qIG1h aW5XZWJWaWV3ID0gVGVzdENvbnRyb2xsZXI6OnNpbmdsZXRvbigpLm1haW5XZWJWaWV3KCk7Cisg ICAgICAgIEFTU0VSVChtYWluV2ViVmlldyk7CisKKyAgICAgICAgW21haW5XZWJWaWV3LT5wbGF0 Zm9ybVZpZXcoKSBfZG9BZnRlckFjdGl2aXR5U3RhdGVVcGRhdGU6IF57CisgICAgICAgICAgICBp ZiAoIW1fY29udGV4dCkKKyAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgIG1f Y29udGV4dC0+YXN5bmNUYXNrQ29tcGxldGUoY2FsbGJhY2tJRCk7CisgICAgICAgIH1dOworICAg IH0pOworfQorCiB2b2lkIFVJU2NyaXB0Q29udHJvbGxlckNvY29hOjpyZW1vdmVWaWV3RnJvbVdp bmRvdyhKU1ZhbHVlUmVmIGNhbGxiYWNrKQogewogICAgIC8vIEZJWE1FOiBPbiBpT1MsIHdlIG5l dmVyIGludm9rZSB0aGUgY29tcGxldGlvbiBjYWxsYmFjayB0aGF0J3MgcGFzc2VkIGluLiBGaXhp bmcgdGhpcyBjYXVzZXMgdGhlIGxheW91dApAQCAtOTgsMTEgKzExMyw3IEBAIHZvaWQgVUlTY3Jp cHRDb250cm9sbGVyQ29jb2E6OnJlbW92ZVZpZXdGcm9tV2luZG93KEpTVmFsdWVSZWYgY2FsbGJh Y2spCiAgICAgbWFpbldlYlZpZXctPnJlbW92ZUZyb21XaW5kb3coKTsKIAogI2lmIFBMQVRGT1JN KE1BQykKLSAgICBbbWFpbldlYlZpZXctPnBsYXRmb3JtVmlldygpIF9kb0FmdGVyQWN0aXZpdHlT dGF0ZVVwZGF0ZTpeewotICAgICAgICBpZiAoIW1fY29udGV4dCkKLSAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgbV9jb250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShjYWxsYmFja0lEKTsKLSAg ICB9XTsKKyAgICBjb21wbGV0ZVRhc2tBc3luY2hyb25vdXNseUFmdGVyQWN0aXZpdHlTdGF0ZVVw ZGF0ZShjYWxsYmFja0lEKTsKICNlbmRpZiAvLyBQTEFURk9STShNQUMpCiB9CiAKQEAgLTExOCwx MSArMTI5LDcgQEAgdm9pZCBVSVNjcmlwdENvbnRyb2xsZXJDb2NvYTo6YWRkVmlld1RvV2luZG93 KEpTVmFsdWVSZWYgY2FsbGJhY2spCiAgICAgbWFpbldlYlZpZXctPmFkZFRvV2luZG93KCk7CiAK ICNpZiBQTEFURk9STShNQUMpCi0gICAgW21haW5XZWJWaWV3LT5wbGF0Zm9ybVZpZXcoKSBfZG9B ZnRlckFjdGl2aXR5U3RhdGVVcGRhdGU6XnsKLSAgICAgICAgaWYgKCFtX2NvbnRleHQpCi0gICAg ICAgICAgICByZXR1cm47Ci0gICAgICAgIG1fY29udGV4dC0+YXN5bmNUYXNrQ29tcGxldGUoY2Fs bGJhY2tJRCk7Ci0gICAgfV07CisgICAgY29tcGxldGVUYXNrQXN5bmNocm9ub3VzbHlBZnRlckFj dGl2aXR5U3RhdGVVcGRhdGUoY2FsbGJhY2tJRCk7CiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQog fQogCg==