216361 2020-09-10 07:15:20 -0700 [GTK] REGRESSION(r266815): Several GTK API tests are timing out 2020-09-12 00:09:17 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216138 P2 Normal --- 1 dpino webkit-unassigned aperez bburg bugs-noreply cgarcia ews-watchlist hi pangle oldest_to_newest 1687355 0 dpino 2020-09-10 07:15:20 -0700 The following GTK-API tests are failing after r266815: Unexpected timeouts (3) /WebKit2Gtk/TestInspector /webkit/WebKitWebInspector/custom-container-destroyed /webkit/WebKitWebInspector/manual-attach-detach /webkit/WebKitWebInspector/default 1687356 1 dpino 2020-09-10 07:18:22 -0700 See: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/15753/steps/API%20tests/logs/stdio TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspector... /webkit/WebKitWebInspector/default: TIMEOUT GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’ GLib-DEBUG: posix_spawn avoided (child_setup specified) GLib-DEBUG: posix_spawn avoided (child_setup specified) GLib-DEBUG: posix_spawn avoided (child_setup specified) GLib-DEBUG: posix_spawn avoided (child_setup specified) resource:///org/webkit/inspector/UserInterface/Main.js:16766: CONSOLE JS ERROR SyntaxError: Unexpected keyword 'let'. Expected ';' after variable declaration. resource:///org/webkit/inspector/UserInterface/Main.html:38:11: CONSOLE JS ERROR ReferenceError: Can't find variable: WI /webkit/WebKitWebInspector/manual-attach-detach: TIMEOUT GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’ GLib-DEBUG: posix_spawn avoided (child_setup specified) GLib-DEBUG: posix_spawn avoided (child_setup specified) GLib-DEBUG: posix_spawn avoided (child_setup specified) GLib-DEBUG: posix_spawn avoided (child_setup specified) resource:///org/webkit/inspector/UserInterface/Main.js:16766: CONSOLE JS ERROR SyntaxError: Unexpected keyword 'let'. Expected ';' after variable declaration. resource:///org/webkit/inspector/UserInterface/Main.html:38:11: CONSOLE JS ERROR ReferenceError: Can't find variable: WI 1687704 2 408526 cgarcia 2020-09-11 04:55:46 -0700 Created attachment 408526 Patch 1687710 3 408526 aperez 2020-09-11 06:03:11 -0700 Comment on attachment 408526 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408526&action=review > Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:357 > + let identifier = `${options.identifier ?? title}-event-listener-section`; I wonder how was the debugging session which arrived at this… just, wow! 1687715 4 cgarcia 2020-09-11 07:01:02 -0700 It was easy because the error message was pretty clear and we already had the revision that introduced the bug :-) 1687903 5 bburg 2020-09-11 23:52:24 -0700 Thanks for investigating, Carlos! 1687905 6 cgarcia 2020-09-12 00:09:17 -0700 Committed r266975: <https://trac.webkit.org/changeset/266975> 408526 2020-09-11 04:55:46 -0700 2020-09-11 06:03:11 -0700 Patch wk2-inspector-fix.diff text/plain 3208 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4NTNkM2NmMzcwYi4uOGNkNDQ3MTI4MTg2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0xMSAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g UkVHUkVTU0lPTihyMjY2ODE1KTogU2V2ZXJhbCBHVEsgQVBJIHRlc3RzIGFyZSB0aW1pbmcgb3V0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYzNjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlz c2luZyB0cmFpbGluZyAnOycuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTU5v ZGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorCiAyMDIwLTA5LTEwICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtb2Rlcm5pemUgZ2Vu ZXJhdGVkIGJhY2tlbmQgcHJvdG9jb2wgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWls c1NpZGViYXJQYW5lbC5qcwppbmRleCA2NmQzYjI3MGRmY2IuLjA4NzVhNTJmOTVmMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURl dGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTM1NCw3ICszNTQs NyBAQCBXSS5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIERPTU5vZGVEZXRhaWxz U2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuRE9NRAogICAgICAgICAgICAgfQogCiAgICAgICAgICAg ICBjb25zdCBkZWZhdWx0Q29sbGFwc2VkU2V0dGluZ1ZhbHVlID0gdHJ1ZTsKLSAgICAgICAgICAg IGxldCBpZGVudGlmaWVyID0gYCR7b3B0aW9ucy5pZGVudGlmaWVyID8/IHRpdGxlfS1ldmVudC1s aXN0ZW5lci1zZWN0aW9uYAorICAgICAgICAgICAgbGV0IGlkZW50aWZpZXIgPSBgJHtvcHRpb25z LmlkZW50aWZpZXIgPz8gdGl0bGV9LWV2ZW50LWxpc3RlbmVyLXNlY3Rpb25gOwogICAgICAgICAg ICAgbGV0IHNlY3Rpb24gPSBuZXcgV0kuRGV0YWlsc1NlY3Rpb24oaWRlbnRpZmllciwgdGl0bGUs IGdyb3Vwcywgb3B0aW9uc0VsZW1lbnQsIGRlZmF1bHRDb2xsYXBzZWRTZXR0aW5nVmFsdWUpOwog ICAgICAgICAgICAgc2VjdGlvbi5lbGVtZW50LmNsYXNzTGlzdC5hZGQoImV2ZW50LWxpc3RlbmVy LXNlY3Rpb24iKTsKICAgICAgICAgICAgIHJldHVybiBzZWN0aW9uOwpkaWZmIC0tZ2l0IGEvVG9v bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDk1M2MzMjI3MmE5MC4uMDAzMDA4 NGJiNWYwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDktMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjI2NjgxNSk6IFNl dmVyYWwgR1RLIEFQSSB0ZXN0cyBhcmUgdGltaW5nIG91dAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2MzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHRlc3RzIHRoYXQgYXJlIG5vdyBwYXNz aW5nLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNv bjoKKwogMjAyMC0wOS0xMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjY2ODQyIGFuZCByMjY2ODgzLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbiBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KaW5kZXggZmFkNmRiODJh NTYzLi40ZDA4ZjljNzYzMTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9U ZXN0RXhwZWN0YXRpb25zLmpzb24KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RF eHBlY3RhdGlvbnMuanNvbgpAQCAtMTAwLDE5ICsxMDAsNiBAQAogICAgICJUZXN0SW5zcGVjdG9y U2VydmVyIjogewogICAgICAgICAiZXhwZWN0ZWQiOiB7ImFsbCI6IHsic2xvdyI6IHRydWV9fQog ICAgIH0sCi0gICAgIlRlc3RJbnNwZWN0b3IiOiB7Ci0gICAgICAgICJzdWJ0ZXN0cyI6IHsKLSAg ICAgICAgICAgICIvd2Via2l0L1dlYktpdFdlYkluc3BlY3Rvci9jdXN0b20tY29udGFpbmVyLWRl c3Ryb3llZCI6IHsKLSAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJndGsiOiB7InN0YXR1cyI6 IFsiVElNRU9VVCJdLCAiYnVnIjogIndlYmtpdC5vcmcvYi8yMTYzNjEifX0KLSAgICAgICAgICAg IH0sCi0gICAgICAgICAgICAiL3dlYmtpdC9XZWJLaXRXZWJJbnNwZWN0b3IvbWFudWFsLWF0dGFj aC1kZXRhY2giOiB7Ci0gICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiZ3RrIjogeyJzdGF0dXMi OiBbIlRJTUVPVVQiXSwgImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMjE2MzYxIn19Ci0gICAgICAgICAg ICB9LAotICAgICAgICAgICAgIi93ZWJraXQvV2ViS2l0V2ViSW5zcGVjdG9yL2RlZmF1bHQiOiB7 Ci0gICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiZ3RrIjogeyJzdGF0dXMiOiBbIlRJTUVPVVQi XSwgImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMjE2MzYxIn19Ci0gICAgICAgICAgICB9Ci0gICAgICAg IH0KLSAgICB9LAogICAgICJUZXN0V2ViS2l0RmF2aWNvbkRhdGFiYXNlIjogewogICAgICAgICAi c3VidGVzdHMiOiB7CiAgICAgICAgICAgICAiL3dlYmtpdC9XZWJLaXRGYXZpY29uRGF0YWJhc2Uv Z2V0LWZhdmljb24iOiB7Cg==