<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>216330</bug_id>
          
          <creation_ts>2020-09-09 15:37:48 -0700</creation_ts>
          <short_desc>WPT exporter should use --3way when patch is from git</short_desc>
          <delta_ts>2022-03-28 09:29:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>238446</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>238446</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Sneddon [:gsnedders]">gsnedders</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>noam</cc>
    
    <cc>ntim</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1687166</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2020-09-09 15:37:48 -0700</bug_when>
    <thetext>When we&apos;re running on a git checkout of WebKit, the WPT exporter just gets its patch from `git diff`. This includes blob IDs, which means we can then use `git apply --3way` when applying the patch to the WPT tree, which has a better chance of succeeding (unless the file got modified during import) as the blob the patch applies to is recorded and therefore git doesn&apos;t just blindly try to apply it to the tip-of-tree of WPT, but can use its merge machinery.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1689243</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-09-16 15:38:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/69019391&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1855564</commentid>
    <comment_count>2</comment_count>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2022-03-28 06:09:57 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=238446 resolves</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1855636</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2022-03-28 09:29:40 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 238446 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>