216323 2020-09-09 13:35:07 -0700 kill-old-processes: Avoid calling kill command with empty string with GNU xargs 2020-09-13 22:24:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216068 InRadar P2 Normal --- 1 lmoura lmoura aakash_jain ap darin dpino ews-watchlist webkit-bug-importer oldest_to_newest 1687111 0 lmoura 2020-09-09 13:35:07 -0700 Currently, the kill-old-processes command to kill python scripts (like run-webkit-tests) has an unchecked "xargs kill" at the end, which may output an error message if there is no such command to be killed (as it is the case most of the time). Linux' version of xargs has the "-r" option which can be used to avoid running the command. 1687112 1 408362 lmoura 2020-09-09 13:38:02 -0700 Created attachment 408362 Patch 1687119 2 408362 darin 2020-09-09 14:06:23 -0700 Comment on attachment 408362 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408362&action=review > Tools/ChangeLog:3 > + kill-old-processes: Avoid calling kill command with empty string This is a platform-specific bug and fix. On BSD systems like macOS, xargs already doesn’t do this. But on platforms with GNU xargs this "-r" option is needed. 1687234 3 408402 lmoura 2020-09-09 19:33:53 -0700 Created attachment 408402 Patch for landing 1687235 4 lmoura 2020-09-09 19:35:37 -0700 Committed r266808: <https://trac.webkit.org/changeset/266808> 1687236 5 webkit-bug-importer 2020-09-09 19:36:20 -0700 <rdar://problem/68612810> 1688184 6 dpino 2020-09-13 22:24:57 -0700 *** Bug 215999 has been marked as a duplicate of this bug. *** 408362 2020-09-09 13:38:02 -0700 2020-09-09 20:04:28 -0700 Patch bug-216323-20200909173801.patch text/plain 1601 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2Nzc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmMyMTQ1Mjc5ODFjMzFlY2YyNzc5NmZlMmE5NGY5YjU4 NTI5NTBhMy4uODdhNWE3NGFiZjFjYTgyZmIxNDI1YmQ2YTBmOTZjNTMyOTU3YTU2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA5LTA5ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIGtpbGwtb2xkLXByb2Nlc3NlczogQXZvaWQgY2FsbGluZyBraWxsIGNvbW1hbmQgd2l0aCBl bXB0eSBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNjMyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzOgorICAgICAgICAobWFp bik6CisKIDIwMjAtMDktMDkgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBQaGlsaXBwZSBOb3JtYW5kIHRvIEVXUyBlbWFpbHMgdW5zdWJzY3JpYmUg bGlzdApkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vz c2VzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCmluZGV4IDg4 MDI1OGQxYzMyNGUwNDhiOTM0YTJjYWY1OWI3MWY3NDQxOGMxYWIuLmQ4MzFlM2I1YmU0NTA5YWJk Yzk1NzE4NmI1OGZjNmVlNzhiYTY2OTAgMTAwNzU1Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2tpbGwtb2xkLXByb2Nlc3NlcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9raWxs LW9sZC1wcm9jZXNzZXMKQEAgLTE4MCw3ICsxODAsNyBAQCBkZWYgbWFpbih1c2VyPU5vbmUpOgog ICAgICAgICBidWlsZGRpcl9iaW4gPSAiV2ViS2l0QnVpbGQvUmVsZWFzZS9iaW4iIGlmIG9zLnBh dGguaXNkaXIoIldlYktpdEJ1aWxkL1JlbGVhc2UvYmluIikgZWxzZSAiV2ViS2l0QnVpbGQvRGVi dWcvYmluIgogICAgICAgICBmb3IgdGFzayBpbiB0YXNrc1RvS2lsbCArIHRhc2tUb0tpbGxVbml4 ICsgbGlzdEFsbFdlYktpdFByb2dyYW1zKGJ1aWxkZGlyX2Jpbik6CiAgICAgICAgICAgICBvcy5z eXN0ZW0oImtpbGxhbGwgLTkgLXYgIiArIHRhc2spCi0gICAgICAgIG9zLnN5c3RlbSgicHMgYXV4 IHwgZ3JlcCAtUCAnLisvcHl0aG9uIC4rKHJ1bl93ZWJraXRfdGVzdHN8cnVuLXdlYmtpdC10ZXN0 c3xtb2RfcHl3ZWJzb2NrZXQpJyB8IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50ICQyfScgfCB4 YXJncyBraWxsIikKKyAgICAgICAgb3Muc3lzdGVtKCJwcyBhdXggfCBncmVwIC1QICcuKy9weXRo b24gLisocnVuX3dlYmtpdF90ZXN0c3xydW4td2Via2l0LXRlc3RzfG1vZF9weXdlYnNvY2tldCkn IHwgZ3JlcCAtdiBncmVwIHwgYXdrICd7cHJpbnQgJDJ9JyB8IHhhcmdzIC1yIGtpbGwiKQogICAg ICAgICByZW1vdmVPcnBoYW5TaG1TZWdtZW50cygpCiAgICAgZWxzZToKICAgICAgICAgc3lzLmV4 aXQoKQo= 408402 2020-09-09 19:33:53 -0700 2020-09-09 19:33:53 -0700 Patch for landing bug-216323-20200909233351.patch text/plain 1617 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2ODA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTFiNDU4ZjFjYjM4Yjg3OWZmYmJhODMzOTE2OGM1Mzhl MjhlNTE5My4uMjRmYTUxYzhkODMxN2FkNGE1ZTQ3OGIzYjM1YThmNTIyZDc2NDQ2YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA5LTA5ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIGtpbGwtb2xkLXByb2Nlc3NlczogQXZvaWQgY2FsbGluZyBraWxsIGNvbW1hbmQgd2l0aCBl bXB0eSBzdHJpbmcgd2l0aCBHTlUgeGFyZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxNjMyMworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzOgor ICAgICAgICAobWFpbik6CisKIDIwMjAtMDktMDkgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgogCiAgICAgICAgIGV3cyBtaWdodCBtYXJrIGJ1aWxkIGFzIHN1Y2Nlc3NmdWwg aWYgdGVzdHMgZmFpbCB0byBydW4KZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2tpbGwtb2xkLXByb2Nlc3NlcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXBy b2Nlc3NlcwppbmRleCA4ODAyNThkMWMzMjRlMDQ4YjkzNGEyY2FmNTliNzFmNzQ0MThjMWFiLi5k ODMxZTNiNWJlNDUwOWFiZGM5NTcxODZiNThmYzZlZTc4YmE2NjkwIDEwMDc1NQotLS0gYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMKKysrIGIvVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCkBAIC0xODAsNyArMTgwLDcgQEAgZGVmIG1h aW4odXNlcj1Ob25lKToKICAgICAgICAgYnVpbGRkaXJfYmluID0gIldlYktpdEJ1aWxkL1JlbGVh c2UvYmluIiBpZiBvcy5wYXRoLmlzZGlyKCJXZWJLaXRCdWlsZC9SZWxlYXNlL2JpbiIpIGVsc2Ug IldlYktpdEJ1aWxkL0RlYnVnL2JpbiIKICAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tpbGwg KyB0YXNrVG9LaWxsVW5peCArIGxpc3RBbGxXZWJLaXRQcm9ncmFtcyhidWlsZGRpcl9iaW4pOgog ICAgICAgICAgICAgb3Muc3lzdGVtKCJraWxsYWxsIC05IC12ICIgKyB0YXNrKQotICAgICAgICBv cy5zeXN0ZW0oInBzIGF1eCB8IGdyZXAgLVAgJy4rL3B5dGhvbiAuKyhydW5fd2Via2l0X3Rlc3Rz fHJ1bi13ZWJraXQtdGVzdHN8bW9kX3B5d2Vic29ja2V0KScgfCBncmVwIC12IGdyZXAgfCBhd2sg J3twcmludCAkMn0nIHwgeGFyZ3Mga2lsbCIpCisgICAgICAgIG9zLnN5c3RlbSgicHMgYXV4IHwg Z3JlcCAtUCAnLisvcHl0aG9uIC4rKHJ1bl93ZWJraXRfdGVzdHN8cnVuLXdlYmtpdC10ZXN0c3xt b2RfcHl3ZWJzb2NrZXQpJyB8IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50ICQyfScgfCB4YXJn cyAtciBraWxsIikKICAgICAgICAgcmVtb3ZlT3JwaGFuU2htU2VnbWVudHMoKQogICAgIGVsc2U6 CiAgICAgICAgIHN5cy5leGl0KCkK