216297 2020-09-08 17:13:42 -0700 WebCore UnifiedSource81 builds for upwards of 10 minutes 2020-09-08 20:15:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap bdakin benjamin calvaris ews-watchlist ggaren keith_miller simon.fraser webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1686824 0 thorton 2020-09-08 17:13:42 -0700 WebCore UnifiedSource81 builds for upwards of 10 minutes 1686825 1 408289 thorton 2020-09-08 17:13:53 -0700 Created attachment 408289 Patch 1686831 2 thorton 2020-09-08 17:22:58 -0700 I suppose we need to restrict to clang only. 1686835 3 408291 thorton 2020-09-08 17:24:43 -0700 Created attachment 408291 Patch 1686844 4 408291 ap 2020-09-08 17:41:51 -0700 Comment on attachment 408291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408291&action=review > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463 > + // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed. Fixed in all versions that we are building with... 1686869 5 thorton 2020-09-08 18:56:31 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 408291 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408291&action=review > > > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463 > > + // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed. > > Fixed in all versions that we are building with... Sure, or we can add conditional flags (I suppose I could have done that here, too, but I was too lazy to figure it out). 1686886 6 thorton 2020-09-08 20:14:37 -0700 Committed r266768: <https://trac.webkit.org/changeset/266768> 1686887 7 webkit-bug-importer 2020-09-08 20:15:25 -0700 <rdar://problem/68546448> 408289 2020-09-08 17:13:53 -0700 2020-09-08 17:24:42 -0700 Patch bug-216297-20200908171352.patch text/plain 1650 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5NDNhYzVkZTQ0ZWEx MzRiNDM5ZTc3MGI3MTUwMmM5MzBhNDc5Zi4uNGViYTQ5NzE0ZDBhODFkMjRmMTUyNzk0MjJjMWU0 OTIxN2UxOTExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTA4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFdlYkNvcmUgVW5p ZmllZFNvdXJjZTgxIGJ1aWxkcyBmb3IgdXB3YXJkcyBvZiAxMCBtaW51dGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyOTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1dlYkNv cmVCdWlsdGluTmFtZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkNvcmVCdWlsdGluTmFtZXM6 OldlYkNvcmVCdWlsdGluTmFtZXMpOgorICAgICAgICBXb3JrIGFyb3VuZCBhbiBMTFZNIHJlZ3Jl c3Npb24gYnkgZGlzYWJsaW5nIGRlYnVnZ2luZyBpbiB0aGUKKyAgICAgICAgV2ViQ29yZUJ1aWx0 aW5OYW1lcyBjb25zdHJ1Y3Rvci4gVGhpcyBpcyB0cmFja2VkIGJ5IDxyZGFyOi8vNjgyNDY2ODY+ LgorCisgICAgICAgIFRoaXMgZHJvcHMgdGhlIFdlYkNvcmUgYnVpbGQgdGltZSBvbiBteSBpTWFj IFBybyBmcm9tIDE0IG1pbnV0ZXMgdG8gNi4KKwogMjAyMC0wOS0wOCAgU2FtIFdlaW5pZyAgPHdl aW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYklETF0gQWRkIHN1cHBvcnQgZm9yIHBhcnRp YWwgaW50ZXJmYWNlIG1peGlucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvV2ViQ29yZUJ1aWx0aW5OYW1lcy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV2Vi Q29yZUJ1aWx0aW5OYW1lcy5oCmluZGV4IDQyMWE0NmY4MWJkNmU5ZjFmOGM3ODIyNjA2NzEyYjlj OGFiYTMzOTMuLjBiOTA5YzIzOGQxOWMxYmM4NWU4NzNmYWJiZTg1MjRkZmYzMTNhZjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVCdWlsdGluTmFtZXMuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlQnVpbHRpbk5hbWVzLmgKQEAg LTQ2MCw3ICs0NjAsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFdlYkNvcmVCdWls dGluTmFtZXMgewogcHVibGljOgotICAgIGV4cGxpY2l0IFdlYkNvcmVCdWlsdGluTmFtZXMoSlND OjpWTSYgdm0pCisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGUgX19hdHRyaWJ1dGVfXygobm9kZWJ1 ZykpIHdoZW4gPHJkYXI6Ly82ODI0NjY4Nj4gaXMgZml4ZWQuCisgICAgX19hdHRyaWJ1dGVfXygo bm9kZWJ1ZykpIGV4cGxpY2l0IFdlYkNvcmVCdWlsdGluTmFtZXMoSlNDOjpWTSYgdm0pCiAgICAg ICAgIDogbV92bSh2bSkKICAgICAgICAgV0VCQ09SRV9DT01NT05fUFJJVkFURV9JREVOVElGSUVS U19FQUNIX1BST1BFUlRZX05BTUUoSU5JVElBTElaRV9CVUlMVElOX05BTUVTKQogICAgIHsK 408291 2020-09-08 17:24:43 -0700 2020-09-08 18:54:45 -0700 Patch bug-216297-20200908172443.patch text/plain 1639 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5NDNhYzVkZTQ0ZWEx MzRiNDM5ZTc3MGI3MTUwMmM5MzBhNDc5Zi4uOTgzNjM3NGQ0YWFkM2RlODYyZGFjNDY1ZmM5OWZj ZTA1MzBlYjhjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTA4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFdlYkNvcmUgVW5p ZmllZFNvdXJjZTgxIGJ1aWxkcyBmb3IgdXB3YXJkcyBvZiAxMCBtaW51dGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyOTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1dlYkNv cmVCdWlsdGluTmFtZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkNvcmVCdWlsdGluTmFtZXM6 OldlYkNvcmVCdWlsdGluTmFtZXMpOgorICAgICAgICBXb3JrIGFyb3VuZCBhbiBMTFZNIHJlZ3Jl c3Npb24gYnkgZGlzYWJsaW5nIGRlYnVnZ2luZyBpbiB0aGUKKyAgICAgICAgV2ViQ29yZUJ1aWx0 aW5OYW1lcyBjb25zdHJ1Y3Rvci4gVGhpcyBpcyB0cmFja2VkIGJ5IDxyZGFyOi8vNjgyNDY2ODY+ LgorCisgICAgICAgIFRoaXMgZHJvcHMgdGhlIFdlYkNvcmUgcmVsZWFzZSBidWlsZCB0aW1lIG9u IG15IGlNYWMgUHJvIGZyb20gMTQgbWludXRlcyB0byA2LgorCiAyMDIwLTA5LTA4ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViSURMXSBBZGQgc3VwcG9ydCBm b3IgcGFydGlhbCBpbnRlcmZhY2UgbWl4aW5zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9XZWJDb3JlQnVpbHRpbk5hbWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9XZWJDb3JlQnVpbHRpbk5hbWVzLmgKaW5kZXggNDIxYTQ2ZjgxYmQ2ZTlmMWY4Yzc4MjI2 MDY3MTJiOWM4YWJhMzM5My4uYTdiYjI1OThjOWU2MDM3MWRiNWFhNTU0OTEzMTU0YzBhNDI4ZDE2 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV2ViQ29yZUJ1aWx0aW5O YW1lcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVCdWlsdGluTmFt ZXMuaApAQCAtNDYwLDYgKzQ2MCwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFdl YkNvcmVCdWlsdGluTmFtZXMgewogcHVibGljOgorICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhlIF9f YXR0cmlidXRlX18oKG5vZGVidWcpKSB3aGVuIDxyZGFyOi8vNjgyNDY2ODY+IGlzIGZpeGVkLgor I2lmIENPTVBJTEVSKENMQU5HKQorICAgIF9fYXR0cmlidXRlX18oKG5vZGVidWcpKQorI2VuZGlm CiAgICAgZXhwbGljaXQgV2ViQ29yZUJ1aWx0aW5OYW1lcyhKU0M6OlZNJiB2bSkKICAgICAgICAg OiBtX3ZtKHZtKQogICAgICAgICBXRUJDT1JFX0NPTU1PTl9QUklWQVRFX0lERU5USUZJRVJTX0VB Q0hfUFJPUEVSVFlfTkFNRShJTklUSUFMSVpFX0JVSUxUSU5fTkFNRVMpCg==