216280 2020-09-08 12:37:01 -0700 REGRESSION(r266681) [GTK] constexpr build failure in LTS/Debian with GCC 8 2020-09-08 14:11:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216219 InRadar P2 Normal --- 1 lmoura lmoura achristensen bugs-noreply darin sam webkit-bug-importer oldest_to_newest 1686679 0 lmoura 2020-09-08 12:37:01 -0700 Error: [257/502] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-54.cpp.o FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-54.cpp.o <snip long include line> In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32:0, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:56, from ../../Source/WebCore/platform/text/TextCodecCJK.cpp:26, from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-54.cpp:1: ../../Source/WebCore/platform/text/TextCodecSingleByte.cpp: In function ‘constexpr const SingleByteDecodeTable& WebCore::tableForDecoding(WebCore::TextCodecSingleByte::Encoding)’: DerivedSources/ForwardingHeaders/wtf/Assertions.h:587:56: error: call to non-constexpr function ‘void CRASH_WITH_INFO(...)’ #define RELEASE_ASSERT_NOT_REACHED(...) CRASH_WITH_INFO(__VA_ARGS__) ~~~~~~~~~~~~~~~^~~~~~~~~~~~~ ../../Source/WebCore/platform/text/TextCodecSingleByte.cpp:237:5: note: in expansion of macro ‘RELEASE_ASSERT_NOT_REACHED’ RELEASE_ASSERT_NOT_REACHED(); ^~~~~~~~~~~~~~~~~~~~~~~~~~ GCC 8 has some limitations checking non-constexpr expressions after return statements. Example: https://godbolt.org/z/dhPvaf Related GCC bugs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86678 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67371 1686684 1 408256 lmoura 2020-09-08 12:43:41 -0700 Created attachment 408256 Patch 1686693 2 408256 darin 2020-09-08 12:52:14 -0700 Comment on attachment 408256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408256&action=review > Source/WebCore/platform/text/TextCodecSingleByte.cpp:248 > + default: > + RELEASE_ASSERT_NOT_REACHED(); I guess we can do this. But sadly this has a side effect of suppressing the compile-time warning if we forget to include one of the enumeration values here. Would be nice to find a solution that does not do that. 1686695 3 408256 achristensen 2020-09-08 12:56:24 -0700 Comment on attachment 408256 Patch I'd prefer to just remove the constexpr from this function. 1686696 4 408256 achristensen 2020-09-08 12:56:31 -0700 Comment on attachment 408256 Patch I'd prefer to just remove the constexpr from this function. 1686700 5 darin 2020-09-08 12:58:23 -0700 Don’t we need the constexpr to make this work as a template argument? 1686705 6 408256 achristensen 2020-09-08 13:05:57 -0700 Comment on attachment 408256 Patch No, tableForDecoding isn't used as a template argument. 1686706 7 408259 achristensen 2020-09-08 13:07:22 -0700 Created attachment 408259 Patch 1686707 8 408260 achristensen 2020-09-08 13:08:11 -0700 Created attachment 408260 Patch 1686735 9 achristensen 2020-09-08 14:05:51 -0700 Lauro, does this fix your build? 1686739 10 lmoura 2020-09-08 14:10:40 -0700 (In reply to Alex Christensen from comment #9) > Lauro, does this fix your build? Could not test it direcly on the bot but indeed it should fix. 1686740 11 achristensen 2020-09-08 14:10:53 -0700 http://trac.webkit.org/r266749 1686742 12 webkit-bug-importer 2020-09-08 14:11:38 -0700 <rdar://problem/68529158> 408256 2020-09-08 12:43:41 -0700 2020-09-08 13:07:20 -0700 Patch bug-216280-20200908164339.patch text/plain 1763 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI4MThmYzAyMmU2NzAw MTI1ZDM0MzVhMTM3ZDFiNDA4ZjA4NjdkMi4uNzZiY2Q0NmI0YzczYWQwYjZmOTlhNmZhZTU0ZDhk NmJjNzAxNGU1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTA4ICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI2NjY4 MSkgW0dUS10gY29uc3RleHByIGJ1aWxkIGZhaWx1cmUgaW4gTFRTL0RlYmlhbiB3aXRoIEdDQyA4 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyODAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHQ0MgOCAo VWJ1bnR1IDE4LjA0L0N1cnJlbnQgRGViaWFuIHN0YWJsZSkgaGFzIHNvbWUgbGltaXRhdGlvbnMg cmVnYXJkaW5nIG5vbi1jb25zdGV4cHIKKyAgICAgICAgZXhwcmVzc2lvbnMgaW4gbmV2ZXIgZXhl Y3V0ZWQgcG9ydGlvbnMgb2YgY29uc3QtZXhwciBmdW5jdGlvbnMsIGZhaWxpbmcgdG8gYnVpbGQg d2l0aAorICAgICAgICB0aGUgImNhbGwgdG8gbm9uLWNvbnN0ZXhwciBmdW5jdGlvbi4uLiIgZXJy b3IuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL3RleHQvVGV4dENvZGVjU2luZ2xlQnl0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0 YWJsZUZvckRlY29kaW5nKTogVXNlIHRoZSBkZWZhdWx0IGNhc2UgYXMgdGhpcyBoYXMgdGhlIHNh bWUKKyAgICAgICAgZWZmZWN0IGFuZCBpcyBjb3JyZWN0bHkgZXZhbHVhdGVkIGJ5IEdDQyA4Lgor CiAyMDIwLTA5LTA4ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4 IGNyYXNoIGluIGltYWdlLWxvYWRpbmctbGF6eS1zbG93Lmh0bWwgV1BUIHRlc3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dENvZGVjU2luZ2xlQnl0ZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY1NpbmdsZUJ5dGUuY3BwCmlu ZGV4IDZkOGY1NGMyZDY2YzIyNzFkYzg1NTUwOTFlMTdmYTAyZTUyM2Q3MzYuLjZlNTg4ZTk0MDE5 YzhiOTY2MjA0YTlkYWJkMjI4NDQ1ZGNkY2UzYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3RleHQvVGV4dENvZGVjU2luZ2xlQnl0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNTaW5nbGVCeXRlLmNwcApAQCAtMjQ0LDggKzI0NCw5 IEBAIHN0YXRpYyBjb25zdGV4cHIgY29uc3QgU2luZ2xlQnl0ZURlY29kZVRhYmxlJiB0YWJsZUZv ckRlY29kaW5nKFRleHRDb2RlY1NpbmdsZUJ5CiAgICAgICAgIHJldHVybiBpYm04NjY7CiAgICAg Y2FzZSBUZXh0Q29kZWNTaW5nbGVCeXRlOjpFbmNvZGluZzo6S09JOFU6CiAgICAgICAgIHJldHVy biBrb2k4dTsKKyAgICBkZWZhdWx0OgorICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hF RCgpOwogICAgIH0KLSAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCiAvLyBo dHRwczovL2VuY29kaW5nLnNwZWMud2hhdHdnLm9yZy8jc2luZ2xlLWJ5dGUtZW5jb2Rlcgo= 408259 2020-09-08 13:07:22 -0700 2020-09-08 13:08:09 -0700 Patch bug-216280-20200908130721.patch text/plain 1354 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2Njc0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA5LTA4ICBBTGF1cm8g TW91cmEgPGxtb3VyYUBpZ2FsaWEuY29tPiBhbmQgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI2NjY4MSkgW0dUS10gY29u c3RleHByIGJ1aWxkIGZhaWx1cmUgaW4gTFRTL0RlYmlhbiB3aXRoIEdDQyA4CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyODAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvVGV4 dENvZGVjU2luZ2xlQnl0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0YWJsZUZvckRlY29kaW5n KToKKwogMjAyMC0wOS0wOCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBpT1M6IDxhdHRhY2htZW50PidzIFF1aWNrTG9vayB0aHVtYm5haWxzIGNhbiBh cHBlYXIgc3F1aXNoZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dENv ZGVjU2luZ2xlQnl0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v dGV4dC9UZXh0Q29kZWNTaW5nbGVCeXRlLmNwcAkocmV2aXNpb24gMjY2NzAzKQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNTaW5nbGVCeXRlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjIxLDcgKzIyMSw3IEBAIHN0YXRpYyBTaW5nbGVCeXRlRW5jb2RlVGFibGUgdGFi bGVGb3JFbmMKICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCi1zdGF0aWMg Y29uc3RleHByIGNvbnN0IFNpbmdsZUJ5dGVEZWNvZGVUYWJsZSYgdGFibGVGb3JEZWNvZGluZyhU ZXh0Q29kZWNTaW5nbGVCeXRlOjpFbmNvZGluZyBlbmNvZGluZykKK3N0YXRpYyBjb25zdCBTaW5n bGVCeXRlRGVjb2RlVGFibGUmIHRhYmxlRm9yRGVjb2RpbmcoVGV4dENvZGVjU2luZ2xlQnl0ZTo6 RW5jb2RpbmcgZW5jb2RpbmcpCiB7CiAgICAgc3dpdGNoIChlbmNvZGluZykgewogICAgIGNhc2Ug VGV4dENvZGVjU2luZ2xlQnl0ZTo6RW5jb2Rpbmc6OklTT184ODU5XzM6Cg== 408260 2020-09-08 13:08:11 -0700 2020-09-08 14:10:43 -0700 Patch bug-216280-20200908130810.patch text/plain 1353 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2Njc0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA5LTA4ICBMYXVybyBN b3VyYSA8bG1vdXJhQGlnYWxpYS5jb20+IGFuZCBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY2NjgxKSBbR1RLXSBjb25z dGV4cHIgYnVpbGQgZmFpbHVyZSBpbiBMVFMvRGViaWFuIHdpdGggR0NDIDgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjI4MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9UZXh0 Q29kZWNTaW5nbGVCeXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRhYmxlRm9yRGVjb2Rpbmcp OgorCiAyMDIwLTA5LTA4ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog CiAgICAgICAgIGlPUzogPGF0dGFjaG1lbnQ+J3MgUXVpY2tMb29rIHRodW1ibmFpbHMgY2FuIGFw cGVhciBzcXVpc2hlZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0Q29k ZWNTaW5nbGVCeXRlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90 ZXh0L1RleHRDb2RlY1NpbmdsZUJ5dGUuY3BwCShyZXZpc2lvbiAyNjY3MDMpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY1NpbmdsZUJ5dGUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMjEsNyArMjIxLDcgQEAgc3RhdGljIFNpbmdsZUJ5dGVFbmNvZGVUYWJsZSB0YWJs ZUZvckVuYwogICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKLXN0YXRpYyBj b25zdGV4cHIgY29uc3QgU2luZ2xlQnl0ZURlY29kZVRhYmxlJiB0YWJsZUZvckRlY29kaW5nKFRl eHRDb2RlY1NpbmdsZUJ5dGU6OkVuY29kaW5nIGVuY29kaW5nKQorc3RhdGljIGNvbnN0IFNpbmds ZUJ5dGVEZWNvZGVUYWJsZSYgdGFibGVGb3JEZWNvZGluZyhUZXh0Q29kZWNTaW5nbGVCeXRlOjpF bmNvZGluZyBlbmNvZGluZykKIHsKICAgICBzd2l0Y2ggKGVuY29kaW5nKSB7CiAgICAgY2FzZSBU ZXh0Q29kZWNTaW5nbGVCeXRlOjpFbmNvZGluZzo6SVNPXzg4NTlfMzoK