216259 2020-09-07 20:05:03 -0700 [LFC][IFC] Remove redundant FormattingContext::Quirks::lineDescentNeedsCollapsing 2020-09-08 06:27:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1686465 0 zalan 2020-09-07 20:05:03 -0700 After the refactoring this function is not needed anymore. 1686466 1 408207 zalan 2020-09-07 20:20:12 -0700 Created attachment 408207 Patch 1686539 2 ews-feeder 2020-09-08 06:26:30 -0700 Committed r266722: <https://trac.webkit.org/changeset/266722> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408207. 1686540 3 webkit-bug-importer 2020-09-08 06:27:16 -0700 <rdar://problem/68504706> 408207 2020-09-07 20:20:12 -0700 2020-09-08 06:26:30 -0700 Patch bug-216259-20200907202011.patch text/plain 4050 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI0ZWVhOWM5ZDgzZmU3 NTg5ZmQwMDFlZTQ5OWJkZDk5ODllNzQxOS4uMjZmZjFhZDRkYWFlMDFjMDc2ZTZlYmNkYjA5ZDA1 NmQ2M2FlZjYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTA3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg cmVkdW5kYW50IEZvcm1hdHRpbmdDb250ZXh0OjpRdWlya3M6OmxpbmVEZXNjZW50TmVlZHNDb2xs YXBzaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTYyNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGZ1bmN0aW9uIGlzIG5vdCBuZWVkZWQgYW55bW9yZS4gSW5saW5lQm94ZXMgc3RhcnQgY29s bGFwc2VkIGJ5IGRlZmF1bHQgYW5kIHRoZXkgZ2V0IHN0cmV0Y2hlZCB3aGVuIHRoZXkgZ2FpbiBj b250ZW50CisgICAgICAgIChhbmQgdGhlIHJvb3QgaW5saW5lIGJveCBoYXMgbm8gaW1hZ2luYXJ5 IHN0cnV0IGluIG5vbi1zdGFuZGFyZCBtb2RlKS4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0Lmg6CisgICAgICAgICogbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRRdWlya3MuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6UXVpcmtzOjpsaW5l RGVzY2VudE5lZWRzQ29sbGFwc2luZyBjb25zdCk6IERlbGV0ZWQuCisKIDIwMjAtMDktMDYgIFdl bnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBgV2Vi Q29yZTo6V3JpdGluZ01vZGVgIGFuIDgtYml0IGVudW0gY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0 LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0 aW5nQ29udGV4dC5oCmluZGV4IGMyM2NmZWVkODk5OWY5MDAxODNmMzMwN2E5NjJiOWU4OTgwMDFh Y2IuLmRjOTk2OWJlMmNmNGE5ODI5NTE2YTJmMGU1ZGM2ZDU2MjE3ZWIzODAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdD b250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5s aW5lRm9ybWF0dGluZ0NvbnRleHQuaApAQCAtNDgsNyArNDgsNiBAQCBwdWJsaWM6CiAKICAgICBj bGFzcyBRdWlya3MgOiBwdWJsaWMgRm9ybWF0dGluZ0NvbnRleHQ6OlF1aXJrcyB7CiAgICAgcHVi bGljOgotICAgICAgICBib29sIGxpbmVEZXNjZW50TmVlZHNDb2xsYXBzaW5nKGNvbnN0IExpbmU6 OlJ1bkxpc3QmKSBjb25zdDsKICAgICAgICAgSW5saW5lTGF5b3V0VW5pdCBpbml0aWFsTGluZUhl aWdodCgpIGNvbnN0OwogCiAgICAgcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0UXVpcmtzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRp bmdDb250ZXh0UXVpcmtzLmNwcAppbmRleCBkMmFjZTQ1NDIwMGQ4ZjY2YmFlYWQxMGJiYTdlZmY2 YzZlZWRlODQ2Li4wNjMxMTdjYTdlM2VhM2YzYTdiOTQ1Y2FkZWNlZDU3ZDI1NDIzYmYzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt YXR0aW5nQ29udGV4dFF1aXJrcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRRdWlya3MuY3BwCkBAIC0yNCw1MiAr MjQsMTMgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiRGlzcGxheUJv eC5oIgogI2luY2x1ZGUgIklubGluZUZvcm1hdHRpbmdDb250ZXh0LmgiCi0jaW5jbHVkZSAiSW5s aW5lTGluZUJveC5oIgogCiAjaWYgRU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQpCiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIG5hbWVzcGFjZSBMYXlvdXQgewogCi1ib29sIElubGluZUZv cm1hdHRpbmdDb250ZXh0OjpRdWlya3M6OmxpbmVEZXNjZW50TmVlZHNDb2xsYXBzaW5nKGNvbnN0 IExpbmU6OlJ1bkxpc3QmIHJ1bkxpc3QpIGNvbnN0Ci17Ci0gICAgLy8gQ29sbGFwc2UgbGluZSBk ZXNjZW50IGluIGxpbWl0ZWQgYW5kIGZ1bGwgcXVpcmsgbW9kZSB3aGVuIHRoZXJlJ3Mgbm8gYmFz ZWxpbmUgYWxpZ25lZCBjb250ZW50IG9yCi0gICAgLy8gdGhlIGJhc2VsaW5lIGFsaWduZWQgY29u dGVudCBoYXMgbm8gZGVzY2VudC4KLSAgICBhdXRvJiBsYXlvdXRTdGF0ZSA9IHRoaXMtPmxheW91 dFN0YXRlKCk7Ci0gICAgaWYgKCFsYXlvdXRTdGF0ZS5pblF1aXJrc01vZGUoKSAmJiAhbGF5b3V0 U3RhdGUuaW5MaW1pdGVkUXVpcmtzTW9kZSgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAg ICBmb3IgKGF1dG8mIHJ1biA6IHJ1bkxpc3QpIHsKLSAgICAgICAgYXV0byYgbGF5b3V0Qm94ID0g cnVuLmxheW91dEJveCgpOwotICAgICAgICBpZiAocnVuLmlzQ29udGFpbmVyRW5kKCkgfHwgbGF5 b3V0Qm94LnN0eWxlKCkudmVydGljYWxBbGlnbigpICE9IFZlcnRpY2FsQWxpZ246OkJhc2VsaW5l KQotICAgICAgICAgICAgY29udGludWU7Ci0KLSAgICAgICAgaWYgKHJ1bi5pc0xpbmVCcmVhaygp KQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBpZiAocnVuLmlzVGV4dCgpKQot ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBpZiAocnVuLmlzQ29udGFpbmVyU3Rh cnQoKSkgewotICAgICAgICAgICAgYXV0byYgYm94R2VvbWV0cnkgPSBmb3JtYXR0aW5nQ29udGV4 dCgpLmdlb21ldHJ5Rm9yQm94KGxheW91dEJveCk7Ci0gICAgICAgICAgICBpZiAoYm94R2VvbWV0 cnkuaG9yaXpvbnRhbEJvcmRlcigpIHx8IChib3hHZW9tZXRyeS5ob3Jpem9udGFsUGFkZGluZygp ICYmIGJveEdlb21ldHJ5Lmhvcml6b250YWxQYWRkaW5nKCkudmFsdWUoKSkpCi0gICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIH0KLSAg ICAgICAgaWYgKHJ1bi5pc0JveCgpKSB7Ci0gICAgICAgICAgICBpZiAobGF5b3V0Qm94LmlzSW5s aW5lQmxvY2tCb3goKSAmJiBsYXlvdXRCb3guZXN0YWJsaXNoZXNJbmxpbmVGb3JtYXR0aW5nQ29u dGV4dCgpKSB7Ci0gICAgICAgICAgICAgICAgYXV0byYgZm9ybWF0dGluZ1N0YXRlID0gbGF5b3V0 U3RhdGUuZXN0YWJsaXNoZWRJbmxpbmVGb3JtYXR0aW5nU3RhdGUoZG93bmNhc3Q8Q29udGFpbmVy Qm94PihsYXlvdXRCb3gpKTsKLSAgICAgICAgICAgICAgICBhdXRvIGxhc3RMaW5lID0gZm9ybWF0 dGluZ1N0YXRlLmRpc3BsYXlJbmxpbmVDb250ZW50KCktPmxpbmVzLmxhc3QoKTsKLSAgICAgICAg ICAgICAgICBpZiAobGFzdExpbmUuaGVpZ2h0KCkgPiBsYXN0TGluZS5iYXNlbGluZSgpKQotICAg ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAg ICBjb250aW51ZTsKLSAgICAgICAgfQotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAg ICB9Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIElubGluZUxheW91dFVuaXQgSW5saW5lRm9ybWF0 dGluZ0NvbnRleHQ6OlF1aXJrczo6aW5pdGlhbExpbmVIZWlnaHQoKSBjb25zdAogewogICAgIC8v IE5lZ2F0aXZlIGxpbmVIZWlnaHQgdmFsdWUgbWVhbnMgdGhlIGxpbmUtaGVpZ2h0IGlzIG5vdCBz ZXQK