216254 2020-09-07 15:10:03 -0700 [GTK] AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo 2020-09-08 08:25:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All Linux RESOLVED FIXED P2 Normal --- 1 mgorse webkit-unassigned aperez bugs-noreply cgarcia darin mgorse oldest_to_newest 1686443 0 mgorse 2020-09-07 15:10:03 -0700 TryInitializeSHM has a wpebackend-fdo version check, but, for versions older than 1.7.0, it does the wrong thing and acts as though it has successfully initialized. Epiphany is currently coredumping with the openSUSE GNOME:Next repository (using webkitgtk 2.29.92), and I suspect that this is the reason. 1686444 1 408199 mgorse 2020-09-07 15:14:12 -0700 Created attachment 408199 Patch. 1686448 2 408199 darin 2020-09-07 16:01:22 -0700 Comment on attachment 408199 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=408199&action=review > Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:140 > + return false; We’d like to structure the #if so there is not dead code after a return. So the code after the #endif should be moved before the #else. 1686451 3 408202 mgorse 2020-09-07 16:32:41 -0700 Created attachment 408202 Patch. 1686504 4 408202 aperez 2020-09-08 00:58:43 -0700 Comment on attachment 408202 Patch. Hello! Thanks for the patch, Michael. Could you please move the “return” around as suggested by Darin? Other than that and adding the [WPE] tag to the bug description, the change looks good =) View in context: https://bugs.webkit.org/attachment.cgi?id=408202&action=review > Source/WebKit/ChangeLog:3 > + AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo Let's also add the [WPE] tag to the bug description :) 1686509 5 cgarcia 2020-09-08 01:12:21 -0700 This is a gtk bug, not WPE 1686545 6 408227 mgorse 2020-09-08 07:26:02 -0700 Created attachment 408227 Patch. Updated ChangeLog entry. I believe I have also done what Darin requested in terms of the return value. 1686560 7 ews-feeder 2020-09-08 08:25:10 -0700 Committed r266726: <https://trac.webkit.org/changeset/266726> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408227. 408199 2020-09-07 15:14:12 -0700 2020-09-07 16:32:41 -0700 Patch. shm.patch text/plain 1197 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYWYyZGVjM2IyNGYyLi41M2M0Yzk1ZTczNmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjAtMDktMDcgIE1pa2UgR29yc2UgIDxtZ29yc2VAc3VzZS5jb20+CisKKyAg ICAgICAgQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kIG1pZ2h0IGVycm9uZW91c2x5IHRy eSB0byB1c2UgU0hNIHdpdGggb2xkZXIgd3BlYmFja2VuZC1mZG8KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjI1NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRl ZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwOgorICAgICAgICAoV2ViS2l0Ojp0cnlJbml0aWFsaXpl U0hNKTogUmV0dXJuIGZhbHNlIGZvciB3cGViYWNrZW5kLWZkbyA8IDEuNy4wLgorCiAyMDIwLTA5 LTA3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByZXZlcnRpbmcgcjI2NjY0NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5bGFuZC5jcHAK aW5kZXggMjMwMzFhN2JmMmJkLi5mNWJjMmUwNTRiNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxh bmQuY3BwCkBAIC0xMzYsNiArMTM2LDggQEAgc3RhdGljIGJvb2wgdHJ5SW5pdGlhbGl6ZVNITSgp CiAjaWYgV1BFX0ZET19DSEVDS19WRVJTSU9OKDEsIDcsIDApCiAgICAgaWYgKCF3cGVfZmRvX2lu aXRpYWxpemVfc2htKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbHNlCisgICAgcmV0dXJu IGZhbHNlOwogI2VuZGlmCiAKICAgICBzX3dheWxhbmRJbXBsID0gV2F5bGFuZEltcGw6OlNITTsK 408202 2020-09-07 16:32:41 -0700 2020-09-08 07:26:02 -0700 Patch. shm.patch text/plain 1259 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYWYyZGVjM2IyNGYyLi41M2M0Yzk1ZTczNmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjAtMDktMDcgIE1pa2UgR29yc2UgIDxtZ29yc2VAc3VzZS5jb20+CisKKyAg ICAgICAgQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kIG1pZ2h0IGVycm9uZW91c2x5IHRy eSB0byB1c2UgU0hNIHdpdGggb2xkZXIgd3BlYmFja2VuZC1mZG8KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjI1NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRl ZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwOgorICAgICAgICAoV2ViS2l0Ojp0cnlJbml0aWFsaXpl U0hNKTogUmV0dXJuIGZhbHNlIGZvciB3cGViYWNrZW5kLWZkbyA8IDEuNy4wLgorCiAyMDIwLTA5 LTA3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByZXZlcnRpbmcgcjI2NjY0NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5bGFuZC5jcHAK aW5kZXggMjMwMzFhN2JmMmJkLi4yMTMwYjUxN2Q1OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxh bmQuY3BwCkBAIC0xMzYsMTAgKzEzNiwxMiBAQCBzdGF0aWMgYm9vbCB0cnlJbml0aWFsaXplU0hN KCkKICNpZiBXUEVfRkRPX0NIRUNLX1ZFUlNJT04oMSwgNywgMCkKICAgICBpZiAoIXdwZV9mZG9f aW5pdGlhbGl6ZV9zaG0oKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotI2VuZGlmCiAKICAgICBz X3dheWxhbmRJbXBsID0gV2F5bGFuZEltcGw6OlNITTsKICAgICByZXR1cm4gdHJ1ZTsKKyNlbHNl CisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCiB9CiAjZW5kaWYgLy8gVVNFKFdQRV9SRU5ERVJF UikKIAo= 408227 2020-09-08 07:26:02 -0700 2020-09-08 08:25:11 -0700 Patch. shm.patch text/plain 1328 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggN2I3MGY1YzliZWI5Li4zZTM3Mjk2MTdlNDkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjAtMDktMDggIE1pa2UgR29yc2UgIDxtZ29yc2VAc3VzZS5jb20+CisKKyAg ICAgICAgW0dUS10gQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kIG1pZ2h0IGVycm9uZW91 c2x5IHRyeSB0byB1c2UgU0hNIHdpdGggb2xkZXIgd3BlYmFja2VuZC1mZG8KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjI1NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9BY2Nl bGVyYXRlZEJhY2tpbmdTdG9yZVdheWxhbmQuY3BwOgorICAgICAgICAoV2ViS2l0Ojp0cnlJbml0 aWFsaXplU0hNKTogUmV0dXJuIGZhbHNlIGZvciB3cGViYWNrZW5kLWZkbyA8IDEuNy4wLgorCiAy MDIwLTA5LTA4ICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHTElCXSBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIgaXMgbm90IHN0YXJ0ZWQgaWYgV2ViS2l0 V2ViQ29udGV4dCBpcyBub3QgY3JlYXRlZCBhbHJlYWR5IGNyZWF0ZWQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxhbmQu Y3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3Jl V2F5bGFuZC5jcHAKaW5kZXggMjMwMzFhN2JmMmJkLi4yMTMwYjUxN2Q1OWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxh bmQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tp bmdTdG9yZVdheWxhbmQuY3BwCkBAIC0xMzYsMTAgKzEzNiwxMiBAQCBzdGF0aWMgYm9vbCB0cnlJ bml0aWFsaXplU0hNKCkKICNpZiBXUEVfRkRPX0NIRUNLX1ZFUlNJT04oMSwgNywgMCkKICAgICBp ZiAoIXdwZV9mZG9faW5pdGlhbGl6ZV9zaG0oKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotI2Vu ZGlmCiAKICAgICBzX3dheWxhbmRJbXBsID0gV2F5bGFuZEltcGw6OlNITTsKICAgICByZXR1cm4g dHJ1ZTsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCiB9CiAjZW5kaWYgLy8gVVNF KFdQRV9SRU5ERVJFUikKIAo=