216249 2020-09-07 12:32:58 -0700 [css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode 2020-09-08 00:36:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar changseok darin esprehn+autocc ews-watchlist glenn kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1686419 0 svillar 2020-09-07 12:32:58 -0700 [css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode 1686426 1 408193 svillar 2020-09-07 12:49:05 -0700 Created attachment 408193 Patch 1686449 2 408193 zalan 2020-09-07 16:06:36 -0700 Comment on attachment 408193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408193&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:291 > + // We need the containing block to have a definite block-size in order to resolve the block-size of the descendant, > + // except when in quirks mode. Flexboxes follow strict behavior even in quirks mode, though. > + if (!cb || (document().inQuirksMode() && !cb->isFlexibleBoxIncludingDeprecated())) This pretty much sums up what I dislike about the current RenderTree design. 1686501 3 svillar 2020-09-08 00:35:57 -0700 Committed r266716: <https://trac.webkit.org/changeset/266716> 1686502 4 webkit-bug-importer 2020-09-08 00:36:17 -0700 <rdar://problem/68491400> 408193 2020-09-07 12:49:05 -0700 2020-09-07 16:04:02 -0700 Patch bug-216249-20200907214903.patch text/plain 6914 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThjYTdiYTNiNzk2NjZh MTUwZTYxOWRiMWM5ZWQ2NmZmMGQyNDdmMi4uYTc3MmY0ZWRkYTgyNWQ3ZmRmYTU0NWQxZjBhOThk MDlkN2MwMDU2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTA3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eF0gRG9uJ3Qgc2tpcCBmbGV4Ym94ZXMgd2l0aCBhdXRvIGhlaWdodCBmb3IgcGVyY2VudGFnZSBj b21wdXRhdGlvbnMgaW4gcXVpcmtzIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxNjI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZG4ndCBza2lwIGZsZXhib3hlcyB3aXRoIGhlaWdo dDphdXRvIHdoZW4gZ29pbmcgdXAgdGhlIGFuY2VzdG9yIGNoYWluIGFzIHdlIGRvIHdpdGggb3Ro ZXIgdHlwZXMgYXMgZ3JpZC4KKworICAgICAgICBBcGFydCBmcm9tIHRoYXQsIHdlIGZvcmNlIGZs ZXhpYmxlIGJveCB0byBmb2xsb3cgc3RyaWN0IG1vZGUgZXZlbiB3aGVuIGRvY3VtZW50IGlzIGlu IHF1aXJrcyBtb2RlIGFzIGZsZXhib3gKKyAgICAgICAgd2FzIGludmVudGVkIHdheSBhZnRlciBx dWlya3kgYnJvd3NlcnMuIFRoaXMgbWF0Y2hlcyBDaHJvbWl1bSwgRWRnZSAocHJlLUNocm9taXVt KSBhbmQgRmlyZWZveCBiZWhhdmlvdXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6c2tpcENvbnRhaW5pbmdCbG9ja0Zv clBlcmNlbnRIZWlnaHRDYWxjdWxhdGlvbiBjb25zdCk6IERvbid0IHNraXAgZmxleGJveGVzLgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6aGFzQXV0b0hlaWdodE9yQ29udGFpbmluZ0Js b2NrV2l0aEF1dG9IZWlnaHQgY29uc3QpOiBJZ25vcmUgcXVpcmtzIG1vZGUgZm9yIGZsZXhib3hl cy4KKwogMjAyMC0wOS0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgRml4IGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNjY1MDggYXMgcGVy IHBvc3QtY29tbWl0IGNvbW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3Bw CmluZGV4IDhmM2ZiOGZhMjZjOTI1MDg4Y2UyN2I2MTEzNjY1YWYyN2NjOTViYTUuLmI4N2MzNzBh NjkxOGQyYzhkNWYxYmNiZGFmOTRhYWIxYWEwYjgyYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCkBAIC0yOTg3LDcgKzI5ODcsNyBAQCBib29sIFJlbmRlckJveDo6c2tp cENvbnRhaW5pbmdCbG9ja0ZvclBlcmNlbnRIZWlnaHRDYWxjdWxhdGlvbihjb25zdCBSZW5kZXJC b3gmCiAgICAgCiAgICAgLy8gRm9yIHF1aXJrcyBtb2RlLCB3ZSBza2lwIG1vc3QgYXV0by1oZWln aHQgY29udGFpbmluZyBibG9ja3Mgd2hlbiBjb21wdXRpbmcKICAgICAvLyBwZXJjZW50YWdlcy4K LSAgICByZXR1cm4gZG9jdW1lbnQoKS5pblF1aXJrc01vZGUoKSAmJiAhY29udGFpbmluZ0Jsb2Nr LmlzVGFibGVDZWxsKCkgJiYgIWNvbnRhaW5pbmdCbG9jay5pc091dE9mRmxvd1Bvc2l0aW9uZWQo KSAmJiAhY29udGFpbmluZ0Jsb2NrLmlzUmVuZGVyR3JpZCgpICYmIGNvbnRhaW5pbmdCbG9jay5z dHlsZSgpLmxvZ2ljYWxIZWlnaHQoKS5pc0F1dG8oKTsKKyAgICByZXR1cm4gZG9jdW1lbnQoKS5p blF1aXJrc01vZGUoKSAmJiAhY29udGFpbmluZ0Jsb2NrLmlzVGFibGVDZWxsKCkgJiYgIWNvbnRh aW5pbmdCbG9jay5pc091dE9mRmxvd1Bvc2l0aW9uZWQoKSAmJiAhY29udGFpbmluZ0Jsb2NrLmlz UmVuZGVyR3JpZCgpICYmICFjb250YWluaW5nQmxvY2suaXNGbGV4aWJsZUJveEluY2x1ZGluZ0Rl cHJlY2F0ZWQoKSAmJiBjb250YWluaW5nQmxvY2suc3R5bGUoKS5sb2dpY2FsSGVpZ2h0KCkuaXNB dXRvKCk7CiB9CiAKIGJvb2wgUmVuZGVyQm94OjpzaG91bGRUcmVhdENoaWxkQXNSZXBsYWNlZElu VGFibGVDZWxscygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94TW9kZWxPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveE1vZGVsT2JqZWN0LmNwcAppbmRleCA1ZGRmYzMxMTg0N2JhZmQ5M2YzMzk0OGMxMTI1YmVl ZThjMjgzOTg3Li5mMTY3YzNiMmNjMmUwMmM3YTZhMTViNjA4YzdiYWNmYTZmZjYwNThiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAK QEAgLTI4NiwxMyArMjg2LDEyIEBAIGJvb2wgUmVuZGVyQm94TW9kZWxPYmplY3Q6Omhhc0F1dG9I ZWlnaHRPckNvbnRhaW5pbmdCbG9ja1dpdGhBdXRvSGVpZ2h0KCkgY29uc3QKICAgICBpZiAobG9n aWNhbEhlaWdodExlbmd0aC5pc0F1dG8oKSAmJiAhaXNPdXRPZkZsb3dQb3NpdGlvbmVkV2l0aElt cGxpY2l0SGVpZ2h0KCp0aGlzKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBpZiAoZG9j dW1lbnQoKS5pblF1aXJrc01vZGUoKSkKKyAgICAvLyBXZSBuZWVkIHRoZSBjb250YWluaW5nIGJs b2NrIHRvIGhhdmUgYSBkZWZpbml0ZSBibG9jay1zaXplIGluIG9yZGVyIHRvIHJlc29sdmUgdGhl IGJsb2NrLXNpemUgb2YgdGhlIGRlc2NlbmRhbnQsCisgICAgLy8gZXhjZXB0IHdoZW4gaW4gcXVp cmtzIG1vZGUuIEZsZXhib3hlcyBmb2xsb3cgc3RyaWN0IGJlaGF2aW9yIGV2ZW4gaW4gcXVpcmtz IG1vZGUsIHRob3VnaC4KKyAgICBpZiAoIWNiIHx8IChkb2N1bWVudCgpLmluUXVpcmtzTW9kZSgp ICYmICFjYi0+aXNGbGV4aWJsZUJveEluY2x1ZGluZ0RlcHJlY2F0ZWQoKSkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAotICAgIGlmIChjYikKLSAgICAgICAgcmV0dXJuICFjYi0+aGFzRGVmaW5p dGVMb2dpY2FsSGVpZ2h0KCk7Ci0KLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuICFjYi0+ aGFzRGVmaW5pdGVMb2dpY2FsSGVpZ2h0KCk7CiB9CiAKIERlY29kaW5nTW9kZSBSZW5kZXJCb3hN b2RlbE9iamVjdDo6ZGVjb2RpbmdNb2RlRm9ySW1hZ2VEcmF3KGNvbnN0IEltYWdlJiBpbWFnZSwg Y29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8pIGNvbnN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwppbmRleCA5NmMzOWI2MWFiMzhhNjVkMThiNmI0MmY0OWFhOTllZTYyZGZjNjVjLi5iN2My NDE1ZWRkOGE2ZmMwMDAyNzI1NDRkY2M3MjliZGYyMjM4ODhjIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wOS0wNyAgU2VyZ2lvIFZpbGxhciBT ZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbY3NzLWZsZXhdIERvbid0IHNr aXAgZmxleGJveGVzIHdpdGggYXV0byBoZWlnaHQgZm9yIHBlcmNlbnRhZ2UgY29tcHV0YXRpb25z IGluIHF1aXJrcyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTYyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXhlZCB0aGUgKEZBSUwpIGV4cGVjdGF0aW9ucyBvZiB0d28gV1BUIHRlc3RzIHRo YXQgYXJlIG5vdyBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9j c3MtZmxleGJveC9wZXJjZW50YWdlLXNpemUtcXVpcmtzLWV4cGVjdGVkLnR4dDogUmVwbGFjZWQg RkFJTCB3aXRoIFBBU1MuCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxl eGJveC9xdWlya3MtYXV0by1ibG9jay1zaXplLXdpdGgtcGVyY2VudGFnZS1pdGVtLWV4cGVjdGVk LnR4dDogRGl0dG8uCisKIDIwMjAtMDktMDYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIE1ha2UgVGV4dENvZGVjQ0pLIGFuZCBUZXh0Q29kZWNTaW5nbGVCeXRlIHRo cmVhZC1zYWZlIGFuZCByZWZhY3RvciBhIGJpdCB0byBzaGFyZSBjb2RlCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJv eC9wZXJjZW50YWdlLXNpemUtcXVpcmtzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3BlcmNlbnRhZ2Utc2l6 ZS1xdWlya3MtZXhwZWN0ZWQudHh0CmluZGV4IDMyMDhhYTlkNjM1ODU0MWJlYzE0Y2FjZDBhOGFl ZWQxNTk1ZWE1YzAuLjI4ZGQ3MzIxNWRiMjI4ZGQzNzkwYzFiZmExNmRhMDU1YmI3MTc3M2UgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3Nz L2Nzcy1mbGV4Ym94L3BlcmNlbnRhZ2Utc2l6ZS1xdWlya3MtZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94 L3BlcmNlbnRhZ2Utc2l6ZS1xdWlya3MtZXhwZWN0ZWQudHh0CkBAIC0xLDIxICsxLDEwIEBACiAK IFBBU1MgLmZsZXhib3ggMSAKIFBBU1MgLmZsZXhib3ggMiAKLUZBSUwgLmZsZXhib3ggMyBhc3Nl cnRfZXF1YWxzOiAKLTxkaXYgY2xhc3M9ImZsZXhib3giIHN0eWxlPSJoZWlnaHQ6IGF1dG8iPgot ICAgICAgICA8ZGl2IHN0eWxlPSJoZWlnaHQ6IDEwcHg7IG1pbi1oZWlnaHQ6IDUwJTsiIGRhdGEt ZXhwZWN0ZWQtaGVpZ2h0PSIxMCI+PC9kaXY+Ci0gICAgICAgIDxkaXYgc3R5bGU9ImhlaWdodDog NTAlOyIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjAiPjwvZGl2PgotICAgICAgICA8ZGl2IHN0eWxl PSJoZWlnaHQ6IDEwcHg7IG1heC1oZWlnaHQ6IDUwJTsiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIx MCI+PC9kaXY+Ci0gICAgICAgIDxkaXYgc3R5bGU9Im1pbi1oZWlnaHQ6IDEwcHg7IGhlaWdodDog MTAwcHg7IG1heC1oZWlnaHQ6IDUwJTsiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIxMDAiPjwvZGl2 PgotICAgIDwvZGl2PgotaGVpZ2h0IGV4cGVjdGVkIDEwIGJ1dCBnb3QgMjUKK1BBU1MgLmZsZXhi b3ggMyAKIFBBU1MgLmZsZXhib3ggNCAKIFBBU1MgLmZsZXhib3ggNSAKLUZBSUwgLmZsZXhib3gg NiBhc3NlcnRfZXF1YWxzOiAKLTxkaXYgY2xhc3M9ImZsZXhib3giPgotICAgICAgICA8ZGl2IHN0 eWxlPSJmbGV4OiAwIDAgNTAlIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMCI+PC9kaXY+Ci0gICAg PC9kaXY+Ci1oZWlnaHQgZXhwZWN0ZWQgMCBidXQgZ290IDI1CitQQVNTIC5mbGV4Ym94IDYgCiBQ QVNTIC5mbGV4Ym94IDcgCiBQQVNTIC5mbGV4Ym94IDggCiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3F1aXJr cy1hdXRvLWJsb2NrLXNpemUtd2l0aC1wZXJjZW50YWdlLWl0ZW0tZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gv cXVpcmtzLWF1dG8tYmxvY2stc2l6ZS13aXRoLXBlcmNlbnRhZ2UtaXRlbS1leHBlY3RlZC50eHQK aW5kZXggYzEwNjMzNDU0MDQ4Y2ExOGZmZDUwNDI3MDUzZGJkMzMzODczOTE0Ni4uMGRiNmRmMzcz MGZjOWU2Y2M0N2I1OWFkN2VlYTVlMjA3OTE4N2M5YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvcXVpcmtzLWF1 dG8tYmxvY2stc2l6ZS13aXRoLXBlcmNlbnRhZ2UtaXRlbS1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gv cXVpcmtzLWF1dG8tYmxvY2stc2l6ZS13aXRoLXBlcmNlbnRhZ2UtaXRlbS1leHBlY3RlZC50eHQK QEAgLTIsMTIgKzIsNSBAQCBUaGVyZSBzaG91bGQgYmUgYSBncmVlbiBzcXVhcmUgdG8gdGhlIGxl ZnQgb2YgYSBibHVlIHNxdWFyZSwgYW5kIG5vIHJlZC4KIAogCiAKLUZBSUwgI2NvbnRhaW5lciAx IGFzc2VydF9lcXVhbHM6IAotPGRpdiBpZD0iY29udGFpbmVyIiBzdHlsZT0id2lkdGg6MjAwcHg7 IGhlaWdodDo0NTZweDsiPgotICA8ZGl2IHN0eWxlPSJkaXNwbGF5OmZsZXg7IGJhY2tncm91bmQ6 Ymx1ZTsiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIxMDAiPgotICAgIDxpbWcgc3R5bGU9IndpZHRo OjEwMHB4OyBoZWlnaHQ6IDUwJTsiIHNyYz0ic3VwcG9ydC8xeDEtZ3JlZW4ucG5nIiBkYXRhLWV4 cGVjdGVkLWhlaWdodD0iMTAwIj4KLSAgICA8ZGl2IHN0eWxlPSJ3aWR0aDogNTBweDsgaGVpZ2h0 OiAxMDAlOyBiYWNrZ3JvdW5kOiByZWQ7IiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMCI+PC9kaXY+ Ci0gIDwvZGl2PgotPC9kaXY+Ci1oZWlnaHQgZXhwZWN0ZWQgMTAwIGJ1dCBnb3QgNDU2CitQQVNT ICNjb250YWluZXIgMSAKIAo=