216226 2020-09-06 07:47:05 -0700 Build failure; cannot find seccomp.h 2020-09-09 15:06:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All Linux RESOLVED FIXED P2 Normal --- 1 mgorse webkit-unassigned annulen aperez bugs-noreply darin ews-watchlist gyuyoung.kim mgorse ryuan.choi sergio oldest_to_newest 1686187 0 mgorse 2020-09-06 07:47:05 -0700 I am getting a build failure with webkitgtk 2.29.92 where g++ cannot find seccomp.h when BubblewrapLauncher.cpp tries to include it. It looks as though LIBSECCOMP_INCLUDE_DIRS just isn't being added to WebKit_SYSTEM_INCLUDE_DIRECTORIES, so I'm not sure why I'm seeing a failure now where I wasn't with 2.28.4. 1686191 1 408123 mgorse 2020-09-06 09:29:58 -0700 Created attachment 408123 Patch. 1686216 2 ews-feeder 2020-09-06 14:24:52 -0700 ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. 1686352 3 408177 mgorse 2020-09-07 07:03:55 -0700 Created attachment 408177 Patch. 1686370 4 408177 darin 2020-09-07 09:47:14 -0700 Comment on attachment 408177 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=408177&action=review > Source/WebKit/ChangeLog:8 > + No new tests (build fix only). Next time you contribute a patch like this you are welcome to just delete this line altogether. 1686377 5 ews-feeder 2020-09-07 10:02:45 -0700 Committed r266702: <https://trac.webkit.org/changeset/266702> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408177. 1687142 6 aperez 2020-09-09 15:06:11 -0700 It would have been nice to convert the CMake find module for libseccomp to use imported targets while at it… anyway—next time, thanks for writing the patch, Mike! 408123 2020-09-06 09:29:58 -0700 2020-09-07 07:03:55 -0700 Patch. build.patch text/plain 1097 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTVlZmUzMjEwZjIwLi5iOTc3YjRkOTI1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDktMDYgIE1pa2UgR29yc2UgIDxtZ29yc2VAc3VzZS5jb20+CisKKyAg ICAgICAgQnVpbGQgZmFpbHVyZTsgY2Fubm90IGZpbmQgc2VjY29tcC5oCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyMjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4K KworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOiBBZGQgTElCU0VDQ09NUF9JTkNMVURFX0RJ UlMgdG8KKyAgICAgICAgV2ViS2l0X1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTLgorCiAyMDIw LTA5LTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAg IFtNb3Rpb25NYXJrXSBSZW5kZXJMYXllcjo6cGFpbnRMYXllckNvbnRlbnRzIHNwZW5kcyB+NSUg b2YgdGhlIHRpbWUgaW4gTW9ub3RvbmljVGltZTo6bm93KCkgaW4gTXVsdGlwbHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0L1BsYXRm b3JtR1RLLmNtYWtlCmluZGV4IDcxNWQzOGQ3NmI4OS4uMzMzZmFmNGUyYWM0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm1HVEsuY21ha2UKQEAgLTQ0Myw2ICs0NDMsNyBAQCBsaXN0KEFQUEVORCBXZWJLaXRfU1lT VEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0dTVFJFQU1FUl9JTkNMVURFX0RJUlN9CiAg ICAgJHtHU1RSRUFNRVJfUEJVVElMU19JTkNMVURFX0RJUlN9CiAgICAgJHtHVEtfSU5DTFVERV9E SVJTfQorICAgICR7TElCU0VDQ09NUF9JTkNMVURFX0RJUlN9CiAgICAgJHtMSUJTT1VQX0lOQ0xV REVfRElSU30KICkKIAo= 408177 2020-09-07 07:03:55 -0700 2020-09-07 10:02:46 -0700 Patch. build.patch text/plain 1106 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTVlZmUzMjEwZjIwLi40NDU1NDAzNGJmMTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDktMDYgIE1pa2UgR29yc2UgIDxtZ29yc2VAc3VzZS5jb20+CisKKyAg ICAgICAgQnVpbGQgZmFpbHVyZTsgY2Fubm90IGZpbmQgc2VjY29tcC5oCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyMjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKGJ1aWxkIGZp eCBvbmx5KS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOiBBZGQgTElCU0VDQ09NUF9J TkNMVURFX0RJUlMgdG8KKyAgICAgICAgV2ViS2l0X1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVT LgorCiAyMDIwLTA5LTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgog CiAgICAgICAgIFtNb3Rpb25NYXJrXSBSZW5kZXJMYXllcjo6cGFpbnRMYXllckNvbnRlbnRzIHNw ZW5kcyB+NSUgb2YgdGhlIHRpbWUgaW4gTW9ub3RvbmljVGltZTo6bm93KCkgaW4gTXVsdGlwbHkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDcxNWQzOGQ3NmI4OS4uMzMzZmFmNGUyYWM0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTQ0Myw2ICs0NDMsNyBAQCBsaXN0KEFQUEVORCBX ZWJLaXRfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0dTVFJFQU1FUl9JTkNMVURF X0RJUlN9CiAgICAgJHtHU1RSRUFNRVJfUEJVVElMU19JTkNMVURFX0RJUlN9CiAgICAgJHtHVEtf SU5DTFVERV9ESVJTfQorICAgICR7TElCU0VDQ09NUF9JTkNMVURFX0RJUlN9CiAgICAgJHtMSUJT T1VQX0lOQ0xVREVfRElSU30KICkKIAo=