<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>216218</bug_id>
          
          <creation_ts>2020-09-05 14:36:41 -0700</creation_ts>
          <short_desc>Fix formatting of LegacyOverrideBuiltIns</short_desc>
          <delta_ts>2020-09-05 17:45:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Sam Weinig">sam</assigned_to>
          <cc>darin</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1686123</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-05 14:36:41 -0700</bug_when>
    <thetext>Fix formatting of LegacyOverrideBuiltIns</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686124</commentid>
    <comment_count>1</comment_count>
      <attachid>408098</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-05 14:37:56 -0700</bug_when>
    <thetext>Created attachment 408098
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686133</commentid>
    <comment_count>2</comment_count>
      <attachid>408098</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-09-05 15:18:29 -0700</bug_when>
    <thetext>Comment on attachment 408098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408098&amp;action=review

&gt; Source/WebCore/bindings/js/JSDOMAbstractOperations.h:35
&gt; +enum class LegacyOverrideBuiltIns {  No, Yes };

Extra space before &quot;No&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686144</commentid>
    <comment_count>3</comment_count>
      <attachid>408105</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-05 17:12:03 -0700</bug_when>
    <thetext>Created attachment 408105
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686151</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-09-05 17:44:11 -0700</bug_when>
    <thetext>Committed r266676: &lt;https://trac.webkit.org/changeset/266676&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408105.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686152</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-09-05 17:45:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/68408023&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>408098</attachid>
            <date>2020-09-05 14:37:56 -0700</date>
            <delta_ts>2020-09-05 17:12:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-216218-20200905143755.patch</filename>
            <type>text/plain</type>
            <size>1483</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NjY3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTA1ICBTYW0gV2Vp
bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggZm9ybWF0dGluZyBvZiBMZWdh
Y3lPdmVycmlkZUJ1aWx0SW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0yMTYyMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBOZWdsZWN0ZWQgdG8gZml4IHRoaXMgYml0IG9mIGZlZWRiYWNrIGluIGEgcHJl
dmlvdXMgY2hhbmdlLiBNYWtlcyAKKyAgICAgICAgZW51bSBjbGFzcyBMZWdhY3lPdmVycmlkZUJ1
aWx0SW5zIGEgYml0IG1vcmUgcmVhZGFibGUuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RP
TUFic3RyYWN0T3BlcmF0aW9ucy5oOgorCiAyMDIwLTA5LTA1ICBNeWxlcyBDLiBNYXhmaWVsZCAg
PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBVU0UoUExBVEZPUk1fU1lT
VEVNX0ZBTExCQUNLX0xJU1QpIGlzIHRydWUgb24gYWxsIENvY29hIHBsYXRmb3Jtcywgc28gdGhl
cmUncyBubyBuZWVkIHRvIGNvbnN1bHQgaXQgaW4gQ29jb2Etc3BlY2lmaWMgZmlsZXMKSW5kZXg6
IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQWJzdHJhY3RPcGVyYXRpb25zLmgKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01BYnN0cmFjdE9wZXJh
dGlvbnMuaAkocmV2aXNpb24gMjY2NjcxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv
SlNET01BYnN0cmFjdE9wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMzIsMTAgKzMyLDcg
QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogLy8gSW1wbGVtZW50YXRpb25zIG9mIHRoZSBhYnN0cmFj
dCBvcGVyYXRpb25zIGRlZmluZWQgYXQKIC8vIGh0dHBzOi8vaGV5Y2FtLmdpdGh1Yi5pby93ZWJp
ZGwvI2xlZ2FjeS1wbGF0Zm9ybS1vYmplY3QtYWJzdHJhY3Qtb3BzCiAKLWVudW0gY2xhc3MgTGVn
YWN5T3ZlcnJpZGVCdWlsdElucyB7Ci0gICAgTm8sCi0gICAgWWVzCi19OworZW51bSBjbGFzcyBM
ZWdhY3lPdmVycmlkZUJ1aWx0SW5zIHsgIE5vLCBZZXMgfTsKIAogLy8gQW4gaW1wbGVtZW50YXRp
b24gb2YgdGhlICduYW1lZCBwcm9wZXJ0eSB2aXNpYmlsaXR5IGFsZ29yaXRobScKIC8vIGh0dHBz
Oi8vaGV5Y2FtLmdpdGh1Yi5pby93ZWJpZGwvI2Rmbi1uYW1lZC1wcm9wZXJ0eS12aXNpYmlsaXR5
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>408105</attachid>
            <date>2020-09-05 17:12:03 -0700</date>
            <delta_ts>2020-09-05 17:44:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-216218-20200905171202.patch</filename>
            <type>text/plain</type>
            <size>1404</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NjY3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTA1ICBTYW0gV2Vp
bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggZm9ybWF0dGluZyBvZiBMZWdh
Y3lPdmVycmlkZUJ1aWx0SW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0yMTYyMTgKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKwor
ICAgICAgICBOZWdsZWN0ZWQgdG8gZml4IHRoaXMgYml0IG9mIGZlZWRiYWNrIGluIGEgcHJldmlv
dXMgY2hhbmdlLiBNYWtlcyAKKyAgICAgICAgZW51bSBjbGFzcyBMZWdhY3lPdmVycmlkZUJ1aWx0
SW5zIGEgYml0IG1vcmUgcmVhZGFibGUuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUFi
c3RyYWN0T3BlcmF0aW9ucy5oOgorCiAyMDIwLTA5LTA1ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1t
YXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBGYW1pbHldIFJlbW92ZSB0aGUgY29u
Y2VwdCBvZiBjdXN0b20gZmFsbGJhY2sgZm9udHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRp
bmdzL2pzL0pTRE9NQWJzdHJhY3RPcGVyYXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl
YkNvcmUvYmluZGluZ3MvanMvSlNET01BYnN0cmFjdE9wZXJhdGlvbnMuaAkocmV2aXNpb24gMjY2
NjczKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01BYnN0cmFjdE9wZXJhdGlv
bnMuaAkod29ya2luZyBjb3B5KQpAQCAtMzIsMTAgKzMyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUg
ewogLy8gSW1wbGVtZW50YXRpb25zIG9mIHRoZSBhYnN0cmFjdCBvcGVyYXRpb25zIGRlZmluZWQg
YXQKIC8vIGh0dHBzOi8vaGV5Y2FtLmdpdGh1Yi5pby93ZWJpZGwvI2xlZ2FjeS1wbGF0Zm9ybS1v
YmplY3QtYWJzdHJhY3Qtb3BzCiAKLWVudW0gY2xhc3MgTGVnYWN5T3ZlcnJpZGVCdWlsdElucyB7
Ci0gICAgTm8sCi0gICAgWWVzCi19OworZW51bSBjbGFzcyBMZWdhY3lPdmVycmlkZUJ1aWx0SW5z
IHsgTm8sIFllcyB9OwogCiAvLyBBbiBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgJ25hbWVkIHByb3Bl
cnR5IHZpc2liaWxpdHkgYWxnb3JpdGhtJwogLy8gaHR0cHM6Ly9oZXljYW0uZ2l0aHViLmlvL3dl
YmlkbC8jZGZuLW5hbWVkLXByb3BlcnR5LXZpc2liaWxpdHkK
</data>

          </attachment>
      

    </bug>

</bugzilla>