216216 2020-09-05 12:42:46 -0700 XML documents in iframes should not inherit encoding from parent frame 2020-09-05 13:55:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez darin ews-watchlist japhet webkit-bug-importer oldest_to_newest 1686101 0 achristensen 2020-09-05 12:42:46 -0700 XML documents in iframes should not inherit encoding from parent frame 1686103 1 408093 achristensen 2020-09-05 12:44:00 -0700 Created attachment 408093 Patch 1686106 2 408093 darin 2020-09-05 12:48:41 -0700 Comment on attachment 408093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408093&action=review > Source/WebCore/loader/DocumentWriter.cpp:61 > + if (auto* document = frame ? frame->document() : nullptr) { > + if (document->isXMLDocument()) > + return false; > + } The code in this function dereferences frame without checking for null. And the only caller already dereferences the frame before calling this function. So we do not need to check for null here. We should change the argument type to a reference. Also, the only caller calls this function twice in a row. It should use a boolean local instead. Could write this: if (is<XMLDocument>(frame->document())) return false; The null check is built into the is<> function. But also, the code below uses frame->document() without checking it for null either. 1686108 3 408093 darin 2020-09-05 12:50:22 -0700 Comment on attachment 408093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408093&action=review > Source/WebCore/loader/DocumentWriter.cpp:59 > + if (document->isXMLDocument()) Maybe this should be done the other way around, where the HTMLDocument case is the special one: if (!is<HTMLDocument>(frame->document())) return false; Or: return is<HTMLDocument>(frame->document()) && parentFrame && ... 1686113 4 achristensen 2020-09-05 13:54:57 -0700 http://trac.webkit.org/r266671 1686114 5 webkit-bug-importer 2020-09-05 13:55:14 -0700 <rdar://problem/68404034> 408093 2020-09-05 12:44:00 -0700 2020-09-05 12:48:41 -0700 Patch bug-216216-20200905124359.patch text/plain 3477 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NjY1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTA1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgWE1MIGRvY3Vt ZW50cyBpbiBpZnJhbWVzIHNob3VsZCBub3QgaW5oZXJpdCBlbmNvZGluZyBmcm9tIHBhcmVudCBm cmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2 MjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBzZWVtcyB0byBtYXRjaCB0aGUgYmVoYXZpb3Igb2YgQ2hyb21lIGFuZCBGaXJlZm94LgorICAg ICAgICBDb3ZlcmVkIGJ5IG5ld2x5IHBhc3Npbmcgd2ViIHBsYXRmb3JtIHRlc3RzLCB3aGljaCBv dGhlciBicm93c2VycyBhbHJlYWR5IHBhc3MuCisKKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRX cml0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FuUmVmZXJUb1BhcmVudEZyYW1lRW5jb2Rp bmcpOgorCiAyMDIwLTA5LTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgRml4IGJ1aWxkIHdoZW4gdXNpbmcgbm9uLXN0YW5kYXJkIHVuaWZp ZWQgc291cmNlcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNw cAkocmV2aXNpb24gMjY2NjUwKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3Jp dGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsMTAgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiBzdGF0aWMgaW5saW5lIGJvb2wgY2FuUmVmZXJUb1BhcmVudEZyYW1lRW5jb2Rpbmco Y29uc3QgRnJhbWUqIGZyYW1lLCBjb25zdCBGcmFtZSogcGFyZW50RnJhbWUpIAogeworICAgIGlm IChhdXRvKiBkb2N1bWVudCA9IGZyYW1lID8gZnJhbWUtPmRvY3VtZW50KCkgOiBudWxscHRyKSB7 CisgICAgICAgIGlmIChkb2N1bWVudC0+aXNYTUxEb2N1bWVudCgpKQorICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KICAgICByZXR1cm4gcGFyZW50RnJhbWUgJiYgcGFyZW50RnJhbWUt PmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCkuY2FuQWNjZXNzKGZyYW1lLT5kb2N1bWVudCgp LT5zZWN1cml0eU9yaWdpbigpKTsKIH0KICAgICAKSW5kZXg6IExheW91dFRlc3RzL2ltcG9ydGVk L3czYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZwkocmV2aXNpb24gMjY2NjY3KQorKysgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA5LTA1ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgWE1MIGRv Y3VtZW50cyBpbiBpZnJhbWVzIHNob3VsZCBub3QgaW5oZXJpdCBlbmNvZGluZyBmcm9tIHBhcmVu dCBmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE2MjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3ZWItcGxhdGZvcm0tdGVzdHMvZW5jb2RpbmcvdXRmLTMyLWZyb20td2luMTI1Mi1leHBlY3Rl ZC50eHQ6CisKIDIwMjAtMDktMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIENTUyByZXZlcnQgc2hvdWxkIHNlcmlhbGl6ZSBhcyAicmV2ZXJ0Iiwgbm90ICJSZXZl cnQiCkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Vu Y29kaW5nL3V0Zi0zMi1mcm9tLXdpbjEyNTItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZW5jb2RpbmcvdXRmLTMy LWZyb20td2luMTI1Mi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDI2NjY1MCkKKysrIExheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZW5jb2RpbmcvdXRmLTMyLWZyb20t d2luMTI1Mi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMTAgKzEsMTAgQEAKIAog UEFTUyBFeHBlY3QgcmVzb3VyY2VzL3V0Zi0zMi1iaWctZW5kaWFuLWJvbS5odG1sIHRvIHBhcnNl IGFzIHdpbmRvd3MtMTI1MiAKLUZBSUwgRXhwZWN0IHJlc291cmNlcy91dGYtMzItYmlnLWVuZGlh bi1ib20ueG1sIHRvIHBhcnNlIGFzIFVURi04IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJVVEYt OCIgYnV0IGdvdCAid2luZG93cy0xMjUyIgorUEFTUyBFeHBlY3QgcmVzb3VyY2VzL3V0Zi0zMi1i aWctZW5kaWFuLWJvbS54bWwgdG8gcGFyc2UgYXMgVVRGLTggCiBQQVNTIEV4cGVjdCByZXNvdXJj ZXMvdXRmLTMyLWJpZy1lbmRpYW4tbm9ib20uaHRtbCB0byBwYXJzZSBhcyB3aW5kb3dzLTEyNTIg Ci1GQUlMIEV4cGVjdCByZXNvdXJjZXMvdXRmLTMyLWJpZy1lbmRpYW4tbm9ib20ueG1sIHRvIHBh cnNlIGFzIFVURi04IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJVVEYtOCIgYnV0IGdvdCAid2lu ZG93cy0xMjUyIgorUEFTUyBFeHBlY3QgcmVzb3VyY2VzL3V0Zi0zMi1iaWctZW5kaWFuLW5vYm9t LnhtbCB0byBwYXJzZSBhcyBVVEYtOCAKIFBBU1MgRXhwZWN0IHJlc291cmNlcy91dGYtMzItbGl0 dGxlLWVuZGlhbi1ib20uaHRtbCB0byBwYXJzZSBhcyBVVEYtMTZMRSAKIFBBU1MgRXhwZWN0IHJl c291cmNlcy91dGYtMzItbGl0dGxlLWVuZGlhbi1ib20ueG1sIHRvIHBhcnNlIGFzIFVURi0xNkxF IAogUEFTUyBFeHBlY3QgcmVzb3VyY2VzL3V0Zi0zMi1saXR0bGUtZW5kaWFuLW5vYm9tLmh0bWwg dG8gcGFyc2UgYXMgd2luZG93cy0xMjUyIAotRkFJTCBFeHBlY3QgcmVzb3VyY2VzL3V0Zi0zMi1s aXR0bGUtZW5kaWFuLW5vYm9tLnhtbCB0byBwYXJzZSBhcyBVVEYtOCBhc3NlcnRfZXF1YWxzOiBl eHBlY3RlZCAiVVRGLTgiIGJ1dCBnb3QgIndpbmRvd3MtMTI1MiIKK1BBU1MgRXhwZWN0IHJlc291 cmNlcy91dGYtMzItbGl0dGxlLWVuZGlhbi1ub2JvbS54bWwgdG8gcGFyc2UgYXMgVVRGLTggCiAK