216215 2020-09-05 07:07:11 -0700 -Wreturn-type warning in BaseAudioContext.cpp 2020-09-05 08:57:41 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cdumez darin eric.carlson ews-watchlist glenn jer.noble mcatanzaro philipj sergio oldest_to_newest 1686061 0 mcatanzaro 2020-09-05 07:07:11 -0700 [2556/3671] Building CXX object Source...ources/UnifiedSource-4babe430-24.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-4babe430-24.cpp:3: ../../Source/WebCore/Modules/webaudio/BaseAudioContext.cpp: In member function ‘WebCore::PeriodicWave& WebCore::BaseAudioContext::periodicWave(WebCore::OscillatorType)’: ../../Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:1328:1: warning: control reaches end of non-void function [-Wreturn-type] 1328 | } | ^ For the past several years, I've been fixing this with RELEASE_ASSERT_NOT_REACHED(). The other alternative would be to CRASH(). In this case, we also have an awkward construction: case OscillatorType::Custom: ASSERT_NOT_REACHED(); #ifdef NDEBUG FALLTHROUGH; #endif Which appears to be an attempt to avoid performance penalty form RELEASE_ASSERT_NOT_REACHED(). It's simpler and safer to just use RELEASE_ASSERT_NOT_REACHED(). 1686062 1 408084 mcatanzaro 2020-09-05 07:11:22 -0700 Created attachment 408084 Patch 1686075 2 ews-feeder 2020-09-05 08:57:40 -0700 Committed r266661: <https://trac.webkit.org/changeset/266661> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408084. 408084 2020-09-05 07:11:22 -0700 2020-09-05 08:57:40 -0700 Patch bug-216215-20200905091121.patch text/plain 1666 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTY0YTFmMTE0YjU3MDZk NmM1ZmRmYjRjOTllMGVjNDdjMjUwNzRkOC4uOWRjNWJmMDMyMGFmYjBhMWRhZDc1MmMzM2Y2YTQ1 ZWIzMTBiZGNkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA5LTA1ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XcmV0dXJu LXR5cGUgd2FybmluZyBpbiBCYXNlQXVkaW9Db250ZXh0LmNwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2MjE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0Jhc2VBdWRp b0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QmFzZUF1ZGlvQ29udGV4dDo6cGVyaW9k aWNXYXZlKToKKwogMjAyMC0wOS0wNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNjY2MTQgYW5kIHIyNjY2 NTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0Jhc2VBdWRp b0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9D b250ZXh0LmNwcAppbmRleCBkYzUzZGIxNGZiMzhjYjcxOTVhODAyMzdiOWIyMjRmYzg0MGYxY2Ez Li5jMDU0NGM5Y2UwYzNkZTQ4YTdhZGQxNDQxNzUwYTI0NjU4MGUyOTM4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0Jhc2VBdWRpb0NvbnRleHQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQmFzZUF1ZGlvQ29udGV4dC5jcHAKQEAg LTEzMTYsMTUgKzEzMTYsMTMgQEAgUGVyaW9kaWNXYXZlJiBCYXNlQXVkaW9Db250ZXh0OjpwZXJp b2RpY1dhdmUoT3NjaWxsYXRvclR5cGUgdHlwZSkKICAgICAgICAgICAgIG1fY2FjaGVkUGVyaW9k aWNXYXZlVHJpYW5nbGUgPSBQZXJpb2RpY1dhdmU6OmNyZWF0ZVRyaWFuZ2xlKHNhbXBsZVJhdGUo KSk7CiAgICAgICAgIHJldHVybiAqbV9jYWNoZWRQZXJpb2RpY1dhdmVUcmlhbmdsZTsKICAgICBj YXNlIE9zY2lsbGF0b3JUeXBlOjpDdXN0b206Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwotI2lmZGVmIE5ERUJVRwotICAgICAgICBGQUxMVEhST1VHSDsKLSNlbmRpZgorICAgICAgICBS RUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIGNhc2UgT3NjaWxsYXRvclR5cGU6OlNp bmU6CiAgICAgICAgIGlmICghbV9jYWNoZWRQZXJpb2RpY1dhdmVTaW5lKQogICAgICAgICAgICAg bV9jYWNoZWRQZXJpb2RpY1dhdmVTaW5lID0gUGVyaW9kaWNXYXZlOjpjcmVhdGVTaW5lKHNhbXBs ZVJhdGUoKSk7CiAgICAgICAgIHJldHVybiAqbV9jYWNoZWRQZXJpb2RpY1dhdmVTaW5lOwogICAg IH0KKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCiAjaWYgIVJFTEVBU0Vf TE9HX0RJU0FCTEVECg==