216182 2020-09-04 09:29:40 -0700 Remove stale reference to RuntimeEnabledFeatures 2025-05-14 10:07:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=215962 GoodFirstBug, InRadar P2 Normal --- 215981 1 sam webkit-unassigned ahmad.saleem792 ap bfulgham emw graouts ntim thorton webkit-bug-importer oldest_to_newest 1685693 0 sam 2020-09-04 09:29:40 -0700 Use of WebCore::RuntimeEnabledFeatures is almost always wrong as it is a global singleton that can be set by multiple different API layer preferences objects. Over the years, it has become convenient, as it "works" for settings that need to be accessed in non-page accessible places, but in reality, those are likely threading issues waiting to happen or layering violations due to use of RuntimeEnabledFeatures from the platform directory. See related, 215962 (Obsolete DeprecatedGlobalSettings) 1685695 1 sam 2020-09-04 09:31:20 -0700 The biggest thing to do here is likely adding a mechanism to extend WebCore::Settings (as generated from Settings.yaml) or a subset thereof, to work with Workers. 1687738 2 webkit-bug-importer 2020-09-11 09:30:13 -0700 <rdar://problem/68714643> 1976555 3 ahmad.saleem792 2023-09-08 16:02:38 -0700 Only able to find one incorrect include 'RuntimeEnabledFeatures' (using this search): https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#35 and https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#100 It also got consolidated here: https://github.com/WebKit/WebKit/commit/5ddb4127ac4e4a104338422e546a1cdc7b698769 @Tim - you reviewed above commit, do we need this bug to remain open? @Alexey - any help if Tim is not right contact? 1976577 4 ap 2023-09-08 18:48:37 -0700 CC'ing some folks who worked on feature flags recently. 1990119 5 ntim 2023-11-06 01:57:17 -0800 Yeah RuntimeEnabledFeatures was removed. I'm going to repurpose this to be about removing the stale include Ahmad found. 2116414 6 alexbdamac 2025-05-11 23:35:56 -0700 Pull request: https://github.com/WebKit/WebKit/pull/45233 2117094 7 sam 2025-05-14 10:07:10 -0700 I removed this file (along with the whole DecoderTest directory) in https://bugs.webkit.org/show_bug.cgi?id=292936 / 593ffb9. We can close this.