<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>216175</bug_id>
          
          <creation_ts>2020-09-04 07:56:27 -0700</creation_ts>
          <short_desc>[macOS] Add client decoder entitlement</short_desc>
          <delta_ts>2020-09-04 09:36:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Per Arne Vollan">pvollan</reporter>
          <assigned_to name="Per Arne Vollan">pvollan</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>jer.noble</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1685640</commentid>
    <comment_count>0</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-09-04 07:56:27 -0700</bug_when>
    <thetext>Add client decoder entitlement on macOS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685643</commentid>
    <comment_count>1</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-09-04 07:59:50 -0700</bug_when>
    <thetext>&lt;rdar://problem/67532128&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685646</commentid>
    <comment_count>2</comment_count>
      <attachid>407971</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-09-04 08:00:24 -0700</bug_when>
    <thetext>Created attachment 407971
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685683</commentid>
    <comment_count>3</comment_count>
      <attachid>407971</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2020-09-04 09:11:00 -0700</bug_when>
    <thetext>Comment on attachment 407971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407971&amp;action=review

r=me

&gt; Source/WebKit/Scripts/process-entitlements.sh:22
&gt; +            plistbuddy Add :com.apple.developer.coremedia.allow-client-decoder-sandbox bool YES

I think this label might change, but maybe we want to use this now to get some benchmark data?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685697</commentid>
    <comment_count>4</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-09-04 09:33:34 -0700</bug_when>
    <thetext>(In reply to Brent Fulgham from comment #3)
&gt; Comment on attachment 407971 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=407971&amp;action=review
&gt; 
&gt; r=me
&gt; 
&gt; &gt; Source/WebKit/Scripts/process-entitlements.sh:22
&gt; &gt; +            plistbuddy Add :com.apple.developer.coremedia.allow-client-decoder-sandbox bool YES
&gt; 
&gt; I think this label might change, but maybe we want to use this now to get
&gt; some benchmark data?

Yes, I believe that is the plan.

Thanks for reviewing!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685701</commentid>
    <comment_count>5</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-09-04 09:36:33 -0700</bug_when>
    <thetext>Landed &lt;https://trac.webkit.org/changeset/266613/webkit&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>407971</attachid>
            <date>2020-09-04 08:00:24 -0700</date>
            <delta_ts>2020-09-04 09:11:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-216175-20200904080023.patch</filename>
            <type>text/plain</type>
            <size>1463</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjY2MDcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTA0ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIEFkZCBjbGllbnQg
ZGVjb2RlciBlbnRpdGxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MjE2MTc1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NzUzMjEyOD4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2xpZW50
IGRlY29kZXIgZW50aXRsZW1lbnQgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBvbiBtYWNPUy4K
KworICAgICAgICAqIFNjcmlwdHMvcHJvY2Vzcy1lbnRpdGxlbWVudHMuc2g6CisKIDIwMjAtMDkt
MDQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW21h
Y09TXSBVSSBwcm9jZXNzIHNvbWV0aW1lcyBjcmFzaGVzIHVuZGVyIC1bV0tTaGFyaW5nU2Vydmlj
ZVBpY2tlckRlbGVnYXRlIHNoYXJpbmdTZXJ2aWNlOmRpZFNoYXJlSXRlbXM6XQpJbmRleDogU291
cmNlL1dlYktpdC9TY3JpcHRzL3Byb2Nlc3MtZW50aXRsZW1lbnRzLnNoCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJLaXQvU2NyaXB0cy9wcm9jZXNzLWVudGl0bGVtZW50cy5zaAkocmV2aXNpb24g
MjY2NDU1KQorKysgU291cmNlL1dlYktpdC9TY3JpcHRzL3Byb2Nlc3MtZW50aXRsZW1lbnRzLnNo
CSh3b3JraW5nIGNvcHkpCkBAIC0xOSw2ICsxOSw3IEBAIGZ1bmN0aW9uIG1hY19wcm9jZXNzX3dl
YmNvbnRlbnRfZW50aXRsZW0KICAgICAgICAgcGxpc3RidWRkeSBBZGQgOmNvbS5hcHBsZS5yb290
bGVzcy5zdG9yYWdlLldlYktpdFdlYkNvbnRlbnRTYW5kYm94IGJvb2wgWUVTCiAgICAgICAgIGlm
ICgoICIke1RBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SfSIgPj0gMTEwMDAwICkpCiAgICAg
ICAgIHRoZW4KKyAgICAgICAgICAgIHBsaXN0YnVkZHkgQWRkIDpjb20uYXBwbGUuZGV2ZWxvcGVy
LmNvcmVtZWRpYS5hbGxvdy1jbGllbnQtZGVjb2Rlci1zYW5kYm94IGJvb2wgWUVTCiAgICAgICAg
ICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnBhYy5zaGFyZWRfcmVnaW9uX2lkIHN0cmlu
ZyBXZWJDb250ZW50CiAgICAgICAgICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnByaXZh
dGUucGFjLmV4Y2VwdGlvbiBib29sIFlFUwogICAgICAgICBmaQo=
</data>
<flag name="review"
          id="423339"
          type_id="1"
          status="+"
          setter="bfulgham"
    />
          </attachment>
      

    </bug>

</bugzilla>