216143 2020-09-03 14:33:50 -0700 REGRESSION(r266498): crashes in debug 2020-09-03 14:36:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 216097 1 commit-queue commit-queue darin sam tsavell webkit-bug-importer oldest_to_newest 1685432 0 commit-queue 2020-09-03 14:33:50 -0700 https://trac.webkit.org/changeset/266498 broke the build: crashes in debug This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1685434 1 407913 commit-queue 2020-09-03 14:33:55 -0700 Created attachment 407913 REVERT of r266498 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1685436 2 darin 2020-09-03 14:35:12 -0700 *** Bug 216128 has been marked as a duplicate of this bug. *** 1685437 3 ews-feeder 2020-09-03 14:35:21 -0700 Committed r266556: <https://trac.webkit.org/changeset/266556> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407913. 1685438 4 webkit-bug-importer 2020-09-03 14:36:18 -0700 <rdar://problem/68302424> 407913 2020-09-03 14:33:55 -0700 2020-09-03 14:35:21 -0700 REVERT of r266498 bug-216143-20200903213355.patch text/plain 7104 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2N2IyZDhlNjk4OTQx NTAwNTIxZmU1YTQ0YTc4NTkwZDM2MWU0NC4uNjJkNmI5ZDk0NzI3OWRhZjk3MTE4NmVkOTRlMjY2 N2I5NzQ4NmY1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTAzICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI2NjQ5OC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxNjE0MworCisgICAgICAgIGNyYXNoZXMgaW4gZGVidWcKKworICAgICAg ICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIlNpbXBsaWZ5IHNvbWUgZWRpdGluZyBj b2RlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2 MDk3CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNjY0OTgKKwog MjAyMC0wOS0wMyAgRnJhbmsgWWFuZyAgPGd1b3dlaV95YW5nQGFwcGxlLmNvbT4KIAogICAgICAg ICBDb3JlSW1hZ2UgSW1wbGVtZW50YXRpb24gb2YgU291cmNlR3JhcGhpYyBhbmQgc2F0dXJhdGUo KSwgaHVlLXJvdGF0ZSgpLCBncmF5c2NhbGUoKSBhbmQgc2VwaWEoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0Nv bnRhaW5lck5vZGUuY3BwCmluZGV4IGVkZDA3NjUwMDFkYmE0YWM4YjEzNDc2N2M1MTk0NDMzYjk2 NmEyMGUuLmEyMmJiOGY5OGM1ZWM3ZjQ4Yzc4NzlkMmYwYjg0MzRlYWYyNTRlMzEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKQEAgLTYzMiwxMSArNjMyLDYgQEAgdm9pZCBDb250 YWluZXJOb2RlOjpyZXBsYWNlQWxsQ2hpbGRyZW4oc3RkOjpudWxscHRyX3QpCiAvLyBodHRwczov L2RvbS5zcGVjLndoYXR3Zy5vcmcvI2NvbmNlcHQtbm9kZS1yZXBsYWNlLWFsbAogdm9pZCBDb250 YWluZXJOb2RlOjpyZXBsYWNlQWxsQ2hpbGRyZW5XaXRoTmV3VGV4dChjb25zdCBTdHJpbmcmIHRl eHQpCiB7Ci0gICAgaWYgKHRleHQuaXNFbXB0eSgpKSB7Ci0gICAgICAgIHJlcGxhY2VBbGxDaGls ZHJlbihudWxscHRyKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIGF1dG8gbm9kZSA9 IGRvY3VtZW50KCkuY3JlYXRlVGV4dE5vZGUodGV4dCk7CiAgICAgaWYgKCFoYXNDaGlsZE5vZGVz KCkpIHsKICAgICAgICAgLy8gYXBwZW5kQ2hpbGRXaXRob3V0UHJlSW5zZXJ0aW9uVmFsaWRpdHlD aGVjaygpIGNhbiBvbmx5IHRocm93IHdoZW4gbm9kZSBoYXMgYSBwYXJlbnQgYW5kIHdlIGFscmVh ZHkgYXNzZXJ0ZWQgaXQgZG9lc24ndC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCA3M2ZlMTA3OWY0NGJh YzdiMThiMDhjZmY1ZTJiOTNhNzhhMTgwNGEwLi4xNmVmYTBiNTllMGU0MWI5NjUxNTMyMzNiZjVl YTBkOTU2YjNkNTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC0xNTgwLDkgKzE1ODAsMTQgQEAgRXhj ZXB0aW9uT3I8dm9pZD4gTm9kZTo6c2V0VGV4dENvbnRlbnQoY29uc3QgU3RyaW5nJiB0ZXh0KQog ICAgIGNhc2UgUFJPQ0VTU0lOR19JTlNUUlVDVElPTl9OT0RFOgogICAgICAgICByZXR1cm4gc2V0 Tm9kZVZhbHVlKHRleHQpOwogICAgIGNhc2UgRUxFTUVOVF9OT0RFOgotICAgIGNhc2UgRE9DVU1F TlRfRlJBR01FTlRfTk9ERToKLSAgICAgICAgZG93bmNhc3Q8Q29udGFpbmVyTm9kZT4oKnRoaXMp LnJlcGxhY2VBbGxDaGlsZHJlbldpdGhOZXdUZXh0KHRleHQpOworICAgIGNhc2UgRE9DVU1FTlRf RlJBR01FTlRfTk9ERTogeworICAgICAgICBhdXRvJiBjb250YWluZXIgPSBkb3duY2FzdDxDb250 YWluZXJOb2RlPigqdGhpcyk7CisgICAgICAgIGlmICh0ZXh0LmlzRW1wdHkoKSkKKyAgICAgICAg ICAgIGNvbnRhaW5lci5yZXBsYWNlQWxsQ2hpbGRyZW4obnVsbHB0cik7CisgICAgICAgIGVsc2UK KyAgICAgICAgICAgIGNvbnRhaW5lci5yZXBsYWNlQWxsQ2hpbGRyZW5XaXRoTmV3VGV4dCh0ZXh0 KTsKICAgICAgICAgcmV0dXJuIHsgfTsKKyAgICB9CiAgICAgY2FzZSBET0NVTUVOVF9OT0RFOgog ICAgIGNhc2UgRE9DVU1FTlRfVFlQRV9OT0RFOgogICAgICAgICAvLyBEbyBub3RoaW5nLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9pb3MvRWRpdG9ySU9TLm1tIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9pb3MvRWRpdG9ySU9TLm1tCmluZGV4IDIzOWU4OTQzOWM4MzQ5MmIz Nzg2Yzc4ODdmZWYyNGE3ZDM3YWNlNDkuLjA4ZDEyZGJkMDBmMjI2NjEwZDNhNGU1NWYxMDU4NmZl ZDQ1NzMxOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaW9zL0VkaXRvcklP Uy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2lvcy9FZGl0b3JJT1MubW0KQEAgLTMy OSwyMCArMzI5LDQ4IEBAIHZvaWQgRWRpdG9yOjpzZXRUZXh0QXNDaGlsZE9mRWxlbWVudChjb25z dCBTdHJpbmcmIHRleHQsIEVsZW1lbnQmIGVsZW1lbnQpCiAgICAgY2xlYXJVbmRvUmVkb09wZXJh dGlvbnMoKTsKIAogICAgIC8vIElmIHRoZSBlbGVtZW50IGlzIGVtcHR5IGFscmVhZHkgYW5kIHdl J3JlIG5vdCBhZGRpbmcgdGV4dCwgd2UgY2FuIGVhcmx5IHJldHVybiBhbmQgYXZvaWQgY2xlYXJp bmcvc2V0dGluZwotICAgIC8vIGEgc2VsZWN0aW9uIGF0IFswLCAwXSBhbmQgdGhlIGV4cGVuc2Ug aW52b2x2ZWQgaW4gY3JlYXRpbmcgVmlzaWJsZVBvc2l0aW9ucy4KKyAgICAvLyBhIHNlbGVjdGlv biBhdCBbMCwgMF0gYW5kIHRoZSBleHBlbnNlIGludm9sdmVkIGluIGNyZWF0aW9uIFZpc2libGVQ b3NpdGlvbnMuCiAgICAgaWYgKCFlbGVtZW50LmZpcnN0Q2hpbGQoKSAmJiB0ZXh0LmlzRW1wdHko KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gQXMgYSBzaWRlIGVmZmVjdCB0aGlzIGZ1bmN0 aW9uIHNldHMgYSBjYXJldCBzZWxlY3Rpb24gYWZ0ZXIgdGhlIGluc2VydGVkIGNvbnRlbnQuCi0g ICAgLy8gV2hhdCBmb2xsb3dzIGlzIG1vcmUgZXhwZW5zaXZlIGlmIHRoZXJlIGlzIGEgc2VsZWN0 aW9uLCBzbyBjbGVhciBpdCBzaW5jZSBpdCdzIGdvaW5nIHRvIGNoYW5nZSBhbnl3YXkuCisgICAg Ly8gQXMgYSBzaWRlIGVmZmVjdCB0aGlzIGZ1bmN0aW9uIHNldHMgYSBjYXJldCBzZWxlY3Rpb24g YWZ0ZXIgdGhlIGluc2VydGVkIGNvbnRlbnQuIE11Y2ggb2Ygd2hhdAorICAgIC8vIGZvbGxvd3Mg aXMgbW9yZSBleHBlbnNpdmUgaWYgdGhlcmUgaXMgYSBzZWxlY3Rpb24sIHNvIGNsZWFyIGl0IHNp bmNlIGl0J3MgZ29pbmcgdG8gY2hhbmdlIGFueXdheS4KICAgICBtX2RvY3VtZW50LnNlbGVjdGlv bigpLmNsZWFyKCk7CiAKLSAgICBlbGVtZW50LnJlcGxhY2VBbGxDaGlsZHJlbldpdGhOZXdUZXh0 KHRleHQpOworICAgIC8vIGNsZWFyIG91dCBhbGwgY3VycmVudCBjaGlsZHJlbiBvZiBlbGVtZW50 CisgICAgZWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwogCi0gICAgVmlzaWJsZVBvc2l0aW9uIGFm dGVyQ29udGVudHMgPSBjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24oJmVsZW1lbnQsIGVsZW1l bnQuY291bnRDaGlsZE5vZGVzKCkpOwotICAgIGlmIChhZnRlckNvbnRlbnRzLmlzTnVsbCgpKQor ICAgIGlmICh0ZXh0Lmxlbmd0aCgpKSB7CisgICAgICAgIC8vIGluc2VydCBuZXcgdGV4dAorICAg ICAgICAvLyByZW1vdmUgZWxlbWVudCBmcm9tIHRyZWUgd2hpbGUgZG9pbmcgaXQKKyAgICAgICAg Ly8gRklYTUU6IFRoZSBlbGVtZW50IHdlJ3JlIGluc2VydGluZyBpbnRvIGlzIG9mdGVuIHRoZSBi b2R5IGVsZW1lbnQuIEl0IHNlZW1zIHN0cmFuZ2UgdG8gYmUgcmVtb3ZpbmcgaXQKKyAgICAgICAg Ly8gKGV2ZW4gaWYgaXQgaXMgb25seSB0ZW1wb3JhcnkpLiBSZXBsYWNlU2VsZWN0aW9uQ29tbWFu ZCBkb2Vzbid0IGJvdGhlciBkb2luZyB0aGlzIHdoZW4gaXQgaW5zZXJ0cworICAgICAgICAvLyBj b250ZW50LCB3aHkgc2hvdWxkIHdlIGhlcmU/CisgICAgICAgIFJlZlB0cjxOb2RlPiBwYXJlbnQg PSBlbGVtZW50LnBhcmVudE5vZGUoKTsKKyAgICAgICAgUmVmUHRyPE5vZGU+IHNpYmxpbmdBZnRl ciA9IGVsZW1lbnQubmV4dFNpYmxpbmcoKTsKKyAgICAgICAgaWYgKHBhcmVudCkKKyAgICAgICAg ICAgIGVsZW1lbnQucmVtb3ZlKCk7CisKKyAgICAgICAgZWxlbWVudC5hcHBlbmRDaGlsZChjcmVh dGVGcmFnbWVudEZyb21UZXh0KG1ha2VSYW5nZVNlbGVjdGluZ05vZGVDb250ZW50cyhlbGVtZW50 KSwgdGV4dCkpOworCisgICAgICAgIC8vIHJlc3RvcmUgZWxlbWVudCB0byBkb2N1bWVudAorICAg ICAgICBpZiAocGFyZW50KSB7CisgICAgICAgICAgICBpZiAoc2libGluZ0FmdGVyKQorICAgICAg ICAgICAgICAgIHBhcmVudC0+aW5zZXJ0QmVmb3JlKGVsZW1lbnQsIHNpYmxpbmdBZnRlci5nZXQo KSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgcGFyZW50LT5hcHBlbmRDaGls ZChlbGVtZW50KTsKKyAgICAgICAgfQorICAgIH0KKworICAgIC8vIHNldCB0aGUgc2VsZWN0aW9u IHRvIHRoZSBlbmQKKyAgICBWaXNpYmxlUG9zaXRpb24gdmlzaWJsZVBvcyhjcmVhdGVMZWdhY3lF ZGl0aW5nUG9zaXRpb24oJmVsZW1lbnQsIGVsZW1lbnQuY291bnRDaGlsZE5vZGVzKCkpKTsKKyAg ICBpZiAodmlzaWJsZVBvcy5pc051bGwoKSkKICAgICAgICAgcmV0dXJuOwotICAgIG1fZG9jdW1l bnQuc2VsZWN0aW9uKCkuc2V0U2VsZWN0aW9uKGFmdGVyQ29udGVudHMpOworCisgICAgVmlzaWJs ZVNlbGVjdGlvbiBzZWxlY3Rpb247CisgICAgc2VsZWN0aW9uLnNldEJhc2UodmlzaWJsZVBvcyk7 CisgICAgc2VsZWN0aW9uLnNldEV4dGVudCh2aXNpYmxlUG9zKTsKKyAgICBtX2RvY3VtZW50LnNl bGVjdGlvbigpLnNldFNlbGVjdGlvbihzZWxlY3Rpb24pOwogCiAgICAgY2xpZW50KCktPnJlc3Bv bmRUb0NoYW5nZWRDb250ZW50cygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcApp bmRleCA1ODU0M2IxNWU0OTU4ZjEzMjQ3MTQ0MTlmNjVkMzQ4NTkwNjE1NjVkLi45Mzk4NGYzODJj ZDRlZjFkZjZjYzE3YzAzM2Y1NWZkYmYxNzZiNGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVt ZW50LmNwcApAQCAtNTM5LDcgKzUzOSwxMCBAQCBFeGNlcHRpb25Pcjx2b2lkPiBIVE1MRWxlbWVu dDo6c2V0SW5uZXJUZXh0KGNvbnN0IFN0cmluZyYgdGV4dCkKICAgICAvLyBGSVhNRTogVGhpcyBk b2Vzbid0IHRha2Ugd2hpdGVzcGFjZSBjb2xsYXBzaW5nIGludG8gYWNjb3VudCBhdCBhbGwuCiAK ICAgICBpZiAoIXRleHQuY29udGFpbnMoJ1xuJykgJiYgIXRleHQuY29udGFpbnMoJ1xyJykpIHsK LSAgICAgICAgcmVwbGFjZUFsbENoaWxkcmVuV2l0aE5ld1RleHQodGV4dCk7CisgICAgICAgIGlm ICh0ZXh0LmlzRW1wdHkoKSkKKyAgICAgICAgICAgIHJlcGxhY2VBbGxDaGlsZHJlbihudWxscHRy KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcmVwbGFjZUFsbENoaWxkcmVuV2l0aE5ld1Rl eHQodGV4dCk7CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVNlbGVjdGlvbi5jcHAKaW5kZXggYTE3M2FjYzU3MWMxMGUwNjA4MmFlZDYxNzRhOGE4MmE5MjQ1 MWYzMi4uZWNmMmFlYWQ2ZDRlZWM4N2EyZWVmYTMzNDMyZDAwNGEyNGNhM2YxOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmNwcApAQCAtMzMyLDcgKzMzMiw3IEBAIHZvaWQgRE9NU2Vs ZWN0aW9uOjphZGRSYW5nZShSYW5nZSYgbGl2ZVJhbmdlKQogCiB2b2lkIERPTVNlbGVjdGlvbjo6 ZGVsZXRlRnJvbURvY3VtZW50KCkKIHsKLSAgICBhdXRvIGZyYW1lID0gbWFrZVJlZlB0cih0aGlz LT5mcmFtZSgpKTsKKyAgICBhdXRvKiBmcmFtZSA9IHRoaXMtPmZyYW1lKCk7CiAgICAgaWYgKCFm cmFtZSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0zNDAsOCArMzQwLDExIEBAIHZvaWQgRE9NU2Vs ZWN0aW9uOjpkZWxldGVGcm9tRG9jdW1lbnQoKQogICAgIGlmICghc2VsZWN0ZWRSYW5nZSB8fCBz ZWxlY3RlZFJhbmdlLT5zdGFydC5jb250YWluZXItPmNvbnRhaW5pbmdTaGFkb3dSb290KCkpCiAg ICAgICAgIHJldHVybjsKIAorICAgIFJlZjxGcmFtZT4gcHJvdGVjdG9yKCpmcmFtZSk7CiAgICAg Y3JlYXRlTGl2ZVJhbmdlKCpzZWxlY3RlZFJhbmdlKS0+ZGVsZXRlQ29udGVudHMoKTsKLSAgICBm cmFtZS0+c2VsZWN0aW9uKCkuc2V0U2VsZWN0ZWRSYW5nZShtYWtlU2ltcGxlUmFuZ2Uoc2VsZWN0 ZWRSYW5nZS0+c3RhcnQpLCBBZmZpbml0eTo6VXBzdHJlYW0sIEZyYW1lU2VsZWN0aW9uOjpTaG91 bGRDbG9zZVR5cGluZzo6Tm8pOworICAgIGF1dG8gY29udGFpbmVyID0gc2VsZWN0ZWRSYW5nZS0+ c3RhcnQuY29udGFpbmVyLnB0cigpOworICAgIGF1dG8gb2Zmc2V0ID0gc2VsZWN0ZWRSYW5nZS0+ c3RhcnQub2Zmc2V0OworICAgIHNldEJhc2VBbmRFeHRlbnQoY29udGFpbmVyLCBvZmZzZXQsIGNv bnRhaW5lciwgb2Zmc2V0KTsKIH0KIAogYm9vbCBET01TZWxlY3Rpb246OmNvbnRhaW5zTm9kZShO b2RlJiBub2RlLCBib29sIGFsbG93UGFydGlhbCkgY29uc3QK