216100 2020-09-02 14:52:04 -0700 run-webkit-tests spends 20-30 seconds "building" ImageDiff 2020-09-02 21:20:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 204420 InRadar P2 Normal --- 1 jbedard jbedard ap darin ews-watchlist glenn thorton webkit-bug-importer oldest_to_newest 1685009 0 jbedard 2020-09-02 14:52:04 -0700 Tools/Scripts/build-imagediff --release takes an inordinate amount of time for a null build (20-30 seconds), and run-webkit-tests calls it on every invocation, even if you pass --no-build. This is 40-50% of the time it takes to run-webkit-tests a single test in the iOS simulator, and thus would wildly increase the turnaround rate when developing a test. 1685010 1 jbedard 2020-09-02 14:52:29 -0700 <rdar://problem/68232690> 1685012 2 407819 jbedard 2020-09-02 14:57:33 -0700 Created attachment 407819 Patch 1685018 3 407819 thorton 2020-09-02 15:11:32 -0700 Comment on attachment 407819 Patch Won't _path_to_image_diff (which is @memoize'd) store the failure to find it in check_image_diff, and return that after we build it (thus making ImageDiff not found if it got built)? 1685030 4 jbedard 2020-09-02 15:38:36 -0700 (In reply to Tim Horton from comment #3) > Comment on attachment 407819 [details] > Patch > > Won't _path_to_image_diff (which is @memoize'd) store the failure to find it > in check_image_diff, and return that after we build it (thus making > ImageDiff not found if it got built)? Likely yes, the right solution is probably to clear out the memoization, but our current @memoize doesn't support that 1685093 5 ap 2020-09-02 18:18:15 -0700 Isn't bug 204420 the root cause here? 1685094 6 thorton 2020-09-02 18:22:12 -0700 (In reply to Alexey Proskuryakov from comment #5) > Isn't bug 204420 the root cause here? Do you mean "isn't this a dupe of that"? I think the answer is "yes"! 1685152 7 darin 2020-09-02 21:20:44 -0700 *** This bug has been marked as a duplicate of bug 204420 *** 407819 2020-09-02 14:57:33 -0700 2020-09-02 15:29:31 -0700 Patch bug-216100-20200902145732.patch text/plain 1369 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NjQ5MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA5LTAyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzIHNwZW5kcyAyMC0zMCBzZWNvbmRzICJidWls ZGluZyIgSW1hZ2VEaWZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTYxMDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY4MjMyNjkwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9wb3J0L2Jhc2UucHk6CisgICAgICAgIChQb3J0LmNoZWNrX2ltYWdlX2RpZmYpOiBDaGVj ayB0aGUgdmVyc2lvbiBvZiBJbWFnZURpZmYgd2UgYWN0dWFsbHkgaW50ZW5kIHRvIHVzZS4KKwog MjAyMC0wOS0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBB ZGQgYSB2YXJpYW50IG9mIG1hcCB3aGljaCBmaWx0ZXJzIGl0ZW1zIHRvIFZlY3Rvci5oCkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQkocmV2aXNpb24gMjY2NDkwKQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTI3NSw3 ICsyNzUsNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAKICAgICBkZWYgY2hlY2tfaW1hZ2VfZGlm ZihzZWxmLCBvdmVycmlkZV9zdGVwPU5vbmUsIGxvZ2dpbmc9VHJ1ZSk6CiAgICAgICAgICIiIlRo aXMgcm91dGluZSBpcyB1c2VkIHRvIGNoZWNrIHdoZXRoZXIgaW1hZ2VfZGlmZiBiaW5hcnkgZXhp c3RzLiIiIgotICAgICAgICBpbWFnZV9kaWZmX3BhdGggPSBzZWxmLl9wYXRoX3RvX2RlZmF1bHRf aW1hZ2VfZGlmZigpCisgICAgICAgIGltYWdlX2RpZmZfcGF0aCA9IHNlbGYuX3BhdGhfdG9faW1h Z2VfZGlmZigpCiAgICAgICAgIGlmIG5vdCBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhpbWFnZV9k aWZmX3BhdGgpOgogICAgICAgICAgICAgaWYgbG9nZ2luZzoKICAgICAgICAgICAgICAgICBfbG9n LmVycm9yKCJJbWFnZURpZmYgd2FzIG5vdCBmb3VuZCBhdCAlcyIgJSBpbWFnZV9kaWZmX3BhdGgp Cg==